192934 2018-12-20 09:04:46 -0800 [MSE][GStreamer] Use GRefPtr in AppendPipeline::pushNewBuffer() 2019-02-05 08:04:00 -0800 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 aboya aboya bugs-noreply calvaris commit-queue mcatanzaro webkit-bug-importer oldest_to_newest 1489858 0 aboya 2018-12-20 09:04:46 -0800 One fewer raw pointer. 1489859 1 357816 aboya 2018-12-20 09:06:15 -0800 Created attachment 357816 Patch 1489937 2 357816 mcatanzaro 2018-12-20 10:51:20 -0800 Comment on attachment 357816 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=357816&action=review > Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.h:52 > - GstFlowReturn pushNewBuffer(GstBuffer*); > + GstFlowReturn pushNewBuffer(GRefPtr<GstBuffer>&&); This looks like the proper way to sink ownership, yes! The original code failed to follow the rule to never transfer ownership through raw pointers. 1493255 3 357816 commit-queue 2019-01-10 04:46:26 -0800 Comment on attachment 357816 Patch Clearing flags on attachment: 357816 Committed r239826: <https://trac.webkit.org/changeset/239826> 1493256 4 commit-queue 2019-01-10 04:46:27 -0800 All reviewed patches have been landed. Closing bug. 357816 2018-12-20 09:06:15 -0800 2019-01-10 04:46:26 -0800 Patch bug-192934-20181220180613.patch text/plain 4466 aboya U3VidmVyc2lvbiBSZXZpc2lvbjogMjM5Mzg3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZGQ5NGFiMTYxMjIyMjZm ZDUyZjU4YjBjOTA2MjVkNDVlNmZkMWEwZC4uYzlhY2E1OWZlNzM4YmY1MWQyY2I1MGFjNmYzNzAx NTExNGMzOTZkYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE4LTEyLTIwICBBbGlj aWEgQm95YSBHYXJjw61hICA8YWJveWFAaWdhbGlhLmNvbT4KKworICAgICAgICBbTVNFXVtHU3Ry ZWFtZXJdIFVzZSBHUmVmUHRyIGluIEFwcGVuZFBpcGVsaW5lOjpwdXNoTmV3QnVmZmVyKCkKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5MjkzNAorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0v Z3JhcGhpY3MvZ3N0cmVhbWVyL21zZS9BcHBlbmRQaXBlbGluZS5jcHA6CisgICAgICAgIChXZWJD b3JlOjpBcHBlbmRQaXBlbGluZTo6cHVzaE5ld0J1ZmZlcik6CisgICAgICAgICogcGxhdGZvcm0v Z3JhcGhpY3MvZ3N0cmVhbWVyL21zZS9BcHBlbmRQaXBlbGluZS5oOgorICAgICAgICAqIHBsYXRm b3JtL2dyYXBoaWNzL2dzdHJlYW1lci9tc2UvTWVkaWFTb3VyY2VDbGllbnRHU3RyZWFtZXJNU0Uu Y3BwOgorICAgICAgICAoV2ViQ29yZTo6TWVkaWFTb3VyY2VDbGllbnRHU3RyZWFtZXJNU0U6OmFw cGVuZCk6CisKIDIwMTgtMTItMTkgIEplciBOb2JsZSAgPGplci5ub2JsZUBhcHBsZS5jb20+CiAK ICAgICAgICAgRm9yY2Ugc3luY2hyb25vdXMgZGVjb2RlIGluIFdlYkNvcmVEZWNvbXByZXNzaW9u U2Vzc2lvbjo6ZGVjb2RlU2FtcGxlU3luYygpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvbXNlL0FwcGVuZFBpcGVsaW5lLmNwcCBiL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9tc2UvQXBwZW5kUGlwZWxpbmUu Y3BwCmluZGV4IDAyNmEyMDU3M2VjMzJhZGIyYTNiYzhhNjg2MDIzZWE4MGFkODMxMDguLjBkYjRj MTZmNjA0NmQzMDc5ZWU0ODQxYzRhY2JkN2IxY2EwMjU3YjcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9tc2UvQXBwZW5kUGlwZWxpbmUuY3Bw CisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9tc2UvQXBw ZW5kUGlwZWxpbmUuY3BwCkBAIC01NTIsMTAgKzU1MiwxMCBAQCB2b2lkIEFwcGVuZFBpcGVsaW5l OjpyZXNldFBhcnNlclN0YXRlKCkKICNlbmRpZgogfQogCi1Hc3RGbG93UmV0dXJuIEFwcGVuZFBp cGVsaW5lOjpwdXNoTmV3QnVmZmVyKEdzdEJ1ZmZlciogYnVmZmVyKQorR3N0Rmxvd1JldHVybiBB cHBlbmRQaXBlbGluZTo6cHVzaE5ld0J1ZmZlcihHUmVmUHRyPEdzdEJ1ZmZlcj4mJiBidWZmZXIp CiB7Ci0gICAgR1NUX1RSQUNFX09CSkVDVChtX3BpcGVsaW5lLmdldCgpLCAicHVzaGluZyBkYXRh IGJ1ZmZlciAlIiBHU1RfUFRSX0ZPUk1BVCwgYnVmZmVyKTsKLSAgICBHc3RGbG93UmV0dXJuIHB1 c2hEYXRhQnVmZmVyUmV0ID0gZ3N0X2FwcF9zcmNfcHVzaF9idWZmZXIoR1NUX0FQUF9TUkMobV9h cHBzcmMuZ2V0KCkpLCBidWZmZXIpOworICAgIEdTVF9UUkFDRV9PQkpFQ1QobV9waXBlbGluZS5n ZXQoKSwgInB1c2hpbmcgZGF0YSBidWZmZXIgJSIgR1NUX1BUUl9GT1JNQVQsIGJ1ZmZlci5nZXQo KSk7CisgICAgR3N0Rmxvd1JldHVybiBwdXNoRGF0YUJ1ZmZlclJldCA9IGdzdF9hcHBfc3JjX3B1 c2hfYnVmZmVyKEdTVF9BUFBfU1JDKG1fYXBwc3JjLmdldCgpKSwgYnVmZmVyLmxlYWtSZWYoKSk7 CiAgICAgLy8gUHVzaGluZyBidWZmZXJzIHRvIGFwcHNyYyBjYW4gb25seSBmYWlsIGlmIHRoZSBh cHBzcmMgaXMgZmx1c2hpbmcsIGluIEVPUyBvciBzdG9wcGVkLiBOZWl0aGVyIG9mIHRoZXNlIHNo b3VsZAogICAgIC8vIGJlIHRydWUgYXQgdGhpcyBwb2ludC4KICAgICBnX3JldHVybl92YWxfaWZf ZmFpbChwdXNoRGF0YUJ1ZmZlclJldCA9PSBHU1RfRkxPV19PSywgR1NUX0ZMT1dfRVJST1IpOwpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL21z ZS9BcHBlbmRQaXBlbGluZS5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0 cmVhbWVyL21zZS9BcHBlbmRQaXBlbGluZS5oCmluZGV4IGQzYTUyMGQ4YzcyMjAwODljYjVmNTll ZGRmOTFjOWE5ZDk4YTg3M2QuLmQ1OTU5ODk5MGY5YWMyYmUxMWI3YjZjODg0MTQ4MjhkMTAyMGM5 NWQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1l ci9tc2UvQXBwZW5kUGlwZWxpbmUuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFw aGljcy9nc3RyZWFtZXIvbXNlL0FwcGVuZFBpcGVsaW5lLmgKQEAgLTQ5LDcgKzQ5LDcgQEAgcHVi bGljOgogICAgIEFwcGVuZFBpcGVsaW5lKFJlZjxNZWRpYVNvdXJjZUNsaWVudEdTdHJlYW1lck1T RT4sIFJlZjxTb3VyY2VCdWZmZXJQcml2YXRlR1N0cmVhbWVyPiwgTWVkaWFQbGF5ZXJQcml2YXRl R1N0cmVhbWVyTVNFJik7CiAgICAgdmlydHVhbCB+QXBwZW5kUGlwZWxpbmUoKTsKIAotICAgIEdz dEZsb3dSZXR1cm4gcHVzaE5ld0J1ZmZlcihHc3RCdWZmZXIqKTsKKyAgICBHc3RGbG93UmV0dXJu IHB1c2hOZXdCdWZmZXIoR1JlZlB0cjxHc3RCdWZmZXI+JiYpOwogICAgIHZvaWQgcmVzZXRQYXJz ZXJTdGF0ZSgpOwogICAgIFJlZjxTb3VyY2VCdWZmZXJQcml2YXRlR1N0cmVhbWVyPiBzb3VyY2VC dWZmZXJQcml2YXRlKCkgeyByZXR1cm4gbV9zb3VyY2VCdWZmZXJQcml2YXRlLmdldCgpOyB9CiAg ICAgR3N0Q2FwcyogYXBwc2lua0NhcHMoKSB7IHJldHVybiBtX2FwcHNpbmtDYXBzLmdldCgpOyB9 CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIv bXNlL01lZGlhU291cmNlQ2xpZW50R1N0cmVhbWVyTVNFLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9tc2UvTWVkaWFTb3VyY2VDbGllbnRHU3RyZWFtZXJN U0UuY3BwCmluZGV4IGM4NGZjMzY1OTg1NGI5ZTA0YjEyNmQzZTYwMzAwZmViZjIxOGJjNmEuLmIz N2FkYWVmNDMzNmYyYTViOGNjMzM2NDlkODQ1YTYxNjg3ZGI0NGIgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9tc2UvTWVkaWFTb3VyY2VDbGll bnRHU3RyZWFtZXJNU0UuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L2dzdHJlYW1lci9tc2UvTWVkaWFTb3VyY2VDbGllbnRHU3RyZWFtZXJNU0UuY3BwCkBAIC0xNDEs MTMgKzE0MSwxMyBAQCBib29sIE1lZGlhU291cmNlQ2xpZW50R1N0cmVhbWVyTVNFOjphcHBlbmQo UmVmUHRyPFNvdXJjZUJ1ZmZlclByaXZhdGVHU3RyZWFtZXI+CiAgICAgLy8gV3JhcCB0aGUgd2hv bGUgVmVjdG9yIG9iamVjdCBpbiBjYXNlIHRoZSBkYXRhIGlzIHN0b3JlZCBpbiB0aGUgaW5saW5l ZCBidWZmZXIuCiAgICAgYXV0byogYnVmZmVyRGF0YSA9IGRhdGEuZGF0YSgpOwogICAgIGF1dG8g YnVmZmVyTGVuZ3RoID0gZGF0YS5zaXplKCk7Ci0gICAgR3N0QnVmZmVyKiBidWZmZXIgPSBnc3Rf YnVmZmVyX25ld193cmFwcGVkX2Z1bGwoc3RhdGljX2Nhc3Q8R3N0TWVtb3J5RmxhZ3M+KDApLCBi dWZmZXJEYXRhLCBidWZmZXJMZW5ndGgsIDAsIGJ1ZmZlckxlbmd0aCwgbmV3IFZlY3Rvcjx1bnNp Z25lZCBjaGFyPihXVEZNb3ZlKGRhdGEpKSwKKyAgICBHUmVmUHRyPEdzdEJ1ZmZlcj4gYnVmZmVy ID0gYWRvcHRHUmVmKGdzdF9idWZmZXJfbmV3X3dyYXBwZWRfZnVsbChzdGF0aWNfY2FzdDxHc3RN ZW1vcnlGbGFncz4oMCksIGJ1ZmZlckRhdGEsIGJ1ZmZlckxlbmd0aCwgMCwgYnVmZmVyTGVuZ3Ro LCBuZXcgVmVjdG9yPHVuc2lnbmVkIGNoYXI+KFdURk1vdmUoZGF0YSkpLAogICAgICAgICBbXShn cG9pbnRlciBkYXRhKQogICAgICAgICB7CiAgICAgICAgICAgICBkZWxldGUgc3RhdGljX2Nhc3Q8 VmVjdG9yPHVuc2lnbmVkIGNoYXI+Kj4oZGF0YSk7Ci0gICAgICAgIH0pOworICAgICAgICB9KSk7 CiAKLSAgICByZXR1cm4gYXBwZW5kUGlwZWxpbmUtPnB1c2hOZXdCdWZmZXIoYnVmZmVyKSA9PSBH U1RfRkxPV19PSzsKKyAgICByZXR1cm4gYXBwZW5kUGlwZWxpbmUtPnB1c2hOZXdCdWZmZXIoV1RG TW92ZShidWZmZXIpKSA9PSBHU1RfRkxPV19PSzsKIH0KIAogdm9pZCBNZWRpYVNvdXJjZUNsaWVu dEdTdHJlYW1lck1TRTo6bWFya0VuZE9mU3RyZWFtKE1lZGlhU291cmNlUHJpdmF0ZTo6RW5kT2ZT dHJlYW1TdGF0dXMgc3RhdHVzKQo=