192929 2018-12-20 06:48:20 -0800 [GTK][WPE] Grant the sandbox read access to XDG_DATA_HOME/prgname 2018-12-20 08:18:37 -0800 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 pgriffis webkit-unassigned berto bugs-noreply cgarcia commit-queue ews-watchlist gustavo mcatanzaro oldest_to_newest 1489829 0 pgriffis 2018-12-20 06:48:20 -0800 [GTK][WPE] Grant the sandbox read access to XDG_DATA_HOME/prgname 1489830 1 357809 pgriffis 2018-12-20 06:50:06 -0800 Created attachment 357809 Patch 1489831 2 ews-watchlist 2018-12-20 06:52:52 -0800 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 1489833 3 357809 mcatanzaro 2018-12-20 06:53:50 -0800 Comment on attachment 357809 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=357809&action=review > Source/WebKit/UIProcess/API/glib/WebKitWebContext.cpp:1162 > + * The WebProcess is granted read-only access to the subdirectory matching g_get_prgname() The web process 1489835 4 357810 pgriffis 2018-12-20 07:24:03 -0800 Created attachment 357810 Patch 1489843 5 357810 commit-queue 2018-12-20 08:18:35 -0800 Comment on attachment 357810 Patch Clearing flags on attachment: 357810 Committed r239440: <https://trac.webkit.org/changeset/239440> 1489844 6 commit-queue 2018-12-20 08:18:37 -0800 All reviewed patches have been landed. Closing bug. 357809 2018-12-20 06:50:06 -0800 2018-12-20 07:24:00 -0800 Patch bug-192929-20181220095006.patch text/plain 3628 pgriffis U3VidmVyc2lvbiBSZXZpc2lvbjogMjM5MTI0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDg5NjkyMGM3ZTU4Mzg1YTQ1 NjM5ZWJhMzhjYmFjMDY3YjA3MzZlZTMuLjQ3MjlhNTIwNmRmYWM1MzVhYzRhMjFkNWQ0N2U3MmQx NjgzMmI5YzIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTgtMTItMjAgIFBhdHJpY2sg R3JpZmZpcyAgPHBncmlmZmlzQGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dUS11bV1BFXSBHcmFu dCB0aGUgc2FuZGJveCByZWFkIGFjY2VzcyB0byBYREdfREFUQV9IT01FL3ByZ25hbWUKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5MjkyOQorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVUlQcm9jZXNzL0FQ SS9nbGliL1dlYktpdFdlYkNvbnRleHQuY3BwOgorICAgICAgICAqIFVJUHJvY2Vzcy9MYXVuY2hl ci9nbGliL0J1YmJsZXdyYXBMYXVuY2hlci5jcHA6CisgICAgICAgIChXZWJLaXQ6OmJ1YmJsZXdy YXBTcGF3bik6CisKIDIwMTgtMTItMTIgIENocmlzIEZsZWl6YWNoICA8Y2ZsZWl6YWNoQGFwcGxl LmNvbT4KIAogICAgICAgICBbbWV0YV1bV2ViS2l0XSBSZW1vdmUgdXNpbmcgbmFtZXNwYWNlIFdl YkNvcmUgYW5kIFdlYktpdCBpbiB0aGUgZ2xvYmFsIHNjb3BlIGZvciB1bmlmaWVkIHNvdXJjZSBi dWlsZHMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9nbGliL1dlYktp dFdlYkNvbnRleHQuY3BwIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL2dsaWIvV2ViS2l0 V2ViQ29udGV4dC5jcHAKaW5kZXggN2FmYTc5YzYxZWJjYzAyZWNmYjhlZjk5YmRkZGUxMzc1ODYy NDEzMy4uZWI0NjkwNTE1M2Y0OGIwY2U1YmE0MTE0NTkzNWI5MWIyNzU1YTEyZCAxMDA2NDQKLS0t IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL2dsaWIvV2ViS2l0V2ViQ29udGV4dC5jcHAK KysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL2dsaWIvV2ViS2l0V2ViQ29udGV4dC5j cHAKQEAgLTExNTksOSArMTE1OSw5IEBAIHZvaWQgd2Via2l0X3dlYl9jb250ZXh0X3JlZ2lzdGVy X3VyaV9zY2hlbWUoV2ViS2l0V2ViQ29udGV4dCogY29udGV4dCwgY29uc3QgY2hhCiAgKgogICog VGhpcyBpcyBvbmx5IGltcGxlbWVudGVkIG9uIExpbnV4IGFuZCBpcyBhIG5vLW9wIG90aGVyd2lz ZS4KICAqCi0gKiBJZiB5b3UgcmVhZCBmcm9tIGAkWERHX0NPTkZJR19IT01FL2dfZ2V0X3ByZ25h bWUoKWAgb3IgYCRYREdfQ0FDSEVfSE9NRS9nX2dldF9wcmduYW1lKClgCi0gKiBpbiB5b3VyIFdl YlByb2Nlc3MgeW91IG11c3QgZW5zdXJlIGl0IGV4aXN0cyBiZWZvcmUgc3VicHJvY2Vzc2VzIGFy ZSBjcmVhdGVkLgotICogVGhpcyBiZWhhdmlvciBtYXkgY2hhbmdlIGluIHRoZSBmdXR1cmUuCisg KiBUaGUgV2ViUHJvY2VzcyBpcyBncmFudGVkIHJlYWQtb25seSBhY2Nlc3MgdG8gdGhlIHN1YmRp cmVjdG9yeSBtYXRjaGluZyBnX2dldF9wcmduYW1lKCkKKyAqIGluIGAkWERHX0NPTkZJR19IT01F YCwgYCRYREdfQ0FDSEVfSE9NRWAsIGFuZCBgJFhER19EQVRBX0hPTUVgIGlmIGl0IGV4aXN0cyBi ZWZvcmUgdGhlCisgKiBwcm9jZXNzIGlzIGNyZWF0ZWQuIFRoaXMgYmVoYXZpb3IgbWF5IGNoYW5n ZSBpbiB0aGUgZnV0dXJlLgogICoKICAqIFNpbmNlOiAyLjI0CiAgKi8KZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJLaXQvVUlQcm9jZXNzL0xhdW5jaGVyL2dsaWIvQnViYmxld3JhcExhdW5jaGVyLmNw cCBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0xhdW5jaGVyL2dsaWIvQnViYmxld3JhcExhdW5j aGVyLmNwcAppbmRleCA5OWExODI0Nzc0YTQ2NGU2ZGMxYmY0MzgwN2JkYzZhZDY4YWMxZTZhLi5l NDM0ZTAzMzM5ODdhOTI3NDljMDBkZGM1YjUzMzYwOTA0ZGVmMWJlIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViS2l0L1VJUHJvY2Vzcy9MYXVuY2hlci9nbGliL0J1YmJsZXdyYXBMYXVuY2hlci5jcHAK KysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvTGF1bmNoZXIvZ2xpYi9CdWJibGV3cmFwTGF1 bmNoZXIuY3BwCkBAIC03NjMsNiArNzYzLDEzIEBAIEdSZWZQdHI8R1N1YnByb2Nlc3M+IGJ1YmJs ZXdyYXBTcGF3bihHU3VicHJvY2Vzc0xhdW5jaGVyKiBsYXVuY2hlciwgY29uc3QgUHJvY2VzCiAg ICAgICAgIC8vIGFoZWFkIG9mIHRpbWUgaWYgdGhleSByZXF1aXJlIGl0LgogICAgICAgICBHVW5p cXVlUHRyPGNoYXI+IGNvbmZpZ0RpcihnX2J1aWxkX2ZpbGVuYW1lKGdfZ2V0X3VzZXJfY29uZmln X2RpcigpLCBnX2dldF9wcmduYW1lKCksIG51bGxwdHIpKTsKICAgICAgICAgR1VuaXF1ZVB0cjxj aGFyPiBjYWNoZURpcihnX2J1aWxkX2ZpbGVuYW1lKGdfZ2V0X3VzZXJfY2FjaGVfZGlyKCksIGdf Z2V0X3ByZ25hbWUoKSwgbnVsbHB0cikpOworICAgICAgICBHVW5pcXVlUHRyPGNoYXI+IGRhdGFE aXIoZ19idWlsZF9maWxlbmFtZShnX2dldF91c2VyX2RhdGFfZGlyKCksIGdfZ2V0X3ByZ25hbWUo KSwgbnVsbHB0cikpOworCisgICAgICAgIHNhbmRib3hBcmdzLmFwcGVuZFZlY3RvcihWZWN0b3I8 Q1N0cmluZz4oeworICAgICAgICAgICAgIi0tcm8tYmluZC10cnkiLCBjYWNoZURpci5nZXQoKSwg Y2FjaGVEaXIuZ2V0KCksCisgICAgICAgICAgICAiLS1yby1iaW5kLXRyeSIsIGNvbmZpZ0Rpci5n ZXQoKSwgY29uZmlnRGlyLmdldCgpLAorICAgICAgICAgICAgIi0tcm8tYmluZC10cnkiLCBkYXRh RGlyLmdldCgpLCBkYXRhRGlyLmdldCgpLAorICAgICAgICB9KSk7CiAKICAgICAgICAgVmVjdG9y PFN0cmluZz4gZXh0cmFQYXRocyA9IHsgImFwcGxpY2F0aW9uQ2FjaGVEaXJlY3RvcnkiLCAid2F5 bGFuZFNvY2tldCJ9OwogICAgICAgICBmb3IgKGNvbnN0IGF1dG8mIHBhdGggOiBleHRyYVBhdGhz KSB7CkBAIC03NzEsMTEgKzc3OCw2IEBAIEdSZWZQdHI8R1N1YnByb2Nlc3M+IGJ1YmJsZXdyYXBT cGF3bihHU3VicHJvY2Vzc0xhdW5jaGVyKiBsYXVuY2hlciwgY29uc3QgUHJvY2VzCiAgICAgICAg ICAgICAgICAgc2FuZGJveEFyZ3MuYXBwZW5kVmVjdG9yKFZlY3RvcjxDU3RyaW5nPih7ICItLWJp bmQtdHJ5IiwgZXh0cmFQYXRoLnV0ZjgoKSwgZXh0cmFQYXRoLnV0ZjgoKSB9KSk7CiAgICAgICAg IH0KIAotICAgICAgICBzYW5kYm94QXJncy5hcHBlbmRWZWN0b3IoVmVjdG9yPENTdHJpbmc+KHsK LSAgICAgICAgICAgICItLXJvLWJpbmQtdHJ5IiwgY2FjaGVEaXIuZ2V0KCksIGNhY2hlRGlyLmdl dCgpLAotICAgICAgICAgICAgIi0tcm8tYmluZC10cnkiLCBjb25maWdEaXIuZ2V0KCksIGNvbmZp Z0Rpci5nZXQoKSwKLSAgICAgICAgfSkpOwotCiAgICAgICAgIGJpbmREQnVzU2Vzc2lvbihzYW5k Ym94QXJncywgcHJveHkpOwogICAgICAgICAvLyBGSVhNRTogV2Ugc2hvdWxkIG1vdmUgdG8gUGlw ZXdpcmUgYXMgc29vbiBhcyB2aWFibGUsIFB1bHNlIGRvZXNuJ3QgcmVzdHJpY3QgY2xpZW50cyBh dG0uCiAgICAgICAgIGJpbmRQdWxzZShzYW5kYm94QXJncyk7Cg== 357810 2018-12-20 07:24:03 -0800 2018-12-20 08:18:35 -0800 Patch bug-192929-20181220102402.patch text/plain 3632 pgriffis U3VidmVyc2lvbiBSZXZpc2lvbjogMjM5MTI0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDg5NjkyMGM3ZTU4Mzg1YTQ1 NjM5ZWJhMzhjYmFjMDY3YjA3MzZlZTMuLmViZTJjNzVkMDZkMjhiNzUyYjgzZGY4NGEzMzMxYjBk YWU1NDVkZWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTgtMTItMjAgIFBhdHJpY2sg R3JpZmZpcyAgPHBncmlmZmlzQGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dUS11bV1BFXSBHcmFu dCB0aGUgc2FuZGJveCByZWFkIGFjY2VzcyB0byBYREdfREFUQV9IT01FL3ByZ25hbWUKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5MjkyOQorCisgICAg ICAgIFJldmlld2VkIGJ5IE1pY2hhZWwgQ2F0YW56YXJvLgorCisgICAgICAgICogVUlQcm9jZXNz L0FQSS9nbGliL1dlYktpdFdlYkNvbnRleHQuY3BwOgorICAgICAgICAqIFVJUHJvY2Vzcy9MYXVu Y2hlci9nbGliL0J1YmJsZXdyYXBMYXVuY2hlci5jcHA6CisgICAgICAgIChXZWJLaXQ6OmJ1YmJs ZXdyYXBTcGF3bik6CisKIDIwMTgtMTItMTIgIENocmlzIEZsZWl6YWNoICA8Y2ZsZWl6YWNoQGFw cGxlLmNvbT4KIAogICAgICAgICBbbWV0YV1bV2ViS2l0XSBSZW1vdmUgdXNpbmcgbmFtZXNwYWNl IFdlYkNvcmUgYW5kIFdlYktpdCBpbiB0aGUgZ2xvYmFsIHNjb3BlIGZvciB1bmlmaWVkIHNvdXJj ZSBidWlsZHMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9nbGliL1dl YktpdFdlYkNvbnRleHQuY3BwIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL2dsaWIvV2Vi S2l0V2ViQ29udGV4dC5jcHAKaW5kZXggN2FmYTc5YzYxZWJjYzAyZWNmYjhlZjk5YmRkZGUxMzc1 ODYyNDEzMy4uMzY0ZjEyNzczN2M4ZTY0NGNlMzU0NmI1YWQwMDEzYWZiZmYzOGVmMiAxMDA2NDQK LS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL2dsaWIvV2ViS2l0V2ViQ29udGV4dC5j cHAKKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL2dsaWIvV2ViS2l0V2ViQ29udGV4 dC5jcHAKQEAgLTExNTksOSArMTE1OSw5IEBAIHZvaWQgd2Via2l0X3dlYl9jb250ZXh0X3JlZ2lz dGVyX3VyaV9zY2hlbWUoV2ViS2l0V2ViQ29udGV4dCogY29udGV4dCwgY29uc3QgY2hhCiAgKgog ICogVGhpcyBpcyBvbmx5IGltcGxlbWVudGVkIG9uIExpbnV4IGFuZCBpcyBhIG5vLW9wIG90aGVy d2lzZS4KICAqCi0gKiBJZiB5b3UgcmVhZCBmcm9tIGAkWERHX0NPTkZJR19IT01FL2dfZ2V0X3By Z25hbWUoKWAgb3IgYCRYREdfQ0FDSEVfSE9NRS9nX2dldF9wcmduYW1lKClgCi0gKiBpbiB5b3Vy IFdlYlByb2Nlc3MgeW91IG11c3QgZW5zdXJlIGl0IGV4aXN0cyBiZWZvcmUgc3VicHJvY2Vzc2Vz IGFyZSBjcmVhdGVkLgotICogVGhpcyBiZWhhdmlvciBtYXkgY2hhbmdlIGluIHRoZSBmdXR1cmUu CisgKiBUaGUgd2ViIHByb2Nlc3MgaXMgZ3JhbnRlZCByZWFkLW9ubHkgYWNjZXNzIHRvIHRoZSBz dWJkaXJlY3RvcnkgbWF0Y2hpbmcgZ19nZXRfcHJnbmFtZSgpCisgKiBpbiBgJFhER19DT05GSUdf SE9NRWAsIGAkWERHX0NBQ0hFX0hPTUVgLCBhbmQgYCRYREdfREFUQV9IT01FYCBpZiBpdCBleGlz dHMgYmVmb3JlIHRoZQorICogcHJvY2VzcyBpcyBjcmVhdGVkLiBUaGlzIGJlaGF2aW9yIG1heSBj aGFuZ2UgaW4gdGhlIGZ1dHVyZS4KICAqCiAgKiBTaW5jZTogMi4yNAogICovCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9MYXVuY2hlci9nbGliL0J1YmJsZXdyYXBMYXVuY2hl ci5jcHAgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9MYXVuY2hlci9nbGliL0J1YmJsZXdyYXBM YXVuY2hlci5jcHAKaW5kZXggOTlhMTgyNDc3NGE0NjRlNmRjMWJmNDM4MDdiZGM2YWQ2OGFjMWU2 YS4uZTQzNGUwMzMzOTg3YTkyNzQ5YzAwZGRjNWI1MzM2MDkwNGRlZjFiZSAxMDA2NDQKLS0tIGEv U291cmNlL1dlYktpdC9VSVByb2Nlc3MvTGF1bmNoZXIvZ2xpYi9CdWJibGV3cmFwTGF1bmNoZXIu Y3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0xhdW5jaGVyL2dsaWIvQnViYmxld3Jh cExhdW5jaGVyLmNwcApAQCAtNzYzLDYgKzc2MywxMyBAQCBHUmVmUHRyPEdTdWJwcm9jZXNzPiBi dWJibGV3cmFwU3Bhd24oR1N1YnByb2Nlc3NMYXVuY2hlciogbGF1bmNoZXIsIGNvbnN0IFByb2Nl cwogICAgICAgICAvLyBhaGVhZCBvZiB0aW1lIGlmIHRoZXkgcmVxdWlyZSBpdC4KICAgICAgICAg R1VuaXF1ZVB0cjxjaGFyPiBjb25maWdEaXIoZ19idWlsZF9maWxlbmFtZShnX2dldF91c2VyX2Nv bmZpZ19kaXIoKSwgZ19nZXRfcHJnbmFtZSgpLCBudWxscHRyKSk7CiAgICAgICAgIEdVbmlxdWVQ dHI8Y2hhcj4gY2FjaGVEaXIoZ19idWlsZF9maWxlbmFtZShnX2dldF91c2VyX2NhY2hlX2Rpcigp LCBnX2dldF9wcmduYW1lKCksIG51bGxwdHIpKTsKKyAgICAgICAgR1VuaXF1ZVB0cjxjaGFyPiBk YXRhRGlyKGdfYnVpbGRfZmlsZW5hbWUoZ19nZXRfdXNlcl9kYXRhX2RpcigpLCBnX2dldF9wcmdu YW1lKCksIG51bGxwdHIpKTsKKworICAgICAgICBzYW5kYm94QXJncy5hcHBlbmRWZWN0b3IoVmVj dG9yPENTdHJpbmc+KHsKKyAgICAgICAgICAgICItLXJvLWJpbmQtdHJ5IiwgY2FjaGVEaXIuZ2V0 KCksIGNhY2hlRGlyLmdldCgpLAorICAgICAgICAgICAgIi0tcm8tYmluZC10cnkiLCBjb25maWdE aXIuZ2V0KCksIGNvbmZpZ0Rpci5nZXQoKSwKKyAgICAgICAgICAgICItLXJvLWJpbmQtdHJ5Iiwg ZGF0YURpci5nZXQoKSwgZGF0YURpci5nZXQoKSwKKyAgICAgICAgfSkpOwogCiAgICAgICAgIFZl Y3RvcjxTdHJpbmc+IGV4dHJhUGF0aHMgPSB7ICJhcHBsaWNhdGlvbkNhY2hlRGlyZWN0b3J5Iiwg IndheWxhbmRTb2NrZXQifTsKICAgICAgICAgZm9yIChjb25zdCBhdXRvJiBwYXRoIDogZXh0cmFQ YXRocykgewpAQCAtNzcxLDExICs3NzgsNiBAQCBHUmVmUHRyPEdTdWJwcm9jZXNzPiBidWJibGV3 cmFwU3Bhd24oR1N1YnByb2Nlc3NMYXVuY2hlciogbGF1bmNoZXIsIGNvbnN0IFByb2NlcwogICAg ICAgICAgICAgICAgIHNhbmRib3hBcmdzLmFwcGVuZFZlY3RvcihWZWN0b3I8Q1N0cmluZz4oeyAi LS1iaW5kLXRyeSIsIGV4dHJhUGF0aC51dGY4KCksIGV4dHJhUGF0aC51dGY4KCkgfSkpOwogICAg ICAgICB9CiAKLSAgICAgICAgc2FuZGJveEFyZ3MuYXBwZW5kVmVjdG9yKFZlY3RvcjxDU3RyaW5n Pih7Ci0gICAgICAgICAgICAiLS1yby1iaW5kLXRyeSIsIGNhY2hlRGlyLmdldCgpLCBjYWNoZURp ci5nZXQoKSwKLSAgICAgICAgICAgICItLXJvLWJpbmQtdHJ5IiwgY29uZmlnRGlyLmdldCgpLCBj b25maWdEaXIuZ2V0KCksCi0gICAgICAgIH0pKTsKLQogICAgICAgICBiaW5kREJ1c1Nlc3Npb24o c2FuZGJveEFyZ3MsIHByb3h5KTsKICAgICAgICAgLy8gRklYTUU6IFdlIHNob3VsZCBtb3ZlIHRv IFBpcGV3aXJlIGFzIHNvb24gYXMgdmlhYmxlLCBQdWxzZSBkb2Vzbid0IHJlc3RyaWN0IGNsaWVu dHMgYXRtLgogICAgICAgICBiaW5kUHVsc2Uoc2FuZGJveEFyZ3MpOwo=