192927 2018-12-20 05:43:18 -0800 [GTK] WebDriver: tests in imported/w3c/webdriver/tests/element_clear/user_prompts.py are failing 2018-12-20 09:45:39 -0800 1 1 1 Unclassified WebKit WebDriver WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=192928 Gtk, InRadar P2 Normal --- 1 cgarcia webkit-unassigned bburg berto bugs-noreply commit-queue ews-watchlist gustavo mcatanzaro webkit-bug-importer oldest_to_newest 1489824 0 cgarcia 2018-12-20 05:43:18 -0800 Some of them time out and others fail. We are not handling user prompts un clear element command. We should also make sure that the web view gets back the focus when a script dialog is dismissed. 1489825 1 357807 cgarcia 2018-12-20 05:46:47 -0800 Created attachment 357807 Patch 1489826 2 ews-watchlist 2018-12-20 05:49:47 -0800 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 1489881 3 357807 commit-queue 2018-12-20 09:44:47 -0800 Comment on attachment 357807 Patch Clearing flags on attachment: 357807 Committed r239444: <https://trac.webkit.org/changeset/239444> 1489882 4 commit-queue 2018-12-20 09:44:49 -0800 All reviewed patches have been landed. Closing bug. 1489886 5 webkit-bug-importer 2018-12-20 09:45:39 -0800 <rdar://problem/46874544> 357807 2018-12-20 05:46:47 -0800 2018-12-20 09:44:47 -0800 Patch wd-gtk-clear-prompts.diff text/plain 4728 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJEcml2ZXIvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkRyaXZl ci9DaGFuZ2VMb2cKaW5kZXggMGY4MWMxNjFhMDcuLjdiMmYyNWE4ZTBmIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViRHJpdmVyL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViRHJpdmVyL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDE1IEBACisyMDE4LTEyLTIwICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNn YXJjaWFAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLXSBXZWJEcml2ZXI6IHRlc3RzIGluIGlt cG9ydGVkL3czYy93ZWJkcml2ZXIvdGVzdHMvZWxlbWVudF9jbGVhci91c2VyX3Byb21wdHMucHkg YXJlIGZhaWxpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTE5MjkyNworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIEhhbmRsZSB1c2VyIHByb21wdHMgaW4gZWxlbWVudCBjbGVhciBjb21tYW5kLgorCisgICAg ICAgICogU2Vzc2lvbi5jcHA6CisgICAgICAgIChXZWJEcml2ZXI6OlNlc3Npb246OmVsZW1lbnRD bGVhcik6CisKIDIwMTgtMTItMTkgIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KIAog ICAgICAgICB3dGYvT3B0aW9uYWwuaDogbW92ZS1jb25zdHJ1Y3RvciBhbmQgbW92ZS1hc3NpZ25t ZW50IG9wZXJhdG9yIHNob3VsZCBkaXNlbmdhZ2UgdGhlIHZhbHVlIGJlaW5nIG1vdmVkIGZyb20K ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJEcml2ZXIvU2Vzc2lvbi5jcHAgYi9Tb3VyY2UvV2ViRHJp dmVyL1Nlc3Npb24uY3BwCmluZGV4IDBjNjNhMjBhYTEyLi5hZjJiYjdhN2NmNSAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkRyaXZlci9TZXNzaW9uLmNwcAorKysgYi9Tb3VyY2UvV2ViRHJpdmVyL1Nl c3Npb24uY3BwCkBAIC0xNTYwLDIxICsxNTYwLDI4IEBAIHZvaWQgU2Vzc2lvbjo6ZWxlbWVudENs ZWFyKGNvbnN0IFN0cmluZyYgZWxlbWVudElELCBGdW5jdGlvbjx2b2lkIChDb21tYW5kUmVzdWx0 CiAgICAgICAgIHJldHVybjsKICAgICB9CiAKLSAgICBSZWZQdHI8SlNPTjo6QXJyYXk+IGFyZ3Vt ZW50cyA9IEpTT046OkFycmF5OjpjcmVhdGUoKTsKLSAgICBhcmd1bWVudHMtPnB1c2hTdHJpbmco Y3JlYXRlRWxlbWVudChlbGVtZW50SUQpLT50b0pTT05TdHJpbmcoKSk7Ci0KLSAgICBSZWZQdHI8 SlNPTjo6T2JqZWN0PiBwYXJhbWV0ZXJzID0gSlNPTjo6T2JqZWN0OjpjcmVhdGUoKTsKLSAgICBw YXJhbWV0ZXJzLT5zZXRTdHJpbmcoImJyb3dzaW5nQ29udGV4dEhhbmRsZSJfcywgbV90b3BsZXZl bEJyb3dzaW5nQ29udGV4dC52YWx1ZSgpKTsKLSAgICBpZiAobV9jdXJyZW50QnJvd3NpbmdDb250 ZXh0KQotICAgICAgICBwYXJhbWV0ZXJzLT5zZXRTdHJpbmcoImZyYW1lSGFuZGxlIl9zLCBtX2N1 cnJlbnRCcm93c2luZ0NvbnRleHQudmFsdWUoKSk7Ci0gICAgcGFyYW1ldGVycy0+c2V0U3RyaW5n KCJmdW5jdGlvbiJfcywgRm9ybUVsZW1lbnRDbGVhckphdmFTY3JpcHQpOwotICAgIHBhcmFtZXRl cnMtPnNldEFycmF5KCJhcmd1bWVudHMiX3MsIFdURk1vdmUoYXJndW1lbnRzKSk7Ci0gICAgbV9o b3N0LT5zZW5kQ29tbWFuZFRvQmFja2VuZCgiZXZhbHVhdGVKYXZhU2NyaXB0RnVuY3Rpb24iX3Ms IFdURk1vdmUocGFyYW1ldGVycyksIFtwcm90ZWN0ZWRUaGlzID0gbWFrZVJlZigqdGhpcyksIGNv bXBsZXRpb25IYW5kbGVyID0gV1RGTW92ZShjb21wbGV0aW9uSGFuZGxlcildKFNlc3Npb25Ib3N0 OjpDb21tYW5kUmVzcG9uc2UmJiByZXNwb25zZSkgewotICAgICAgICBpZiAocmVzcG9uc2UuaXNF cnJvcikgewotICAgICAgICAgICAgY29tcGxldGlvbkhhbmRsZXIoQ29tbWFuZFJlc3VsdDo6ZmFp bChXVEZNb3ZlKHJlc3BvbnNlLnJlc3BvbnNlT2JqZWN0KSkpOworICAgIGhhbmRsZVVzZXJQcm9t cHRzKFt0aGlzLCBlbGVtZW50SUQsIGNvbXBsZXRpb25IYW5kbGVyID0gV1RGTW92ZShjb21wbGV0 aW9uSGFuZGxlcildKENvbW1hbmRSZXN1bHQmJiByZXN1bHQpIG11dGFibGUgeworICAgICAgICBp ZiAocmVzdWx0LmlzRXJyb3IoKSkgeworICAgICAgICAgICAgY29tcGxldGlvbkhhbmRsZXIoV1RG TW92ZShyZXN1bHQpKTsKICAgICAgICAgICAgIHJldHVybjsKICAgICAgICAgfQotICAgICAgICBj b21wbGV0aW9uSGFuZGxlcihDb21tYW5kUmVzdWx0OjpzdWNjZXNzKCkpOworCisgICAgICAgIFJl ZlB0cjxKU09OOjpBcnJheT4gYXJndW1lbnRzID0gSlNPTjo6QXJyYXk6OmNyZWF0ZSgpOworICAg ICAgICBhcmd1bWVudHMtPnB1c2hTdHJpbmcoY3JlYXRlRWxlbWVudChlbGVtZW50SUQpLT50b0pT T05TdHJpbmcoKSk7CisKKyAgICAgICAgUmVmUHRyPEpTT046Ok9iamVjdD4gcGFyYW1ldGVycyA9 IEpTT046Ok9iamVjdDo6Y3JlYXRlKCk7CisgICAgICAgIHBhcmFtZXRlcnMtPnNldFN0cmluZygi YnJvd3NpbmdDb250ZXh0SGFuZGxlIl9zLCBtX3RvcGxldmVsQnJvd3NpbmdDb250ZXh0LnZhbHVl KCkpOworICAgICAgICBpZiAobV9jdXJyZW50QnJvd3NpbmdDb250ZXh0KQorICAgICAgICAgICAg cGFyYW1ldGVycy0+c2V0U3RyaW5nKCJmcmFtZUhhbmRsZSJfcywgbV9jdXJyZW50QnJvd3NpbmdD b250ZXh0LnZhbHVlKCkpOworICAgICAgICBwYXJhbWV0ZXJzLT5zZXRTdHJpbmcoImZ1bmN0aW9u Il9zLCBGb3JtRWxlbWVudENsZWFySmF2YVNjcmlwdCk7CisgICAgICAgIHBhcmFtZXRlcnMtPnNl dEFycmF5KCJhcmd1bWVudHMiX3MsIFdURk1vdmUoYXJndW1lbnRzKSk7CisgICAgICAgIG1faG9z dC0+c2VuZENvbW1hbmRUb0JhY2tlbmQoImV2YWx1YXRlSmF2YVNjcmlwdEZ1bmN0aW9uIl9zLCBX VEZNb3ZlKHBhcmFtZXRlcnMpLCBbcHJvdGVjdGVkVGhpcyA9IG1ha2VSZWYoKnRoaXMpLCBjb21w bGV0aW9uSGFuZGxlciA9IFdURk1vdmUoY29tcGxldGlvbkhhbmRsZXIpXShTZXNzaW9uSG9zdDo6 Q29tbWFuZFJlc3BvbnNlJiYgcmVzcG9uc2UpIHsKKyAgICAgICAgICAgIGlmIChyZXNwb25zZS5p c0Vycm9yKSB7CisgICAgICAgICAgICAgICAgY29tcGxldGlvbkhhbmRsZXIoQ29tbWFuZFJlc3Vs dDo6ZmFpbChXVEZNb3ZlKHJlc3BvbnNlLnJlc3BvbnNlT2JqZWN0KSkpOworICAgICAgICAgICAg ICAgIHJldHVybjsKKyAgICAgICAgICAgIH0KKyAgICAgICAgICAgIGNvbXBsZXRpb25IYW5kbGVy KENvbW1hbmRSZXN1bHQ6OnN1Y2Nlc3MoKSk7CisgICAgICAgIH0pOwogICAgIH0pOwogfQogCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdl TG9nCmluZGV4IDNmMjdhOTY1Y2M2Li45YzkxOGI3ODM1MCAxMDA2NDQKLS0tIGEvU291cmNlL1dl YktpdC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9DaGFuZ2VMb2cKQEAgLTEsMyArMSwx NSBAQAorMjAxOC0xMi0yMCAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5j b20+CisKKyAgICAgICAgW0dUS10gV2ViRHJpdmVyOiB0ZXN0cyBpbiBpbXBvcnRlZC93M2Mvd2Vi ZHJpdmVyL3Rlc3RzL2VsZW1lbnRfY2xlYXIvdXNlcl9wcm9tcHRzLnB5IGFyZSBmYWlsaW5nCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTI5MjcKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBHaXZlIHRoZSBm b2N1cyBiYWNrIHRvIHRoZSB3ZWIgdmlldyB3aGVuIGEgZGlhbG9nIGlzIGRpc21pc3NlZC4KKwor ICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFdlYlZpZXdCYXNlLmNwcDoKKyAgICAg ICAgKHdlYmtpdFdlYlZpZXdCYXNlQ29udGFpbmVyUmVtb3ZlKToKKwogMjAxOC0xMi0xOSAgQ2hy aXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgogCiAgICAgICAgIHd0Zi9PcHRpb25hbC5oOiBt b3ZlLWNvbnN0cnVjdG9yIGFuZCBtb3ZlLWFzc2lnbm1lbnQgb3BlcmF0b3Igc2hvdWxkIGRpc2Vu Z2FnZSB0aGUgdmFsdWUgYmVpbmcgbW92ZWQgZnJvbQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktp dC9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRXZWJWaWV3QmFzZS5jcHAgYi9Tb3VyY2UvV2ViS2l0 L1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFdlYlZpZXdCYXNlLmNwcAppbmRleCBkN2QwYTZkNDk4 NC4uNGIyNmIxMDhhYWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9n dGsvV2ViS2l0V2ViVmlld0Jhc2UuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQ SS9ndGsvV2ViS2l0V2ViVmlld0Jhc2UuY3BwCkBAIC00NjAsNiArNDYwLDggQEAgc3RhdGljIHZv aWQgd2Via2l0V2ViVmlld0Jhc2VDb250YWluZXJSZW1vdmUoR3RrQ29udGFpbmVyKiBjb250YWlu ZXIsIEd0a1dpZGdldCoKICAgICAgICAgcHJpdi0+aW5zcGVjdG9yVmlld1NpemUgPSAwOwogICAg IH0gZWxzZSBpZiAocHJpdi0+ZGlhbG9nID09IHdpZGdldCkgewogICAgICAgICBwcml2LT5kaWFs b2cgPSBudWxscHRyOworICAgICAgICBpZiAoZ3RrX3dpZGdldF9nZXRfdmlzaWJsZSh3aWRnZXRD b250YWluZXIpKQorICAgICAgICAgICAgZ3RrX3dpZGdldF9ncmFiX2ZvY3VzKHdpZGdldENvbnRh aW5lcik7CiAgICAgfSBlbHNlIHsKICAgICAgICAgQVNTRVJUKHByaXYtPmNoaWxkcmVuLmNvbnRh aW5zKHdpZGdldCkpOwogICAgICAgICBwcml2LT5jaGlsZHJlbi5yZW1vdmUod2lkZ2V0KTsK