192918 2018-12-19 22:52:34 -0800 Web Inspector: Audits: don't cache default audits 2018-12-20 10:15:55 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 190754 1 hi hi bburg commit-queue hi inspector-bugzilla-changes webkit-bug-importer oldest_to_newest 1489751 0 hi 2018-12-19 22:52:34 -0800 If the localization changes between WebInspector sessions, the default audits should use the new localization instead of the old one, which will be cached along with the audit in the IndexedDB. 1489752 1 hi 2018-12-19 22:52:44 -0800 <rdar://problem/46626543> 1489753 2 357788 hi 2018-12-19 22:54:36 -0800 Created attachment 357788 Patch 1489786 3 357788 bburg 2018-12-20 00:06:01 -0800 Comment on attachment 357788 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=357788&action=review r=me > Source/WebInspectorUI/ChangeLog:9 > + * UserInterface/Controllers/AuditManager.js: Needs a changelog. For example, explain that by caching you mean using IndexedDB to save the audits. If default audits are not stored in IDB, they will be programmatically recreated every time with UIString labels looked up at runtime using the current locale. 1489889 4 357824 hi 2018-12-20 09:48:15 -0800 Created attachment 357824 Patch 1489907 5 357824 commit-queue 2018-12-20 10:15:54 -0800 Comment on attachment 357824 Patch Clearing flags on attachment: 357824 Committed r239449: <https://trac.webkit.org/changeset/239449> 1489908 6 commit-queue 2018-12-20 10:15:55 -0800 All reviewed patches have been landed. Closing bug. 357788 2018-12-19 22:54:36 -0800 2018-12-20 09:48:13 -0800 Patch bug-192918-20181219235436.patch text/plain 1770 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGI0NjRjY2E4NzJhZGI0YzdkOWVjOGRlOTU1YmNk M2FiMmQ5YTY2MzcuLjljYTNlNjQ1MDhjMTBhZWEwOWQ4MGViZTE2M2JkNTY0Y2RiYzYzODcgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE4LTEyLTE5ICBEZXZp biBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBB dWRpdHM6IGRvbid0IGNhY2hlIGRlZmF1bHQgYXVkaXRzCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTI5MTgKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVt LzQ2NjI2NTQzPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgICogVXNlckludGVyZmFjZS9Db250cm9sbGVycy9BdWRpdE1hbmFnZXIuanM6CisgICAgICAg IChXSS5BdWRpdE1hbmFnZXIucHJvdG90eXBlLnJlbW92ZVRlc3QpOgorICAgICAgICAoV0kuQXVk aXRNYW5hZ2VyLnByb3RvdHlwZS5hZGREZWZhdWx0VGVzdHNJZk5lZWRlZCk6CisKIDIwMTgtMTIt MTkgIERldmluIFJvdXNzbyAgPGRyb3Vzc29AYXBwbGUuY29tPgogCiAgICAgICAgIFdlYiBJbnNw ZWN0b3I6IEF1ZGl0OiBmaXggZGVzY3JpcHRpb25zIGZvciBkZWZhdWx0IHRlc3RzCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Db250cm9sbGVycy9BdWRp dE1hbmFnZXIuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Db250cm9s bGVycy9BdWRpdE1hbmFnZXIuanMKaW5kZXggM2Y3MjdmM2FiODNlMWE5NTcyMjEyZWIyOTA0YTE2 NGFhMzdmMjVjYS4uNzY4NGI0ZDk2MDFmNDQ1YjEzOTdmMzI2YjgyNGExNWEyNGI0MmVmMCAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQ29udHJvbGxlcnMv QXVkaXRNYW5hZ2VyLmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNl L0NvbnRyb2xsZXJzL0F1ZGl0TWFuYWdlci5qcwpAQCAtMTcyLDcgKzE3Miw4IEBAIFdJLkF1ZGl0 TWFuYWdlciA9IGNsYXNzIEF1ZGl0TWFuYWdlciBleHRlbmRzIFdJLk9iamVjdAogCiAgICAgICAg IHRoaXMuZGlzcGF0Y2hFdmVudFRvTGlzdGVuZXJzKFdJLkF1ZGl0TWFuYWdlci5FdmVudC5UZXN0 UmVtb3ZlZCwge3Rlc3R9KTsKIAotICAgICAgICBXSS5vYmplY3RTdG9yZXMuYXVkaXRzLmRlbGV0 ZU9iamVjdCh0ZXN0KTsKKyAgICAgICAgaWYgKCF0ZXN0Ll9fZGVmYXVsdCkKKyAgICAgICAgICAg IFdJLm9iamVjdFN0b3Jlcy5hdWRpdHMuZGVsZXRlT2JqZWN0KHRlc3QpOwogICAgIH0KIAogICAg IC8vIFByaXZhdGUKQEAgLTI1Myw4ICsyNTQsOCBAQCBXSS5BdWRpdE1hbmFnZXIgPSBjbGFzcyBB dWRpdE1hbmFnZXIgZXh0ZW5kcyBXSS5PYmplY3QKICAgICAgICAgXTsKIAogICAgICAgICBmb3Ig KGxldCB0ZXN0IG9mIGRlZmF1bHRUZXN0cykgeworICAgICAgICAgICAgdGVzdC5fX2RlZmF1bHQg PSB0cnVlOwogICAgICAgICAgICAgdGhpcy5fYWRkVGVzdCh0ZXN0KTsKLSAgICAgICAgICAgIFdJ Lm9iamVjdFN0b3Jlcy5hdWRpdHMuYWRkT2JqZWN0KHRlc3QpOwogICAgICAgICB9CiAgICAgfQog fTsK 357824 2018-12-20 09:48:15 -0800 2018-12-20 10:15:54 -0800 Patch bug-192918-20181220104814.patch text/plain 2065 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGI0NjRjY2E4NzJhZGI0YzdkOWVjOGRlOTU1YmNk M2FiMmQ5YTY2MzcuLjgxY2VkNzk0ODNhMmY1M2U1ZThiOTkwMjAyZDE4MmEyN2JkZGZjY2YgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE4LTEyLTIwICBEZXZp biBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBB dWRpdHM6IGRvbid0IGNhY2hlIGRlZmF1bHQgYXVkaXRzCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTI5MTgKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVt LzQ2NjI2NTQzPgorCisgICAgICAgIFJldmlld2VkIGJ5IEJyaWFuIEJ1cmcuCisKKyAgICAgICAg SW5zdGVhZCBvZiBhZGRpbmcgdGhlIGRlZmF1bHQgYXVkaXRzIHRvIHRoZSAiYXVkaXRzIiBgV0ku T2JqZWN0U3RvcmVgLCB3aGljaCBwcmVzZXJ2ZXMgdGhlbQorICAgICAgICBhY3Jvc3MgV2ViSW5z cGVjdG9yIHNlc3Npb25zLCBsb2FkIHRoZW0gZXZlcnkgdGltZSBXZWJJbnNwZWN0b3IgaXMgb3Bl bmVkICh1bmxlc3MgdGhlcmUgYXJlCisgICAgICAgIGV4aXN0aW5nIGF1ZGl0cykgc28gdGhhdCB0 aGUgbG9jYWxpemVkIHN0cmluZ3MgYXJlIGFibGUgdG8gcmVzcG9uZCB0byBsb2NhbGUgY2hhbmdl cy4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvQ29udHJvbGxlcnMvQXVkaXRNYW5hZ2VyLmpz OgorICAgICAgICAoV0kuQXVkaXRNYW5hZ2VyLnByb3RvdHlwZS5yZW1vdmVUZXN0KToKKyAgICAg ICAgKFdJLkF1ZGl0TWFuYWdlci5wcm90b3R5cGUuYWRkRGVmYXVsdFRlc3RzSWZOZWVkZWQpOgor CiAyMDE4LTEyLTE5ICBEZXZpbiBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KIAogICAgICAg ICBXZWIgSW5zcGVjdG9yOiBBdWRpdDogZml4IGRlc2NyaXB0aW9ucyBmb3IgZGVmYXVsdCB0ZXN0 cwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQ29udHJv bGxlcnMvQXVkaXRNYW5hZ2VyLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZh Y2UvQ29udHJvbGxlcnMvQXVkaXRNYW5hZ2VyLmpzCmluZGV4IDNmNzI3ZjNhYjgzZTFhOTU3MjIx MmViMjkwNGExNjRhYTM3ZjI1Y2EuLjc2ODRiNGQ5NjAxZjQ0NWIxMzk3ZjMyNmI4MjRhMTVhMjRi NDJlZjAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0Nv bnRyb2xsZXJzL0F1ZGl0TWFuYWdlci5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNl ckludGVyZmFjZS9Db250cm9sbGVycy9BdWRpdE1hbmFnZXIuanMKQEAgLTE3Miw3ICsxNzIsOCBA QCBXSS5BdWRpdE1hbmFnZXIgPSBjbGFzcyBBdWRpdE1hbmFnZXIgZXh0ZW5kcyBXSS5PYmplY3QK IAogICAgICAgICB0aGlzLmRpc3BhdGNoRXZlbnRUb0xpc3RlbmVycyhXSS5BdWRpdE1hbmFnZXIu RXZlbnQuVGVzdFJlbW92ZWQsIHt0ZXN0fSk7CiAKLSAgICAgICAgV0kub2JqZWN0U3RvcmVzLmF1 ZGl0cy5kZWxldGVPYmplY3QodGVzdCk7CisgICAgICAgIGlmICghdGVzdC5fX2RlZmF1bHQpCisg ICAgICAgICAgICBXSS5vYmplY3RTdG9yZXMuYXVkaXRzLmRlbGV0ZU9iamVjdCh0ZXN0KTsKICAg ICB9CiAKICAgICAvLyBQcml2YXRlCkBAIC0yNTMsOCArMjU0LDggQEAgV0kuQXVkaXRNYW5hZ2Vy ID0gY2xhc3MgQXVkaXRNYW5hZ2VyIGV4dGVuZHMgV0kuT2JqZWN0CiAgICAgICAgIF07CiAKICAg ICAgICAgZm9yIChsZXQgdGVzdCBvZiBkZWZhdWx0VGVzdHMpIHsKKyAgICAgICAgICAgIHRlc3Qu X19kZWZhdWx0ID0gdHJ1ZTsKICAgICAgICAgICAgIHRoaXMuX2FkZFRlc3QodGVzdCk7Ci0gICAg ICAgICAgICBXSS5vYmplY3RTdG9yZXMuYXVkaXRzLmFkZE9iamVjdCh0ZXN0KTsKICAgICAgICAg fQogICAgIH0KIH07Cg==