192913 2018-12-19 20:45:43 -0800 UserMedia test should use WKPageNavigationClient 2019-01-03 10:22:27 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build PC Linux RESOLVED FIXED InRadar P2 Normal --- 1 mcatanzaro mcatanzaro achristensen commit-queue lforschler mcatanzaro webkit-bug-importer youennf oldest_to_newest 1489706 0 mcatanzaro 2018-12-19 20:45:43 -0800 r239167 "On page close, WebPage::m_userMediaPermissionRequestManager is nullified too early" introduced a deprecation warning: [452/530] Building CXX object Tools/TestWebKitAPI/C...keFiles/TestWebKit.dir/Tests/WebKit/UserMedia.cpp.o ../../Tools/TestWebKitAPI/Tests/WebKit/UserMedia.cpp: In member function ‘virtual void TestWebKitAPI::WebKit_OnDeviceChangeCrash_Test::TestBody()’: ../../Tools/TestWebKitAPI/Tests/WebKit/UserMedia.cpp:139:66: warning: ‘void WKPageSetPageLoaderClient(WKPageRef, const WKPageLoaderClientBase*)’ is deprecated: use WKPageSetPageNavigationClient [-Wdeprecated-declarations] WKPageSetPageLoaderClient(webView2.page(), &loaderClient.base); ^ In file included from DerivedSources/ForwardingHeaders/WebKit/WKPage.h:1, from ../../Source/WebKit/UIProcess/API/C/WebKit2_C.h:53, from DerivedSources/ForwardingHeaders/WebKit/WebKit2_C.h:1, from ../../Tools/TestWebKitAPI/config.h:49, from ../../Tools/TestWebKitAPI/Tests/WebKit/UserMedia.cpp:20: ../../Source/WebKit/UIProcess/API/C/WKPage.h:228:16: note: declared here WK_EXPORT void WKPageSetPageLoaderClient(WKPageRef page, const WKPageLoaderClientBase* client) WK_C_API_DEPRECATED_WITH_REPLACEMENT(WKPageSetPageNavigationClient, macosx(WK_MAC_TBA)); ^~~~~~~~~~~~~~~~~~~~~~~~~ ../../Tools/TestWebKitAPI/Tests/WebKit/UserMedia.cpp:139:66: warning: ‘void WKPageSetPageLoaderClient(WKPageRef, const WKPageLoaderClientBase*)’ is deprecated: use WKPageSetPageNavigationClient [-Wdeprecated-declarations] WKPageSetPageLoaderClient(webView2.page(), &loaderClient.base); ^ In file included from DerivedSources/ForwardingHeaders/WebKit/WKPage.h:1, from ../../Source/WebKit/UIProcess/API/C/WebKit2_C.h:53, from DerivedSources/ForwardingHeaders/WebKit/WebKit2_C.h:1, from ../../Tools/TestWebKitAPI/config.h:49, from ../../Tools/TestWebKitAPI/Tests/WebKit/UserMedia.cpp:20: ../../Source/WebKit/UIProcess/API/C/WKPage.h:228:16: note: declared here WK_EXPORT void WKPageSetPageLoaderClient(WKPageRef page, const WKPageLoaderClientBase* client) WK_C_API_DEPRECATED_WITH_REPLACEMENT(WKPageSetPageNavigationClient, macosx(WK_MAC_TBA)); ^~~~~~~~~~~~~~~~~~~~~~~~~ 1489711 1 357774 mcatanzaro 2018-12-19 21:03:47 -0800 Created attachment 357774 Patch 1491111 2 mcatanzaro 2019-01-01 12:03:26 -0800 Ping reviewers 1491456 3 357774 commit-queue 2019-01-03 10:21:06 -0800 Comment on attachment 357774 Patch Clearing flags on attachment: 357774 Committed r239596: <https://trac.webkit.org/changeset/239596> 1491457 4 commit-queue 2019-01-03 10:21:07 -0800 All reviewed patches have been landed. Closing bug. 1491458 5 webkit-bug-importer 2019-01-03 10:22:27 -0800 <rdar://problem/47027896> 357774 2018-12-19 21:03:47 -0800 2019-01-03 10:21:06 -0800 Patch bug-192913-20181219230346.patch text/plain 2048 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjM5NDI4CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZDA2OTM5M2MzNDMyMTc5YWY3NDk0ZmQ0NWM5NjVmMGUx ZTlhZGZmZS4uM2FkZTI3MTEyYzYyNTRlMDc1NzQ4OTgyZGJmYjc1ZmRmNWFkYjc3YSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2 IEBACisyMDE4LTEyLTE5ICBNaWNoYWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AaWdhbGlhLmNv bT4KKworICAgICAgICBVc2VyTWVkaWEgdGVzdCBzaG91bGQgdXNlIFdLUGFnZU5hdmlnYXRpb25D bGllbnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5 MjkxMworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRo ZSB0ZXN0IGN1cnJlbnRseSB1c2VzIHRoZSBkZXByZWNhdGVkIFdLUGFnZUxvYWRlckNsaWVudC4g SXQgc2hvdWxkIHVzZQorICAgICAgICBXS1BhZ2VOYXZpZ2F0aW9uQ2xpZW50IGluc3RlYWQsIHdo aWNoIHByb3ZpZGVzIHRoZSBzYW1lIGNhbGxiYWNrIHVuZGVyIGEgc2ltaWxhciBuYW1lLgorCisg ICAgICAgICogVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXQvVXNlck1lZGlhLmNwcDoKKyAgICAg ICAgKFRlc3RXZWJLaXRBUEk6OlRFU1QpOgorCiAyMDE4LTEyLTE5ICBDaHJpcyBEdW1leiAgPGNk dW1lekBhcHBsZS5jb20+CiAKICAgICAgICAgd3RmL09wdGlvbmFsLmg6IG1vdmUtY29uc3RydWN0 b3IgYW5kIG1vdmUtYXNzaWdubWVudCBvcGVyYXRvciBzaG91bGQgZGlzZW5nYWdlIHRoZSB2YWx1 ZSBiZWluZyBtb3ZlZCBmcm9tCmRpZmYgLS1naXQgYS9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3Rz L1dlYktpdC9Vc2VyTWVkaWEuY3BwIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXQv VXNlck1lZGlhLmNwcAppbmRleCAyZjBjYmUyMDNiOTJkODgxZGMxODU1MDY5ZDMwZTcwY2NkZDMy MWNmLi45MWMyNzg2M2IyYTYxZjg5MTc3NjBlOTE2ZGUyZDlkZjk5YzY2ZDk2IDEwMDY0NAotLS0g YS9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdC9Vc2VyTWVkaWEuY3BwCisrKyBiL1Rv b2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0L1VzZXJNZWRpYS5jcHAKQEAgLTEzMiwxMSAr MTMyLDExIEBAIFRFU1QoV2ViS2l0LCBPbkRldmljZUNoYW5nZUNyYXNoKQogICAgIC8vIExvYWQg YSBzZWNvbmQgcGFnZSBpbiBzYW1lIHByb2Nlc3MuCiAgICAgUGxhdGZvcm1XZWJWaWV3IHdlYlZp ZXcyKGNvbnRleHQuZ2V0KCksIHBhZ2VHcm91cC5nZXQoKSk7CiAgICAgV0tQYWdlU2V0UGFnZVVJ Q2xpZW50KHdlYlZpZXcyLnBhZ2UoKSwgJnVpQ2xpZW50LmJhc2UpOwotICAgIFdLUGFnZUxvYWRl ckNsaWVudFYwIGxvYWRlckNsaWVudDsKLSAgICBtZW1zZXQoJmxvYWRlckNsaWVudCwgMCwgc2l6 ZW9mKGxvYWRlckNsaWVudCkpOwotICAgIGxvYWRlckNsaWVudC5iYXNlLnZlcnNpb24gPSAwOwot ICAgIGxvYWRlckNsaWVudC5wcm9jZXNzRGlkQ3Jhc2ggPSBkaWRDcmFzaENhbGxiYWNrOwotICAg IFdLUGFnZVNldFBhZ2VMb2FkZXJDbGllbnQod2ViVmlldzIucGFnZSgpLCAmbG9hZGVyQ2xpZW50 LmJhc2UpOworICAgIFdLUGFnZU5hdmlnYXRpb25DbGllbnRWMCBuYXZpZ2F0aW9uQ2xpZW50Owor ICAgIG1lbXNldCgmbmF2aWdhdGlvbkNsaWVudCwgMCwgc2l6ZW9mKG5hdmlnYXRpb25DbGllbnQp KTsKKyAgICBuYXZpZ2F0aW9uQ2xpZW50LmJhc2UudmVyc2lvbiA9IDA7CisgICAgbmF2aWdhdGlv bkNsaWVudC53ZWJQcm9jZXNzRGlkQ3Jhc2ggPSBkaWRDcmFzaENhbGxiYWNrOworICAgIFdLUGFn ZVNldFBhZ2VOYXZpZ2F0aW9uQ2xpZW50KHdlYlZpZXcyLnBhZ2UoKSwgJm5hdmlnYXRpb25DbGll bnQuYmFzZSk7CiAKICAgICB3YXNQcm9tcHRlZCA9IGZhbHNlOwogICAgIHVybCA9IGFkb3B0V0so VXRpbDo6Y3JlYXRlVVJMRm9yUmVzb3VyY2UoImdldFVzZXJNZWRpYSIsICJodG1sIikpOwo=