192911 2018-12-19 19:19:16 -0800 ITMLKit Inspector: Computed Style Box Model section throws exceptions 2018-12-20 12:05:43 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck commit-queue inspector-bugzilla-changes joepeck mattbaker webkit-bug-importer oldest_to_newest 1489667 0 joepeck 2018-12-19 19:19:16 -0800 ITMLKit Inspector: Computed Style Box Model section throws exceptions ITMLKit doesn't always provide a display/position/width/height etc properties. Protect against this, and just show an empty message in the box model section if those properties do not exist. 1489668 1 webkit-bug-importer 2018-12-19 19:19:37 -0800 <rdar://problem/46861112> 1489669 2 357771 joepeck 2018-12-19 19:23:04 -0800 Created attachment 357771 [PATCH] Proposed Fix 1489680 3 357771 mattbaker 2018-12-19 19:43:56 -0800 Comment on attachment 357771 [PATCH] Proposed Fix r=me. Nice cleanup of BoxModelDetailsSectionRow. 1489986 4 357771 commit-queue 2018-12-20 12:05:42 -0800 Comment on attachment 357771 [PATCH] Proposed Fix Clearing flags on attachment: 357771 Committed r239459: <https://trac.webkit.org/changeset/239459> 1489987 5 commit-queue 2018-12-20 12:05:43 -0800 All reviewed patches have been landed. Closing bug. 357771 2018-12-19 19:23:04 -0800 2018-12-20 12:05:42 -0800 [PATCH] Proposed Fix box-1.patch text/plain 6485 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDhmYzI1ZmQyMjQyLi4zMjdlM2I1YTYxMSAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTgtMTItMTkgIEpvc2Vw aCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKworICAgICAgICBJVE1MS2l0IEluc3Bl Y3RvcjogQ29tcHV0ZWQgU3R5bGUgQm94IE1vZGVsIHNlY3Rpb24gdGhyb3dzIGV4Y2VwdGlvbnMK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5MjkxMQor ICAgICAgICA8cmRhcjovL3Byb2JsZW0vNDY4NjExMTI+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL0JveE1vZGVs RGV0YWlsc1NlY3Rpb25Sb3cuanM6CisgICAgICAgIChXSS5Cb3hNb2RlbERldGFpbHNTZWN0aW9u Um93LnByb3RvdHlwZS5fdXBkYXRlTWV0cmljcy5jcmVhdGVCb3hQYXJ0RWxlbWVudCk6CisgICAg ICAgIChXSS5Cb3hNb2RlbERldGFpbHNTZWN0aW9uUm93LnByb3RvdHlwZS5fdXBkYXRlTWV0cmlj cy5jcmVhdGVDb250ZW50QXJlYUVsZW1lbnQpOgorICAgICAgICAoV0kuQm94TW9kZWxEZXRhaWxz U2VjdGlvblJvdy5wcm90b3R5cGUuX3VwZGF0ZU1ldHJpY3MpOgorICAgICAgICBJVE1MS2l0IGRv ZXNuJ3QgYWx3YXlzIHByb3ZpZGUgYSBkaXNwbGF5L3Bvc2l0aW9uL3dpZHRoL2hlaWdodCBldGMg cHJvcGVydGllcy4KKyAgICAgICAgUHJvdGVjdCBhZ2FpbnN0IHRoaXMsIGFuZCBqdXN0IHNob3cg YW4gZW1wdHkgbWVzc2FnZSBpbiB0aGUgYm94IG1vZGVsIHNlY3Rpb24KKyAgICAgICAgaWYgdGhv c2UgcHJvcGVydGllcyBkbyBub3QgZXhpc3QuCisKIDIwMTgtMTItMTkgIEpvc2VwaCBQZWNvcmFy byAgPHBlY29yYXJvQGFwcGxlLmNvbT4KIAogICAgICAgICBJVE1MS2l0IEluc3BlY3RvcjogRWxl bWVudHMgdGFiIGRvZXMgbm90IHNob3cgRE9NIFRyZWUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJ bnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0JveE1vZGVsRGV0YWlsc1NlY3Rpb25Sb3cu anMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9Cb3hNb2RlbERl dGFpbHNTZWN0aW9uUm93LmpzCmluZGV4IGFhYWM5MDQ1ZWRmLi45NDQxYjJhZjQzNSAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvQm94TW9kZWxE ZXRhaWxzU2VjdGlvblJvdy5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVy ZmFjZS9WaWV3cy9Cb3hNb2RlbERldGFpbHNTZWN0aW9uUm93LmpzCkBAIC0xMzcsNyArMTM3LDEx IEBAIFdJLkJveE1vZGVsRGV0YWlsc1NlY3Rpb25Sb3cgPSBjbGFzcyBCb3hNb2RlbERldGFpbHNT ZWN0aW9uUm93IGV4dGVuZHMgV0kuRGV0YWlsCiAgICAgICAgIHsKICAgICAgICAgICAgIGxldCBz dWZmaXggPSB0aGlzLl9nZXRDb21wb25lbnRTdWZmaXgobmFtZSk7CiAgICAgICAgICAgICBsZXQg cHJvcGVydHlOYW1lID0gKG5hbWUgIT09ICJwb3NpdGlvbiIgPyBuYW1lICsgIi0iIDogIiIpICsg c2lkZSArIHN1ZmZpeDsKLSAgICAgICAgICAgIGxldCB2YWx1ZSA9IHN0eWxlLnByb3BlcnR5Rm9y TmFtZShwcm9wZXJ0eU5hbWUpLnZhbHVlOworICAgICAgICAgICAgbGV0IHByb3BlcnR5ID0gc3R5 bGUucHJvcGVydHlGb3JOYW1lKHByb3BlcnR5TmFtZSk7CisgICAgICAgICAgICBpZiAoIXByb3Bl cnR5KQorICAgICAgICAgICAgICAgIHJldHVybiBudWxsOworCisgICAgICAgICAgICBsZXQgdmFs dWUgPSBwcm9wZXJ0eS52YWx1ZTsKICAgICAgICAgICAgIGlmICh2YWx1ZSA9PT0gIiIgfHwgKG5h bWUgIT09ICJwb3NpdGlvbiIgJiYgdmFsdWUgPT09ICIwcHgiKSB8fCAobmFtZSA9PT0gInBvc2l0 aW9uIiAmJiB2YWx1ZSA9PT0gImF1dG8iKSkKICAgICAgICAgICAgICAgICB2YWx1ZSA9ICIiOwog ICAgICAgICAgICAgZWxzZQpAQCAtMTUyLDcgKzE1NiwxMSBAQCBXSS5Cb3hNb2RlbERldGFpbHNT ZWN0aW9uUm93ID0gY2xhc3MgQm94TW9kZWxEZXRhaWxzU2VjdGlvblJvdyBleHRlbmRzIFdJLkRl dGFpbAogICAgICAgICB7CiAgICAgICAgICAgICBjb25zb2xlLmFzc2VydChuYW1lID09PSAid2lk dGgiIHx8IG5hbWUgPT09ICJoZWlnaHQiKTsKIAotICAgICAgICAgICAgbGV0IHNpemUgPSBzdHls ZS5wcm9wZXJ0eUZvck5hbWUobmFtZSkudmFsdWUucmVwbGFjZSgvcHgkLywgIiIpOworICAgICAg ICAgICAgbGV0IHByb3BlcnR5ID0gc3R5bGUucHJvcGVydHlGb3JOYW1lKG5hbWUpOworICAgICAg ICAgICAgaWYgKCFwcm9wZXJ0eSkKKyAgICAgICAgICAgICAgICByZXR1cm4gbnVsbDsKKworICAg ICAgICAgICAgbGV0IHNpemUgPSBwcm9wZXJ0eS52YWx1ZS5yZXBsYWNlKC9weCQvLCAiIik7CiAg ICAgICAgICAgICBpZiAoc3R5bGUucHJvcGVydHlGb3JOYW1lKCJib3gtc2l6aW5nIikudmFsdWUg PT09ICJib3JkZXItYm94IikgewogICAgICAgICAgICAgICAgIGxldCBib3JkZXJCb3ggPSB0aGlz Ll9nZXRCb3goc3R5bGUsICJib3JkZXIiKTsKICAgICAgICAgICAgICAgICBsZXQgcGFkZGluZ0Jv eCA9IHRoaXMuX2dldEJveChzdHlsZSwgInBhZGRpbmciKTsKQEAgLTE5NywxNiArMjA1LDI0IEBA IFdJLkJveE1vZGVsRGV0YWlsc1NlY3Rpb25Sb3cgPSBjbGFzcyBCb3hNb2RlbERldGFpbHNTZWN0 aW9uUm93IGV4dGVuZHMgV0kuRGV0YWlsCiAgICAgICAgICAgICByZXR1cm47CiAgICAgICAgIH0K IAorICAgICAgICBsZXQgZGlzcGxheVByb3BlcnR5ID0gc3R5bGUucHJvcGVydHlGb3JOYW1lKCJk aXNwbGF5Iik7CisgICAgICAgIGxldCBwb3NpdGlvblByb3BlcnR5ID0gc3R5bGUucHJvcGVydHlG b3JOYW1lKCJwb3NpdGlvbiIpOworICAgICAgICBpZiAoIWRpc3BsYXlQcm9wZXJ0eSB8fCAhcG9z aXRpb25Qcm9wZXJ0eSkgeworICAgICAgICAgICAgdGhpcy5zaG93RW1wdHlNZXNzYWdlKCk7Cisg ICAgICAgICAgICByZXR1cm47CisgICAgICAgIH0KKwogICAgICAgICB2YXIgcHJldmlvdXNCb3gg PSBudWxsOwogICAgICAgICBmb3IgKGxldCBuYW1lIG9mIFsiY29udGVudCIsICJwYWRkaW5nIiwg ImJvcmRlciIsICJtYXJnaW4iLCAicG9zaXRpb24iXSkgewotICAgICAgICAgICAgaWYgKG5hbWUg PT09ICJtYXJnaW4iICYmIG5vTWFyZ2luRGlzcGxheVR5cGVbc3R5bGUucHJvcGVydHlGb3JOYW1l KCJkaXNwbGF5IikudmFsdWVdKQorCisgICAgICAgICAgICBpZiAobmFtZSA9PT0gIm1hcmdpbiIg JiYgbm9NYXJnaW5EaXNwbGF5VHlwZVtkaXNwbGF5UHJvcGVydHkudmFsdWVdKQogICAgICAgICAg ICAgICAgIGNvbnRpbnVlOwotICAgICAgICAgICAgaWYgKG5hbWUgPT09ICJwYWRkaW5nIiAmJiBu b1BhZGRpbmdEaXNwbGF5VHlwZVtzdHlsZS5wcm9wZXJ0eUZvck5hbWUoImRpc3BsYXkiKS52YWx1 ZV0pCisgICAgICAgICAgICBpZiAobmFtZSA9PT0gInBhZGRpbmciICYmIG5vUGFkZGluZ0Rpc3Bs YXlUeXBlW2Rpc3BsYXlQcm9wZXJ0eS52YWx1ZV0pCiAgICAgICAgICAgICAgICAgY29udGludWU7 Ci0gICAgICAgICAgICBpZiAobmFtZSA9PT0gInBvc2l0aW9uIiAmJiBub1Bvc2l0aW9uVHlwZVtz dHlsZS5wcm9wZXJ0eUZvck5hbWUoInBvc2l0aW9uIikudmFsdWVdKQorICAgICAgICAgICAgaWYg KG5hbWUgPT09ICJwb3NpdGlvbiIgJiYgbm9Qb3NpdGlvblR5cGVbcG9zaXRpb25Qcm9wZXJ0eS52 YWx1ZV0pCiAgICAgICAgICAgICAgICAgY29udGludWU7CiAKLSAgICAgICAgICAgIHZhciBib3hF bGVtZW50ID0gZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgiZGl2Iik7CisgICAgICAgICAgICBsZXQg Ym94RWxlbWVudCA9IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoImRpdiIpOwogICAgICAgICAgICAg Ym94RWxlbWVudC5jbGFzc05hbWUgPSBuYW1lOwogICAgICAgICAgICAgYm94RWxlbWVudC5fbmFt ZSA9IG5hbWU7CiAgICAgICAgICAgICBib3hFbGVtZW50LmFkZEV2ZW50TGlzdGVuZXIoIm1vdXNl b3ZlciIsIHRoaXMuX2hpZ2hsaWdodERPTU5vZGUuYmluZCh0aGlzLCB0cnVlLCBuYW1lID09PSAi cG9zaXRpb24iID8gImFsbCIgOiBuYW1lKSwgZmFsc2UpOwpAQCAtMjE1LDIzICsyMzEsMzcgQEAg V0kuQm94TW9kZWxEZXRhaWxzU2VjdGlvblJvdyA9IGNsYXNzIEJveE1vZGVsRGV0YWlsc1NlY3Rp b25Sb3cgZXh0ZW5kcyBXSS5EZXRhaWwKICAgICAgICAgICAgIGlmIChuYW1lID09PSAiY29udGVu dCIpIHsKICAgICAgICAgICAgICAgICBsZXQgd2lkdGhFbGVtZW50ID0gY3JlYXRlQ29udGVudEFy ZWFFbGVtZW50LmNhbGwodGhpcywgIndpZHRoIik7CiAgICAgICAgICAgICAgICAgbGV0IGhlaWdo dEVsZW1lbnQgPSBjcmVhdGVDb250ZW50QXJlYUVsZW1lbnQuY2FsbCh0aGlzLCAiaGVpZ2h0Iik7 CisgICAgICAgICAgICAgICAgaWYgKCF3aWR0aEVsZW1lbnQgfHwgIWhlaWdodEVsZW1lbnQpIHsK KyAgICAgICAgICAgICAgICAgICAgdGhpcy5zaG93RW1wdHlNZXNzYWdlKCk7CisgICAgICAgICAg ICAgICAgICAgIHJldHVybjsKKyAgICAgICAgICAgICAgICB9CisKICAgICAgICAgICAgICAgICBi b3hFbGVtZW50LmFwcGVuZCh3aWR0aEVsZW1lbnQsICIgXHUwMEQ3ICIsIGhlaWdodEVsZW1lbnQp OwogICAgICAgICAgICAgfSBlbHNlIHsKLSAgICAgICAgICAgICAgICB2YXIgbGFiZWxFbGVtZW50 ID0gZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgiZGl2Iik7CisgICAgICAgICAgICAgICAgbGV0IHRv cEVsZW1lbnQgPSBjcmVhdGVCb3hQYXJ0RWxlbWVudC5jYWxsKHRoaXMsIG5hbWUsICJ0b3AiKTsK KyAgICAgICAgICAgICAgICBsZXQgbGVmdEVsZW1lbnQgPSBjcmVhdGVCb3hQYXJ0RWxlbWVudC5j YWxsKHRoaXMsIG5hbWUsICJsZWZ0Iik7CisgICAgICAgICAgICAgICAgbGV0IHJpZ2h0RWxlbWVu dCA9IGNyZWF0ZUJveFBhcnRFbGVtZW50LmNhbGwodGhpcywgbmFtZSwgInJpZ2h0Iik7CisgICAg ICAgICAgICAgICAgbGV0IGJvdHRvbUVsZW1lbnQgPSBjcmVhdGVCb3hQYXJ0RWxlbWVudC5jYWxs KHRoaXMsIG5hbWUsICJib3R0b20iKTsKKyAgICAgICAgICAgICAgICBpZiAoIXRvcEVsZW1lbnQg fHwgIWxlZnRFbGVtZW50IHx8ICFyaWdodEVsZW1lbnQgfHwgIWJvdHRvbUVsZW1lbnQpIHsKKyAg ICAgICAgICAgICAgICAgICAgdGhpcy5zaG93RW1wdHlNZXNzYWdlKCk7CisgICAgICAgICAgICAg ICAgICAgIHJldHVybjsKKyAgICAgICAgICAgICAgICB9CisKKyAgICAgICAgICAgICAgICBsZXQg bGFiZWxFbGVtZW50ID0gZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgiZGl2Iik7CiAgICAgICAgICAg ICAgICAgbGFiZWxFbGVtZW50LmNsYXNzTmFtZSA9ICJsYWJlbCI7CiAgICAgICAgICAgICAgICAg bGFiZWxFbGVtZW50LnRleHRDb250ZW50ID0gbmFtZTsKICAgICAgICAgICAgICAgICBib3hFbGVt ZW50LmFwcGVuZENoaWxkKGxhYmVsRWxlbWVudCk7CiAKLSAgICAgICAgICAgICAgICBib3hFbGVt ZW50LmFwcGVuZENoaWxkKGNyZWF0ZUJveFBhcnRFbGVtZW50LmNhbGwodGhpcywgbmFtZSwgInRv cCIpKTsKKyAgICAgICAgICAgICAgICBib3hFbGVtZW50LmFwcGVuZENoaWxkKHRvcEVsZW1lbnQp OwogICAgICAgICAgICAgICAgIGJveEVsZW1lbnQuYXBwZW5kQ2hpbGQoZG9jdW1lbnQuY3JlYXRl RWxlbWVudCgiYnIiKSk7Ci0gICAgICAgICAgICAgICAgYm94RWxlbWVudC5hcHBlbmRDaGlsZChj cmVhdGVCb3hQYXJ0RWxlbWVudC5jYWxsKHRoaXMsIG5hbWUsICJsZWZ0IikpOworICAgICAgICAg ICAgICAgIGJveEVsZW1lbnQuYXBwZW5kQ2hpbGQobGVmdEVsZW1lbnQpOwogCiAgICAgICAgICAg ICAgICAgaWYgKHByZXZpb3VzQm94KQogICAgICAgICAgICAgICAgICAgICBib3hFbGVtZW50LmFw cGVuZENoaWxkKHByZXZpb3VzQm94KTsKIAotICAgICAgICAgICAgICAgIGJveEVsZW1lbnQuYXBw ZW5kQ2hpbGQoY3JlYXRlQm94UGFydEVsZW1lbnQuY2FsbCh0aGlzLCBuYW1lLCAicmlnaHQiKSk7 CisgICAgICAgICAgICAgICAgYm94RWxlbWVudC5hcHBlbmRDaGlsZChyaWdodEVsZW1lbnQpOwog ICAgICAgICAgICAgICAgIGJveEVsZW1lbnQuYXBwZW5kQ2hpbGQoZG9jdW1lbnQuY3JlYXRlRWxl bWVudCgiYnIiKSk7Ci0gICAgICAgICAgICAgICAgYm94RWxlbWVudC5hcHBlbmRDaGlsZChjcmVh dGVCb3hQYXJ0RWxlbWVudC5jYWxsKHRoaXMsIG5hbWUsICJib3R0b20iKSk7CisgICAgICAgICAg ICAgICAgYm94RWxlbWVudC5hcHBlbmRDaGlsZChib3R0b21FbGVtZW50KTsKICAgICAgICAgICAg IH0KIAogICAgICAgICAgICAgcHJldmlvdXNCb3ggPSBib3hFbGVtZW50Owo=