192875 2018-12-19 13:59:25 -0800 [GTK][WPE] Enable CSS typed OM 2019-11-11 14:34:43 -0800 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=190710 P2 Normal --- 175733 1 aboya clopez annulen bugs-noreply cdumez cgarcia chi187 clopez csaavedra ews-watchlist ggaren graouts gyuyoung.kim ryuan.choi sergio youennf oldest_to_newest 1489454 0 aboya 2018-12-19 13:59:25 -0800 New test failing: css-typedom/attributeStyleMap.html --- /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/css-typedom/attributeStyleMap-expected.txt +++ /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/css-typedom/attributeStyleMap-actual.txt @@ -1,4 +1,4 @@ -PASS test that element.attributeStyleMap exists -PASS test that element.attributeStyleMap has a valid width value +FAIL test that element.attributeStyleMap exists assert_true: expected true got false +FAIL test that element.attributeStyleMap has a valid width value undefined is not an object (evaluating 'el.attributeStyleMap.get') 1489587 1 aboya 2018-12-19 16:42:49 -0800 Same error in imported/w3c/web-platform-tests/css/css-properties-values-api/unit-cycles.html. Interestingly, WebKit does not seem to support this feature very well according to the multiplatform expectations, but in this case somehow attributeStyleMap does not even exist, whereas in the general expectations its methods don't exist. --- /home/buildbot/wpe/wpe-linux-64-release-tests/build/layout-test-results/imported/w3c/web-platform-tests/css/css-properties-values-api/unit-cycles-expected.txt +++ /home/buildbot/wpe/wpe-linux-64-release-tests/build/layout-test-results/imported/w3c/web-platform-tests/css/css-properties-values-api/unit-cycles-actual.txt @@ -1,4 +1,4 @@ -CONSOLE MESSAGE: line 63: TypeError: element.attributeStyleMap.clear is not a function. (In 'element.attributeStyleMap.clear()', 'element.attributeStyleMap.clear' is undefined) +CONSOLE MESSAGE: line 63: TypeError: undefined is not an object (evaluating 'element.attributeStyleMap.clear') -FAIL Untitled TypeError: element.attributeStyleMap.clear is not a function. (In 'element.attributeStyleMap.clear()', 'element.attributeStyleMap.clear' is undefined) +FAIL Untitled TypeError: undefined is not an object (evaluating 'element.attributeStyleMap.clear') 1492257 2 csaavedra 2019-01-07 07:57:00 -0800 I've skipped the css-typedom directory for now, once we enable the feature we have to revisit the tests. 1582882 3 clopez 2019-10-23 10:55:43 -0700 The implementation is tracked in bug 175733. I think we can enable this for GTK/WPE as a experimental feature. The layout test pass after doing so. 1583768 4 381909 clopez 2019-10-25 04:59:50 -0700 Created attachment 381909 Patch 1584465 5 381909 clopez 2019-10-28 09:25:23 -0700 Comment on attachment 381909 Patch Clearing flags on attachment: 381909 Committed r251656: <https://trac.webkit.org/changeset/251656> 1584466 6 clopez 2019-10-28 09:25:27 -0700 All reviewed patches have been landed. Closing bug. 381909 2019-10-25 04:59:50 -0700 2019-10-28 09:25:23 -0700 Patch bug-192875-20191025135949.patch text/plain 6241 clopez U3VidmVyc2lvbiBSZXZpc2lvbjogMjUxNTg3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDAwMWI3NDEzMGNlNzYzMmVj YWFlODY0NWQxYTljZGUyZGVhYmQ0NzYuLmE4Zjg5MmNjNGYxM2M4MDc2NzQ1N2EyNWRjMTBmMzgx YzhiN2VlMzYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTktMTAtMjUgIENhcmxvcyBB bGJlcnRvIExvcGV6IFBlcmV6ICA8Y2xvcGV6QGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dUS11b V1BFXSBFbmFibGUgQ1NTIHR5cGVkIE9NCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xOTI4NzUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBFbmFibGUgdGhlIHJ1bnRpbWUgZmVhdHVyZSBieSBkZWZhdWx0IG9u IEdUSy9XUEUgd2hlbiBidWlsZGluZyB3aXRoCisgICAgICAgIGV4cGVyaW1lbnRhbCBmZWF0dXJl cyBlbmFibGVkLgorCisgICAgICAgIENvdmVyZWQgYnkgZXhpc3RpbmcgdGVzdHMuCisKKyAgICAg ICAgKiBTaGFyZWQvV2ViUHJlZmVyZW5jZXMueWFtbDoKKyAgICAgICAgKiBTaGFyZWQvV2ViUHJl ZmVyZW5jZXNEZWZhdWx0VmFsdWVzLmg6CisKIDIwMTktMTAtMjUgIENocmlzIER1bWV6ICA8Y2R1 bWV6QGFwcGxlLmNvbT4KIAogICAgICAgICBTdGFuZGFyZGl6ZSAiUGFnZUlEPSIgdnMgInBhZ2VJ RCA9IiBpbiByZWxlYXNlIGxvZ2dpbmcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvU2hhcmVk L1dlYlByZWZlcmVuY2VzLnlhbWwgYi9Tb3VyY2UvV2ViS2l0L1NoYXJlZC9XZWJQcmVmZXJlbmNl cy55YW1sCmluZGV4IDI1OWJhNzIyYTFlMjAyM2E4MWVkOWRmNjRiMjJhNzllODg5NTQ4MTUuLjVk YzJkNjI1OGRjNDY5Y2M0ZWFjZDY5MjBmOWJlYTMzMjQzYTFmOTUgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQvU2hhcmVkL1dlYlByZWZlcmVuY2VzLnlhbWwKKysrIGIvU291cmNlL1dlYktpdC9T aGFyZWQvV2ViUHJlZmVyZW5jZXMueWFtbApAQCAtMTM3OSw3ICsxMzc5LDcgQEAgQ1NTUGFpbnRp bmdBUElFbmFibGVkOgogCiBDU1NUeXBlZE9NRW5hYmxlZDoKICAgdHlwZTogYm9vbAotICBkZWZh dWx0VmFsdWU6IGZhbHNlCisgIGRlZmF1bHRWYWx1ZTogREVGQVVMVF9DU1NfVFlQRURfT01fRU5B QkxFRAogICBodW1hblJlYWRhYmxlTmFtZTogIkNTUyBUeXBlZCBPTSIKICAgaHVtYW5SZWFkYWJs ZURlc2NyaXB0aW9uOiAiRW5hYmxlIHRoZSBDU1MgVHlwZWQgT00iCiAgIHdlYmNvcmVCaW5kaW5n OiBSdW50aW1lRW5hYmxlZEZlYXR1cmVzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1NoYXJl ZC9XZWJQcmVmZXJlbmNlc0RlZmF1bHRWYWx1ZXMuaCBiL1NvdXJjZS9XZWJLaXQvU2hhcmVkL1dl YlByZWZlcmVuY2VzRGVmYXVsdFZhbHVlcy5oCmluZGV4IDE4ODg5MmI5NDRiM2E1ODU4NTg3MDJk OTIyNDAwMzIxNTk4MjBhYTcuLjY5YjVhNDlhY2Y3ZDRjNmQxMTMxZmU5ZWY4MDc4OWNlMWJjN2Vj MmMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvU2hhcmVkL1dlYlByZWZlcmVuY2VzRGVmYXVs dFZhbHVlcy5oCisrKyBiL1NvdXJjZS9XZWJLaXQvU2hhcmVkL1dlYlByZWZlcmVuY2VzRGVmYXVs dFZhbHVlcy5oCkBAIC0yODIsNiArMjgyLDExIEBACiAjZGVmaW5lIERFRkFVTFRfQVNZTkNfT1ZF UkZMT1dfU0NST0xMSU5HX0VOQUJMRUQgZmFsc2UKICNlbmRpZgogCisjaWYgRU5BQkxFKEVYUEVS SU1FTlRBTF9GRUFUVVJFUykgJiYgKFBMQVRGT1JNKEdUSykgfHwgUExBVEZPUk0oV1BFKSkKKyNk ZWZpbmUgREVGQVVMVF9DU1NfVFlQRURfT01fRU5BQkxFRCB0cnVlCisjZWxzZQorI2RlZmluZSBE RUZBVUxUX0NTU19UWVBFRF9PTV9FTkFCTEVEIGZhbHNlCisjZW5kaWYKIAogI2lmIEVOQUJMRShF WFBFUklNRU5UQUxfRkVBVFVSRVMpICYmIChQTEFURk9STShHVEspIHx8IFBMQVRGT1JNKFdQRSkp CiAjZGVmaW5lIERFRkFVTFRfU0VSVkVSX1RJTUlOR19FTkFCTEVEIHRydWUKZGlmZiAtLWdpdCBh L1NvdXJjZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtlIGIvU291cmNlL2NtYWtlL09wdGlvbnNHVEsu Y21ha2UKaW5kZXggZjMyNmM5ZDVjOThlYmMzMzY5OTczNDEwNzlhMzQ1YTFkOGZmMGJjOS4uMWQ1 Y2YyMWRkMmQ4ZGRmNzNiODI1N2UxMThkMTgwMDA1YzYxZWJlOSAxMDA2NDQKLS0tIGEvU291cmNl L2NtYWtlL09wdGlvbnNHVEsuY21ha2UKKysrIGIvU291cmNlL2NtYWtlL09wdGlvbnNHVEsuY21h a2UKQEAgLTE2Miw2ICsxNjIsNyBAQCBXRUJLSVRfT1BUSU9OX0RFRkFVTFRfUE9SVF9WQUxVRShF TkFCTEVfTkVUV09SS19DQUNIRV9TUEVDVUxBVElWRV9SRVZBTElEQVRJT04gUAogV0VCS0lUX09Q VElPTl9ERUZBVUxUX1BPUlRfVkFMVUUoRU5BQkxFX1NFUlZJQ0VfV09SS0VSIFBSSVZBVEUgT04p CiBXRUJLSVRfT1BUSU9OX0RFRkFVTFRfUE9SVF9WQUxVRShFTkFCTEVfU0hBUkVBQkxFX1JFU09V UkNFIFBVQkxJQyBPTikKIFdFQktJVF9PUFRJT05fREVGQVVMVF9QT1JUX1ZBTFVFKEVOQUJMRV9X RUJfUlRDIFBSSVZBVEUgJHtFTkFCTEVfRVhQRVJJTUVOVEFMX0ZFQVRVUkVTfSkKK1dFQktJVF9P UFRJT05fREVGQVVMVF9QT1JUX1ZBTFVFKEVOQUJMRV9DU1NfVFlQRURfT00gUFJJVkFURSAke0VO QUJMRV9FWFBFUklNRU5UQUxfRkVBVFVSRVN9KQogCiBpbmNsdWRlKEdTdHJlYW1lckRlcGVuZGVu Y2llcykKIApkaWZmIC0tZ2l0IGEvU291cmNlL2NtYWtlL09wdGlvbnNXUEUuY21ha2UgYi9Tb3Vy Y2UvY21ha2UvT3B0aW9uc1dQRS5jbWFrZQppbmRleCAxM2EzNmZlNjcxYTg2MmFlODNkMmYxZmVi NjVmOGY0NmRlY2FjMGMxLi5jZmNlNTNkOWFjN2M1ZDBkMWMzYjRmNjU2ZjNlYzZlOTQzMzA2NTNh IDEwMDY0NAotLS0gYS9Tb3VyY2UvY21ha2UvT3B0aW9uc1dQRS5jbWFrZQorKysgYi9Tb3VyY2Uv Y21ha2UvT3B0aW9uc1dQRS5jbWFrZQpAQCAtNTksNiArNTksNyBAQCBXRUJLSVRfT1BUSU9OX0RF RkFVTFRfUE9SVF9WQUxVRShFTkFCTEVfU01PT1RIX1NDUk9MTElORyBQUklWQVRFIE9GRikKIFdF QktJVF9PUFRJT05fREVGQVVMVF9QT1JUX1ZBTFVFKEVOQUJMRV9UT1VDSF9FVkVOVFMgUFJJVkFU RSBPTikKIFdFQktJVF9PUFRJT05fREVGQVVMVF9QT1JUX1ZBTFVFKEVOQUJMRV9XRUJHTDIgUFJJ VkFURSAke0VOQUJMRV9FWFBFUklNRU5UQUxfRkVBVFVSRVN9KQogV0VCS0lUX09QVElPTl9ERUZB VUxUX1BPUlRfVkFMVUUoRU5BQkxFX1dFQl9SVEMgUFJJVkFURSAke0VOQUJMRV9FWFBFUklNRU5U QUxfRkVBVFVSRVN9KQorV0VCS0lUX09QVElPTl9ERUZBVUxUX1BPUlRfVkFMVUUoRU5BQkxFX0NT U19UWVBFRF9PTSBQUklWQVRFICR7RU5BQkxFX0VYUEVSSU1FTlRBTF9GRUFUVVJFU30pCiAKICMg UHVibGljIG9wdGlvbnMgc3BlY2lmaWMgdG8gdGhlIFdQRSBwb3J0LiBEbyBub3QgYWRkIGFueSBv cHRpb25zIGhlcmUgdW5sZXNzCiAjIHRoZXJlIGlzIGEgc3Ryb25nIHJlYXNvbiB3ZSBzaG91bGQg c3VwcG9ydCBjaGFuZ2luZyB0aGUgdmFsdWUgb2YgdGhlIG9wdGlvbiwKZGlmZiAtLWdpdCBhL0xh eW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCA2ODk0ZjQ5 ZTk3Mzk2NGEzZmUyOWViOGEwOWEzZGQ4NGUzYjY5ZGJkLi41M2YzMzNiNGViOTAzZmZkZmRlODU3 MmEwYjdjYTFiMGVkZjAxYjNhIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysr IGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTktMTAtMjUgIENh cmxvcyBBbGJlcnRvIExvcGV6IFBlcmV6ICA8Y2xvcGV6QGlnYWxpYS5jb20+CisKKyAgICAgICAg W0dUS11bV1BFXSBFbmFibGUgQ1NTIHR5cGVkIE9NCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTI4NzUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBVbnNraXAgdGhlIHRlc3RzIHRoYXQgbm93IHBhc3MuCisK KyAgICAgICAgKiBwbGF0Zm9ybS9ndGsvVGVzdEV4cGVjdGF0aW9uczoKKyAgICAgICAgKiBwbGF0 Zm9ybS93cGUvVGVzdEV4cGVjdGF0aW9uczoKKwogMjAxOS0xMC0yNSAgQ2hyaXMgRHVtZXogIDxj ZHVtZXpAYXBwbGUuY29tPgogCiAgICAgICAgIERhdGFiYXNlQ29udGV4dCBzaG91bGQgbm90IHBy ZXZlbnQgZW50ZXJpbmcgdGhlIGJhY2svZm9yd2FyZCBjYWNoZQpkaWZmIC0tZ2l0IGEvTGF5b3V0 VGVzdHMvcGxhdGZvcm0vZ3RrL1Rlc3RFeHBlY3RhdGlvbnMgYi9MYXlvdXRUZXN0cy9wbGF0Zm9y bS9ndGsvVGVzdEV4cGVjdGF0aW9ucwppbmRleCA4OWFlYjViMDExZmFiMGRhNmNiYTI5MzAxYTJh ZTA2MGFkZmY0YjgxLi4zMGU5OWNhNTQzMGY4YmVhYWI1YmQ2NDEwZWMxYzBiMzkzYTg1NWM4IDEw MDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvVGVzdEV4cGVjdGF0aW9ucworKysg Yi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvVGVzdEV4cGVjdGF0aW9ucwpAQCAtNzE1LDkgKzcx NSw2IEBAIEJ1ZyhHVEspIHBsdWdpbnMvcXVpY2t0aW1lLXBsdWdpbi1yZXBsYWNlbWVudC5odG1s IFsgU2tpcCBdCiAjIEVOQUJMRShDU1NfU0NST0xMX1NOQVApIGlzIGRpc2FibGVkLgogY3NzMy9z Y3JvbGwtc25hcCBbIFNraXAgXQogCi0jIEVOQUJMRShDU1NfVFlQRURfT00pIGlzIGRpc2FibGVk Lgotd2Via2l0Lm9yZy9iLzE5Mjg3NSBjc3MtdHlwZWRvbSBbIFNraXAgXQotCiAjIEVOQUJMRShD U1NfUEFJTlRJTkdfQVBJKSBpcyBkaXNhYmxlZC4KIHdlYmtpdC5vcmcvYi8xOTA3MTAgZmFzdC9j c3MtY3VzdG9tLXBhaW50IFsgU2tpcCBdCiAKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRm b3JtL3dwZS9UZXN0RXhwZWN0YXRpb25zIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vd3BlL1Rlc3RF eHBlY3RhdGlvbnMKaW5kZXggNmZhMmFmMGQ2ZmNjNGU4MWRkMDE3YjVkMTNhMGQxYTU1ZTNjOWQ2 Yi4uOWU2Yjc0YjMwNTVlOTMxOWM0MjU1ODBmODIyZGJiZmUyZWU5ZWFmNyAxMDA2NDQKLS0tIGEv TGF5b3V0VGVzdHMvcGxhdGZvcm0vd3BlL1Rlc3RFeHBlY3RhdGlvbnMKKysrIGIvTGF5b3V0VGVz dHMvcGxhdGZvcm0vd3BlL1Rlc3RFeHBlY3RhdGlvbnMKQEAgLTE4NCw5ICsxODQsNiBAQCBmYXN0 L2V2ZW50cy90b3VjaC9nZXN0dXJlL3Jlc291cmNlcy9kcmFnLWluc2lkZS1uZXN0ZWQtaWZyYW1l czMuaHRtbCBbIFNraXAgXQogIyBFTkFCTEVfREFSS19NT0RFX0NTUyBpcyBPRkYgaW4gV1BFLgog Y3NzLWRhcmstbW9kZSBbIFNraXAgXQogCi0jIEVOQUJMRShDU1NfVFlQRURfT00pIGlzIGRpc2Fi bGVkLgotd2Via2l0Lm9yZy9iLzE5Mjg3NSBjc3MtdHlwZWRvbSBbIFNraXAgXQotCiAjIEVOQUJM RShDU1NfUEFJTlRJTkdfQVBJKSBpcyBkaXNhYmxlZAogd2Via2l0Lm9yZy9iLzE5MDcxMCBmYXN0 L2Nzcy1jdXN0b20tcGFpbnQgWyBTa2lwIF0KIApkaWZmIC0tZ2l0IGEvQ2hhbmdlTG9nIGIvQ2hh bmdlTG9nCmluZGV4IDgxN2M3YjViNzkwMDI4MjhlN2E1ZTUzNzM5NWUxODJjNjA4MzllMjEuLjU2 NGRkYTkyMjU3ZDFkMDZlMjVmYWNjZjA0NDI1YzJhYzRmOWJlNzggMTAwNjQ0Ci0tLSBhL0NoYW5n ZUxvZworKysgYi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxOS0xMC0yNSAgQ2FybG9z IEFsYmVydG8gTG9wZXogUGVyZXogIDxjbG9wZXpAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RL XVtXUEVdIEVuYWJsZSBDU1MgdHlwZWQgT00KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTE5Mjg3NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFRoaXMgZW5hYmxlcyB0aGUgZmVhdHVyZSB3aGVuIGJ1aWxkaW5n IHdpdGggZXhwZXJpbWVudGFsIGZlYXR1cmVzIGVuYWJsZWQuCisKKyAgICAgICAgKiBTb3VyY2Uv Y21ha2UvT3B0aW9uc0dUSy5jbWFrZToKKyAgICAgICAgKiBTb3VyY2UvY21ha2UvT3B0aW9uc1dQ RS5jbWFrZToKKwogMjAxOS0xMC0yMiAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGln YWxpYS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZC4gVXBkYXRlIE9wdGlvbnNHVEsuY21ha2Ug YW5kIE5FV1MgZm9yIDIuMjcuMiByZWxlYXNlCg==