192871 2018-12-19 12:32:34 -0800 Web Inspector: Elements tab: arrow key after undoing a DOM node delete selects the wrong element 2018-12-19 16:46:22 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P3 Normal --- 1 mattbaker mattbaker commit-queue hi inspector-bugzilla-changes webkit-bug-importer oldest_to_newest 1489409 0 mattbaker 2018-12-19 12:32:34 -0800 Summary: Arrow key after undoing a DOM node delete selects the wrong element. Test Page: <p id="a"></p> <p id="b"></p> <p id="c"></p> Steps to Reproduce: 1. Inspect test page 2. Elements tab > select DOM node for p#b 3. Press Delete 4. DOM node for p#c selected 5. Undo 6. DOM node for p#b restored 7. Press arrow key up Actual: => DOM node for p#a selected Expected: => DOM node for p#b selected 1489410 1 webkit-bug-importer 2018-12-19 12:33:00 -0800 <rdar://problem/46849060> 1489447 2 357716 mattbaker 2018-12-19 13:50:31 -0800 Created attachment 357716 Patch 1489468 3 357716 hi 2018-12-19 14:07:49 -0800 Comment on attachment 357716 Patch rs=me, nice catch :) Is it possible for us to select the item before it's been inserted? I'd assume not as the indexes would get all messed up. If so, however, we may not want to move either value if the index is selected. 1489566 4 mattbaker 2018-12-19 16:19:52 -0800 (In reply to Devin Rousso from comment #3) > Comment on attachment 357716 [details] > Patch > > rs=me, nice catch :) > > Is it possible for us to select the item before it's been inserted? I'd > assume not as the indexes would get all messed up. If so, however, we may > not want to move either value if the index is selected. `TreeElement.prototype.select` will return if it hasn't been attached, so it looks like we shouldn't be able to get into this state. I'll add an assert since I can't be completely sure. 1489567 5 357748 mattbaker 2018-12-19 16:20:00 -0800 Created attachment 357748 Patch for landing 1489590 6 357748 commit-queue 2018-12-19 16:46:21 -0800 Comment on attachment 357748 Patch for landing Clearing flags on attachment: 357748 Committed r239405: <https://trac.webkit.org/changeset/239405> 1489591 7 commit-queue 2018-12-19 16:46:22 -0800 All reviewed patches have been landed. Closing bug. 357716 2018-12-19 13:50:31 -0800 2018-12-19 16:19:58 -0800 Patch bug-192871-20181219135030.patch text/plain 1856 mattbaker U3VidmVyc2lvbiBSZXZpc2lvbjogMjM5MjI1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCA4 NGI3NzNjMjAyODExMDQxZjFmMTk4ZTdlNjk3YjM2N2IwY2I4MDRlLi4yN2FhZDAxNGE4NDJkMzJi OTQ3MmQyODUxYjg0MjVjOTdmYTBiYTMyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOCBAQAorMjAxOC0xMi0xOSAgTWF0dCBCYWtlciAgPG1hdHRiYWtlckBhcHBsZS5jb20+ CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogRWxlbWVudHMgdGFiOiBhcnJvdyBrZXkgYWZ0ZXIg dW5kb2luZyBhIERPTSBub2RlIGRlbGV0ZSBzZWxlY3RzIHRoZSB3cm9uZyBlbGVtZW50CisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTI4NzEKKyAgICAg ICAgPHJkYXI6Ly9wcm9ibGVtLzQ2ODQ5MDYwPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFVuZG9pbmcgYSBET00gbm9kZSByZW1vdmFsIHJlaW5zZXJ0 cyB0aGUgbm9kZSBpbnRvIHRoZSBET01UcmVlT3V0bGluZS4KKyAgICAgICAgV2hlbiB0aGUgcmVp bnNlcnRlZCBub2RlIHByZWNlZGVzIHRoZSBzZWxlY3RlZCBub2RlIGluIHRoZSB0cmVlLCB0aGUK KyAgICAgICAgU2VsZWN0aW9uQ29udHJvbGxlciBzaG91bGQgdXBkYXRlIGBfbGFzdFNlbGVjdGVk SW5kZXhgLgorCisgICAgICAgICogVXNlckludGVyZmFjZS9Db250cm9sbGVycy9TZWxlY3Rpb25D b250cm9sbGVyLmpzOgorICAgICAgICAoV0kuU2VsZWN0aW9uQ29udHJvbGxlci5wcm90b3R5cGUu ZGlkSW5zZXJ0SXRlbSk6CisKIDIwMTgtMTItMTMgIERldmluIFJvdXNzbyAgPGRyb3Vzc29AYXBw bGUuY29tPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IHJlbW92ZSBET00uQmFja2VuZE5vZGVJ ZCBhbmQgYXNzb2NpYXRlZCBjb21tYW5kcy9ldmVudHMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJ bnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0NvbnRyb2xsZXJzL1NlbGVjdGlvbkNvbnRyb2xsZXIu anMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Db250cm9sbGVycy9TZWxl Y3Rpb25Db250cm9sbGVyLmpzCmluZGV4IDcwNjZhM2RmYmYzNzY5MDMwYTkxMWJiZWNiNTYxM2Uw MTA0NWY0MjEuLmI2NWY5ZjAzMWY3YzVlNTUyNzdmNTU0MDUyMjQ1MDgxZWI1MjZkNjYgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0NvbnRyb2xsZXJzL1Nl bGVjdGlvbkNvbnRyb2xsZXIuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRl cmZhY2UvQ29udHJvbGxlcnMvU2VsZWN0aW9uQ29udHJvbGxlci5qcwpAQCAtMjEyLDYgKzIxMiwx MSBAQCBXSS5TZWxlY3Rpb25Db250cm9sbGVyID0gY2xhc3MgU2VsZWN0aW9uQ29udHJvbGxlciBl eHRlbmRzIFdJLk9iamVjdAogCiAgICAgICAgICAgICBjdXJyZW50ID0gdGhpcy5fc2VsZWN0ZWRJ bmRleGVzLmluZGV4TGVzc1RoYW4oY3VycmVudCk7CiAgICAgICAgIH0KKworICAgICAgICBpZiAo dGhpcy5fbGFzdFNlbGVjdGVkSW5kZXggPj0gaW5kZXgpCisgICAgICAgICAgICB0aGlzLl9sYXN0 U2VsZWN0ZWRJbmRleCArPSAxOworICAgICAgICBpZiAodGhpcy5fc2hpZnRBbmNob3JJbmRleCA+ PSBpbmRleCkKKyAgICAgICAgICAgIHRoaXMuX3NoaWZ0QW5jaG9ySW5kZXggKz0gMTsKICAgICB9 CiAKICAgICBkaWRSZW1vdmVJdGVtcyhpbmRleGVzKQo= 357748 2018-12-19 16:20:00 -0800 2018-12-19 16:46:21 -0800 Patch for landing bug-192871-20181219161959.patch text/plain 2677 mattbaker U3VidmVyc2lvbiBSZXZpc2lvbjogMjM5MzkyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCAz MjcxNmRkYmM1NjdkNGJkZDZmNTU1NTZkOWQxY2E5NjcxOWY2MzRmLi41ZDg5YTk2YjA5ZTViMzMw N2E3NWE4ODc0NzU3YjcyMGQ4ZmZkNzk0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOCBAQAorMjAxOC0xMi0xOSAgTWF0dCBCYWtlciAgPG1hdHRiYWtlckBhcHBsZS5jb20+ CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogRWxlbWVudHMgdGFiOiBhcnJvdyBrZXkgYWZ0ZXIg dW5kb2luZyBhIERPTSBub2RlIGRlbGV0ZSBzZWxlY3RzIHRoZSB3cm9uZyBlbGVtZW50CisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTI4NzEKKyAgICAg ICAgPHJkYXI6Ly9wcm9ibGVtLzQ2ODQ5MDYwPgorCisgICAgICAgIFJldmlld2VkIGJ5IERldmlu IFJvdXNzby4KKworICAgICAgICBVbmRvaW5nIGEgRE9NIG5vZGUgcmVtb3ZhbCByZWluc2VydHMg dGhlIG5vZGUgaW50byB0aGUgRE9NVHJlZU91dGxpbmUuCisgICAgICAgIFdoZW4gdGhlIHJlaW5z ZXJ0ZWQgbm9kZSBwcmVjZWRlcyB0aGUgc2VsZWN0ZWQgbm9kZSBpbiB0aGUgdHJlZSwgdGhlCisg ICAgICAgIFNlbGVjdGlvbkNvbnRyb2xsZXIgc2hvdWxkIHVwZGF0ZSBgX2xhc3RTZWxlY3RlZElu ZGV4YC4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvQ29udHJvbGxlcnMvU2VsZWN0aW9uQ29u dHJvbGxlci5qczoKKyAgICAgICAgKFdJLlNlbGVjdGlvbkNvbnRyb2xsZXIucHJvdG90eXBlLmRp ZEluc2VydEl0ZW0pOgorCiAyMDE4LTEyLTE5ICBOaWtpdGEgVmFzaWx5ZXYgIDxudmFzaWx5ZXZA YXBwbGUuY29tPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IERhcmsgTW9kZTogc2VsZWN0ZWQg dGV4dCBpcyB0b28gbGlnaHQgd2hlbiBJbnNwZWN0b3Igd2luZG93IGlzIGluYWN0aXZlCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Db250cm9sbGVycy9T ZWxlY3Rpb25Db250cm9sbGVyLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZh Y2UvQ29udHJvbGxlcnMvU2VsZWN0aW9uQ29udHJvbGxlci5qcwppbmRleCA3MDY2YTNkZmJmMzc2 OTAzMGE5MTFiYmVjYjU2MTNlMDEwNDVmNDIxLi5iNjVmOWYwMzFmN2M1ZTU1Mjc3ZjU1NDA1MjI0 NTA4MWViNTI2ZDY2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVy ZmFjZS9Db250cm9sbGVycy9TZWxlY3Rpb25Db250cm9sbGVyLmpzCisrKyBiL1NvdXJjZS9XZWJJ bnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0NvbnRyb2xsZXJzL1NlbGVjdGlvbkNvbnRyb2xsZXIu anMKQEAgLTIxMiw2ICsyMTIsMTEgQEAgV0kuU2VsZWN0aW9uQ29udHJvbGxlciA9IGNsYXNzIFNl bGVjdGlvbkNvbnRyb2xsZXIgZXh0ZW5kcyBXSS5PYmplY3QKIAogICAgICAgICAgICAgY3VycmVu dCA9IHRoaXMuX3NlbGVjdGVkSW5kZXhlcy5pbmRleExlc3NUaGFuKGN1cnJlbnQpOwogICAgICAg ICB9CisKKyAgICAgICAgaWYgKHRoaXMuX2xhc3RTZWxlY3RlZEluZGV4ID49IGluZGV4KQorICAg ICAgICAgICAgdGhpcy5fbGFzdFNlbGVjdGVkSW5kZXggKz0gMTsKKyAgICAgICAgaWYgKHRoaXMu X3NoaWZ0QW5jaG9ySW5kZXggPj0gaW5kZXgpCisgICAgICAgICAgICB0aGlzLl9zaGlmdEFuY2hv ckluZGV4ICs9IDE7CiAgICAgfQogCiAgICAgZGlkUmVtb3ZlSXRlbXMoaW5kZXhlcykKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1RyZWVPdXRs aW5lLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvVHJlZU91 dGxpbmUuanMKaW5kZXggY2M4YmIyZDA1ZmYxMWJiMmRhMGVhNzg3YmYxM2Q0NGU0NTdlYzI2NC4u MjI4NDBhMWU0MzVlMzc1YjIxMzVmZjAxMzk1ZjliZTRiMjJlY2JkOCAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvVHJlZU91dGxpbmUuanMKKysr IGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvVHJlZU91dGxpbmUu anMKQEAgLTQwNiw4ICs0MDYsMTAgQEAgV0kuVHJlZU91dGxpbmUgPSBjbGFzcyBUcmVlT3V0bGlu ZSBleHRlbmRzIFdJLk9iamVjdAogICAgICAgICB0aGlzLl9jYWNoZWROdW1iZXJPZkRlc2NlbmRl bnRzKys7CiAKICAgICAgICAgbGV0IGluZGV4ID0gdGhpcy5faW5kZXhPZlRyZWVFbGVtZW50KGVs ZW1lbnQpOwotICAgICAgICBpZiAoaW5kZXggPj0gMCkKKyAgICAgICAgaWYgKGluZGV4ID49IDAp IHsKKyAgICAgICAgICAgIGNvbnNvbGUuYXNzZXJ0KCFlbGVtZW50LnNlbGVjdGVkLCAiVHJlZUVs ZW1lbnQgc2hvdWxkIG5vdCBiZSBzZWxlY3RlZCBiZWZvcmUgYmVpbmcgaW5zZXJ0ZWQuIik7CiAg ICAgICAgICAgICB0aGlzLl9zZWxlY3Rpb25Db250cm9sbGVyLmRpZEluc2VydEl0ZW0oaW5kZXgp OworICAgICAgICB9CiAgICAgfQogCiAgICAgX2ZvcmdldFRyZWVFbGVtZW50KGVsZW1lbnQpCg==