192869 2018-12-19 12:06:12 -0800 Remove RTCRtpTransceiver.setDirection 2018-12-19 14:01:33 -0800 1 1 1 Unclassified WebKit WebRTC WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 youennf youennf achristensen commit-queue eric.carlson webkit-bug-importer youennf oldest_to_newest 1489399 0 youennf 2018-12-19 12:06:12 -0800 The attribute setter deprecates this method. 1489402 1 357707 youennf 2018-12-19 12:09:30 -0800 Created attachment 357707 Patch 1489417 2 357707 achristensen 2018-12-19 12:56:28 -0800 Comment on attachment 357707 Patch Can't we remove the C++ function, too? 1489441 3 youennf 2018-12-19 13:33:40 -0800 (In reply to Alex Christensen from comment #2) > Comment on attachment 357707 [details] > Patch > > Can't we remove the C++ function, too? The C++ function is used when setting the 'direction' attribute. 1489458 4 357707 commit-queue 2018-12-19 14:00:32 -0800 Comment on attachment 357707 Patch Clearing flags on attachment: 357707 Committed r239391: <https://trac.webkit.org/changeset/239391> 1489459 5 commit-queue 2018-12-19 14:00:34 -0800 All reviewed patches have been landed. Closing bug. 1489461 6 webkit-bug-importer 2018-12-19 14:01:33 -0800 <rdar://problem/46851629> 357707 2018-12-19 12:09:30 -0800 2018-12-19 14:00:32 -0800 Patch bug-192869-20181219120927.patch text/plain 3098 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjM5MjgyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTgwZjc4MTk5ZDc2YzMw OTBjOGJlYTBkOGEyN2Y3YjVmYmUxNTk4YS4uYWViYjExNDUwNjNhZjVkODJhMTY3M2UzNTE1MjBl NzA5OTU2ZTJhMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE4LTEyLTE5ICBZb3Vl bm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KKworICAgICAgICBSZW1vdmUgUlRDUnRwVHJh bnNjZWl2ZXIuc2V0RGlyZWN0aW9uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xOTI4NjkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBDb3ZlcmVkIGJ5IHJlYmFzZWQgdGVzdC4KKworICAgICAgICAqIE1vZHVs ZXMvbWVkaWFzdHJlYW0vUlRDUnRwVHJhbnNjZWl2ZXIuaWRsOgorCiAyMDE4LTEyLTE3ICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCBidWlsZCBm aXguCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhc3RyZWFtL1JUQ1J0 cFRyYW5zY2VpdmVyLmlkbCBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFzdHJlYW0vUlRD UnRwVHJhbnNjZWl2ZXIuaWRsCmluZGV4IGNjNjQwZjQyOTg3ZGJjZGMxZWZmZjAzYjQ0ZGY3NjZi YTczMzk5YTAuLmVmNTliMDIyNWFhMzU0YmU3MmNkNTkxM2QxNjU2NThiMjhiOWMyMTYgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFzdHJlYW0vUlRDUnRwVHJhbnNjZWl2 ZXIuaWRsCisrKyBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFzdHJlYW0vUlRDUnRwVHJh bnNjZWl2ZXIuaWRsCkBAIC00MSw4ICs0MSw2IEBAIHR5cGVkZWYgUlRDUnRwVHJhbnNjZWl2ZXJE aXJlY3Rpb24gUnRwVHJhbnNjZWl2ZXJEaXJlY3Rpb247CiAgICAgcmVhZG9ubHkgYXR0cmlidXRl IGJvb2xlYW4gc3RvcHBlZDsKICAgICBhdHRyaWJ1dGUgUnRwVHJhbnNjZWl2ZXJEaXJlY3Rpb24g ZGlyZWN0aW9uOwogICAgIFtFbmFibGVkQXRSdW50aW1lPVdlYlJUQ1VuaWZpZWRQbGFuXSByZWFk b25seSBhdHRyaWJ1dGUgUlRDUnRwVHJhbnNjZWl2ZXJEaXJlY3Rpb24/IGN1cnJlbnREaXJlY3Rp b247Ci0gICAgLy8gRklYTUU6IFJlbW92ZSBzZXREaXJlY3Rpb24KLSAgICB2b2lkIHNldERpcmVj dGlvbihSdHBUcmFuc2NlaXZlckRpcmVjdGlvbiBkaXJlY3Rpb24pOwogICAgIHZvaWQgc3RvcCgp OwogICAgIC8vIEZJWE1FIDE2OTY2MjogbWlzc2luZyBzZXRDb2RlY1ByZWZlcmVuY2VzCiB9Owpk aWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL0NoYW5nZUxvZyBiL0xheW91dFRl c3RzL2ltcG9ydGVkL3czYy9DaGFuZ2VMb2cKaW5kZXggNDYyNjBmNTc1NGRhNjVjOGIzZjkzYWVl NzYzZDUwNmYzMWNkYmZhMi4uNzhhYWM3OGIzMDk1OTZlMTAzYjQ2YzFkNGIzODEwNTI3MjIxNTQ2 MSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL0NoYW5nZUxvZworKysgYi9M YXlvdXRUZXN0cy9pbXBvcnRlZC93M2MvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTgt MTItMTkgIFlvdWVubiBGYWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgorCisgICAgICAgIFJlbW92 ZSBSVENSdHBUcmFuc2NlaXZlci5zZXREaXJlY3Rpb24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5Mjg2OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgICogd2ViLXBsYXRmb3JtLXRlc3RzL3dlYnJ0Yy9oaXN0 b3JpY2FsLWV4cGVjdGVkLnR4dDoKKwogMjAxOC0xMi0xNCAgWW91ZW5uIEZhYmxldCAgPHlvdWVu bkBhcHBsZS5jb20+CiAKICAgICAgICAgZ2V0U2VuZGVycy9nZXRSZWNlaXZlcnMoKSBzaG91bGQg bm90IHJldHVybiBjbG9zZWQgdHJhbnNjZWl2ZXIgc2VuZGVycy9yZWNlaXZlcnMKZGlmZiAtLWdp dCBhL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvd2VicnRjL2hp c3RvcmljYWwtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL3dlYi1wbGF0 Zm9ybS10ZXN0cy93ZWJydGMvaGlzdG9yaWNhbC1leHBlY3RlZC50eHQKaW5kZXggNTQzODk3YzM4 MzQxNWJkZmMyMzFhMGMyNTQ3NzkzYjZiODgwYzhhNy4uYzhjODk4NDViODk5NTE0ZDhlNTk2M2Vj NTVmMTAyMzA2MGMzYzI0NiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL3dl Yi1wbGF0Zm9ybS10ZXN0cy93ZWJydGMvaGlzdG9yaWNhbC1leHBlY3RlZC50eHQKKysrIGIvTGF5 b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy93ZWJydGMvaGlzdG9yaWNh bC1leHBlY3RlZC50eHQKQEAgLTksNyArOSw3IEBAIFBBU1MgUlRDUGVlckNvbm5lY3Rpb24gbWVt YmVyIG9uYWRkc3RyZWFtIHNob3VsZCBub3QgZXhpc3QKIFBBU1MgUlRDUGVlckNvbm5lY3Rpb24g bWVtYmVyIG9ucmVtb3Zlc3RyZWFtIHNob3VsZCBub3QgZXhpc3QgCiBQQVNTIFJUQ1BlZXJDb25u ZWN0aW9uIG1lbWJlciByZW1vdmVTdHJlYW0gc2hvdWxkIG5vdCBleGlzdCAKIFBBU1MgUlRDUGVl ckNvbm5lY3Rpb24gbWVtYmVyIHVwZGF0ZUljZSBzaG91bGQgbm90IGV4aXN0IAotRkFJTCBSVENS dHBUcmFuc2NlaXZlciBtZW1iZXIgc2V0RGlyZWN0aW9uIHNob3VsZCBub3QgZXhpc3QgYXNzZXJ0 X2ZhbHNlOiBleHBlY3RlZCBmYWxzZSBnb3QgdHJ1ZQorUEFTUyBSVENSdHBUcmFuc2NlaXZlciBt ZW1iZXIgc2V0RGlyZWN0aW9uIHNob3VsZCBub3QgZXhpc3QgCiBQQVNTIERhdGFDaGFubmVsIGlu dGVyZmFjZSBzaG91bGQgbm90IGV4aXN0IAogUEFTUyBtb3pSVENJY2VDYW5kaWRhdGUgaW50ZXJm YWNlIHNob3VsZCBub3QgZXhpc3QgCiBQQVNTIG1velJUQ1BlZXJDb25uZWN0aW9uIGludGVyZmFj ZSBzaG91bGQgbm90IGV4aXN0IAo=