192859 2018-12-19 10:07:08 -0800 REGRESSION(r239353): iOS WK1 Assertion failure in notifyChildNodeRemoved while running TestWebKitAPI.QuickLook.LegacyQuickLookContent 2018-12-21 16:28:46 -0800 1 1 1 Unclassified WebKit New Bugs Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ryanhaddad rniwa aestes cdumez ddkilzer jlewis3 koivisto rniwa thorton tsavell webkit-bug-importer zalan oldest_to_newest 1489341 0 ryanhaddad 2018-12-19 10:07:08 -0800 TestWebKitAPI.QuickLook.LegacyQuickLookContent ASSERTION FAILED: !ScriptDisallowedScope::InMainThread::isScriptAllowed() ./dom/ContainerNodeAlgorithms.cpp(91) : WebCore::NodeVector WebCore::notifyChildNodeInserted(WebCore::ContainerNode &, WebCore::Node &) 1 0x10ad9b6c9 WTFCrash 2 0x119fdcc8b WTFCrashWithInfo(int, char const*, char const*, int) 3 0x11bf831a3 WebCore::notifyChildNodeInserted(WebCore::ContainerNode&, WebCore::Node&) 4 0x11bf80e40 void WebCore::executeNodeInsertionWithScriptAssertion<WebCore::ContainerNode::parserAppendChild(WebCore::Node&)::$_5>(WebCore::ContainerNode&, WebCore::Node&, WebCore::ContainerNode::ChildChangeSource, WebCore::ReplacedAllChildren, WebCore::ContainerNode::parserAppendChild(WebCore::Node&)::$_5) 5 0x11bf7cb63 WebCore::ContainerNode::parserAppendChild(WebCore::Node&) 6 0x11c5b282a WebCore::insert(WebCore::HTMLConstructionSiteTask&) 7 0x11c5b219d WebCore::executeInsertTask(WebCore::HTMLConstructionSiteTask&) 8 0x11c59feb6 WebCore::executeTask(WebCore::HTMLConstructionSiteTask&) 9 0x11c59fd72 WebCore::HTMLConstructionSite::executeQueuedTasks() 10 0x11c5a0640 WebCore::HTMLConstructionSite::insertHTMLHtmlStartTagBeforeHTML(WebCore::AtomicHTMLToken&&) 11 0x11c5e513b WebCore::HTMLTreeBuilder::defaultForBeforeHTML() 12 0x11c5def0d WebCore::HTMLTreeBuilder::processEndOfFile(WebCore::AtomicHTMLToken&&) 13 0x11c5da9cf WebCore::HTMLTreeBuilder::processToken(WebCore::AtomicHTMLToken&&) 14 0x11c5d9778 WebCore::HTMLTreeBuilder::constructTree(WebCore::AtomicHTMLToken&&) 15 0x11c5a9b71 WebCore::HTMLDocumentParser::constructTreeFromHTMLToken(WebCore::HTMLTokenizer::TokenPtr&) 16 0x11c5a97f8 WebCore::HTMLDocumentParser::pumpTokenizerLoop(WebCore::HTMLDocumentParser::SynchronousMode, bool, WebCore::PumpSession&) 17 0x11c5a7ebe WebCore::HTMLDocumentParser::pumpTokenizer(WebCore::HTMLDocumentParser::SynchronousMode) 18 0x11c5a77cd WebCore::HTMLDocumentParser::pumpTokenizerIfPossible(WebCore::HTMLDocumentParser::SynchronousMode) 19 0x11c5a7580 WebCore::HTMLDocumentParser::prepareToStopParsing() 20 0x11c5aa94f WebCore::HTMLDocumentParser::attemptToEnd() 21 0x11c5aaa28 WebCore::HTMLDocumentParser::finish() 22 0x11c88d11a WebCore::DocumentWriter::end() 23 0x11c84dcaf WebCore::DocumentLoader::finishedLoading() 24 0x11c858081 WebCore::DocumentLoader::maybeLoadEmpty() 25 0x11c858215 WebCore::DocumentLoader::startLoadingMainResource() 26 0x11c8d893a WebCore::FrameLoader::continueLoadAfterNavigationPolicy(WebCore::ResourceRequest const&, WebCore::FormState*, WebCore::ShouldContinue, WebCore::AllowNavigationToInvalidURL)::$_12::operator()()::'lambda'()::operator()() const 27 0x11c8d8659 WTF::Function<void ()>::CallableWrapper<WebCore::FrameLoader::continueLoadAfterNavigationPolicy(WebCore::ResourceRequest const&, WebCore::FormState*, WebCore::ShouldContinue, WebCore::AllowNavigationToInvalidURL)::$_12::operator()()::'lambda'()>::call() 28 0x119fddb9d WTF::Function<void ()>::operator()() const 29 0x11a047220 WTF::CompletionHandler<void ()>::operator()() 30 0x11c8d1a70 WebCore::FrameLoader::prepareForLoadStart(WTF::CompletionHandler<void ()>&&)::$_3::operator()() 31 0x11c8d17d9 WTF::Function<void ()>::CallableWrapper<WebCore::FrameLoader::prepareForLoadStart(WTF::CompletionHandler<void ()>&&)::$_3>::call() Child process terminated with signal 11: Segmentation fault https://build.webkit.org/builders/Apple%20iOS%2012%20Simulator%20Debug%20WK2%20(Tests)/builds/1411/steps/run-api-tests/logs/stdio 1489342 1 ryanhaddad 2018-12-19 10:07:24 -0800 I do not know when this regressed, but I think it is recent. 1489611 2 ryanhaddad 2018-12-19 17:04:40 -0800 I thinks this started with https://trac.webkit.org/changeset/239353/webkit 1489918 3 ryanhaddad 2018-12-20 10:25:51 -0800 Ryosuke, could you please take a look at this one? 1490167 4 webkit-bug-importer 2018-12-20 16:25:28 -0800 <rdar://problem/46887237> 1490173 5 rniwa 2018-12-20 16:34:16 -0800 Ugh... we need to update that assertion for WK1. I guess some API tests are testing WK1 :( 1490284 6 357927 rniwa 2018-12-20 22:00:01 -0800 Created attachment 357927 Fixes the bug 1490331 7 357927 koivisto 2018-12-21 06:41:54 -0800 Comment on attachment 357927 Fixes the bug View in context: https://bugs.webkit.org/attachment.cgi?id=357927&action=review > Source/WebCore/dom/ScriptDisallowedScope.h:90 > + static bool hasDisallowedScope() { return s_count; } Could we still ASSERT(isMainThread())? 1490532 8 rniwa 2018-12-21 15:47:22 -0800 (In reply to Antti Koivisto from comment #7) > Comment on attachment 357927 [details] > Fixes the bug > > View in context: > https://bugs.webkit.org/attachment.cgi?id=357927&action=review > > > Source/WebCore/dom/ScriptDisallowedScope.h:90 > > + static bool hasDisallowedScope() { return s_count; } > > Could we still ASSERT(isMainThread())? Good catch! Sure, will fix. 1490565 9 rniwa 2018-12-21 16:28:46 -0800 Committed r239529: <https://trac.webkit.org/changeset/239529> 357927 2018-12-20 22:00:01 -0800 2018-12-21 06:41:54 -0800 Fixes the bug bug-192859-20181220220000.patch text/plain 4879 rniwa SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIzOTQ5MykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDMxIEBACisyMDE4LTEyLTIwICBSeW9zdWtl IE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIFJFR1JFU1NJT04ocjIzOTM1Myk6 IGlPUyBXSzEgQXNzZXJ0aW9uIGZhaWx1cmUgaW4gbm90aWZ5Q2hpbGROb2RlUmVtb3ZlZCB3aGls ZSBydW5uaW5nCisgICAgICAgIFRlc3RXZWJLaXRBUEkuUXVpY2tMb29rLkxlZ2FjeVF1aWNrTG9v a0NvbnRlbnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTE5Mjg1OQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNDY4ODcyMzc+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWZ0ZXIgcjIzOTM1MywgU2NyaXB0 RGlzYWxsb3dlZFNjb3BlOjpJbk1haW5UaHJlYWQ6OmlzU2NyaXB0QWxsb3dlZCgpIG1heSByZXR1 cm4gZmFsc2Ugd2hlbiB0aGUgd2ViIHRocmVhZAorICAgICAgICBpcyBpbnNpZGUgYSBkZWxlZ2F0 ZSBjYWxsYmFjayBldmVuIHdoZW4gdGhlcmUgaXMgYSBTY3JpcHREaXNhbGxvd2VkU2NvcGUgZGVm aW5lZC4KKworICAgICAgICBSZXBsYWNlIHRoZSBleGlzdGlnbiBkZWJ1ZyBhc3NlcnRpb25zIHdo aWNoIGFzc2VydCAhU2NyaXB0RGlzYWxsb3dlZFNjb3BlOjpJbk1haW5UaHJlYWQ6OmlzU2NyaXB0 QWxsb3dlZCgpCisgICAgICAgIGJ5IGEgbmV3bHkgYWRkZWQgU2NyaXB0RGlzYWxsb3dlZFNjb3Bl OjpJbk1haW5UaHJlYWQ6Omhhc0Rpc2FsbG93ZWRTY29wZSB0byBhdm9pZCBoaXR0aW5nIHRoaXMg YXNzZXJ0aW9uLgorCisgICAgICAgIFRlc3RzOiBUZXN0V2ViS2l0QVBJLlF1aWNrTG9vay5MZWdh Y3lRdWlja0xvb2tDb250ZW50CisKKyAgICAgICAgKiBkb20vQ29udGFpbmVyTm9kZUFsZ29yaXRo bXMuY3BwOgorICAgICAgICAoV2ViQ29yZTo6bm90aWZ5Q2hpbGROb2RlSW5zZXJ0ZWQpOgorICAg ICAgICAoV2ViQ29yZTo6bm90aWZ5Q2hpbGROb2RlUmVtb3ZlZCk6CisgICAgICAgICogZG9tL0Rv Y3VtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkRvY3VtZW50Ojpub2RlQ2hpbGRyZW5XaWxs QmVSZW1vdmVkKToKKyAgICAgICAgKFdlYkNvcmU6OkRvY3VtZW50Ojpub2RlV2lsbEJlUmVtb3Zl ZCk6CisgICAgICAgICogZG9tL1NjcmlwdERpc2FsbG93ZWRTY29wZS5oOgorICAgICAgICAoV2Vi Q29yZTo6U2NyaXB0RGlzYWxsb3dlZFNjb3BlOjpJbk1haW5UaHJlYWQ6Omhhc0Rpc2FsbG93ZWRT Y29wZSk6CisgICAgICAgICogaHRtbC9IVE1MRm9ybUVsZW1lbnQuY3BwOgorICAgICAgICAoV2Vi Q29yZTo6IGNvbnN0KToKKwogMjAxOC0xMi0yMCAgTWljaGFlbCBDYXRhbnphcm8gIDxtY2F0YW56 YXJvQGlnYWxpYS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcmVtb3ZlIHN0cmF5ICNwcmFn bWEgb25jZSBhZGRlZCB0byAuY3BwIGZpbGUKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2RvbS9Db250 YWluZXJOb2RlQWxnb3JpdGhtcy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvZG9t L0NvbnRhaW5lck5vZGVBbGdvcml0aG1zLmNwcAkocmV2aXNpb24gMjM5NDkxKQorKysgU291cmNl L1dlYkNvcmUvZG9tL0NvbnRhaW5lck5vZGVBbGdvcml0aG1zLmNwcAkod29ya2luZyBjb3B5KQpA QCAtODgsNyArODgsNyBAQCBzdGF0aWMgdm9pZCBub3RpZnlOb2RlSW5zZXJ0ZWRJbnRvVHJlZShD CiAKIE5vZGVWZWN0b3Igbm90aWZ5Q2hpbGROb2RlSW5zZXJ0ZWQoQ29udGFpbmVyTm9kZSYgcGFy ZW50T2ZJbnNlcnRlZFRyZWUsIE5vZGUmIG5vZGUpCiB7Ci0gICAgQVNTRVJUKCFTY3JpcHREaXNh bGxvd2VkU2NvcGU6OkluTWFpblRocmVhZDo6aXNTY3JpcHRBbGxvd2VkKCkpOworICAgIEFTU0VS VChTY3JpcHREaXNhbGxvd2VkU2NvcGU6OkluTWFpblRocmVhZDo6aGFzRGlzYWxsb3dlZFNjb3Bl KCkpOwogCiAgICAgSW5zcGVjdG9ySW5zdHJ1bWVudGF0aW9uOjpkaWRJbnNlcnRET01Ob2RlKG5v ZGUuZG9jdW1lbnQoKSwgbm9kZSk7CiAKQEAgLTE1Miw3ICsxNTIsNyBAQCBzdGF0aWMgdm9pZCBu b3RpZnlOb2RlUmVtb3ZlZEZyb21UcmVlKENvCiB2b2lkIG5vdGlmeUNoaWxkTm9kZVJlbW92ZWQo Q29udGFpbmVyTm9kZSYgb2xkUGFyZW50T2ZSZW1vdmVkVHJlZSwgTm9kZSYgY2hpbGQpCiB7CiAg ICAgLy8gQXNzZXJ0IHRoYXQgdGhlIGNhbGxlciBvZiB0aGlzIGZ1bmN0aW9uIGhhcyBhbiBpbnN0 YW5jZSBvZiBTY3JpcHREaXNhbGxvd2VkU2NvcGUuCi0gICAgQVNTRVJUKCFpc01haW5UaHJlYWQo KSB8fCAhU2NyaXB0RGlzYWxsb3dlZFNjb3BlOjpJbk1haW5UaHJlYWQ6OmlzU2NyaXB0QWxsb3dl ZCgpKTsKKyAgICBBU1NFUlQoIWlzTWFpblRocmVhZCgpIHx8IFNjcmlwdERpc2FsbG93ZWRTY29w ZTo6SW5NYWluVGhyZWFkOjpoYXNEaXNhbGxvd2VkU2NvcGUoKSk7CiAgICAgQ29udGFpbmVyQ2hp bGRSZW1vdmFsU2NvcGUgcmVtb3ZhbFNjb3BlKG9sZFBhcmVudE9mUmVtb3ZlZFRyZWUsIGNoaWxk KTsKIAogICAgIC8vIFRyZWUgc2NvcGUgaGFzIGNoYW5nZWQgaWYgdGhlIGNvbnRhaW5lciBub2Rl IGZyb20gd2hpY2ggIm5vZGUiIGlzIHJlbW92ZWQgaXMgaW4gYSBkb2N1bWVudCBvciBhIHNoYWRv dyByb290LgpJbmRleDogU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50LmNwcAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBTb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1lbnQuY3BwCShyZXZpc2lvbiAyMzk0OTEpCisr KyBTb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1lbnQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC00MzU4 LDcgKzQzNTgsNyBAQCB2b2lkIERvY3VtZW50Ojp1cGRhdGVSYW5nZXNBZnRlckNoaWxkcmVuCiAK IHZvaWQgRG9jdW1lbnQ6Om5vZGVDaGlsZHJlbldpbGxCZVJlbW92ZWQoQ29udGFpbmVyTm9kZSYg Y29udGFpbmVyKQogewotICAgIEFTU0VSVCghU2NyaXB0RGlzYWxsb3dlZFNjb3BlOjpJbk1haW5U aHJlYWQ6OmlzU2NyaXB0QWxsb3dlZCgpKTsKKyAgICBBU1NFUlQoU2NyaXB0RGlzYWxsb3dlZFNj b3BlOjpJbk1haW5UaHJlYWQ6Omhhc0Rpc2FsbG93ZWRTY29wZSgpKTsKIAogICAgIGFkanVzdEZv Y3VzZWROb2RlT25Ob2RlUmVtb3ZhbChjb250YWluZXIsIE5vZGVSZW1vdmFsOjpDaGlsZHJlbk9m Tm9kZSk7CiAgICAgYWRqdXN0Rm9jdXNOYXZpZ2F0aW9uTm9kZU9uTm9kZVJlbW92YWwoY29udGFp bmVyLCBOb2RlUmVtb3ZhbDo6Q2hpbGRyZW5PZk5vZGUpOwpAQCAtNDM5MSw3ICs0MzkxLDcgQEAg dm9pZCBEb2N1bWVudDo6bm9kZUNoaWxkcmVuV2lsbEJlUmVtb3ZlZAogCiB2b2lkIERvY3VtZW50 Ojpub2RlV2lsbEJlUmVtb3ZlZChOb2RlJiBub2RlKQogewotICAgIEFTU0VSVCghU2NyaXB0RGlz YWxsb3dlZFNjb3BlOjpJbk1haW5UaHJlYWQ6OmlzU2NyaXB0QWxsb3dlZCgpKTsKKyAgICBBU1NF UlQoU2NyaXB0RGlzYWxsb3dlZFNjb3BlOjpJbk1haW5UaHJlYWQ6Omhhc0Rpc2FsbG93ZWRTY29w ZSgpKTsKIAogICAgIGFkanVzdEZvY3VzZWROb2RlT25Ob2RlUmVtb3ZhbChub2RlKTsKICAgICBh ZGp1c3RGb2N1c05hdmlnYXRpb25Ob2RlT25Ob2RlUmVtb3ZhbChub2RlKTsKSW5kZXg6IFNvdXJj ZS9XZWJDb3JlL2RvbS9TY3JpcHREaXNhbGxvd2VkU2NvcGUuaAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3Vy Y2UvV2ViQ29yZS9kb20vU2NyaXB0RGlzYWxsb3dlZFNjb3BlLmgJKHJldmlzaW9uIDIzOTQ5MSkK KysrIFNvdXJjZS9XZWJDb3JlL2RvbS9TY3JpcHREaXNhbGxvd2VkU2NvcGUuaAkod29ya2luZyBj b3B5KQpAQCAtODcsNiArODcsOCBAQCBwdWJsaWM6CiAjZW5kaWYKICAgICAgICAgfQogCisgICAg ICAgIHN0YXRpYyBib29sIGhhc0Rpc2FsbG93ZWRTY29wZSgpIHsgcmV0dXJuIHNfY291bnQ7IH0K KwogICAgICAgICBzdGF0aWMgYm9vbCBpc1NjcmlwdEFsbG93ZWQoKQogICAgICAgICB7CiAgICAg ICAgICAgICBBU1NFUlQoaXNNYWluVGhyZWFkKCkpOwpJbmRleDogU291cmNlL1dlYkNvcmUvaHRt bC9IVE1MRm9ybUVsZW1lbnQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2h0bWwv SFRNTEZvcm1FbGVtZW50LmNwcAkocmV2aXNpb24gMjM5NDkxKQorKysgU291cmNlL1dlYkNvcmUv aHRtbC9IVE1MRm9ybUVsZW1lbnQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC04NjMsNyArODYzLDcg QEAgdm9pZCBIVE1MRm9ybUVsZW1lbnQ6OmZpbmlzaFBhcnNpbmdDaGlsZAogCiBjb25zdCBWZWN0 b3I8Rm9ybUFzc29jaWF0ZWRFbGVtZW50Kj4mIEhUTUxGb3JtRWxlbWVudDo6dW5zYWZlQXNzb2Np YXRlZEVsZW1lbnRzKCkgY29uc3QKIHsKLSAgICBBU1NFUlQoIVNjcmlwdERpc2FsbG93ZWRTY29w ZTo6SW5NYWluVGhyZWFkOjppc1NjcmlwdEFsbG93ZWQoKSk7CisgICAgQVNTRVJUKFNjcmlwdERp c2FsbG93ZWRTY29wZTo6SW5NYWluVGhyZWFkOjpoYXNEaXNhbGxvd2VkU2NvcGUoKSk7CiAgICAg cmV0dXJuIG1fYXNzb2NpYXRlZEVsZW1lbnRzOwogfQogCg==