192840 2018-12-18 19:20:53 -0800 SVGUseElement::findTarget should return nullptr when there is a cycle 2018-12-19 15:52:26 -0800 1 1 1 Unclassified WebKit SVG WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 rniwa rniwa koivisto sabouhallawa simon.fraser thorton webkit-bug-importer zalan zimmermann oldest_to_newest 1489177 0 rniwa 2018-12-18 19:20:53 -0800 https://trac.webkit.org/changeset/233366 added an early return to updateShadowTree() when there is a cycle but there is a separate cycle detection for when there is a corresponding element in SVGUseElement::findTarget. Support detecting a cycle in SVGUseElement::findTarget to consolidate these two cycle detection code paths. 1489187 1 357647 rniwa 2018-12-18 19:49:01 -0800 Created attachment 357647 Cleanup 1489484 2 357647 thorton 2018-12-19 14:30:39 -0800 Comment on attachment 357647 Cleanup View in context: https://bugs.webkit.org/attachment.cgi?id=357647&action=review > Source/WebCore/ChangeLog:12 > + No new tests since there shoul be no behavioral change. s/shoul/should/ 1489545 3 rniwa 2018-12-19 15:51:06 -0800 Committed r239402: <https://trac.webkit.org/changeset/239402> 1489547 4 webkit-bug-importer 2018-12-19 15:52:26 -0800 <rdar://problem/46855832> 357647 2018-12-18 19:49:01 -0800 2018-12-19 14:30:39 -0800 Cleanup bug-192840-20181218194901.patch text/plain 2407 rniwa SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIzOTM2NSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBACisyMDE4LTEyLTE4ICBSeW9zdWtl IE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIFNWR1VzZUVsZW1lbnQ6OmZpbmRU YXJnZXQgc2hvdWxkIHJldHVybiBudWxscHRyIHdoZW4gdGhlcmUgaXMgYSBjeWNsZQorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTkyODQwCisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgcjIzMzM2NiBhZGRlZCBh biBlYXJseSByZXR1cm4gdG8gdXBkYXRlU2hhZG93VHJlZSgpIHdoZW4gdGhlcmUgaXMgYSBjeWNs ZSBiZXR3ZWVuIGFuIHVzZSBlbGVtZW50IGFuZCBpdHMgdGFyZ2V0LgorICAgICAgICBDb25zb2xp ZGF0ZSB0aGlzIGN5Y2xlIGRldGVjdGlvbiBjb2RlIHdpdGggdGhlIG9uZSBpbiBTVkdVc2VFbGVt ZW50OjpmaW5kVGFyZ2V0IHdoaWNoIGRldGVjdGVkIGN5Y2xlcyB3aGVuCisgICAgICAgIHRoZSBT VkcgdXNlIGVsZW1lbnQgaXRzZWxmIGhhZCBhIGNvcnJlc3BvbmRpbmcgZWxlbWVudC4KKworICAg ICAgICBObyBuZXcgdGVzdHMgc2luY2UgdGhlcmUgc2hvdWwgYmUgbm8gYmVoYXZpb3JhbCBjaGFu Z2UuCisKKyAgICAgICAgKiBzdmcvU1ZHVXNlRWxlbWVudC5jcHA6CisgICAgICAgIChXZWJDb3Jl OjpTVkdVc2VFbGVtZW50Ojp1cGRhdGVTaGFkb3dUcmVlKToKKyAgICAgICAgKFdlYkNvcmU6OlNW R1VzZUVsZW1lbnQ6OmZpbmRUYXJnZXQgY29uc3QpOgorCiAyMDE4LTEyLTE4ICBKdXN0aW4gTWlj aGF1ZCAgPGp1c3Rpbl9taWNoYXVkQGFwcGxlLmNvbT4KIAogICAgICAgICBVcGRhdGUgQ1NTIFBy b3BlcnRpZXMgYW5kIFZhbHVlcyBBUEkgdG8gdXNlIG5ldyBjeWNsZSBmYWxsYmFjayBiZWhhdmlv dXIKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3N2Zy9TVkdVc2VFbGVtZW50LmNwcAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBTb3VyY2UvV2ViQ29yZS9zdmcvU1ZHVXNlRWxlbWVudC5jcHAJKHJldmlzaW9uIDIzOTM2 NCkKKysrIFNvdXJjZS9XZWJDb3JlL3N2Zy9TVkdVc2VFbGVtZW50LmNwcAkod29ya2luZyBjb3B5 KQpAQCAtMjQ0LDkgKzI0NCw3IEBAIHZvaWQgU1ZHVXNlRWxlbWVudDo6dXBkYXRlU2hhZG93VHJl ZSgpCiAgICAgICAgIHJldHVybjsKICAgICB9CiAKLSAgICBpZiAoaXNEZXNjZW5kYW50T2YodGFy Z2V0KSkKLSAgICAgICAgcmV0dXJuOwotICAgIAorICAgIFJFTEVBU0VfQVNTRVJUKCFpc0Rlc2Nl bmRhbnRPZih0YXJnZXQpKTsKICAgICB7CiAgICAgICAgIGF1dG8mIHNoYWRvd1Jvb3QgPSBlbnN1 cmVVc2VyQWdlbnRTaGFkb3dSb290KCk7CiAgICAgICAgIGNsb25lVGFyZ2V0KHNoYWRvd1Jvb3Qs ICp0YXJnZXQpOwpAQCAtNDIzLDEzICs0MjEsMTYgQEAgU1ZHRWxlbWVudCogU1ZHVXNlRWxlbWVu dDo6ZmluZFRhcmdldChTdAogICAgIGlmICghdGFyZ2V0LmlzQ29ubmVjdGVkKCkgfHwgaXNEaXNh bGxvd2VkRWxlbWVudCh0YXJnZXQpKQogICAgICAgICByZXR1cm4gbnVsbHB0cjsKIAotICAgIC8v IFJlamVjdCBhbnkgdGFyZ2V0IHRoYXQgaGFzIGFscmVhZHkgYmVlbiBjbG9uZWQgdG8gY3JlYXRl IG9uZSBvZiB0aGUgYW5jZXN0b3JzIG9mIHRoaXMgZWxlbWVudCwKLSAgICAvLyBhbHJlYWR5IGlu IHRoZSBzaGFkb3cgdHJlZS4gVGhpcyBpcyBzdWZmaWNpZW50IHRvIHByZXZlbnQgY3ljbGVzLgog ICAgIGlmIChjb3JyZXNwb25kaW5nRWxlbWVudCkgewogICAgICAgICBmb3IgKGF1dG8mIGFuY2Vz dG9yIDogbGluZWFnZU9mVHlwZTxTVkdFbGVtZW50PigqdGhpcykpIHsKICAgICAgICAgICAgIGlm IChhbmNlc3Rvci5jb3JyZXNwb25kaW5nRWxlbWVudCgpID09ICZ0YXJnZXQpCiAgICAgICAgICAg ICAgICAgcmV0dXJuIG51bGxwdHI7CiAgICAgICAgIH0KKyAgICB9IGVsc2UgeworICAgICAgICBp ZiAodGFyZ2V0LmNvbnRhaW5zKHRoaXMpKQorICAgICAgICAgICAgcmV0dXJuIG51bGxwdHI7Cisg ICAgICAgIC8vIFRhcmdldCBzaG91bGQgb25seSByZWZlciB0byBhIG5vZGUgaW4gdGhlIHNhbWUg dHJlZSBvciBhIG5vZGUgaW4gYW5vdGhlciBkb2N1bWVudC4KKyAgICAgICAgQVNTRVJUKCFpc0Rl c2NlbmRhbnRPclNoYWRvd0Rlc2NlbmRhbnRPZigmdGFyZ2V0KSk7CiAgICAgfQogCiAgICAgcmV0 dXJuICZ0YXJnZXQ7Cg==