192837 2018-12-18 16:03:26 -0800 REGRESSION(r239134) iOS safe browsing warning unable to show details 2018-12-18 21:03:08 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 achristensen achristensen thorton webkit-bug-importer oldest_to_newest 1489120 0 achristensen 2018-12-18 16:03:26 -0800 REGRESSION(r239134) iOS safe browsing warning unable to show details 1489122 1 357628 achristensen 2018-12-18 16:04:29 -0800 Created attachment 357628 Patch 1489135 2 357628 thorton 2018-12-18 16:27:13 -0800 Comment on attachment 357628 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=357628&action=review > Source/WebKit/ChangeLog:10 > + I added a call to updateContentSize in r239134 which was necessary on watchOS but it makes iOS unable to show the details. Why?!?! 1489136 3 achristensen 2018-12-18 16:28:50 -0800 It was necessary on the watch because the content is bigger than a watch screen and you need to scroll down to see or do anything. I don't know why setting the size on the watch twice works fine but on iOS it does not. 1489138 4 thorton 2018-12-18 16:35:05 -0800 Seems like it would be good to know that? Especially since it's just "do a layout and set contentSize" which should certainly not break things? 1489145 5 357637 achristensen 2018-12-18 17:15:35 -0800 Created attachment 357637 Patch 1489199 6 achristensen 2018-12-18 21:01:18 -0800 http://trac.webkit.org/r239367 1489201 7 webkit-bug-importer 2018-12-18 21:03:08 -0800 <rdar://problem/46830755> 357628 2018-12-18 16:04:29 -0800 2018-12-18 17:15:33 -0800 Patch bug-192837-20181218160428.patch text/plain 1317 achristensen SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyMzkzNjApCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDE4LTEyLTE4ICBBbGV4IENocmlz dGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUkVHUkVTU0lPTihy MjM5MTM0KSBpT1Mgc2FmZSBicm93c2luZyB3YXJuaW5nIHVuYWJsZSB0byBzaG93IGRldGFpbHMK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5MjgzNwor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVUlQcm9j ZXNzL0NvY29hL1dLU2FmZUJyb3dzaW5nV2FybmluZy5tbToKKyAgICAgICAgKC1bV0tTYWZlQnJv d3NpbmdXYXJuaW5nIGFkZENvbnRlbnRdKToKKyAgICAgICAgSSBhZGRlZCBhIGNhbGwgdG8gdXBk YXRlQ29udGVudFNpemUgaW4gcjIzOTEzNCB3aGljaCB3YXMgbmVjZXNzYXJ5IG9uIHdhdGNoT1Mg YnV0IGl0IG1ha2VzIGlPUyB1bmFibGUgdG8gc2hvdyB0aGUgZGV0YWlscy4KKwogMjAxOC0xMi0x OCAgU2lodWkgTGl1ICA8c2lodWlfbGl1QGFwcGxlLmNvbT4KIAogICAgICAgICBDbGVhbiB1cCBJ bmRleGVkREIgZmlsZXMgYmV0d2VlbiB0ZXN0cwpJbmRleDogU291cmNlL1dlYktpdC9VSVByb2Nl c3MvQ29jb2EvV0tTYWZlQnJvd3NpbmdXYXJuaW5nLm1tCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9X ZWJLaXQvVUlQcm9jZXNzL0NvY29hL1dLU2FmZUJyb3dzaW5nV2FybmluZy5tbQkocmV2aXNpb24g MjM5MzM4KQorKysgU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQ29jb2EvV0tTYWZlQnJvd3NpbmdX YXJuaW5nLm1tCSh3b3JraW5nIGNvcHkpCkBAIC0zNTksNyArMzU5LDcgQEAgLSAodm9pZClhZGRD b250ZW50CiAgICAgICAgICAgICBbW2dvQmFjay5ib3R0b21BbmNob3IgYW5jaG9yV2l0aE9mZnNl dFRvQW5jaG9yOmJveC5ib3R0b21BbmNob3JdIGNvbnN0cmFpbnRFcXVhbFRvQ29uc3RhbnQ6bWFy Z2luU2l6ZV0sCiAgICAgICAgIF1dOwogICAgIH0KLSNpZiAhUExBVEZPUk0oTUFDKQorI2lmIFBM QVRGT1JNKFdBVENIT1MpCiAgICAgW3NlbGYgdXBkYXRlQ29udGVudFNpemVdOwogI2VuZGlmCiAj ZW5kaWYK 357637 2018-12-18 17:15:35 -0800 2018-12-18 17:26:07 -0800 Patch bug-192837-20181218171534.patch text/plain 3723 achristensen SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyMzkzNjApCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDE4LTEyLTE4ICBBbGV4IENocmlz dGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUkVHUkVTU0lPTihy MjM5MTM0KSBpT1Mgc2FmZSBicm93c2luZyB3YXJuaW5nIHVuYWJsZSB0byBzaG93IGRldGFpbHMK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5MjgzNwor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVUlQcm9j ZXNzL0NvY29hL1dLU2FmZUJyb3dzaW5nV2FybmluZy5tbToKKyAgICAgICAgKC1bV0tTYWZlQnJv d3NpbmdXYXJuaW5nIGFkZENvbnRlbnRdKToKKyAgICAgICAgSSBoYWQgYSBmcmFnaWxlIGRlc2ln biB0aGF0IHJlbGllZCBvbiB0aGUgaW50ZXJuYWwgdmlldyBoZWlyYXJjaHkgc3RydWN0dXJlIG9m IFVJU2Nyb2xsVmlldywKKyAgICAgICAgd2hpY2ggSSBjaGFuZ2VkIGluIHIyMzkxMzQgYnkgaW50 cm9kdWNpbmcgYSBsYXlvdXQgd2hpY2ggY2hhbmdlZCB3aGVyZSBpdHMgc2Nyb2xsYmFycyB3ZXJl IGluIHRoZSB2aWV3IGhlaXJhcmNoeS4KKyAgICAgICAgSSBub3cgaGF2ZSBhIG1vcmUgcm9idXN0 IGRlc2lnbiB0aGF0IHNhdmVzIGEgV2Vha09iakNQdHIgdG8gdGhlIHZpZXcgSSBuZWVkIHRvIHRy YXZlcnNlIHRvLgorICAgICAgICBUZXN0aW5nIGlzIHByb2JsZW1hdGljIGJlY2F1c2UgdGhpcyBo YWQgdG8gZG8gd2l0aCBzY3JvbGxiYXJzIGFuZCBVSVNjcm9sbFZpZXcgaW50ZXJuYWxzIHdoaWNo IHNlZW0gdG8gYmVoYXZlCisgICAgICAgIGRpZmZlcmVudGx5IGluIFRlc3RXZWJLaXRBUEksIGJ1 dCBJIHZlcmlmaWVkIG1hbnVhbGx5IHRoYXQgdGhpcyBmaXhlcyB0aGUgaXNzdWUuCisKIDIwMTgt MTItMTggIFNpaHVpIExpdSAgPHNpaHVpX2xpdUBhcHBsZS5jb20+CiAKICAgICAgICAgQ2xlYW4g dXAgSW5kZXhlZERCIGZpbGVzIGJldHdlZW4gdGVzdHMKSW5kZXg6IFNvdXJjZS9XZWJLaXQvVUlQ cm9jZXNzL0NvY29hL1dLU2FmZUJyb3dzaW5nV2FybmluZy5oCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJj ZS9XZWJLaXQvVUlQcm9jZXNzL0NvY29hL1dLU2FmZUJyb3dzaW5nV2FybmluZy5oCShyZXZpc2lv biAyMzkzMzgpCisrKyBTb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9Db2NvYS9XS1NhZmVCcm93c2lu Z1dhcm5pbmcuaAkod29ya2luZyBjb3B5KQpAQCAtNDMsOSArNDMsMTEgQEAgZW51bSBjbGFzcyBD b250aW51ZVVuc2FmZUxvYWQgOiBib29sOwogT0JKQ19DTEFTUyBXS1NhZmVCcm93c2luZ1RleHRW aWV3OwogCiAjaWYgUExBVEZPUk0oTUFDKQordXNpbmcgVmlld1R5cGUgPSBOU1ZpZXc7CiB1c2lu ZyBSZWN0VHlwZSA9IE5TUmVjdDsKIEBpbnRlcmZhY2UgV0tTYWZlQnJvd3NpbmdXYXJuaW5nIDog TlNWaWV3PE5TVGV4dFZpZXdEZWxlZ2F0ZT4KICNlbHNlCit1c2luZyBWaWV3VHlwZSA9IFVJVmll dzsKIHVzaW5nIFJlY3RUeXBlID0gQ0dSZWN0OwogQGludGVyZmFjZSBXS1NhZmVCcm93c2luZ1dh cm5pbmcgOiBVSVNjcm9sbFZpZXc8VUlUZXh0Vmlld0RlbGVnYXRlPgogI2VuZGlmCkBAIC01NCw2 ICs1Niw3IEBAIHVzaW5nIFJlY3RUeXBlID0gQ0dSZWN0OwogICAgIENvbXBsZXRpb25IYW5kbGVy PHZvaWQoVmFyaWFudDxXZWJLaXQ6OkNvbnRpbnVlVW5zYWZlTG9hZCwgVVJMPiYmKT4gX2NvbXBs ZXRpb25IYW5kbGVyOwogICAgIFJlZlB0cjxjb25zdCBXZWJLaXQ6OlNhZmVCcm93c2luZ1dhcm5p bmc+IF93YXJuaW5nOwogICAgIFdlYWtPYmpDUHRyPFdLU2FmZUJyb3dzaW5nVGV4dFZpZXc+IF9k ZXRhaWxzOworICAgIFdlYWtPYmpDUHRyPFZpZXdUeXBlPiBfYm94OwogfQogCiAtIChpbnN0YW5j ZXR5cGUpaW5pdFdpdGhGcmFtZTooUmVjdFR5cGUpZnJhbWUgc2FmZUJyb3dzaW5nV2FybmluZzoo Y29uc3QgV2ViS2l0OjpTYWZlQnJvd3NpbmdXYXJuaW5nJil3YXJuaW5nIGNvbXBsZXRpb25IYW5k bGVyOihDb21wbGV0aW9uSGFuZGxlcjx2b2lkKFZhcmlhbnQ8V2ViS2l0OjpDb250aW51ZVVuc2Fm ZUxvYWQsIFVSTD4mJik+JiYpY29tcGxldGlvbkhhbmRsZXI7CkluZGV4OiBTb3VyY2UvV2ViS2l0 L1VJUHJvY2Vzcy9Db2NvYS9XS1NhZmVCcm93c2luZ1dhcm5pbmcubW0KPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL1dlYktpdC9VSVByb2Nlc3MvQ29jb2EvV0tTYWZlQnJvd3NpbmdXYXJuaW5nLm1tCShy ZXZpc2lvbiAyMzkzMzgpCisrKyBTb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9Db2NvYS9XS1NhZmVC cm93c2luZ1dhcm5pbmcubW0JKHdvcmtpbmcgY29weSkKQEAgLTUwLDcgKzUwLDYgQEAgdXNpbmcg Rm9udFR5cGUgPSBOU0ZvbnQ7CiB1c2luZyBUZXh0Vmlld1R5cGUgPSBOU1RleHRWaWV3OwogdXNp bmcgQnV0dG9uVHlwZSA9IE5TQnV0dG9uOwogdXNpbmcgQWxpZ25tZW50VHlwZSA9IE5TTGF5b3V0 QXR0cmlidXRlOwotdXNpbmcgVmlld1R5cGUgPSBOU1ZpZXc7CiB1c2luZyBTaXplVHlwZSA9IE5T U2l6ZTsKICNlbHNlCiB1c2luZyBDb2xvclR5cGUgPSBVSUNvbG9yOwpAQCAtNTgsNyArNTcsNiBA QCB1c2luZyBGb250VHlwZSA9IFVJRm9udDsKIHVzaW5nIFRleHRWaWV3VHlwZSA9IFVJVGV4dFZp ZXc7CiB1c2luZyBCdXR0b25UeXBlID0gVUlCdXR0b247CiB1c2luZyBBbGlnbm1lbnRUeXBlID0g VUlTdGFja1ZpZXdBbGlnbm1lbnQ7Ci11c2luZyBWaWV3VHlwZSA9IFVJVmlldzsKIHVzaW5nIFNp emVUeXBlID0gQ0dTaXplOwogI2VuZGlmCiAKQEAgLTI5OSw2ICsyOTcsNyBAQCAtICh2b2lkKWFk ZENvbnRlbnQKICAgICBhdXRvIHNob3dEZXRhaWxzID0gbWFrZUJ1dHRvbihXYXJuaW5nSXRlbTo6 U2hvd0RldGFpbHNCdXR0b24sIHNlbGYsIEBzZWxlY3RvcihzaG93RGV0YWlsc0NsaWNrZWQpKTsK ICAgICBhdXRvIGdvQmFjayA9IG1ha2VCdXR0b24oV2FybmluZ0l0ZW06OkdvQmFja0J1dHRvbiwg c2VsZiwgQHNlbGVjdG9yKGdvQmFja0NsaWNrZWQpKTsKICAgICBhdXRvIGJveCA9IFtbVmlld1R5 cGUgbmV3XSBhdXRvcmVsZWFzZV07CisgICAgX2JveCA9IGJveDsKICAgICBzZXRCYWNrZ3JvdW5k KGJveCwgY29sb3JGb3JJdGVtKFdhcm5pbmdJdGVtOjpCb3hCYWNrZ3JvdW5kLCBzZWxmKSk7CiAg ICAgYm94LmxheWVyLmNvcm5lclJhZGl1cyA9IGJveENvcm5lclJhZGl1czsKIApAQCAtMzY3LDcg KzM2Niw3IEBAIC0gKHZvaWQpYWRkQ29udGVudAogCiAtICh2b2lkKXNob3dEZXRhaWxzQ2xpY2tl ZAogewotICAgIFZpZXdUeXBlICpib3ggPSBzZWxmLnN1YnZpZXdzLmxhc3RPYmplY3Q7CisgICAg Vmlld1R5cGUgKmJveCA9IF9ib3guZ2V0KCkuZ2V0KCk7CiAgICAgQnV0dG9uVHlwZSAqc2hvd0Rl dGFpbHMgPSBib3guc3Vidmlld3MubGFzdE9iamVjdDsKICAgICBbc2hvd0RldGFpbHMgcmVtb3Zl RnJvbVN1cGVydmlld107CiAK