<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>192835</bug_id>
          
          <creation_ts>2018-12-18 15:32:06 -0800</creation_ts>
          <short_desc>[WebAuthN] userPresence should always be true</short_desc>
          <delta_ts>2018-12-21 15:32:53 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebCore Misc.</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>181943</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Jiewen Tan">jiewen_tan</reporter>
          <assigned_to name="Jiewen Tan">jiewen_tan</assigned_to>
          <cc>alex.gaynor</cc>
    
    <cc>bfulgham</cc>
    
    <cc>cdumez</cc>
    
    <cc>commit-queue</cc>
    
    <cc>jiewen_tan</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1489105</commentid>
    <comment_count>0</comment_count>
    <who name="Jiewen Tan">jiewen_tan</who>
    <bug_when>2018-12-18 15:32:06 -0800</bug_when>
    <thetext>In the current spec, userPresence is suggested to set to the inverse of userVerification, which doesn&apos;t comply with the CTAP spec. Details in: https://github.com/w3c/webauthn/issues/1123.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1489111</commentid>
    <comment_count>1</comment_count>
    <who name="Jiewen Tan">jiewen_tan</who>
    <bug_when>2018-12-18 15:51:23 -0800</bug_when>
    <thetext>&lt;rdar://problem/46538788&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1490222</commentid>
    <comment_count>2</comment_count>
      <attachid>357908</attachid>
    <who name="Jiewen Tan">jiewen_tan</who>
    <bug_when>2018-12-20 17:34:46 -0800</bug_when>
    <thetext>Created attachment 357908
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1490223</commentid>
    <comment_count>3</comment_count>
      <attachid>357909</attachid>
    <who name="Jiewen Tan">jiewen_tan</who>
    <bug_when>2018-12-20 17:39:06 -0800</bug_when>
    <thetext>Created attachment 357909
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1490224</commentid>
    <comment_count>4</comment_count>
    <who name="Jiewen Tan">jiewen_tan</who>
    <bug_when>2018-12-20 17:40:51 -0800</bug_when>
    <thetext>My suggestion is seconded by Yubico and Microsoft directly on GitHub, and Google via email.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1490484</commentid>
    <comment_count>5</comment_count>
      <attachid>357909</attachid>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2018-12-21 14:24:32 -0800</bug_when>
    <thetext>Comment on attachment 357909
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=357909&amp;action=review

r=me

&gt; Source/WebCore/ChangeLog:11
&gt; +        The change is made to follow my suggestion in the issue as no one has objected it.

&quot;After discussing with other members of the working group, we decided to make userPresence always default to true.&quot;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1490498</commentid>
    <comment_count>6</comment_count>
      <attachid>357909</attachid>
    <who name="Jiewen Tan">jiewen_tan</who>
    <bug_when>2018-12-21 14:44:25 -0800</bug_when>
    <thetext>Comment on attachment 357909
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=357909&amp;action=review

Thanks Brent for r+ this patch.

&gt;&gt; Source/WebCore/ChangeLog:11
&gt;&gt; +        The change is made to follow my suggestion in the issue as no one has objected it.
&gt; 
&gt; &quot;After discussing with other members of the working group, we decided to make userPresence always default to true.&quot;

Fixed.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1490503</commentid>
    <comment_count>7</comment_count>
      <attachid>357983</attachid>
    <who name="Jiewen Tan">jiewen_tan</who>
    <bug_when>2018-12-21 14:48:46 -0800</bug_when>
    <thetext>Created attachment 357983
Patch for landing</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1490522</commentid>
    <comment_count>8</comment_count>
      <attachid>357983</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2018-12-21 15:27:36 -0800</bug_when>
    <thetext>Comment on attachment 357983
Patch for landing

Clearing flags on attachment: 357983

Committed r239523: &lt;https://trac.webkit.org/changeset/239523&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>357908</attachid>
            <date>2018-12-20 17:34:46 -0800</date>
            <delta_ts>2018-12-20 17:39:05 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-192835-20181220173445.patch</filename>
            <type>text/plain</type>
            <size>2869</size>
            <attacher name="Jiewen Tan">jiewen_tan</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjM5NDY1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNmMxMGJhYzYyMGVkNjI0
YzZmMmYxYzA3NTUxYWZkNWY3MmY0MmI2Yi4uMzE0MGYxOTEyOTZkZjQ4OTc4MWVhYjE3NjFkNWJm
MGM1ZjdmNzI1NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE4LTEyLTIwICBKaWV3
ZW4gVGFuICA8amlld2VuX3RhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW1dlYkF1dGhOXSB1c2Vy
UHJlc2VuY2Ugc2hvdWxkIGFsd2F5cyBiZSB0cnVlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr
aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTI4MzUKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzQ2
NTM4Nzg4PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg
IENvdmVyZWQgYnkgZXhpc2l0aW5nIHRlc3RzLgorCisgICAgICAgICogTW9kdWxlcy93ZWJhdXRo
bi9maWRvL0RldmljZVJlcXVlc3RDb252ZXJ0ZXIuY3BwOgorICAgICAgICAoZmlkbzo6ZW5jb2Rl
R2V0QXNzZXJ0aW9uUmVxdWVzdEFzQ0JPUik6CisKIDIwMTgtMTItMjAgIENocmlzIER1bWV6ICA8
Y2R1bWV6QGFwcGxlLmNvbT4KIAogICAgICAgICBVc2UgT3B0aW9uYWw6OnZhbHVlT3IoKSBpbnN0
ZWFkIG9mIE9wdGlvbmFsOjp2YWx1ZV9vcigpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9N
b2R1bGVzL3dlYmF1dGhuL2ZpZG8vRGV2aWNlUmVxdWVzdENvbnZlcnRlci5jcHAgYi9Tb3VyY2Uv
V2ViQ29yZS9Nb2R1bGVzL3dlYmF1dGhuL2ZpZG8vRGV2aWNlUmVxdWVzdENvbnZlcnRlci5jcHAK
aW5kZXggMmQyZDkyMjMzNjdkNTViNmJlYjMwZmJmM2NiMmMwMzIxYWNlMWU1Ni4uZWJkYjE5MjUz
YjJlZmJhNmFhNDU2MDUxNjM2MWFjNzJkMTVhYTg1MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv
cmUvTW9kdWxlcy93ZWJhdXRobi9maWRvL0RldmljZVJlcXVlc3RDb252ZXJ0ZXIuY3BwCisrKyBi
L1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvd2ViYXV0aG4vZmlkby9EZXZpY2VSZXF1ZXN0Q29udmVy
dGVyLmNwcApAQCAtMTU5LDcgKzE1OSw3IEBAIFZlY3Rvcjx1aW50OF90PiBlbmNvZGVHZXRBc3Nl
cnRpb25SZXF1ZXN0QXNDQk9SKGNvbnN0IFZlY3Rvcjx1aW50OF90PiYgaGFzaCwgY29uCiAgICAg
ICAgIHJlcXVpcmVVc2VyVmVyaWZpY2F0aW9uID0gZmFsc2U7CiAgICAgfQogICAgIG9wdGlvbk1h
cFtDQk9SVmFsdWUoa1VzZXJWZXJpZmljYXRpb25NYXBLZXkpXSA9IENCT1JWYWx1ZShyZXF1aXJl
VXNlclZlcmlmaWNhdGlvbik7Ci0gICAgb3B0aW9uTWFwW0NCT1JWYWx1ZShrVXNlclByZXNlbmNl
TWFwS2V5KV0gPSBDQk9SVmFsdWUoIXJlcXVpcmVVc2VyVmVyaWZpY2F0aW9uKTsKKyAgICBvcHRp
b25NYXBbQ0JPUlZhbHVlKGtVc2VyUHJlc2VuY2VNYXBLZXkpXSA9IENCT1JWYWx1ZSh0cnVlKTsK
IAogICAgIGlmICghb3B0aW9uTWFwLmVtcHR5KCkpCiAgICAgICAgIGNib3JNYXBbQ0JPUlZhbHVl
KDUpXSA9IENCT1JWYWx1ZShXVEZNb3ZlKG9wdGlvbk1hcCkpOwpkaWZmIC0tZ2l0IGEvVG9vbHMv
Q2hhbmdlTG9nIGIvVG9vbHMvQ2hhbmdlTG9nCmluZGV4IDM2OGRiNGMzNzQxNTU2NmJiMDg1YmRm
ODE0YWM1MmEyZGUzOGFmZjIuLmVmYmEyMjNhNWI3OTllMTUyZGUyNmVmNWEwZGY0MGRiYzYwM2Ni
Y2EgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZworKysgYi9Ub29scy9DaGFuZ2VMb2cKQEAg
LTEsMyArMSwxNCBAQAorMjAxOC0xMi0yMCAgSmlld2VuIFRhbiAgPGppZXdlbl90YW5AYXBwbGUu
Y29tPgorCisgICAgICAgIFtXZWJBdXRoTl0gdXNlclByZXNlbmNlIHNob3VsZCBhbHdheXMgYmUg
dHJ1ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTky
ODM1CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS80NjUzODc4OD4KKworICAgICAgICBSZXZpZXdl
ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFRlc3RXZWJLaXRBUEkvVGVzdHMvV2Vi
Q29yZS9DdGFwUmVxdWVzdFRlc3QuY3BwOgorICAgICAgICAoVGVzdFdlYktpdEFQSTo6VEVTVCk6
CisKIDIwMTgtMTItMjAgIEpvbmF0aGFuIEJlZGFyZCAgPGpiZWRhcmRAYXBwbGUuY29tPgogCiAg
ICAgICAgIHdlYmtpdHB5OiBBdXRvaW5zdGFsbCBwYWNrYWdlIFVSTHMgaGF2ZSBjaGFuZ2VkCmRp
ZmYgLS1naXQgYS9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYkNvcmUvRmlkb1Rlc3REYXRh
LmggYi9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYkNvcmUvRmlkb1Rlc3REYXRhLmgKaW5k
ZXggZWZlYTY1YmYyYTAyZDczYzY4ZDIyMGM2MmMwYTA2OTBmNmYxMzg3Yy4uNjBkMzdmNWE3YTlj
MDQ2OGYxOTA5NGIxNzlhNjc5NDBmN2M0OGQxZCAxMDA2NDQKLS0tIGEvVG9vbHMvVGVzdFdlYktp
dEFQSS9UZXN0cy9XZWJDb3JlL0ZpZG9UZXN0RGF0YS5oCisrKyBiL1Rvb2xzL1Rlc3RXZWJLaXRB
UEkvVGVzdHMvV2ViQ29yZS9GaWRvVGVzdERhdGEuaApAQCAtMzQ0LDggKzM0NCw4IEBAIGNvbnN0
ZXhwciB1aW50OF90IGtUZXN0Q29tcGxleEN0YXBHZXRBc3NlcnRpb25SZXF1ZXN0W10gPSB7CiAg
ICAgMHhhMiwKICAgICAvLyBrZXkgLSJ1cCIKICAgICAweDYyLCAweDc1LCAweDcwLAotICAgIC8v
IHZhbHVlIC0gRmFsc2UoMjApCi0gICAgMHhmNCwKKyAgICAvLyB2YWx1ZSAtIFRydWUoMjEpCisg
ICAgMHhmNSwKICAgICAvLyBrZXkgLSAidXYiCiAgICAgMHg2MiwgMHg3NSwgMHg3NiwKICAgICAv
LyB2YWx1ZSAtIFRydWUoMjEpCg==
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>357909</attachid>
            <date>2018-12-20 17:39:06 -0800</date>
            <delta_ts>2018-12-21 14:24:32 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-192835-20181220173905.patch</filename>
            <type>text/plain</type>
            <size>3188</size>
            <attacher name="Jiewen Tan">jiewen_tan</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjM5NDY1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNmMxMGJhYzYyMGVkNjI0
YzZmMmYxYzA3NTUxYWZkNWY3MmY0MmI2Yi4uYTYwYTU1ODkxMmRhNDIzM2YwMjNmOWQ5NDI3ZGYy
ZmYzNmM2ZjIzZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE4LTEyLTIwICBKaWV3
ZW4gVGFuICA8amlld2VuX3RhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW1dlYkF1dGhOXSB1c2Vy
UHJlc2VuY2Ugc2hvdWxkIGFsd2F5cyBiZSB0cnVlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr
aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTI4MzUKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzQ2
NTM4Nzg4PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg
IEluIHRoZSBjdXJyZW50IHNwZWMgYXMgb2YgNyBBdWd1c3QgMjAxOCwgdXNlclByZXNlbmNlIGlz
IHN1Z2dlc3RlZCB0byBzZXQgdG8gdGhlIGludmVyc2Ugb2YgdXNlclZlcmlmaWNhdGlvbi4KKyAg
ICAgICAgVGhpcyBkb2Vzbid0IGNvbXBseSB3aXRoIHRoZSBDVEFQIHNwZWMuIERldGFpbHMgaW46
IGh0dHBzOi8vZ2l0aHViLmNvbS93M2Mvd2ViYXV0aG4vaXNzdWVzLzExMjMuCisgICAgICAgIFRo
ZSBjaGFuZ2UgaXMgbWFkZSB0byBmb2xsb3cgbXkgc3VnZ2VzdGlvbiBpbiB0aGUgaXNzdWUgYXMg
bm8gb25lIGhhcyBvYmplY3RlZCBpdC4KKworICAgICAgICBDb3ZlcmVkIGJ5IGV4aXNpdGluZyB0
ZXN0cy4KKworICAgICAgICAqIE1vZHVsZXMvd2ViYXV0aG4vZmlkby9EZXZpY2VSZXF1ZXN0Q29u
dmVydGVyLmNwcDoKKyAgICAgICAgKGZpZG86OmVuY29kZUdldEFzc2VydGlvblJlcXVlc3RBc0NC
T1IpOgorCiAyMDE4LTEyLTIwICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKICAg
ICAgICAgVXNlIE9wdGlvbmFsOjp2YWx1ZU9yKCkgaW5zdGVhZCBvZiBPcHRpb25hbDo6dmFsdWVf
b3IoKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJhdXRobi9maWRvL0Rl
dmljZVJlcXVlc3RDb252ZXJ0ZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJhdXRo
bi9maWRvL0RldmljZVJlcXVlc3RDb252ZXJ0ZXIuY3BwCmluZGV4IDJkMmQ5MjIzMzY3ZDU1YjZi
ZWIzMGZiZjNjYjJjMDMyMWFjZTFlNTYuLmViZGIxOTI1M2IyZWZiYTZhYTQ1NjA1MTYzNjFhYzcy
ZDE1YWE4NTEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvd2ViYXV0aG4vZmlk
by9EZXZpY2VSZXF1ZXN0Q29udmVydGVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVz
L3dlYmF1dGhuL2ZpZG8vRGV2aWNlUmVxdWVzdENvbnZlcnRlci5jcHAKQEAgLTE1OSw3ICsxNTks
NyBAQCBWZWN0b3I8dWludDhfdD4gZW5jb2RlR2V0QXNzZXJ0aW9uUmVxdWVzdEFzQ0JPUihjb25z
dCBWZWN0b3I8dWludDhfdD4mIGhhc2gsIGNvbgogICAgICAgICByZXF1aXJlVXNlclZlcmlmaWNh
dGlvbiA9IGZhbHNlOwogICAgIH0KICAgICBvcHRpb25NYXBbQ0JPUlZhbHVlKGtVc2VyVmVyaWZp
Y2F0aW9uTWFwS2V5KV0gPSBDQk9SVmFsdWUocmVxdWlyZVVzZXJWZXJpZmljYXRpb24pOwotICAg
IG9wdGlvbk1hcFtDQk9SVmFsdWUoa1VzZXJQcmVzZW5jZU1hcEtleSldID0gQ0JPUlZhbHVlKCFy
ZXF1aXJlVXNlclZlcmlmaWNhdGlvbik7CisgICAgb3B0aW9uTWFwW0NCT1JWYWx1ZShrVXNlclBy
ZXNlbmNlTWFwS2V5KV0gPSBDQk9SVmFsdWUodHJ1ZSk7CiAKICAgICBpZiAoIW9wdGlvbk1hcC5l
bXB0eSgpKQogICAgICAgICBjYm9yTWFwW0NCT1JWYWx1ZSg1KV0gPSBDQk9SVmFsdWUoV1RGTW92
ZShvcHRpb25NYXApKTsKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5n
ZUxvZwppbmRleCAzNjhkYjRjMzc0MTU1NjZiYjA4NWJkZjgxNGFjNTJhMmRlMzhhZmYyLi5lZmJh
MjIzYTViNzk5ZTE1MmRlMjZlZjVhMGRmNDBkYmM2MDNjYmNhIDEwMDY0NAotLS0gYS9Ub29scy9D
aGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTgtMTIt
MjAgIEppZXdlbiBUYW4gIDxqaWV3ZW5fdGFuQGFwcGxlLmNvbT4KKworICAgICAgICBbV2ViQXV0
aE5dIHVzZXJQcmVzZW5jZSBzaG91bGQgYWx3YXlzIGJlIHRydWUKKyAgICAgICAgaHR0cHM6Ly9i
dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5MjgzNQorICAgICAgICA8cmRhcjovL3By
b2JsZW0vNDY1Mzg3ODg+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK
KyAgICAgICAgKiBUZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYkNvcmUvQ3RhcFJlcXVlc3RUZXN0LmNw
cDoKKyAgICAgICAgKFRlc3RXZWJLaXRBUEk6OlRFU1QpOgorCiAyMDE4LTEyLTIwICBKb25hdGhh
biBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNvbT4KIAogICAgICAgICB3ZWJraXRweTogQXV0b2lu
c3RhbGwgcGFja2FnZSBVUkxzIGhhdmUgY2hhbmdlZApkaWZmIC0tZ2l0IGEvVG9vbHMvVGVzdFdl
YktpdEFQSS9UZXN0cy9XZWJDb3JlL0ZpZG9UZXN0RGF0YS5oIGIvVG9vbHMvVGVzdFdlYktpdEFQ
SS9UZXN0cy9XZWJDb3JlL0ZpZG9UZXN0RGF0YS5oCmluZGV4IGVmZWE2NWJmMmEwMmQ3M2M2OGQy
MjBjNjJjMGEwNjkwZjZmMTM4N2MuLjYwZDM3ZjVhN2E5YzA0NjhmMTkwOTRiMTc5YTY3OTQwZjdj
NDhkMWQgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViQ29yZS9GaWRv
VGVzdERhdGEuaAorKysgYi9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYkNvcmUvRmlkb1Rl
c3REYXRhLmgKQEAgLTM0NCw4ICszNDQsOCBAQCBjb25zdGV4cHIgdWludDhfdCBrVGVzdENvbXBs
ZXhDdGFwR2V0QXNzZXJ0aW9uUmVxdWVzdFtdID0gewogICAgIDB4YTIsCiAgICAgLy8ga2V5IC0i
dXAiCiAgICAgMHg2MiwgMHg3NSwgMHg3MCwKLSAgICAvLyB2YWx1ZSAtIEZhbHNlKDIwKQotICAg
IDB4ZjQsCisgICAgLy8gdmFsdWUgLSBUcnVlKDIxKQorICAgIDB4ZjUsCiAgICAgLy8ga2V5IC0g
InV2IgogICAgIDB4NjIsIDB4NzUsIDB4NzYsCiAgICAgLy8gdmFsdWUgLSBUcnVlKDIxKQo=
</data>
<flag name="review"
          id="374798"
          type_id="1"
          status="+"
          setter="bfulgham"
    />
          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>357983</attachid>
            <date>2018-12-21 14:48:46 -0800</date>
            <delta_ts>2018-12-21 15:27:36 -0800</delta_ts>
            <desc>Patch for landing</desc>
            <filename>bug-192835-20181221144845.patch</filename>
            <type>text/plain</type>
            <size>3217</size>
            <attacher name="Jiewen Tan">jiewen_tan</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjM5NDY1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNmMxMGJhYzYyMGVkNjI0
YzZmMmYxYzA3NTUxYWZkNWY3MmY0MmI2Yi4uM2RhZmNlMzcwYjI0ZWExODY5ODk5MTJkZTZiYmY3
M2RkMTFiMWQzMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE4LTEyLTIwICBKaWV3
ZW4gVGFuICA8amlld2VuX3RhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW1dlYkF1dGhOXSB1c2Vy
UHJlc2VuY2Ugc2hvdWxkIGFsd2F5cyBiZSB0cnVlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr
aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTI4MzUKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzQ2
NTM4Nzg4PgorCisgICAgICAgIFJldmlld2VkIGJ5IEJyZW50IEZ1bGdoYW0uCisKKyAgICAgICAg
SW4gdGhlIGN1cnJlbnQgc3BlYyBhcyBvZiA3IEF1Z3VzdCAyMDE4LCB1c2VyUHJlc2VuY2UgaXMg
c3VnZ2VzdGVkIHRvIHNldCB0byB0aGUgaW52ZXJzZSBvZiB1c2VyVmVyaWZpY2F0aW9uLgorICAg
ICAgICBUaGlzIGRvZXNuJ3QgY29tcGx5IHdpdGggdGhlIENUQVAgc3BlYy4gRGV0YWlscyBpbjog
aHR0cHM6Ly9naXRodWIuY29tL3czYy93ZWJhdXRobi9pc3N1ZXMvMTEyMy4KKyAgICAgICAgQWZ0
ZXIgZGlzY3Vzc2luZyB3aXRoIG90aGVyIG1lbWJlcnMgb2YgdGhlIHdvcmtpbmcgZ3JvdXAsIHdl
IGRlY2lkZWQgdG8gbWFrZSB1c2VyUHJlc2VuY2UgYWx3YXlzIGRlZmF1bHQgdG8gdHJ1ZS4KKwor
ICAgICAgICBDb3ZlcmVkIGJ5IGV4aXNpdGluZyB0ZXN0cy4KKworICAgICAgICAqIE1vZHVsZXMv
d2ViYXV0aG4vZmlkby9EZXZpY2VSZXF1ZXN0Q29udmVydGVyLmNwcDoKKyAgICAgICAgKGZpZG86
OmVuY29kZUdldEFzc2VydGlvblJlcXVlc3RBc0NCT1IpOgorCiAyMDE4LTEyLTIwICBDaHJpcyBE
dW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKICAgICAgICAgVXNlIE9wdGlvbmFsOjp2YWx1ZU9y
KCkgaW5zdGVhZCBvZiBPcHRpb25hbDo6dmFsdWVfb3IoKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dl
YkNvcmUvTW9kdWxlcy93ZWJhdXRobi9maWRvL0RldmljZVJlcXVlc3RDb252ZXJ0ZXIuY3BwIGIv
U291cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJhdXRobi9maWRvL0RldmljZVJlcXVlc3RDb252ZXJ0
ZXIuY3BwCmluZGV4IDJkMmQ5MjIzMzY3ZDU1YjZiZWIzMGZiZjNjYjJjMDMyMWFjZTFlNTYuLmVi
ZGIxOTI1M2IyZWZiYTZhYTQ1NjA1MTYzNjFhYzcyZDE1YWE4NTEgMTAwNjQ0Ci0tLSBhL1NvdXJj
ZS9XZWJDb3JlL01vZHVsZXMvd2ViYXV0aG4vZmlkby9EZXZpY2VSZXF1ZXN0Q29udmVydGVyLmNw
cAorKysgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dlYmF1dGhuL2ZpZG8vRGV2aWNlUmVxdWVz
dENvbnZlcnRlci5jcHAKQEAgLTE1OSw3ICsxNTksNyBAQCBWZWN0b3I8dWludDhfdD4gZW5jb2Rl
R2V0QXNzZXJ0aW9uUmVxdWVzdEFzQ0JPUihjb25zdCBWZWN0b3I8dWludDhfdD4mIGhhc2gsIGNv
bgogICAgICAgICByZXF1aXJlVXNlclZlcmlmaWNhdGlvbiA9IGZhbHNlOwogICAgIH0KICAgICBv
cHRpb25NYXBbQ0JPUlZhbHVlKGtVc2VyVmVyaWZpY2F0aW9uTWFwS2V5KV0gPSBDQk9SVmFsdWUo
cmVxdWlyZVVzZXJWZXJpZmljYXRpb24pOwotICAgIG9wdGlvbk1hcFtDQk9SVmFsdWUoa1VzZXJQ
cmVzZW5jZU1hcEtleSldID0gQ0JPUlZhbHVlKCFyZXF1aXJlVXNlclZlcmlmaWNhdGlvbik7Cisg
ICAgb3B0aW9uTWFwW0NCT1JWYWx1ZShrVXNlclByZXNlbmNlTWFwS2V5KV0gPSBDQk9SVmFsdWUo
dHJ1ZSk7CiAKICAgICBpZiAoIW9wdGlvbk1hcC5lbXB0eSgpKQogICAgICAgICBjYm9yTWFwW0NC
T1JWYWx1ZSg1KV0gPSBDQk9SVmFsdWUoV1RGTW92ZShvcHRpb25NYXApKTsKZGlmZiAtLWdpdCBh
L1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCAzNjhkYjRjMzc0MTU1NjZi
YjA4NWJkZjgxNGFjNTJhMmRlMzhhZmYyLi5jNjlhMWM1YmQwZjg1NDI3OWRmZGZhNDJjZGE4NjUw
YzkwY2U4NTI1IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdl
TG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTgtMTItMjAgIEppZXdlbiBUYW4gIDxqaWV3ZW5fdGFu
QGFwcGxlLmNvbT4KKworICAgICAgICBbV2ViQXV0aE5dIHVzZXJQcmVzZW5jZSBzaG91bGQgYWx3
YXlzIGJlIHRydWUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp
P2lkPTE5MjgzNQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNDY1Mzg3ODg+CisKKyAgICAgICAg
UmV2aWV3ZWQgYnkgQnJlbnQgRnVsZ2hhbS4KKworICAgICAgICAqIFRlc3RXZWJLaXRBUEkvVGVz
dHMvV2ViQ29yZS9DdGFwUmVxdWVzdFRlc3QuY3BwOgorICAgICAgICAoVGVzdFdlYktpdEFQSTo6
VEVTVCk6CisKIDIwMTgtMTItMjAgIEpvbmF0aGFuIEJlZGFyZCAgPGpiZWRhcmRAYXBwbGUuY29t
PgogCiAgICAgICAgIHdlYmtpdHB5OiBBdXRvaW5zdGFsbCBwYWNrYWdlIFVSTHMgaGF2ZSBjaGFu
Z2VkCmRpZmYgLS1naXQgYS9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYkNvcmUvRmlkb1Rl
c3REYXRhLmggYi9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYkNvcmUvRmlkb1Rlc3REYXRh
LmgKaW5kZXggZWZlYTY1YmYyYTAyZDczYzY4ZDIyMGM2MmMwYTA2OTBmNmYxMzg3Yy4uNjBkMzdm
NWE3YTljMDQ2OGYxOTA5NGIxNzlhNjc5NDBmN2M0OGQxZCAxMDA2NDQKLS0tIGEvVG9vbHMvVGVz
dFdlYktpdEFQSS9UZXN0cy9XZWJDb3JlL0ZpZG9UZXN0RGF0YS5oCisrKyBiL1Rvb2xzL1Rlc3RX
ZWJLaXRBUEkvVGVzdHMvV2ViQ29yZS9GaWRvVGVzdERhdGEuaApAQCAtMzQ0LDggKzM0NCw4IEBA
IGNvbnN0ZXhwciB1aW50OF90IGtUZXN0Q29tcGxleEN0YXBHZXRBc3NlcnRpb25SZXF1ZXN0W10g
PSB7CiAgICAgMHhhMiwKICAgICAvLyBrZXkgLSJ1cCIKICAgICAweDYyLCAweDc1LCAweDcwLAot
ICAgIC8vIHZhbHVlIC0gRmFsc2UoMjApCi0gICAgMHhmNCwKKyAgICAvLyB2YWx1ZSAtIFRydWUo
MjEpCisgICAgMHhmNSwKICAgICAvLyBrZXkgLSAidXYiCiAgICAgMHg2MiwgMHg3NSwgMHg3NiwK
ICAgICAvLyB2YWx1ZSAtIFRydWUoMjEpCg==
</data>

          </attachment>
      

    </bug>

</bugzilla>