192822 2018-12-18 11:59:58 -0800 JSON.stringify() should throw OOM on StringBuilder overflows. 2018-12-18 16:03:17 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mark.lam mark.lam commit-queue ews-watchlist keith_miller msaboff saam webkit-bug-importer oldest_to_newest 1488998 0 mark.lam 2018-12-18 11:59:58 -0800 <rdar://problem/46670577> 1489002 1 357596 mark.lam 2018-12-18 12:06:40 -0800 Created attachment 357596 proposed patch. 1489053 2 357596 mark.lam 2018-12-18 13:57:38 -0800 Comment on attachment 357596 proposed patch. Thanks for the review. Landing now. 1489067 3 357596 commit-queue 2018-12-18 14:24:41 -0800 Comment on attachment 357596 proposed patch. Clearing flags on attachment: 357596 Committed r239355: <https://trac.webkit.org/changeset/239355> 1489068 4 commit-queue 2018-12-18 14:24:43 -0800 All reviewed patches have been landed. Closing bug. 1489119 5 mark.lam 2018-12-18 16:03:17 -0800 Landed a test fix in r239360: <http://trac.webkit.org/r239360>. 357596 2018-12-18 12:06:40 -0800 2018-12-18 14:24:41 -0800 proposed patch. bug-192822.patch text/plain 5130 mark.lam SW5kZXg6IEpTVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvQ2hhbmdlTG9n CShyZXZpc2lvbiAyMzkzNDYpCisrKyBKU1Rlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDEzIEBACisyMDE4LTEyLTE4ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNv bT4KKworICAgICAgICBKU09OLnN0cmluZ2lmeSgpIHNob3VsZCB0aHJvdyBPT00gb24gU3RyaW5n QnVpbGRlciBvdmVyZmxvd3MuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xOTI4MjIKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzQ2NjcwNTc3PgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogc3RyZXNzL2pz b24tc3RyaW5naWZ5LXN0cmluZy1idWlsZGVyLW92ZXJmbG93LmpzOiBBZGRlZC4KKwogMjAxOC0x Mi0xOCAgTWFyayBMYW0gIDxtYXJrLmxhbUBhcHBsZS5jb20+CiAKICAgICAgICAgU2tpcCB0aGUg c3RyZXNzL2VsaWRhYmxlLW5ldy1vYmplY3Qtcm9mbGNvcHRlci10aGVuLWV4aXQuanMgdGVzdCBv biAzMi1iaXQuCkluZGV4OiBKU1Rlc3RzL3N0cmVzcy9qc29uLXN0cmluZ2lmeS1zdHJpbmctYnVp bGRlci1vdmVyZmxvdy5qcwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKU1Rlc3RzL3N0cmVzcy9qc29uLXN0cmlu Z2lmeS1zdHJpbmctYnVpbGRlci1vdmVyZmxvdy5qcwkobm9uZXhpc3RlbnQpCisrKyBKU1Rlc3Rz L3N0cmVzcy9qc29uLXN0cmluZ2lmeS1zdHJpbmctYnVpbGRlci1vdmVyZmxvdy5qcwkod29ya2lu ZyBjb3B5KQpAQCAtMCwwICsxLDI5IEBACisvL0Agc2xvdworLy9AIHNraXAgaWYgJGFyY2hpdGVj dHVyZSAhPSAiYXJtNjQiIGFuZCAkYXJjaGl0ZWN0dXJlICE9ICJ4ODYtNjQiCisKK3ZhciBleGNl cHRpb247Cit0cnkgeworICAgIHZhciBzdHIgPSBKU09OLnN0cmluZ2lmeSh7CisgICAgICAgICdh MSc6IHsKKyAgICAgICAgICAgICdhMic6IHsKKyAgICAgICAgICAgICAgICAnYTMnOiB7CisgICAg ICAgICAgICAgICAgICAgICdhNCc6IHsKKyAgICAgICAgICAgICAgICAgICAgICAgICdhNSc6IHsK KyAgICAgICAgICAgICAgICAgICAgICAgICAgICAnYTYnOiAnQUFBQUFBQUFBQScKKyAgICAgICAg ICAgICAgICAgICAgICAgIH0KKyAgICAgICAgICAgICAgICAgICAgfQorICAgICAgICAgICAgICAg IH0KKyAgICAgICAgICAgIH0KKyAgICAgICAgfQorICAgIH0sIGZ1bmN0aW9uIChrZXksIHZhbHVl KSB7CisgICAgICAgIHZhciB2YWwgPSB7CisgICAgICAgICAgICAnQSc6IHRydWUsCisgICAgICAg IH07CisgICAgICAgIHJldHVybiB2YWw7CisgICAgfSwgMSk7Cit9IGNhdGNoIChlKSB7CisgICAg ZXhjZXB0aW9uID0gZTsKK30KKworaWYgKGV4Y2VwdGlvbiAhPSAiRXJyb3I6IE91dCBvZiBtZW1v cnkiKQorICAgIHRocm93ICJGQUlMRUQiOwpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL0No YW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCShy ZXZpc2lvbiAyMzkzMjgpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTgtMTItMTggIE1hcmsgTGFtICA8bWFyay5s YW1AYXBwbGUuY29tPgorCisgICAgICAgIEpTT04uc3RyaW5naWZ5KCkgc2hvdWxkIHRocm93IE9P TSBvbiBTdHJpbmdCdWlsZGVyIG92ZXJmbG93cy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTE5MjgyMgorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNDY2 NzA1Nzc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg KiBydW50aW1lL0pTT05PYmplY3QuY3BwOgorICAgICAgICAoSlNDOjpTdHJpbmdpZmllcjo6c3Ry aW5naWZ5KToKKyAgICAgICAgKEpTQzo6U3RyaW5naWZpZXI6OmFwcGVuZFN0cmluZ2lmaWVkVmFs dWUpOgorICAgICAgICAoSlNDOjpTdHJpbmdpZmllcjo6SG9sZGVyOjphcHBlbmROZXh0UHJvcGVy dHkpOgorCiAyMDE4LTEyLTE3ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KIAogICAg ICAgICBBcnJheSB1bnNoaWZ0L3NoaWZ0IHNob3VsZCBub3QgcmFjZSBhZ2FpbnN0IHRoZSBBSSBp biB0aGUgY29tcGlsZXIgdGhyZWFkLgpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRp bWUvSlNPTk9iamVjdC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL3J1 bnRpbWUvSlNPTk9iamVjdC5jcHAJKHJldmlzaW9uIDIzOTMyOCkKKysrIFNvdXJjZS9KYXZhU2Ny aXB0Q29yZS9ydW50aW1lL0pTT05PYmplY3QuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yNjksMTcg KzI2OSwyMCBAQCBKU1ZhbHVlIFN0cmluZ2lmaWVyOjpzdHJpbmdpZnkoSlNWYWx1ZSB2CiAgICAg SlNPYmplY3QqIG9iamVjdCA9IG51bGxwdHI7CiAgICAgaWYgKGlzQ2FsbGFibGVSZXBsYWNlcigp KSB7CiAgICAgICAgIG9iamVjdCA9IGNvbnN0cnVjdEVtcHR5T2JqZWN0KG1fZXhlYyk7Ci0gICAg ICAgIFJFVFVSTl9JRl9FWENFUFRJT04oc2NvcGUsIGpzTnVsbCgpKTsKKyAgICAgICAgUkVUVVJO X0lGX0VYQ0VQVElPTihzY29wZSwganNVbmRlZmluZWQoKSk7CiAgICAgICAgIG9iamVjdC0+cHV0 RGlyZWN0KHZtLCB2bS5wcm9wZXJ0eU5hbWVzLT5lbXB0eUlkZW50aWZpZXIsIHZhbHVlKTsKICAg ICB9CiAKICAgICBTdHJpbmdCdWlsZGVyIHJlc3VsdChTdHJpbmdCdWlsZGVyOjpPdmVyZmxvd0hh bmRsZXI6OlJlY29yZE92ZXJmbG93KTsKICAgICBIb2xkZXIgcm9vdChIb2xkZXI6OlJvb3RIb2xk ZXIsIG9iamVjdCk7CiAgICAgYXV0byBzdHJpbmdpZnlSZXN1bHQgPSBhcHBlbmRTdHJpbmdpZmll ZFZhbHVlKHJlc3VsdCwgdmFsdWUsIHJvb3QsIGVtcHR5UHJvcGVydHlOYW1lKTsKLSAgICBFWENF UFRJT05fQVNTRVJUKCFzY29wZS5leGNlcHRpb24oKSB8fCAoc3RyaW5naWZ5UmVzdWx0ICE9IFN0 cmluZ2lmeVN1Y2NlZWRlZCkpOworICAgIFJFVFVSTl9JRl9FWENFUFRJT04oc2NvcGUsIGpzVW5k ZWZpbmVkKCkpOworICAgIGlmIChVTkxJS0VMWShyZXN1bHQuaGFzT3ZlcmZsb3dlZCgpKSkgewor ICAgICAgICB0aHJvd091dE9mTWVtb3J5RXJyb3IobV9leGVjLCBzY29wZSk7CisgICAgICAgIHJl dHVybiBqc1VuZGVmaW5lZCgpOworICAgIH0KICAgICBpZiAoVU5MSUtFTFkoc3RyaW5naWZ5UmVz dWx0ICE9IFN0cmluZ2lmeVN1Y2NlZWRlZCkpCiAgICAgICAgIHJldHVybiBqc1VuZGVmaW5lZCgp OwotCiAgICAgUkVMRUFTRV9BTkRfUkVUVVJOKHNjb3BlLCBqc1N0cmluZyhtX2V4ZWMsIHJlc3Vs dC50b1N0cmluZygpKSk7CiB9CiAKQEAgLTM1OSwxMCArMzYyLDYgQEAgU3RyaW5naWZpZXI6OlN0 cmluZ2lmeVJlc3VsdCBTdHJpbmdpZmllcgogICAgICAgICBjb25zdCBTdHJpbmcmIHN0cmluZyA9 IGFzU3RyaW5nKHZhbHVlKS0+dmFsdWUobV9leGVjKTsKICAgICAgICAgUkVUVVJOX0lGX0VYQ0VQ VElPTihzY29wZSwgU3RyaW5naWZ5RmFpbGVkKTsKICAgICAgICAgYnVpbGRlci5hcHBlbmRRdW90 ZWRKU09OU3RyaW5nKHN0cmluZyk7Ci0gICAgICAgIGlmIChVTkxJS0VMWShidWlsZGVyLmhhc092 ZXJmbG93ZWQoKSkpIHsKLSAgICAgICAgICAgIHRocm93T3V0T2ZNZW1vcnlFcnJvcihtX2V4ZWMs IHNjb3BlKTsKLSAgICAgICAgICAgIHJldHVybiBTdHJpbmdpZnlGYWlsZWQ7Ci0gICAgICAgIH0K ICAgICAgICAgcmV0dXJuIFN0cmluZ2lmeVN1Y2NlZWRlZDsKICAgICB9CiAKQEAgLTM5MSw2ICsz OTAsOSBAQCBTdHJpbmdpZmllcjo6U3RyaW5naWZ5UmVzdWx0IFN0cmluZ2lmaWVyCiAgICAgICAg IHJldHVybiBTdHJpbmdpZnlGYWlsZWREdWVUb1VuZGVmaW5lZE9yU3ltYm9sVmFsdWU7CiAgICAg fQogCisgICAgaWYgKFVOTElLRUxZKGJ1aWxkZXIuaGFzT3ZlcmZsb3dlZCgpKSkKKyAgICAgICAg cmV0dXJuIFN0cmluZ2lmeUZhaWxlZDsKKwogICAgIC8vIEhhbmRsZSBjeWNsZSBkZXRlY3Rpb24s IGFuZCBwdXQgdGhlIGhvbGRlciBvbiB0aGUgc3RhY2suCiAgICAgZm9yICh1bnNpZ25lZCBpID0g MDsgaSA8IG1faG9sZGVyU3RhY2suc2l6ZSgpOyBpKyspIHsKICAgICAgICAgaWYgKG1faG9sZGVy U3RhY2tbaV0ub2JqZWN0KCkgPT0gb2JqZWN0KSB7CkBAIC00MTAsNiArNDEyLDggQEAgU3RyaW5n aWZpZXI6OlN0cmluZ2lmeVJlc3VsdCBTdHJpbmdpZmllcgogICAgICAgICB3aGlsZSAobV9ob2xk ZXJTdGFjay5sYXN0KCkuYXBwZW5kTmV4dFByb3BlcnR5KCp0aGlzLCBidWlsZGVyKSkKICAgICAg ICAgICAgIFJFVFVSTl9JRl9FWENFUFRJT04oc2NvcGUsIFN0cmluZ2lmeUZhaWxlZCk7CiAgICAg ICAgIFJFVFVSTl9JRl9FWENFUFRJT04oc2NvcGUsIFN0cmluZ2lmeUZhaWxlZCk7CisgICAgICAg IGlmIChVTkxJS0VMWShidWlsZGVyLmhhc092ZXJmbG93ZWQoKSkpCisgICAgICAgICAgICByZXR1 cm4gU3RyaW5naWZ5RmFpbGVkOwogICAgICAgICBtX2hvbGRlclN0YWNrLnJlbW92ZUxhc3QoKTsK ICAgICAgICAgbV9vYmplY3RTdGFjay5yZW1vdmVMYXN0KCk7CiAgICAgfSB3aGlsZSAoIW1faG9s ZGVyU3RhY2suaXNFbXB0eSgpKTsKQEAgLTQ5Myw2ICs0OTcsOCBAQCBib29sIFN0cmluZ2lmaWVy OjpIb2xkZXI6OmFwcGVuZE5leHRQcm9wCiAgICAgICAgIH0KICAgICAgICAgc3RyaW5naWZpZXIu aW5kZW50KCk7CiAgICAgfQorICAgIGlmIChVTkxJS0VMWShidWlsZGVyLmhhc092ZXJmbG93ZWQo KSkpCisgICAgICAgIHJldHVybiBmYWxzZTsKIAogICAgIC8vIExhc3QgdGltZSB0aHJvdWdoLCBm aW5pc2ggdXAgYW5kIHJldHVybiBmYWxzZS4KICAgICBpZiAobV9pbmRleCA9PSBtX3NpemUpIHsK