192816 2018-12-18 11:18:30 -0800 Use idiomatic const references for equality methods in JSC::JSValue class 2018-12-20 15:14:37 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Local Build Unspecified Unspecified RESOLVED WONTFIX https://bugs.webkit.org/show_bug.cgi?id=192813 P2 Normal --- 1 ddkilzer ddkilzer ews-watchlist fpizlo keith_miller mark.lam msaboff saam ysuzuki oldest_to_newest 1488965 0 ddkilzer 2018-12-18 11:18:30 -0800 Use idiomatic const references for equality helper methods for JSC::JSValue class. 1488971 1 357588 ddkilzer 2018-12-18 11:26:51 -0800 Created attachment 357588 Patch v1 1489020 2 357588 ews-watchlist 2018-12-18 13:08:08 -0800 Comment on attachment 357588 Patch v1 Attachment 357588 did not pass jsc-ews (mac): Output: https://webkit-queues.webkit.org/results/10461961 New failing tests: stress/ftl-put-by-id-setter-exception-interesting-live-state.js.ftl-eager-no-cjit stress/const-semantics.js.ftl-eager-no-cjit apiTests 1489062 3 ddkilzer 2018-12-18 14:10:56 -0800 (In reply to Build Bot from comment #2) > Comment on attachment 357588 [details] > Patch v1 > > Attachment 357588 [details] did not pass jsc-ews (mac): > Output: https://webkit-queues.webkit.org/results/10461961 > > New failing tests: > stress/ftl-put-by-id-setter-exception-interesting-live-state.js.ftl-eager-no- > cjit > stress/const-semantics.js.ftl-eager-no-cjit > apiTests That's surprising! Will run the tests locally next. 1489360 4 ddkilzer 2018-12-19 10:52:18 -0800 (In reply to David Kilzer (:ddkilzer) from comment #3) > (In reply to Build Bot from comment #2) > > Comment on attachment 357588 [details] > > Patch v1 > > > > Attachment 357588 [details] did not pass jsc-ews (mac): > > Output: https://webkit-queues.webkit.org/results/10461961 > > > > New failing tests: > > stress/ftl-put-by-id-setter-exception-interesting-live-state.js.ftl-eager-no- > > cjit > > stress/const-semantics.js.ftl-eager-no-cjit > > apiTests > > That's surprising! Will run the tests locally next. Running locally I don't see the stress/* test failures: $ ./Tools/Scripts/run-javascriptcore-tests --no-build --no-fail-fast --release --verbose For apiTests, I see: 2018-12-19 10:50:22.980 testapi[83267:1353141] Testing Objective-C API 2018-12-19 10:50:22.988 testapi[83267:1353141] TEST: "Negative number maintained its original value": PASSED 2018-12-19 10:50:22.988 testapi[83267:1353141] TEST: "runJITThreadLimitTests() must run at the very beginning to test the case where the global JIT worklist was not initialized yet": PASSED 2018-12-19 10:50:22.988 testapi[83267:1353141] TEST: "Initial number of DFG threads should be the value provided through Options": PASSED 2018-12-19 10:50:22.988 testapi[83267:1353141] TEST: "Number of DFG threads should have been updated": PASSED 2018-12-19 10:50:22.988 testapi[83267:1353141] TEST: "Initial number of DFG threads should be the value provided through Options": PASSED 2018-12-19 10:50:22.988 testapi[83267:1353141] TEST: "Number of DFG threads should have been updated": PASSED 2018-12-19 10:50:22.988 testapi[83267:1353141] TEST: "Initial number of FTL threads should be the value provided through Options": PASSED 2018-12-19 10:50:22.988 testapi[83267:1353141] TEST: "Number of FTL threads should have been updated": FAILED 2018-12-19 10:50:22.988 testapi[83267:1353141] TEST: "Initial number of FTL threads should be the value provided through Options": PASSED 2018-12-19 10:50:22.988 testapi[83267:1353141] TEST: "Number of FTL threads should have been updated": FAILED [...] FAIL: Some tests failed. testapi completed with rc=256 (1) Next I need to rerun the tests locally without the change. 1489416 5 ddkilzer 2018-12-19 12:46:06 -0800 (In reply to David Kilzer (:ddkilzer) from comment #4) > (In reply to David Kilzer (:ddkilzer) from comment #3) > > (In reply to Build Bot from comment #2) > > > Comment on attachment 357588 [details] > > > Patch v1 > > > > > > Attachment 357588 [details] did not pass jsc-ews (mac): > > > Output: https://webkit-queues.webkit.org/results/10461961 > > > > > > New failing tests: > > > stress/ftl-put-by-id-setter-exception-interesting-live-state.js.ftl-eager-no- > > > cjit > > > stress/const-semantics.js.ftl-eager-no-cjit > > > apiTests > > > > That's surprising! Will run the tests locally next. > > Running locally I don't see the stress/* test failures: > > $ ./Tools/Scripts/run-javascriptcore-tests --no-build --no-fail-fast > --release --verbose > > For apiTests, I see: > > 2018-12-19 10:50:22.980 testapi[83267:1353141] Testing Objective-C API > 2018-12-19 10:50:22.988 testapi[83267:1353141] TEST: "Negative number > maintained its original value": PASSED > 2018-12-19 10:50:22.988 testapi[83267:1353141] TEST: > "runJITThreadLimitTests() must run at the very beginning to test the case > where the global JIT worklist was not initialized yet": PASSED > 2018-12-19 10:50:22.988 testapi[83267:1353141] TEST: "Initial number of DFG > threads should be the value provided through Options": PASSED > 2018-12-19 10:50:22.988 testapi[83267:1353141] TEST: "Number of DFG threads > should have been updated": PASSED > 2018-12-19 10:50:22.988 testapi[83267:1353141] TEST: "Initial number of DFG > threads should be the value provided through Options": PASSED > 2018-12-19 10:50:22.988 testapi[83267:1353141] TEST: "Number of DFG threads > should have been updated": PASSED > 2018-12-19 10:50:22.988 testapi[83267:1353141] TEST: "Initial number of FTL > threads should be the value provided through Options": PASSED > 2018-12-19 10:50:22.988 testapi[83267:1353141] TEST: "Number of FTL threads > should have been updated": FAILED > 2018-12-19 10:50:22.988 testapi[83267:1353141] TEST: "Initial number of FTL > threads should be the value provided through Options": PASSED > 2018-12-19 10:50:22.988 testapi[83267:1353141] TEST: "Number of FTL threads > should have been updated": FAILED > [...] > FAIL: Some tests failed. > testapi completed with rc=256 (1) > > Next I need to rerun the tests locally without the change. This was using a Release build of WebKit trunk r239276. 1489820 6 ddkilzer 2018-12-20 04:50:27 -0800 (In reply to David Kilzer (:ddkilzer) from comment #4) > (In reply to David Kilzer (:ddkilzer) from comment #3) > > (In reply to Build Bot from comment #2) > > > Comment on attachment 357588 [details] > > > Patch v1 > > > > > > Attachment 357588 [details] did not pass jsc-ews (mac): > > > Output: https://webkit-queues.webkit.org/results/10461961 > > > > > > New failing tests: > > > stress/ftl-put-by-id-setter-exception-interesting-live-state.js.ftl-eager-no- > > > cjit > > > stress/const-semantics.js.ftl-eager-no-cjit > > > apiTests > > > > That's surprising! Will run the tests locally next. > > Running locally I don't see the stress/* test failures: > > $ ./Tools/Scripts/run-javascriptcore-tests --no-build --no-fail-fast > --release --verbose > > For apiTests, I see: > > 2018-12-19 10:50:22.980 testapi[83267:1353141] Testing Objective-C API > 2018-12-19 10:50:22.988 testapi[83267:1353141] TEST: "Negative number > maintained its original value": PASSED > 2018-12-19 10:50:22.988 testapi[83267:1353141] TEST: > "runJITThreadLimitTests() must run at the very beginning to test the case > where the global JIT worklist was not initialized yet": PASSED > 2018-12-19 10:50:22.988 testapi[83267:1353141] TEST: "Initial number of DFG > threads should be the value provided through Options": PASSED > 2018-12-19 10:50:22.988 testapi[83267:1353141] TEST: "Number of DFG threads > should have been updated": PASSED > 2018-12-19 10:50:22.988 testapi[83267:1353141] TEST: "Initial number of DFG > threads should be the value provided through Options": PASSED > 2018-12-19 10:50:22.988 testapi[83267:1353141] TEST: "Number of DFG threads > should have been updated": PASSED > 2018-12-19 10:50:22.988 testapi[83267:1353141] TEST: "Initial number of FTL > threads should be the value provided through Options": PASSED > 2018-12-19 10:50:22.988 testapi[83267:1353141] TEST: "Number of FTL threads > should have been updated": FAILED > 2018-12-19 10:50:22.988 testapi[83267:1353141] TEST: "Initial number of FTL > threads should be the value provided through Options": PASSED > 2018-12-19 10:50:22.988 testapi[83267:1353141] TEST: "Number of FTL threads > should have been updated": FAILED > [...] > FAIL: Some tests failed. > testapi completed with rc=256 (1) > > Next I need to rerun the tests locally without the change. The "Number of FTL threads should have been updated" test fails without this patch, so seems unrelated. 1489821 7 357806 ddkilzer 2018-12-20 04:51:26 -0800 Created attachment 357806 Patch v1 (retry EWS) Uploading Patch v1 (Attachment 357588) again to force a second EWS run. 1489823 8 ddkilzer 2018-12-20 05:00:52 -0800 Probably don't need to do this based on Darin's comment about WTF::StringView in Bug 192813 Comment #2. 357588 2018-12-18 11:26:51 -0800 2018-12-18 13:52:10 -0800 Patch v1 bug-192816-20181218112651.patch text/plain 6021 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMjM5Mjc2CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA4 MTgxOWRlYzllYTc5MmIzNWRlZWYyMzAzZTdjMTk2NzFkODQ1NzI3Li5mNTRiMTExMmE3NjY0MTNi ZjcyMzE2YThjNTNkZTNlNjhiMGQ0MDZhIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyNiBAQAorMjAxOC0xMi0xOCAgRGF2aWQgS2lsemVyICA8ZGRraWx6ZXJAYXBwbGUuY29t PgorCisgICAgICAgIFVzZSBpZGlvbWF0aWMgY29uc3QgcmVmZXJlbmNlcyBmb3IgZXF1YWxpdHkg bWV0aG9kcyBpbiBKU0M6OkpTVmFsdWUgY2xhc3MKKyAgICAgICAgPGh0dHBzOi8vd2Via2l0Lm9y Zy9iLzE5MjgxNj4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBPbmx5IEpTQzo6SlNWYWx1ZTo6ZXF1YWxTbG93Q2FzZUlubGluZSgpIGlzIG5vdCBjaGFu Z2VkIHRvIHVzZQorICAgICAgICBjb25zdCByZWZlcmVuY2VzIGJlY2F1c2UgaXQgY2hhbmdlcyB0 aGUgdmFsdWUgb2YgaXRzIHBhcmFtZXRlcnMKKyAgICAgICAgYXMgcGFydCBvZiBpdHMgYWxnb3Jp dGhtLgorCisgICAgICAgICogcnVudGltZS9KU0NKU1ZhbHVlLmg6CisgICAgICAgIChKU0M6Om9w ZXJhdG9yPT0pOgorICAgICAgICAoSlNDOjpvcGVyYXRvciE9KToKKyAgICAgICAgKiBydW50aW1l L0pTQ0pTVmFsdWVJbmxpbmVzLmg6CisgICAgICAgIChKU0M6OkpTVmFsdWU6OmVxdWFsKToKKyAg ICAgICAgKEpTQzo6SlNWYWx1ZTo6c3RyaWN0RXF1YWxTbG93Q2FzZUlubGluZSk6CisgICAgICAg IChKU0M6OkpTVmFsdWU6OnN0cmljdEVxdWFsKToKKyAgICAgICAgKEpTQzo6SlNWYWx1ZTo6cHVy ZVN0cmljdEVxdWFsKToKKyAgICAgICAgKiBydW50aW1lL09wZXJhdGlvbnMuY3BwOgorICAgICAg ICAoSlNDOjpKU1ZhbHVlOjplcXVhbFNsb3dDYXNlKToKKyAgICAgICAgKEpTQzo6SlNWYWx1ZTo6 c3RyaWN0RXF1YWxTbG93Q2FzZSk6CisKIDIwMTgtMTItMTggIERhdmlkIEtpbHplciAgPGRka2ls emVyQGFwcGxlLmNvbT4KIAogICAgICAgICBjbGFuZy10aWR5OiBVc2UgY29uc3QgcmVmZXJlbmNl IGZvciBNZWRpYVRpbWUgcGFyYW1ldGVyIHRvIHByZXZlbnQgb2JqZWN0IGNvcHkKZGlmZiAtLWdp dCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTQ0pTVmFsdWUuaCBiL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTQ0pTVmFsdWUuaAppbmRleCA1ODI1MzBkNDRjMGY3ZDI0 ZTgyYTk3ZGJjOTUxM2E1M2UyZGUwMjc2Li5mMTk0MjllMjMwZTgzYWQxZDRhZWRmMWMzYWQ4ZDA4 OWE0NWYxMzgxIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU0NK U1ZhbHVlLmgKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNDSlNWYWx1ZS5o CkBAIC0zMDQsMTMgKzMwNCwxMyBAQCBwdWJsaWM6CiAKICAgICBKU1ZhbHVlIHRvVGhpcyhFeGVj U3RhdGUqLCBFQ01BTW9kZSkgY29uc3Q7CiAKLSAgICBzdGF0aWMgYm9vbCBlcXVhbChFeGVjU3Rh dGUqLCBKU1ZhbHVlIHYxLCBKU1ZhbHVlIHYyKTsKLSAgICBzdGF0aWMgYm9vbCBlcXVhbFNsb3dD YXNlKEV4ZWNTdGF0ZSosIEpTVmFsdWUgdjEsIEpTVmFsdWUgdjIpOworICAgIHN0YXRpYyBib29s IGVxdWFsKEV4ZWNTdGF0ZSosIGNvbnN0IEpTVmFsdWUmIHYxLCBjb25zdCBKU1ZhbHVlJiB2Mik7 CisgICAgc3RhdGljIGJvb2wgZXF1YWxTbG93Q2FzZShFeGVjU3RhdGUqLCBjb25zdCBKU1ZhbHVl JiB2MSwgY29uc3QgSlNWYWx1ZSYgdjIpOwogICAgIHN0YXRpYyBib29sIGVxdWFsU2xvd0Nhc2VJ bmxpbmUoRXhlY1N0YXRlKiwgSlNWYWx1ZSB2MSwgSlNWYWx1ZSB2Mik7Ci0gICAgc3RhdGljIGJv b2wgc3RyaWN0RXF1YWwoRXhlY1N0YXRlKiwgSlNWYWx1ZSB2MSwgSlNWYWx1ZSB2Mik7Ci0gICAg c3RhdGljIGJvb2wgc3RyaWN0RXF1YWxTbG93Q2FzZShFeGVjU3RhdGUqLCBKU1ZhbHVlIHYxLCBK U1ZhbHVlIHYyKTsKLSAgICBzdGF0aWMgYm9vbCBzdHJpY3RFcXVhbFNsb3dDYXNlSW5saW5lKEV4 ZWNTdGF0ZSosIEpTVmFsdWUgdjEsIEpTVmFsdWUgdjIpOwotICAgIHN0YXRpYyBUcmlTdGF0ZSBw dXJlU3RyaWN0RXF1YWwoSlNWYWx1ZSB2MSwgSlNWYWx1ZSB2Mik7CisgICAgc3RhdGljIGJvb2wg c3RyaWN0RXF1YWwoRXhlY1N0YXRlKiwgY29uc3QgSlNWYWx1ZSYgdjEsIGNvbnN0IEpTVmFsdWUm IHYyKTsKKyAgICBzdGF0aWMgYm9vbCBzdHJpY3RFcXVhbFNsb3dDYXNlKEV4ZWNTdGF0ZSosIGNv bnN0IEpTVmFsdWUmIHYxLCBjb25zdCBKU1ZhbHVlJiB2Mik7CisgICAgc3RhdGljIGJvb2wgc3Ry aWN0RXF1YWxTbG93Q2FzZUlubGluZShFeGVjU3RhdGUqLCBjb25zdCBKU1ZhbHVlJiB2MSwgY29u c3QgSlNWYWx1ZSYgdjIpOworICAgIHN0YXRpYyBUcmlTdGF0ZSBwdXJlU3RyaWN0RXF1YWwoY29u c3QgSlNWYWx1ZSYgdjEsIGNvbnN0IEpTVmFsdWUmIHYyKTsKIAogICAgIGJvb2wgaXNDZWxsKCkg Y29uc3Q7CiAgICAgSlNDZWxsKiBhc0NlbGwoKSBjb25zdDsKQEAgLTYxNiwxMSArNjE2LDExIEBA IEFMV0FZU19JTkxJTkUgRW5jb2RlZEpTVmFsdWUgZW5jb2RlZEpTVmFsdWUoKQogICAgIHJldHVy biBKU1ZhbHVlOjplbmNvZGUoSlNWYWx1ZSgpKTsKIH0KIAotaW5saW5lIGJvb2wgb3BlcmF0b3I9 PShjb25zdCBKU1ZhbHVlIGEsIGNvbnN0IEpTQ2VsbCogYikgeyByZXR1cm4gYSA9PSBKU1ZhbHVl KGIpOyB9Ci1pbmxpbmUgYm9vbCBvcGVyYXRvcj09KGNvbnN0IEpTQ2VsbCogYSwgY29uc3QgSlNW YWx1ZSBiKSB7IHJldHVybiBKU1ZhbHVlKGEpID09IGI7IH0KK2lubGluZSBib29sIG9wZXJhdG9y PT0oY29uc3QgSlNWYWx1ZSYgYSwgY29uc3QgSlNDZWxsKiBiKSB7IHJldHVybiBhID09IEpTVmFs dWUoYik7IH0KK2lubGluZSBib29sIG9wZXJhdG9yPT0oY29uc3QgSlNDZWxsKiBhLCBjb25zdCBK U1ZhbHVlJiBiKSB7IHJldHVybiBKU1ZhbHVlKGEpID09IGI7IH0KIAotaW5saW5lIGJvb2wgb3Bl cmF0b3IhPShjb25zdCBKU1ZhbHVlIGEsIGNvbnN0IEpTQ2VsbCogYikgeyByZXR1cm4gYSAhPSBK U1ZhbHVlKGIpOyB9Ci1pbmxpbmUgYm9vbCBvcGVyYXRvciE9KGNvbnN0IEpTQ2VsbCogYSwgY29u c3QgSlNWYWx1ZSBiKSB7IHJldHVybiBKU1ZhbHVlKGEpICE9IGI7IH0KK2lubGluZSBib29sIG9w ZXJhdG9yIT0oY29uc3QgSlNWYWx1ZSYgYSwgY29uc3QgSlNDZWxsKiBiKSB7IHJldHVybiBhICE9 IEpTVmFsdWUoYik7IH0KK2lubGluZSBib29sIG9wZXJhdG9yIT0oY29uc3QgSlNDZWxsKiBhLCBj b25zdCBKU1ZhbHVlJiBiKSB7IHJldHVybiBKU1ZhbHVlKGEpICE9IGI7IH0KIAogCiBib29sIGlz VGhpc1ZhbHVlQWx0ZXJlZChjb25zdCBQdXRQcm9wZXJ0eVNsb3QmLCBKU09iamVjdCogYmFzZU9i amVjdCk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU0NKU1Zh bHVlSW5saW5lcy5oIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNDSlNWYWx1ZUlu bGluZXMuaAppbmRleCA2Y2YzYTIyM2MyZGFiZWNkMjhjNDI5YmYwNzI1NDE1MzI4ZDI0ZDFhLi42 NDNhM2ViYWNiYzA2YjQ2YTlhOGQ0YWI2ZGQ3Y2MzMTNmY2E2ZWVjIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU0NKU1ZhbHVlSW5saW5lcy5oCisrKyBiL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTQ0pTVmFsdWVJbmxpbmVzLmgKQEAgLTk3NCw3ICs5 NzQsNyBAQCBpbmxpbmUgSlNWYWx1ZSBKU1ZhbHVlOjpzdHJ1Y3R1cmVPclVuZGVmaW5lZCgpIGNv bnN0CiB9CiAKIC8vIEVDTUEgMTEuOS4zCi1pbmxpbmUgYm9vbCBKU1ZhbHVlOjplcXVhbChFeGVj U3RhdGUqIGV4ZWMsIEpTVmFsdWUgdjEsIEpTVmFsdWUgdjIpCitpbmxpbmUgYm9vbCBKU1ZhbHVl OjplcXVhbChFeGVjU3RhdGUqIGV4ZWMsIGNvbnN0IEpTVmFsdWUmIHYxLCBjb25zdCBKU1ZhbHVl JiB2MikKIHsKICAgICBpZiAodjEuaXNJbnQzMigpICYmIHYyLmlzSW50MzIoKSkKICAgICAgICAg cmV0dXJuIHYxID09IHYyOwpAQCAtMTA5NSw3ICsxMDk1LDcgQEAgQUxXQVlTX0lOTElORSBib29s IEpTVmFsdWU6OmVxdWFsU2xvd0Nhc2VJbmxpbmUoRXhlY1N0YXRlKiBleGVjLCBKU1ZhbHVlIHYx LCBKU1YKIH0KIAogLy8gRUNNQSAxMS45LjMKLUFMV0FZU19JTkxJTkUgYm9vbCBKU1ZhbHVlOjpz dHJpY3RFcXVhbFNsb3dDYXNlSW5saW5lKEV4ZWNTdGF0ZSogZXhlYywgSlNWYWx1ZSB2MSwgSlNW YWx1ZSB2MikKK0FMV0FZU19JTkxJTkUgYm9vbCBKU1ZhbHVlOjpzdHJpY3RFcXVhbFNsb3dDYXNl SW5saW5lKEV4ZWNTdGF0ZSogZXhlYywgY29uc3QgSlNWYWx1ZSYgdjEsIGNvbnN0IEpTVmFsdWUm IHYyKQogewogICAgIEFTU0VSVCh2MS5pc0NlbGwoKSAmJiB2Mi5pc0NlbGwoKSk7CiAKQEAgLTEx MDYsNyArMTEwNiw3IEBAIEFMV0FZU19JTkxJTkUgYm9vbCBKU1ZhbHVlOjpzdHJpY3RFcXVhbFNs b3dDYXNlSW5saW5lKEV4ZWNTdGF0ZSogZXhlYywgSlNWYWx1ZSB2CiAgICAgcmV0dXJuIHYxID09 IHYyOwogfQogCi1pbmxpbmUgYm9vbCBKU1ZhbHVlOjpzdHJpY3RFcXVhbChFeGVjU3RhdGUqIGV4 ZWMsIEpTVmFsdWUgdjEsIEpTVmFsdWUgdjIpCitpbmxpbmUgYm9vbCBKU1ZhbHVlOjpzdHJpY3RF cXVhbChFeGVjU3RhdGUqIGV4ZWMsIGNvbnN0IEpTVmFsdWUmIHYxLCBjb25zdCBKU1ZhbHVlJiB2 MikKIHsKICAgICBpZiAodjEuaXNJbnQzMigpICYmIHYyLmlzSW50MzIoKSkKICAgICAgICAgcmV0 dXJuIHYxID09IHYyOwpAQCAtMTEyNyw3ICsxMTI3LDcgQEAgaW5saW5lIGludDMyX3QgSlNWYWx1 ZTo6YXNJbnQzMkZvckFyaXRobWV0aWMoKSBjb25zdAogICAgIHJldHVybiBhc0ludDMyKCk7CiB9 CiAKLWlubGluZSBUcmlTdGF0ZSBKU1ZhbHVlOjpwdXJlU3RyaWN0RXF1YWwoSlNWYWx1ZSB2MSwg SlNWYWx1ZSB2MikKK2lubGluZSBUcmlTdGF0ZSBKU1ZhbHVlOjpwdXJlU3RyaWN0RXF1YWwoY29u c3QgSlNWYWx1ZSYgdjEsIGNvbnN0IEpTVmFsdWUmIHYyKQogewogICAgIGlmICh2MS5pc0ludDMy KCkgJiYgdjIuaXNJbnQzMigpKQogICAgICAgICByZXR1cm4gdHJpU3RhdGUodjEgPT0gdjIpOwpk aWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvT3BlcmF0aW9ucy5jcHAg Yi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9PcGVyYXRpb25zLmNwcAppbmRleCA4MzZm OTUzYzNhODdjNTdkNWM2MjJmYmY0YzcwNTA5MDUwNzUxYmViLi5mYTA0YzRhNmM4MDdiNzczMTZk ZDEyMTg1ZmNhMjJlNDYwZmRlMmI1IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv cnVudGltZS9PcGVyYXRpb25zLmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGlt ZS9PcGVyYXRpb25zLmNwcApAQCAtMzEsMTIgKzMxLDEyIEBACiAKIG5hbWVzcGFjZSBKU0Mgewog Ci1ib29sIEpTVmFsdWU6OmVxdWFsU2xvd0Nhc2UoRXhlY1N0YXRlKiBleGVjLCBKU1ZhbHVlIHYx LCBKU1ZhbHVlIHYyKQorYm9vbCBKU1ZhbHVlOjplcXVhbFNsb3dDYXNlKEV4ZWNTdGF0ZSogZXhl YywgY29uc3QgSlNWYWx1ZSYgdjEsIGNvbnN0IEpTVmFsdWUmIHYyKQogewogICAgIHJldHVybiBl cXVhbFNsb3dDYXNlSW5saW5lKGV4ZWMsIHYxLCB2Mik7CiB9CiAKLWJvb2wgSlNWYWx1ZTo6c3Ry aWN0RXF1YWxTbG93Q2FzZShFeGVjU3RhdGUqIGV4ZWMsIEpTVmFsdWUgdjEsIEpTVmFsdWUgdjIp Citib29sIEpTVmFsdWU6OnN0cmljdEVxdWFsU2xvd0Nhc2UoRXhlY1N0YXRlKiBleGVjLCBjb25z dCBKU1ZhbHVlJiB2MSwgY29uc3QgSlNWYWx1ZSYgdjIpCiB7CiAgICAgcmV0dXJuIHN0cmljdEVx dWFsU2xvd0Nhc2VJbmxpbmUoZXhlYywgdjEsIHYyKTsKIH0K 357806 2018-12-20 04:51:26 -0800 2018-12-20 04:51:26 -0800 Patch v1 (retry EWS) bug-192816-20181218112651-retry.patch text/plain 6021 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMjM5Mjc2CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA4 MTgxOWRlYzllYTc5MmIzNWRlZWYyMzAzZTdjMTk2NzFkODQ1NzI3Li5mNTRiMTExMmE3NjY0MTNi ZjcyMzE2YThjNTNkZTNlNjhiMGQ0MDZhIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyNiBAQAorMjAxOC0xMi0xOCAgRGF2aWQgS2lsemVyICA8ZGRraWx6ZXJAYXBwbGUuY29t PgorCisgICAgICAgIFVzZSBpZGlvbWF0aWMgY29uc3QgcmVmZXJlbmNlcyBmb3IgZXF1YWxpdHkg bWV0aG9kcyBpbiBKU0M6OkpTVmFsdWUgY2xhc3MKKyAgICAgICAgPGh0dHBzOi8vd2Via2l0Lm9y Zy9iLzE5MjgxNj4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBPbmx5IEpTQzo6SlNWYWx1ZTo6ZXF1YWxTbG93Q2FzZUlubGluZSgpIGlzIG5vdCBjaGFu Z2VkIHRvIHVzZQorICAgICAgICBjb25zdCByZWZlcmVuY2VzIGJlY2F1c2UgaXQgY2hhbmdlcyB0 aGUgdmFsdWUgb2YgaXRzIHBhcmFtZXRlcnMKKyAgICAgICAgYXMgcGFydCBvZiBpdHMgYWxnb3Jp dGhtLgorCisgICAgICAgICogcnVudGltZS9KU0NKU1ZhbHVlLmg6CisgICAgICAgIChKU0M6Om9w ZXJhdG9yPT0pOgorICAgICAgICAoSlNDOjpvcGVyYXRvciE9KToKKyAgICAgICAgKiBydW50aW1l L0pTQ0pTVmFsdWVJbmxpbmVzLmg6CisgICAgICAgIChKU0M6OkpTVmFsdWU6OmVxdWFsKToKKyAg ICAgICAgKEpTQzo6SlNWYWx1ZTo6c3RyaWN0RXF1YWxTbG93Q2FzZUlubGluZSk6CisgICAgICAg IChKU0M6OkpTVmFsdWU6OnN0cmljdEVxdWFsKToKKyAgICAgICAgKEpTQzo6SlNWYWx1ZTo6cHVy ZVN0cmljdEVxdWFsKToKKyAgICAgICAgKiBydW50aW1lL09wZXJhdGlvbnMuY3BwOgorICAgICAg ICAoSlNDOjpKU1ZhbHVlOjplcXVhbFNsb3dDYXNlKToKKyAgICAgICAgKEpTQzo6SlNWYWx1ZTo6 c3RyaWN0RXF1YWxTbG93Q2FzZSk6CisKIDIwMTgtMTItMTggIERhdmlkIEtpbHplciAgPGRka2ls emVyQGFwcGxlLmNvbT4KIAogICAgICAgICBjbGFuZy10aWR5OiBVc2UgY29uc3QgcmVmZXJlbmNl IGZvciBNZWRpYVRpbWUgcGFyYW1ldGVyIHRvIHByZXZlbnQgb2JqZWN0IGNvcHkKZGlmZiAtLWdp dCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTQ0pTVmFsdWUuaCBiL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTQ0pTVmFsdWUuaAppbmRleCA1ODI1MzBkNDRjMGY3ZDI0 ZTgyYTk3ZGJjOTUxM2E1M2UyZGUwMjc2Li5mMTk0MjllMjMwZTgzYWQxZDRhZWRmMWMzYWQ4ZDA4 OWE0NWYxMzgxIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU0NK U1ZhbHVlLmgKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNDSlNWYWx1ZS5o CkBAIC0zMDQsMTMgKzMwNCwxMyBAQCBwdWJsaWM6CiAKICAgICBKU1ZhbHVlIHRvVGhpcyhFeGVj U3RhdGUqLCBFQ01BTW9kZSkgY29uc3Q7CiAKLSAgICBzdGF0aWMgYm9vbCBlcXVhbChFeGVjU3Rh dGUqLCBKU1ZhbHVlIHYxLCBKU1ZhbHVlIHYyKTsKLSAgICBzdGF0aWMgYm9vbCBlcXVhbFNsb3dD YXNlKEV4ZWNTdGF0ZSosIEpTVmFsdWUgdjEsIEpTVmFsdWUgdjIpOworICAgIHN0YXRpYyBib29s IGVxdWFsKEV4ZWNTdGF0ZSosIGNvbnN0IEpTVmFsdWUmIHYxLCBjb25zdCBKU1ZhbHVlJiB2Mik7 CisgICAgc3RhdGljIGJvb2wgZXF1YWxTbG93Q2FzZShFeGVjU3RhdGUqLCBjb25zdCBKU1ZhbHVl JiB2MSwgY29uc3QgSlNWYWx1ZSYgdjIpOwogICAgIHN0YXRpYyBib29sIGVxdWFsU2xvd0Nhc2VJ bmxpbmUoRXhlY1N0YXRlKiwgSlNWYWx1ZSB2MSwgSlNWYWx1ZSB2Mik7Ci0gICAgc3RhdGljIGJv b2wgc3RyaWN0RXF1YWwoRXhlY1N0YXRlKiwgSlNWYWx1ZSB2MSwgSlNWYWx1ZSB2Mik7Ci0gICAg c3RhdGljIGJvb2wgc3RyaWN0RXF1YWxTbG93Q2FzZShFeGVjU3RhdGUqLCBKU1ZhbHVlIHYxLCBK U1ZhbHVlIHYyKTsKLSAgICBzdGF0aWMgYm9vbCBzdHJpY3RFcXVhbFNsb3dDYXNlSW5saW5lKEV4 ZWNTdGF0ZSosIEpTVmFsdWUgdjEsIEpTVmFsdWUgdjIpOwotICAgIHN0YXRpYyBUcmlTdGF0ZSBw dXJlU3RyaWN0RXF1YWwoSlNWYWx1ZSB2MSwgSlNWYWx1ZSB2Mik7CisgICAgc3RhdGljIGJvb2wg c3RyaWN0RXF1YWwoRXhlY1N0YXRlKiwgY29uc3QgSlNWYWx1ZSYgdjEsIGNvbnN0IEpTVmFsdWUm IHYyKTsKKyAgICBzdGF0aWMgYm9vbCBzdHJpY3RFcXVhbFNsb3dDYXNlKEV4ZWNTdGF0ZSosIGNv bnN0IEpTVmFsdWUmIHYxLCBjb25zdCBKU1ZhbHVlJiB2Mik7CisgICAgc3RhdGljIGJvb2wgc3Ry aWN0RXF1YWxTbG93Q2FzZUlubGluZShFeGVjU3RhdGUqLCBjb25zdCBKU1ZhbHVlJiB2MSwgY29u c3QgSlNWYWx1ZSYgdjIpOworICAgIHN0YXRpYyBUcmlTdGF0ZSBwdXJlU3RyaWN0RXF1YWwoY29u c3QgSlNWYWx1ZSYgdjEsIGNvbnN0IEpTVmFsdWUmIHYyKTsKIAogICAgIGJvb2wgaXNDZWxsKCkg Y29uc3Q7CiAgICAgSlNDZWxsKiBhc0NlbGwoKSBjb25zdDsKQEAgLTYxNiwxMSArNjE2LDExIEBA IEFMV0FZU19JTkxJTkUgRW5jb2RlZEpTVmFsdWUgZW5jb2RlZEpTVmFsdWUoKQogICAgIHJldHVy biBKU1ZhbHVlOjplbmNvZGUoSlNWYWx1ZSgpKTsKIH0KIAotaW5saW5lIGJvb2wgb3BlcmF0b3I9 PShjb25zdCBKU1ZhbHVlIGEsIGNvbnN0IEpTQ2VsbCogYikgeyByZXR1cm4gYSA9PSBKU1ZhbHVl KGIpOyB9Ci1pbmxpbmUgYm9vbCBvcGVyYXRvcj09KGNvbnN0IEpTQ2VsbCogYSwgY29uc3QgSlNW YWx1ZSBiKSB7IHJldHVybiBKU1ZhbHVlKGEpID09IGI7IH0KK2lubGluZSBib29sIG9wZXJhdG9y PT0oY29uc3QgSlNWYWx1ZSYgYSwgY29uc3QgSlNDZWxsKiBiKSB7IHJldHVybiBhID09IEpTVmFs dWUoYik7IH0KK2lubGluZSBib29sIG9wZXJhdG9yPT0oY29uc3QgSlNDZWxsKiBhLCBjb25zdCBK U1ZhbHVlJiBiKSB7IHJldHVybiBKU1ZhbHVlKGEpID09IGI7IH0KIAotaW5saW5lIGJvb2wgb3Bl cmF0b3IhPShjb25zdCBKU1ZhbHVlIGEsIGNvbnN0IEpTQ2VsbCogYikgeyByZXR1cm4gYSAhPSBK U1ZhbHVlKGIpOyB9Ci1pbmxpbmUgYm9vbCBvcGVyYXRvciE9KGNvbnN0IEpTQ2VsbCogYSwgY29u c3QgSlNWYWx1ZSBiKSB7IHJldHVybiBKU1ZhbHVlKGEpICE9IGI7IH0KK2lubGluZSBib29sIG9w ZXJhdG9yIT0oY29uc3QgSlNWYWx1ZSYgYSwgY29uc3QgSlNDZWxsKiBiKSB7IHJldHVybiBhICE9 IEpTVmFsdWUoYik7IH0KK2lubGluZSBib29sIG9wZXJhdG9yIT0oY29uc3QgSlNDZWxsKiBhLCBj b25zdCBKU1ZhbHVlJiBiKSB7IHJldHVybiBKU1ZhbHVlKGEpICE9IGI7IH0KIAogCiBib29sIGlz VGhpc1ZhbHVlQWx0ZXJlZChjb25zdCBQdXRQcm9wZXJ0eVNsb3QmLCBKU09iamVjdCogYmFzZU9i amVjdCk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU0NKU1Zh bHVlSW5saW5lcy5oIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNDSlNWYWx1ZUlu bGluZXMuaAppbmRleCA2Y2YzYTIyM2MyZGFiZWNkMjhjNDI5YmYwNzI1NDE1MzI4ZDI0ZDFhLi42 NDNhM2ViYWNiYzA2YjQ2YTlhOGQ0YWI2ZGQ3Y2MzMTNmY2E2ZWVjIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU0NKU1ZhbHVlSW5saW5lcy5oCisrKyBiL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTQ0pTVmFsdWVJbmxpbmVzLmgKQEAgLTk3NCw3ICs5 NzQsNyBAQCBpbmxpbmUgSlNWYWx1ZSBKU1ZhbHVlOjpzdHJ1Y3R1cmVPclVuZGVmaW5lZCgpIGNv bnN0CiB9CiAKIC8vIEVDTUEgMTEuOS4zCi1pbmxpbmUgYm9vbCBKU1ZhbHVlOjplcXVhbChFeGVj U3RhdGUqIGV4ZWMsIEpTVmFsdWUgdjEsIEpTVmFsdWUgdjIpCitpbmxpbmUgYm9vbCBKU1ZhbHVl OjplcXVhbChFeGVjU3RhdGUqIGV4ZWMsIGNvbnN0IEpTVmFsdWUmIHYxLCBjb25zdCBKU1ZhbHVl JiB2MikKIHsKICAgICBpZiAodjEuaXNJbnQzMigpICYmIHYyLmlzSW50MzIoKSkKICAgICAgICAg cmV0dXJuIHYxID09IHYyOwpAQCAtMTA5NSw3ICsxMDk1LDcgQEAgQUxXQVlTX0lOTElORSBib29s IEpTVmFsdWU6OmVxdWFsU2xvd0Nhc2VJbmxpbmUoRXhlY1N0YXRlKiBleGVjLCBKU1ZhbHVlIHYx LCBKU1YKIH0KIAogLy8gRUNNQSAxMS45LjMKLUFMV0FZU19JTkxJTkUgYm9vbCBKU1ZhbHVlOjpz dHJpY3RFcXVhbFNsb3dDYXNlSW5saW5lKEV4ZWNTdGF0ZSogZXhlYywgSlNWYWx1ZSB2MSwgSlNW YWx1ZSB2MikKK0FMV0FZU19JTkxJTkUgYm9vbCBKU1ZhbHVlOjpzdHJpY3RFcXVhbFNsb3dDYXNl SW5saW5lKEV4ZWNTdGF0ZSogZXhlYywgY29uc3QgSlNWYWx1ZSYgdjEsIGNvbnN0IEpTVmFsdWUm IHYyKQogewogICAgIEFTU0VSVCh2MS5pc0NlbGwoKSAmJiB2Mi5pc0NlbGwoKSk7CiAKQEAgLTEx MDYsNyArMTEwNiw3IEBAIEFMV0FZU19JTkxJTkUgYm9vbCBKU1ZhbHVlOjpzdHJpY3RFcXVhbFNs b3dDYXNlSW5saW5lKEV4ZWNTdGF0ZSogZXhlYywgSlNWYWx1ZSB2CiAgICAgcmV0dXJuIHYxID09 IHYyOwogfQogCi1pbmxpbmUgYm9vbCBKU1ZhbHVlOjpzdHJpY3RFcXVhbChFeGVjU3RhdGUqIGV4 ZWMsIEpTVmFsdWUgdjEsIEpTVmFsdWUgdjIpCitpbmxpbmUgYm9vbCBKU1ZhbHVlOjpzdHJpY3RF cXVhbChFeGVjU3RhdGUqIGV4ZWMsIGNvbnN0IEpTVmFsdWUmIHYxLCBjb25zdCBKU1ZhbHVlJiB2 MikKIHsKICAgICBpZiAodjEuaXNJbnQzMigpICYmIHYyLmlzSW50MzIoKSkKICAgICAgICAgcmV0 dXJuIHYxID09IHYyOwpAQCAtMTEyNyw3ICsxMTI3LDcgQEAgaW5saW5lIGludDMyX3QgSlNWYWx1 ZTo6YXNJbnQzMkZvckFyaXRobWV0aWMoKSBjb25zdAogICAgIHJldHVybiBhc0ludDMyKCk7CiB9 CiAKLWlubGluZSBUcmlTdGF0ZSBKU1ZhbHVlOjpwdXJlU3RyaWN0RXF1YWwoSlNWYWx1ZSB2MSwg SlNWYWx1ZSB2MikKK2lubGluZSBUcmlTdGF0ZSBKU1ZhbHVlOjpwdXJlU3RyaWN0RXF1YWwoY29u c3QgSlNWYWx1ZSYgdjEsIGNvbnN0IEpTVmFsdWUmIHYyKQogewogICAgIGlmICh2MS5pc0ludDMy KCkgJiYgdjIuaXNJbnQzMigpKQogICAgICAgICByZXR1cm4gdHJpU3RhdGUodjEgPT0gdjIpOwpk aWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvT3BlcmF0aW9ucy5jcHAg Yi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9PcGVyYXRpb25zLmNwcAppbmRleCA4MzZm OTUzYzNhODdjNTdkNWM2MjJmYmY0YzcwNTA5MDUwNzUxYmViLi5mYTA0YzRhNmM4MDdiNzczMTZk ZDEyMTg1ZmNhMjJlNDYwZmRlMmI1IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv cnVudGltZS9PcGVyYXRpb25zLmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGlt ZS9PcGVyYXRpb25zLmNwcApAQCAtMzEsMTIgKzMxLDEyIEBACiAKIG5hbWVzcGFjZSBKU0Mgewog Ci1ib29sIEpTVmFsdWU6OmVxdWFsU2xvd0Nhc2UoRXhlY1N0YXRlKiBleGVjLCBKU1ZhbHVlIHYx LCBKU1ZhbHVlIHYyKQorYm9vbCBKU1ZhbHVlOjplcXVhbFNsb3dDYXNlKEV4ZWNTdGF0ZSogZXhl YywgY29uc3QgSlNWYWx1ZSYgdjEsIGNvbnN0IEpTVmFsdWUmIHYyKQogewogICAgIHJldHVybiBl cXVhbFNsb3dDYXNlSW5saW5lKGV4ZWMsIHYxLCB2Mik7CiB9CiAKLWJvb2wgSlNWYWx1ZTo6c3Ry aWN0RXF1YWxTbG93Q2FzZShFeGVjU3RhdGUqIGV4ZWMsIEpTVmFsdWUgdjEsIEpTVmFsdWUgdjIp Citib29sIEpTVmFsdWU6OnN0cmljdEVxdWFsU2xvd0Nhc2UoRXhlY1N0YXRlKiBleGVjLCBjb25z dCBKU1ZhbHVlJiB2MSwgY29uc3QgSlNWYWx1ZSYgdjIpCiB7CiAgICAgcmV0dXJuIHN0cmljdEVx dWFsU2xvd0Nhc2VJbmxpbmUoZXhlYywgdjEsIHYyKTsKIH0K