192815 2018-12-18 11:05:49 -0800 [EME] MediaKeySystemConfiguration distinctiveIdentifier and persistentState should default to optional 2018-12-19 23:20:01 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 calvaris calvaris commit-queue darin jer.noble webkit-bug-importer oldest_to_newest 1488958 0 calvaris 2018-12-18 11:05:49 -0800 [EME] MediaKeySystemConfiguration distinctiveIdentifier and persistentState should default to optional 1488961 1 357585 calvaris 2018-12-18 11:17:18 -0800 Created attachment 357585 Patch 1489249 2 357585 commit-queue 2018-12-19 00:56:03 -0800 Comment on attachment 357585 Patch Clearing flags on attachment: 357585 Committed r239373: <https://trac.webkit.org/changeset/239373> 1489250 3 commit-queue 2018-12-19 00:56:04 -0800 All reviewed patches have been landed. Closing bug. 1489251 4 webkit-bug-importer 2018-12-19 00:57:28 -0800 <rdar://problem/46835043> 1489760 5 357585 darin 2018-12-19 23:20:01 -0800 Comment on attachment 357585 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=357585&action=review > Source/WebCore/ChangeLog:11 > + https://www.w3.org/TR/encrypted-media/#dom-mediakeysystemconfiguration > + says that distinctiveIdentifier and persistentState default to > + optional. Our implementation does not define a default leaving it > + to the first option of the enum, which currently is Required. Actually, I think it was worse than that before. Our implementation was not initializing the field, which doesn’t guarantee what it will be initialized to! We were getting a 0, but that wasn’t guaranteed. 357585 2018-12-18 11:17:18 -0800 2018-12-19 00:56:03 -0800 Patch bug-192815-20181218201717.patch text/plain 1910 calvaris U3VidmVyc2lvbiBSZXZpc2lvbjogMjM5MDA5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTQ0MDkzMTQ1MjA3MGQ5 ZDUwNDdhZDQzNDk2NWNmYmQ3YWNiMWUyNy4uMWMzMTM4MTZjNGNjZWMwMTNmZjgzYThkMTc2Njhl ZGY4NTBiMmVlYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE4LTEyLTE4ICBYYWJp ZXIgUm9kcmlndWV6IENhbHZhciAgPGNhbHZhcmlzQGlnYWxpYS5jb20+CisKKyAgICAgICAgW0VN RV0gTWVkaWFLZXlTeXN0ZW1Db25maWd1cmF0aW9uIGRpc3RpbmN0aXZlSWRlbnRpZmllciBhbmQg cGVyc2lzdGVudFN0YXRlIHNob3VsZCBkZWZhdWx0IHRvIG9wdGlvbmFsCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTI4MTUKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBodHRwczovL3d3dy53My5vcmcvVFIv ZW5jcnlwdGVkLW1lZGlhLyNkb20tbWVkaWFrZXlzeXN0ZW1jb25maWd1cmF0aW9uCisgICAgICAg IHNheXMgdGhhdCBkaXN0aW5jdGl2ZUlkZW50aWZpZXIgYW5kIHBlcnNpc3RlbnRTdGF0ZSBkZWZh dWx0IHRvCisgICAgICAgIG9wdGlvbmFsLiBPdXIgaW1wbGVtZW50YXRpb24gZG9lcyBub3QgZGVm aW5lIGEgZGVmYXVsdCBsZWF2aW5nIGl0CisgICAgICAgIHRvIHRoZSBmaXJzdCBvcHRpb24gb2Yg dGhlIGVudW0sIHdoaWNoIGN1cnJlbnRseSBpcyBSZXF1aXJlZC4KKworICAgICAgICAqIHBsYXRm b3JtL2VuY3J5cHRlZG1lZGlhL0NETUtleVN5c3RlbUNvbmZpZ3VyYXRpb24uaDoKKwogMjAxOC0x Mi0wNyAgRXJpYyBDYXJsc29uICA8ZXJpYy5jYXJsc29uQGFwcGxlLmNvbT4KIAogICAgICAgICBb TWVkaWFTdHJlYW1dICdkZXZpY2VjaGFuZ2UnIGV2ZW50IHNob3VsZCBub3QgZmlyZSBpbiBmcmFt ZXMgdGhhdCBjYW4ndCBhY2Nlc3MgY2FwdHVyZSBkZXZpY2VzCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9lbmNyeXB0ZWRtZWRpYS9DRE1LZXlTeXN0ZW1Db25maWd1cmF0aW9u LmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9lbmNyeXB0ZWRtZWRpYS9DRE1LZXlTeXN0ZW1D b25maWd1cmF0aW9uLmgKaW5kZXggMzg1NDkyMTAxYjliZTliZmY3ZTcxYWE5YWNjNmJhNDg0NDkx ZmRkYi4uNjEyZDY0NWZhYTUyNDhmNzFmMWMxNTY3ZjQ1MDdlODlmM2IzMWNlNSAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZW5jcnlwdGVkbWVkaWEvQ0RNS2V5U3lzdGVtQ29u ZmlndXJhdGlvbi5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2VuY3J5cHRlZG1lZGlh L0NETUtleVN5c3RlbUNvbmZpZ3VyYXRpb24uaApAQCAtNDUsOCArNDUsOCBAQCBzdHJ1Y3QgQ0RN S2V5U3lzdGVtQ29uZmlndXJhdGlvbiB7CiAgICAgVmVjdG9yPFN0cmluZz4gaW5pdERhdGFUeXBl czsKICAgICBWZWN0b3I8Q0RNTWVkaWFDYXBhYmlsaXR5PiBhdWRpb0NhcGFiaWxpdGllczsKICAg ICBWZWN0b3I8Q0RNTWVkaWFDYXBhYmlsaXR5PiB2aWRlb0NhcGFiaWxpdGllczsKLSAgICBDRE1S ZXF1aXJlbWVudCBkaXN0aW5jdGl2ZUlkZW50aWZpZXI7Ci0gICAgQ0RNUmVxdWlyZW1lbnQgcGVy c2lzdGVudFN0YXRlOworICAgIENETVJlcXVpcmVtZW50IGRpc3RpbmN0aXZlSWRlbnRpZmllciB7 IENETVJlcXVpcmVtZW50OjpPcHRpb25hbCB9OworICAgIENETVJlcXVpcmVtZW50IHBlcnNpc3Rl bnRTdGF0ZSB7IENETVJlcXVpcmVtZW50OjpPcHRpb25hbCB9OwogICAgIFZlY3RvcjxDRE1TZXNz aW9uVHlwZT4gc2Vzc2lvblR5cGVzOwogfTsKIAo=