192813 2018-12-18 10:51:29 -0800 Use idiomatic const references for equality helper methods for WTF::StringView class 2020-06-03 18:31:20 -0700 1 1 1 Unclassified WebKit Web Template Framework WebKit Local Build Unspecified Unspecified RESOLVED WONTFIX https://bugs.webkit.org/show_bug.cgi?id=192816 P2 Normal --- 1 ddkilzer ddkilzer achristensen benjamin cdumez cmarcelo darin dbates ews-watchlist oldest_to_newest 1488949 0 ddkilzer 2018-12-18 10:51:29 -0800 Use idiomatic const references for equality methods in WTF::StringView class. Nearly all other `operator==(const TypeName&) const` methods use const references to avoid object copies when comparing two objects. StringView should do the same (unless I'm forgetting why it's not doing this). 1488951 1 357580 ddkilzer 2018-12-18 10:53:47 -0800 Created attachment 357580 Patch v1 1489659 2 darin 2018-12-19 18:42:16 -0800 We don’t do this because it’s not more efficient with StringView; fits well into registers, no work required on copying in production builds. Anders Carlsson originally proposed this. I don’t see any good reason to change this. 1489822 3 ddkilzer 2018-12-20 04:58:43 -0800 (In reply to Darin Adler from comment #2) > We don’t do this because it’s not more efficient with StringView; fits well > into registers, no work required on copying in production builds. Anders > Carlsson originally proposed this. > > I don’t see any good reason to change this. Okay. 357580 2018-12-18 10:53:47 -0800 2020-06-03 18:31:20 -0700 Patch v1 bug-192813-20181218105346.patch text/plain 5385 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMjM5Mjc2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDljNDgwYTU5NjE4YzIyMDEwMWE3N2M5 YmY2MmY5MTdjZTY5YzZmNGEuLjcyZTBhOTNiN2FhMmZhMmI2NmIwZjgwZDA1OGVkZWUwN2MzMmNk MjAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTgtMTItMTcgIERhdmlkIEtpbHplciAgPGRka2ls emVyQGFwcGxlLmNvbT4KKworICAgICAgICBVc2UgaWRpb21hdGljIGNvbnN0IHJlZmVyZW5jZXMg Zm9yIGVxdWFsaXR5IG1ldGhvZHMgaW4gV1RGOjpTdHJpbmdWaWV3IGNsYXNzCisgICAgICAgIDxo dHRwczovL3dlYmtpdC5vcmcvYi8xOTI4MTM+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgKiB3dGYvdGV4dC9TdHJpbmdWaWV3Lmg6CisgICAgICAgIChX VEY6Om9wZXJhdG9yPT0pOgorICAgICAgICAoV1RGOjpvcGVyYXRvciE9KToKKyAgICAgICAgKFdU Rjo6ZXF1YWwpOgorICAgICAgICAoV1RGOjplcXVhbElnbm9yaW5nQVNDSUlDYXNlKToKKyAgICAg ICAgKFdURjo6ZXF1YWxMZXR0ZXJzSWdub3JpbmdBU0NJSUNhc2UpOgorICAgICAgICAtIFN3aXRj aCB0byB1c2UgaWRpb21hdGljIGNvbnN0IHJlZmVyZW5jZXMgZm9yIGVxdWFsaXR5IG1ldGhvZHMu CisKIDIwMTgtMTItMTcgIERhbmllbCBCYXRlcyAgPGRhYmF0ZXNAYXBwbGUuY29tPgogCiAgICAg ICAgIEZpeCB0aGUgQXBwbGUgSW50ZXJuYWwgTWFjIGJ1aWxkIHdpdGggYSBuZXdlciBTREsKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XVEYvd3RmL3RleHQvU3RyaW5nVmlldy5oIGIvU291cmNlL1dURi93 dGYvdGV4dC9TdHJpbmdWaWV3LmgKaW5kZXggNzMxNGU1NmQ5NDEwOGZiYTk1MjAwYTc4MzBlNzZi NzYwNGY3YWQyMi4uYTgzZmU0ZGRlODExOTA1OGE0NDc5ZmQwYTk1ODE5MTg4OTAxYzM2YiAxMDA2 NDQKLS0tIGEvU291cmNlL1dURi93dGYvdGV4dC9TdHJpbmdWaWV3LmgKKysrIGIvU291cmNlL1dU Ri93dGYvdGV4dC9TdHJpbmdWaWV3LmgKQEAgLTE2MSw3ICsxNjEsNyBAQCBwdWJsaWM6CiAgICAg c3RydWN0IFVuZGVybHlpbmdTdHJpbmc7CiAKIHByaXZhdGU6Ci0gICAgZnJpZW5kIGJvb2wgZXF1 YWwoU3RyaW5nVmlldywgU3RyaW5nVmlldyk7CisgICAgZnJpZW5kIGJvb2wgZXF1YWwoY29uc3Qg U3RyaW5nVmlldyYsIGNvbnN0IFN0cmluZ1ZpZXcmKTsKIAogICAgIHZvaWQgaW5pdGlhbGl6ZShj b25zdCBMQ2hhciosIHVuc2lnbmVkIGxlbmd0aCk7CiAgICAgdm9pZCBpbml0aWFsaXplKGNvbnN0 IFVDaGFyKiwgdW5zaWduZWQgbGVuZ3RoKTsKQEAgLTE5MiwyNCArMTkyLDI0IEBAIHByaXZhdGU6 CiAKIHRlbXBsYXRlPHR5cGVuYW1lIENoYXJhY3RlclR5cGUsIHNpemVfdCBpbmxpbmVDYXBhY2l0 eT4gdm9pZCBhcHBlbmQoVmVjdG9yPENoYXJhY3RlclR5cGUsIGlubGluZUNhcGFjaXR5PiYsIFN0 cmluZ1ZpZXcpOwogCi1ib29sIGVxdWFsKFN0cmluZ1ZpZXcsIFN0cmluZ1ZpZXcpOwotYm9vbCBl cXVhbChTdHJpbmdWaWV3LCBjb25zdCBMQ2hhciogYik7Citib29sIGVxdWFsKGNvbnN0IFN0cmlu Z1ZpZXcmLCBjb25zdCBTdHJpbmdWaWV3Jik7Citib29sIGVxdWFsKGNvbnN0IFN0cmluZ1ZpZXcm LCBjb25zdCBMQ2hhciogYik7CiAKLWJvb2wgZXF1YWxJZ25vcmluZ0FTQ0lJQ2FzZShTdHJpbmdW aWV3LCBTdHJpbmdWaWV3KTsKLWJvb2wgZXF1YWxJZ25vcmluZ0FTQ0lJQ2FzZShTdHJpbmdWaWV3 LCBjb25zdCBjaGFyKik7Citib29sIGVxdWFsSWdub3JpbmdBU0NJSUNhc2UoY29uc3QgU3RyaW5n VmlldyYsIGNvbnN0IFN0cmluZ1ZpZXcmKTsKK2Jvb2wgZXF1YWxJZ25vcmluZ0FTQ0lJQ2FzZShj b25zdCBTdHJpbmdWaWV3JiwgY29uc3QgY2hhciopOwogCi10ZW1wbGF0ZTx1bnNpZ25lZCBsZW5n dGg+IGJvb2wgZXF1YWxMZXR0ZXJzSWdub3JpbmdBU0NJSUNhc2UoU3RyaW5nVmlldywgY29uc3Qg Y2hhciAoJmxvd2VyY2FzZUxldHRlcnMpW2xlbmd0aF0pOwordGVtcGxhdGU8dW5zaWduZWQgbGVu Z3RoPiBib29sIGVxdWFsTGV0dGVyc0lnbm9yaW5nQVNDSUlDYXNlKGNvbnN0IFN0cmluZ1ZpZXcm LCBjb25zdCBjaGFyICgmbG93ZXJjYXNlTGV0dGVycylbbGVuZ3RoXSk7CiAKLWlubGluZSBib29s IG9wZXJhdG9yPT0oU3RyaW5nVmlldyBhLCBTdHJpbmdWaWV3IGIpIHsgcmV0dXJuIGVxdWFsKGEs IGIpOyB9Ci1pbmxpbmUgYm9vbCBvcGVyYXRvcj09KFN0cmluZ1ZpZXcgYSwgY29uc3QgTENoYXIg KmIpOwotaW5saW5lIGJvb2wgb3BlcmF0b3I9PShTdHJpbmdWaWV3IGEsIGNvbnN0IGNoYXIgKmIp IHsgcmV0dXJuIGVxdWFsKGEsIHJlaW50ZXJwcmV0X2Nhc3Q8Y29uc3QgTENoYXIqPihiKSk7IH0K LWlubGluZSBib29sIG9wZXJhdG9yPT0oY29uc3QgY2hhciogYSwgU3RyaW5nVmlldyBiKSB7IHJl dHVybiBlcXVhbChiLCBhKTsgfQoraW5saW5lIGJvb2wgb3BlcmF0b3I9PShjb25zdCBTdHJpbmdW aWV3JiBhLCBjb25zdCBTdHJpbmdWaWV3JiBiKSB7IHJldHVybiBlcXVhbChhLCBiKTsgfQoraW5s aW5lIGJvb2wgb3BlcmF0b3I9PShjb25zdCBTdHJpbmdWaWV3JiBhLCBjb25zdCBMQ2hhciogYik7 CitpbmxpbmUgYm9vbCBvcGVyYXRvcj09KGNvbnN0IFN0cmluZ1ZpZXcmIGEsIGNvbnN0IGNoYXIq IGIpIHsgcmV0dXJuIGVxdWFsKGEsIHJlaW50ZXJwcmV0X2Nhc3Q8Y29uc3QgTENoYXIqPihiKSk7 IH0KK2lubGluZSBib29sIG9wZXJhdG9yPT0oY29uc3QgY2hhciogYSwgY29uc3QgU3RyaW5nVmll dyYgYikgeyByZXR1cm4gZXF1YWwoYiwgYSk7IH0KIAotaW5saW5lIGJvb2wgb3BlcmF0b3IhPShT dHJpbmdWaWV3IGEsIFN0cmluZ1ZpZXcgYikgeyByZXR1cm4gIWVxdWFsKGEsIGIpOyB9Ci1pbmxp bmUgYm9vbCBvcGVyYXRvciE9KFN0cmluZ1ZpZXcgYSwgY29uc3QgTENoYXIqIGIpIHsgcmV0dXJu ICFlcXVhbChhLCBiKTsgfQotaW5saW5lIGJvb2wgb3BlcmF0b3IhPShTdHJpbmdWaWV3IGEsIGNv bnN0IGNoYXIqIGIpIHsgcmV0dXJuICFlcXVhbChhLCBiKTsgfQotaW5saW5lIGJvb2wgb3BlcmF0 b3IhPShjb25zdCBMQ2hhciphLCBTdHJpbmdWaWV3IGIpIHsgcmV0dXJuICFlcXVhbChiLCBhKTsg fQotaW5saW5lIGJvb2wgb3BlcmF0b3IhPShjb25zdCBjaGFyKmEsIFN0cmluZ1ZpZXcgYikgeyBy ZXR1cm4gIWVxdWFsKGIsIGEpOyB9CitpbmxpbmUgYm9vbCBvcGVyYXRvciE9KGNvbnN0IFN0cmlu Z1ZpZXcmIGEsIGNvbnN0IFN0cmluZ1ZpZXcmIGIpIHsgcmV0dXJuICFlcXVhbChhLCBiKTsgfQor aW5saW5lIGJvb2wgb3BlcmF0b3IhPShjb25zdCBTdHJpbmdWaWV3JiBhLCBjb25zdCBMQ2hhciog YikgeyByZXR1cm4gIWVxdWFsKGEsIGIpOyB9CitpbmxpbmUgYm9vbCBvcGVyYXRvciE9KGNvbnN0 IFN0cmluZ1ZpZXcmIGEsIGNvbnN0IGNoYXIqIGIpIHsgcmV0dXJuICFlcXVhbChhLCBiKTsgfQor aW5saW5lIGJvb2wgb3BlcmF0b3IhPShjb25zdCBMQ2hhciogYSwgY29uc3QgU3RyaW5nVmlldyYg YikgeyByZXR1cm4gIWVxdWFsKGIsIGEpOyB9CitpbmxpbmUgYm9vbCBvcGVyYXRvciE9KGNvbnN0 IGNoYXIqIGEsIGNvbnN0IFN0cmluZ1ZpZXcmIGIpIHsgcmV0dXJuICFlcXVhbChiLCBhKTsgfQog CiB9CiAKQEAgLTU5Nyw3ICs1OTcsNyBAQCB0ZW1wbGF0ZTx0eXBlbmFtZSBDaGFyYWN0ZXJUeXBl LCBzaXplX3QgaW5saW5lQ2FwYWNpdHk+IHZvaWQgYXBwZW5kKFZlY3RvcjxDaGFyYQogICAgIHN0 cmluZy5nZXRDaGFyYWN0ZXJzV2l0aFVwY29udmVydChidWZmZXIuZGF0YSgpICsgb2xkU2l6ZSk7 CiB9CiAKLWlubGluZSBib29sIGVxdWFsKFN0cmluZ1ZpZXcgYSwgU3RyaW5nVmlldyBiKQoraW5s aW5lIGJvb2wgZXF1YWwoY29uc3QgU3RyaW5nVmlldyYgYSwgY29uc3QgU3RyaW5nVmlldyYgYikK IHsKICAgICBpZiAoYS5tX2NoYXJhY3RlcnMgPT0gYi5tX2NoYXJhY3RlcnMpIHsKICAgICAgICAg QVNTRVJUKGEuaXM4Qml0KCkgPT0gYi5pczhCaXQoKSk7CkBAIC02MDcsNyArNjA3LDcgQEAgaW5s aW5lIGJvb2wgZXF1YWwoU3RyaW5nVmlldyBhLCBTdHJpbmdWaWV3IGIpCiAgICAgcmV0dXJuIGVx dWFsQ29tbW9uKGEsIGIpOwogfQogCi1pbmxpbmUgYm9vbCBlcXVhbChTdHJpbmdWaWV3IGEsIGNv bnN0IExDaGFyKiBiKQoraW5saW5lIGJvb2wgZXF1YWwoY29uc3QgU3RyaW5nVmlldyYgYSwgY29u c3QgTENoYXIqIGIpCiB7CiAgICAgaWYgKCFiKQogICAgICAgICByZXR1cm4gIWEuaXNFbXB0eSgp OwpAQCAtNjIzLDEyICs2MjMsMTIgQEAgaW5saW5lIGJvb2wgZXF1YWwoU3RyaW5nVmlldyBhLCBj b25zdCBMQ2hhciogYikKICAgICByZXR1cm4gZXF1YWwoYS5jaGFyYWN0ZXJzMTYoKSwgYiwgYUxl bmd0aCk7CiB9CiAKLWlubGluZSBib29sIGVxdWFsSWdub3JpbmdBU0NJSUNhc2UoU3RyaW5nVmll dyBhLCBTdHJpbmdWaWV3IGIpCitpbmxpbmUgYm9vbCBlcXVhbElnbm9yaW5nQVNDSUlDYXNlKGNv bnN0IFN0cmluZ1ZpZXcmIGEsIGNvbnN0IFN0cmluZ1ZpZXcmIGIpCiB7CiAgICAgcmV0dXJuIGVx dWFsSWdub3JpbmdBU0NJSUNhc2VDb21tb24oYSwgYik7CiB9CiAKLWlubGluZSBib29sIGVxdWFs SWdub3JpbmdBU0NJSUNhc2UoU3RyaW5nVmlldyBhLCBjb25zdCBjaGFyKiBiKQoraW5saW5lIGJv b2wgZXF1YWxJZ25vcmluZ0FTQ0lJQ2FzZShjb25zdCBTdHJpbmdWaWV3JiBhLCBjb25zdCBjaGFy KiBiKQogewogICAgIHJldHVybiBlcXVhbElnbm9yaW5nQVNDSUlDYXNlQ29tbW9uKGEsIGIpOwog fQpAQCAtOTg5LDcgKzk4OSw3IEBAIFN0cmluZ1ZpZXcgU3RyaW5nVmlldzo6c3RyaXBMZWFkaW5n QW5kVHJhaWxpbmdNYXRjaGVkQ2hhcmFjdGVycyhjb25zdCBNYXRjaGVkQ2hhCiAgICAgcmV0dXJu IHN0cmlwTGVhZGluZ0FuZFRyYWlsaW5nTWF0Y2hlZENoYXJhY3RlcnM8VUNoYXI+KGNoYXJhY3Rl cnMxNigpLCBwcmVkaWNhdGUpOwogfQogCi10ZW1wbGF0ZTx1bnNpZ25lZCBsZW5ndGg+IGlubGlu ZSBib29sIGVxdWFsTGV0dGVyc0lnbm9yaW5nQVNDSUlDYXNlKFN0cmluZ1ZpZXcgc3RyaW5nLCBj b25zdCBjaGFyICgmbG93ZXJjYXNlTGV0dGVycylbbGVuZ3RoXSkKK3RlbXBsYXRlPHVuc2lnbmVk IGxlbmd0aD4gaW5saW5lIGJvb2wgZXF1YWxMZXR0ZXJzSWdub3JpbmdBU0NJSUNhc2UoY29uc3Qg U3RyaW5nVmlldyYgc3RyaW5nLCBjb25zdCBjaGFyICgmbG93ZXJjYXNlTGV0dGVycylbbGVuZ3Ro XSkKIHsKICAgICByZXR1cm4gZXF1YWxMZXR0ZXJzSWdub3JpbmdBU0NJSUNhc2VDb21tb24oc3Ry aW5nLCBsb3dlcmNhc2VMZXR0ZXJzKTsKIH0K