192810 2018-12-18 09:31:27 -0800 REGRESSION: [iOS] API test TestWebKitAPI._WKDownload.OriginatingWebView is a flaky failure 2018-12-18 15:59:44 -0800 1 1 1 Unclassified WebKit New Bugs Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ryanhaddad webkit-unassigned achristensen ap commit-queue david_quesada jlewis3 tsavell webkit-bug-importer oldest_to_newest 1488913 0 ryanhaddad 2018-12-18 09:31:27 -0800 The following API test appears to be a flaky failure on iOS bots: TestWebKitAPI._WKDownload.OriginatingWebView /Volumes/Data/slave/ios-simulator-12-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/Download.mm:261 Value of: !([download originatingWebView]) Actual: false Expected: true https://build.webkit.org/builders/Apple%20iOS%2012%20Simulator%20Release%20WK2%20(Tests)/builds/1607/steps/run-api-tests/logs/stdio 1488917 1 webkit-bug-importer 2018-12-18 09:38:40 -0800 <rdar://problem/46812536> 1488922 2 ryanhaddad 2018-12-18 09:47:16 -0800 It failed about 50% of the time for me locally when I ran: run-api-tests --debug --ios-simulator _WKDownload.OriginatingWebView 1489076 3 david_quesada 2018-12-18 14:39:19 -0800 When I see this fail, it doesn't appear that the originatingWebView has any remaining strong references, but is in the autorelease pool, likely as a result of handling other messages that have been sent to the UI process while the test has run. The test seems to pass (I've hit at least 20 successes in a row, compared to 3/10 successes without any changes) if I defer checking the originatingWebView to the next turn of the runloop. Patch coming up. 1489078 4 357614 david_quesada 2018-12-18 14:45:41 -0800 Created attachment 357614 Patch 1489093 5 357614 achristensen 2018-12-18 15:13:56 -0800 Comment on attachment 357614 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=357614&action=review > Tools/TestWebKitAPI/Tests/WebKitCocoa/Download.mm:260 > + WTF::callOnMainThread([retainedDownload = RetainPtr<_WKDownload> { download }] { [download = retainPtr(download)] 1489096 6 357621 david_quesada 2018-12-18 15:21:29 -0800 Created attachment 357621 Patch for landing 1489117 7 357621 commit-queue 2018-12-18 15:59:43 -0800 Comment on attachment 357621 Patch for landing Clearing flags on attachment: 357621 Committed r239359: <https://trac.webkit.org/changeset/239359> 1489118 8 commit-queue 2018-12-18 15:59:44 -0800 All reviewed patches have been landed. Closing bug. 357614 2018-12-18 14:45:41 -0800 2018-12-18 15:21:29 -0800 Patch file_192810.txt text/plain 3174 david_quesada Y29tbWl0IDU4YjZkOWE2ZGY0Njg0NzBkMGRlYjAwMjliODJkOWY5NWY5MTI4ZTgNCkF1dGhvcjog RGF2aWQgUXVlc2FkYSA8ZGF2aWRfcXVlc2FkYUBhcHBsZS5jb20+DQpEYXRlOiAgIFR1ZSBEZWMg MTggMTQ6NDQ6NDQgMjAxOCAtMDgwMA0KDQogICAgUkVHUkVTU0lPTjogW2lPU10gQVBJIHRlc3Qg VGVzdFdlYktpdEFQSS5fV0tEb3dubG9hZC5PcmlnaW5hdGluZ1dlYlZpZXcgaXMgYSBmbGFreSBm YWlsdXJlDQogICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5Mjgx MA0KICAgIDxyZGFyOi8vcHJvYmxlbS80NjgxMjUzNj4NCiAgICANCiAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4NCiAgICANCiAgICAqIFRlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0Q29j b2EvRG93bmxvYWQubW06DQogICAgKC1bT3JpZ2luYXRpbmdXZWJWaWV3RG93bmxvYWREZWxlZ2F0 ZSBfZG93bmxvYWREaWRTdGFydDpdKToNCiAgICAgICAgQWZ0ZXIgcmVsZWFzaW5nIG91ciByZWZl cmVuY2UgdG8gdGhlIHdlYiB2aWV3LCB3YWl0IHVudGlsIHRoZSBuZXh0IHR1cm4gb2YgdGhlIHJ1 bmxvb3ANCiAgICAgICAgYmVmb3JlIGNoZWNraW5nIHRoYXQgdGhlIG9yaWdpbmF0aW5nV2ViVmll dyBoYXMgYmVlbiB6ZXJvZWQsIHNpbmNlIHRoZSB3ZWIgdmlldyBtaWdodA0KICAgICAgICBzdGls bCBiZSByZWZlcmVuY2VkIGluIHRoZSBhdXRvcmVsZWFzZSBwb29sLiBUaGlzIF9XS0Rvd25sb2Fk IHVuaXQgdGVzdCBpc24ndCBhYm91dA0KICAgICAgICB0ZXN0aW5nIGdlbmVyYWwgbWVtb3J5IG1h bmFnZW1lbnQgb2YgV0tXZWJWaWV3cywgb25seSB0aGF0IF9XS0Rvd25sb2FkIGRvZXMgbm90IHJl dGFpbg0KICAgICAgICBpdHMgd2ViIHZpZXcgdmlhIHRoZSAnb3JpZ2luYXRpbmdXZWJWaWV3JyBw cm9wZXJ0eS4NCg0KZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxv Zw0KaW5kZXggY2Y1YTZhZjFjNWUuLjk2YzgyOTQ1OGJhIDEwMDY0NA0KLS0tIGEvVG9vbHMvQ2hh bmdlTG9nDQorKysgYi9Ub29scy9DaGFuZ2VMb2cNCkBAIC0xLDMgKzEsMTkgQEANCisyMDE4LTEy LTE4ICBEYXZpZCBRdWVzYWRhICA8ZGF2aWRfcXVlc2FkYUBhcHBsZS5jb20+DQorDQorICAgICAg ICBSRUdSRVNTSU9OOiBbaU9TXSBBUEkgdGVzdCBUZXN0V2ViS2l0QVBJLl9XS0Rvd25sb2FkLk9y aWdpbmF0aW5nV2ViVmlldyBpcyBhIGZsYWt5IGZhaWx1cmUNCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTI4MTANCisgICAgICAgIDxyZGFyOi8vcHJv YmxlbS80NjgxMjUzNj4NCisNCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLg0K Kw0KKyAgICAgICAgKiBUZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdENvY29hL0Rvd25sb2FkLm1t Og0KKyAgICAgICAgKC1bT3JpZ2luYXRpbmdXZWJWaWV3RG93bmxvYWREZWxlZ2F0ZSBfZG93bmxv YWREaWRTdGFydDpdKToNCisgICAgICAgICAgICBBZnRlciByZWxlYXNpbmcgb3VyIHJlZmVyZW5j ZSB0byB0aGUgd2ViIHZpZXcsIHdhaXQgdW50aWwgdGhlIG5leHQgdHVybiBvZiB0aGUgcnVubG9v cA0KKyAgICAgICAgICAgIGJlZm9yZSBjaGVja2luZyB0aGF0IHRoZSBvcmlnaW5hdGluZ1dlYlZp ZXcgaGFzIGJlZW4gemVyb2VkLCBzaW5jZSB0aGUgd2ViIHZpZXcgbWlnaHQNCisgICAgICAgICAg ICBzdGlsbCBiZSByZWZlcmVuY2VkIGluIHRoZSBhdXRvcmVsZWFzZSBwb29sLiBUaGlzIF9XS0Rv d25sb2FkIHVuaXQgdGVzdCBpc24ndCBhYm91dA0KKyAgICAgICAgICAgIHRlc3RpbmcgZ2VuZXJh bCBtZW1vcnkgbWFuYWdlbWVudCBvZiBXS1dlYlZpZXdzLCBvbmx5IHRoYXQgX1dLRG93bmxvYWQg ZG9lcyBub3QgcmV0YWluDQorICAgICAgICAgICAgaXRzIHdlYiB2aWV3IHZpYSB0aGUgJ29yaWdp bmF0aW5nV2ViVmlldycgcHJvcGVydHkuDQorDQogMjAxOC0xMi0xOCAgSm9uYXRoYW4gQmVkYXJk ICA8amJlZGFyZEBhcHBsZS5jb20+DQogDQogICAgICAgICB3ZWJraXRweTogSWdub3JlIGRldmlj ZSB0eXBlIGZvciB0ZXN0IHdoZW4gdXNpbmcgLS1mb3JjZQ0KZGlmZiAtLWdpdCBhL1Rvb2xzL1Rl c3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0Q29jb2EvRG93bmxvYWQubW0gYi9Ub29scy9UZXN0V2Vi S2l0QVBJL1Rlc3RzL1dlYktpdENvY29hL0Rvd25sb2FkLm1tDQppbmRleCBkYWUwZDI3MTBjOC4u ODA2ODkzM2JkZDAgMTAwNjQ0DQotLS0gYS9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktp dENvY29hL0Rvd25sb2FkLm1tDQorKysgYi9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktp dENvY29hL0Rvd25sb2FkLm1tDQpAQCAtNDEsNiArNDEsNyBAQA0KICNpbXBvcnQgPFdlYktpdC9X S1VJRGVsZWdhdGVQcml2YXRlLmg+DQogI2ltcG9ydCA8V2ViS2l0L1dLV2ViVmlldy5oPg0KICNp bXBvcnQgPFdlYktpdC9XS1dlYlZpZXdDb25maWd1cmF0aW9uLmg+DQorI2ltcG9ydCA8d3RmL01h aW5UaHJlYWQuaD4NCiAjaW1wb3J0IDx3dGYvUmV0YWluUHRyLmg+DQogI2ltcG9ydCA8d3RmL3Rl eHQvV1RGU3RyaW5nLmg+DQogDQpAQCAtMjUzLDEzICsyNTQsMTMgQEAgLSAoaW5zdGFuY2V0eXBl KWluaXRXaXRoV2ViVmlldzooV0tXZWJWaWV3ICopd2ViVmlldw0KIA0KIC0gKHZvaWQpX2Rvd25s b2FkRGlkU3RhcnQ6KF9XS0Rvd25sb2FkICopZG93bmxvYWQNCiB7DQotICAgIEBhdXRvcmVsZWFz ZXBvb2wgew0KLSAgICAgICAgRVhQRUNUX0VRKFtkb3dubG9hZCBvcmlnaW5hdGluZ1dlYlZpZXdd LCBfd2ViVmlldyk7DQotICAgIH0NCi0NCisgICAgRVhQRUNUX0VRKFtkb3dubG9hZCBvcmlnaW5h dGluZ1dlYlZpZXddLCBfd2ViVmlldyk7DQogICAgIF93ZWJWaWV3ID0gbnVsbHB0cjsNCi0gICAg RVhQRUNUX05VTEwoW2Rvd25sb2FkIG9yaWdpbmF0aW5nV2ViVmlld10pOw0KLSAgICBpc0RvbmUg PSB0cnVlOw0KKw0KKyAgICBXVEY6OmNhbGxPbk1haW5UaHJlYWQoW3JldGFpbmVkRG93bmxvYWQg PSBSZXRhaW5QdHI8X1dLRG93bmxvYWQ+IHsgZG93bmxvYWQgfV0gew0KKyAgICAgICAgRVhQRUNU X05VTEwoW3JldGFpbmVkRG93bmxvYWQgb3JpZ2luYXRpbmdXZWJWaWV3XSk7DQorICAgICAgICBp c0RvbmUgPSB0cnVlOw0KKyAgICB9KTsNCiB9DQogDQogQGVuZA0K 357621 2018-12-18 15:21:29 -0800 2018-12-18 15:59:43 -0800 Patch for landing file_192810.txt text/plain 3146 david_quesada Y29tbWl0IGU3MjkzODcwZWE0OWNhN2E4ZTA4ZWM2M2ZiNDY3NjE2YzRlZmY0NzcNCkF1dGhvcjog RGF2aWQgUXVlc2FkYSA8ZGF2aWRfcXVlc2FkYUBhcHBsZS5jb20+DQpEYXRlOiAgIFR1ZSBEZWMg MTggMTU6MjA6MzkgMjAxOCAtMDgwMA0KDQogICAgUkVHUkVTU0lPTjogW2lPU10gQVBJIHRlc3Qg VGVzdFdlYktpdEFQSS5fV0tEb3dubG9hZC5PcmlnaW5hdGluZ1dlYlZpZXcgaXMgYSBmbGFreSBm YWlsdXJlDQogICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5Mjgx MA0KICAgIDxyZGFyOi8vcHJvYmxlbS80NjgxMjUzNj4NCiAgICANCiAgICBSZXZpZXdlZCBieSBB bGV4IENocmlzdGVuc2VuLg0KICAgIA0KICAgICogVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRD b2NvYS9Eb3dubG9hZC5tbToNCiAgICAoLVtPcmlnaW5hdGluZ1dlYlZpZXdEb3dubG9hZERlbGVn YXRlIF9kb3dubG9hZERpZFN0YXJ0Ol0pOg0KICAgICAgICBBZnRlciByZWxlYXNpbmcgb3VyIHJl ZmVyZW5jZSB0byB0aGUgd2ViIHZpZXcsIHdhaXQgdW50aWwgdGhlIG5leHQgdHVybiBvZiB0aGUg cnVubG9vcA0KICAgICAgICBiZWZvcmUgY2hlY2tpbmcgdGhhdCB0aGUgb3JpZ2luYXRpbmdXZWJW aWV3IGhhcyBiZWVuIHplcm9lZCwgc2luY2UgdGhlIHdlYiB2aWV3IG1pZ2h0DQogICAgICAgIHN0 aWxsIGJlIHJlZmVyZW5jZWQgaW4gdGhlIGF1dG9yZWxlYXNlIHBvb2wuIFRoaXMgX1dLRG93bmxv YWQgdW5pdCB0ZXN0IGlzbid0IGFib3V0DQogICAgICAgIHRlc3RpbmcgZ2VuZXJhbCBtZW1vcnkg bWFuYWdlbWVudCBvZiBXS1dlYlZpZXdzLCBvbmx5IHRoYXQgX1dLRG93bmxvYWQgZG9lcyBub3Qg cmV0YWluDQogICAgICAgIGl0cyB3ZWIgdmlldyB2aWEgdGhlICdvcmlnaW5hdGluZ1dlYlZpZXcn IHByb3BlcnR5Lg0KDQpkaWZmIC0tZ2l0IGEvVG9vbHMvQ2hhbmdlTG9nIGIvVG9vbHMvQ2hhbmdl TG9nDQppbmRleCBjZjVhNmFmMWM1ZS4uYTZmY2FhNjQ1MDUgMTAwNjQ0DQotLS0gYS9Ub29scy9D aGFuZ2VMb2cNCisrKyBiL1Rvb2xzL0NoYW5nZUxvZw0KQEAgLTEsMyArMSwxOSBAQA0KKzIwMTgt MTItMTggIERhdmlkIFF1ZXNhZGEgIDxkYXZpZF9xdWVzYWRhQGFwcGxlLmNvbT4NCisNCisgICAg ICAgIFJFR1JFU1NJT046IFtpT1NdIEFQSSB0ZXN0IFRlc3RXZWJLaXRBUEkuX1dLRG93bmxvYWQu T3JpZ2luYXRpbmdXZWJWaWV3IGlzIGEgZmxha3kgZmFpbHVyZQ0KKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5MjgxMA0KKyAgICAgICAgPHJkYXI6Ly9w cm9ibGVtLzQ2ODEyNTM2Pg0KKw0KKyAgICAgICAgUmV2aWV3ZWQgYnkgQWxleCBDaHJpc3RlbnNl bi4NCisNCisgICAgICAgICogVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRDb2NvYS9Eb3dubG9h ZC5tbToNCisgICAgICAgICgtW09yaWdpbmF0aW5nV2ViVmlld0Rvd25sb2FkRGVsZWdhdGUgX2Rv d25sb2FkRGlkU3RhcnQ6XSk6DQorICAgICAgICAgICAgQWZ0ZXIgcmVsZWFzaW5nIG91ciByZWZl cmVuY2UgdG8gdGhlIHdlYiB2aWV3LCB3YWl0IHVudGlsIHRoZSBuZXh0IHR1cm4gb2YgdGhlIHJ1 bmxvb3ANCisgICAgICAgICAgICBiZWZvcmUgY2hlY2tpbmcgdGhhdCB0aGUgb3JpZ2luYXRpbmdX ZWJWaWV3IGhhcyBiZWVuIHplcm9lZCwgc2luY2UgdGhlIHdlYiB2aWV3IG1pZ2h0DQorICAgICAg ICAgICAgc3RpbGwgYmUgcmVmZXJlbmNlZCBpbiB0aGUgYXV0b3JlbGVhc2UgcG9vbC4gVGhpcyBf V0tEb3dubG9hZCB1bml0IHRlc3QgaXNuJ3QgYWJvdXQNCisgICAgICAgICAgICB0ZXN0aW5nIGdl bmVyYWwgbWVtb3J5IG1hbmFnZW1lbnQgb2YgV0tXZWJWaWV3cywgb25seSB0aGF0IF9XS0Rvd25s b2FkIGRvZXMgbm90IHJldGFpbg0KKyAgICAgICAgICAgIGl0cyB3ZWIgdmlldyB2aWEgdGhlICdv cmlnaW5hdGluZ1dlYlZpZXcnIHByb3BlcnR5Lg0KKw0KIDIwMTgtMTItMTggIEpvbmF0aGFuIEJl ZGFyZCAgPGpiZWRhcmRAYXBwbGUuY29tPg0KIA0KICAgICAgICAgd2Via2l0cHk6IElnbm9yZSBk ZXZpY2UgdHlwZSBmb3IgdGVzdCB3aGVuIHVzaW5nIC0tZm9yY2UNCmRpZmYgLS1naXQgYS9Ub29s cy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdENvY29hL0Rvd25sb2FkLm1tIGIvVG9vbHMvVGVz dFdlYktpdEFQSS9UZXN0cy9XZWJLaXRDb2NvYS9Eb3dubG9hZC5tbQ0KaW5kZXggZGFlMGQyNzEw YzguLjIxYjM1Y2UxYzg2IDEwMDY0NA0KLS0tIGEvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9X ZWJLaXRDb2NvYS9Eb3dubG9hZC5tbQ0KKysrIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9X ZWJLaXRDb2NvYS9Eb3dubG9hZC5tbQ0KQEAgLTQxLDYgKzQxLDcgQEANCiAjaW1wb3J0IDxXZWJL aXQvV0tVSURlbGVnYXRlUHJpdmF0ZS5oPg0KICNpbXBvcnQgPFdlYktpdC9XS1dlYlZpZXcuaD4N CiAjaW1wb3J0IDxXZWJLaXQvV0tXZWJWaWV3Q29uZmlndXJhdGlvbi5oPg0KKyNpbXBvcnQgPHd0 Zi9NYWluVGhyZWFkLmg+DQogI2ltcG9ydCA8d3RmL1JldGFpblB0ci5oPg0KICNpbXBvcnQgPHd0 Zi90ZXh0L1dURlN0cmluZy5oPg0KIA0KQEAgLTI1MywxMyArMjU0LDEzIEBAIC0gKGluc3RhbmNl dHlwZSlpbml0V2l0aFdlYlZpZXc6KFdLV2ViVmlldyAqKXdlYlZpZXcNCiANCiAtICh2b2lkKV9k b3dubG9hZERpZFN0YXJ0OihfV0tEb3dubG9hZCAqKWRvd25sb2FkDQogew0KLSAgICBAYXV0b3Jl bGVhc2Vwb29sIHsNCi0gICAgICAgIEVYUEVDVF9FUShbZG93bmxvYWQgb3JpZ2luYXRpbmdXZWJW aWV3XSwgX3dlYlZpZXcpOw0KLSAgICB9DQotDQorICAgIEVYUEVDVF9FUShbZG93bmxvYWQgb3Jp Z2luYXRpbmdXZWJWaWV3XSwgX3dlYlZpZXcpOw0KICAgICBfd2ViVmlldyA9IG51bGxwdHI7DQot ICAgIEVYUEVDVF9OVUxMKFtkb3dubG9hZCBvcmlnaW5hdGluZ1dlYlZpZXddKTsNCi0gICAgaXNE b25lID0gdHJ1ZTsNCisNCisgICAgV1RGOjpjYWxsT25NYWluVGhyZWFkKFtkb3dubG9hZCA9IHJl dGFpblB0cihkb3dubG9hZCldIHsNCisgICAgICAgIEVYUEVDVF9OVUxMKFtkb3dubG9hZCBvcmln aW5hdGluZ1dlYlZpZXddKTsNCisgICAgICAgIGlzRG9uZSA9IHRydWU7DQorICAgIH0pOw0KIH0N CiANCiBAZW5kDQo=