192809 2018-12-18 09:24:18 -0800 WKWebView default UA doesn't freeze the build number 2018-12-20 10:27:56 -0800 1 1 1 Unclassified WebKit WebKit API WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 180365 182629 1 bfulgham bfulgham achristensen aestes bfulgham cdumez commit-queue ddkilzer jiewen_tan joepeck rniwa oldest_to_newest 1488911 0 bfulgham 2018-12-18 09:24:18 -0800 We noticed that we get the following default UA from a WKWebView on iOS using a sample app in the iPhone 6 simulator: Mozilla/5.0 (iPhone; CPU iPhone OS 12_1 like Mac OS X) AppleWebKit/605.1.15 (KHTML, like Gecko) Mobile/16A342 The default WKWebView UA should have a frozen OS build number, as we do in Safari. Mobile/16A342 -> Mobile/15E148. 1488914 1 bfulgham 2018-12-18 09:35:26 -0800 <rdar://problem/44687185> 1488918 2 357572 bfulgham 2018-12-18 09:38:59 -0800 Created attachment 357572 Patch 1488957 3 357572 jiewen_tan 2018-12-18 11:05:41 -0800 Comment on attachment 357572 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=357572&action=review > Source/WebKitLegacy/mac/WebView/WebView.mm:1159 > - (void)_setBrowserUserAgentProductVersion:(NSString *)productVersion buildVersion:(NSString *)buildVersion bundleVersion:(NSString *)bundleVersion Wonder if we should add some explanations in the header such that callers will be aware of this change? 1489164 4 bfulgham 2018-12-18 18:04:54 -0800 (In reply to Jiewen Tan from comment #3) > Comment on attachment 357572 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=357572&action=review > > > Source/WebKitLegacy/mac/WebView/WebView.mm:1159 > > - (void)_setBrowserUserAgentProductVersion:(NSString *)productVersion buildVersion:(NSString *)buildVersion bundleVersion:(NSString *)bundleVersion > > Wonder if we should add some explanations in the header such that callers > will be aware of this change? Probably not -- this is SPI, so no one should be using it. 1489922 5 357572 commit-queue 2018-12-20 10:27:54 -0800 Comment on attachment 357572 Patch Clearing flags on attachment: 357572 Committed r239451: <https://trac.webkit.org/changeset/239451> 1489923 6 commit-queue 2018-12-20 10:27:56 -0800 All reviewed patches have been landed. Closing bug. 357572 2018-12-18 09:38:59 -0800 2018-12-20 10:27:54 -0800 Patch bug-192809-20181218093858.patch text/plain 3781 bfulgham U3VidmVyc2lvbiBSZXZpc2lvbjogMjM5MjEwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDAxMDlmMWE0OGIwZjk5OTY2 NmY4Mjg2ZjRmM2JhMDY1ODYyZWMzYzEuLjY0ZTgxYjE1MDdkZjg2YzNlZjliOTY3NDc5MGFjMzFj MTRmY2RiNWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTgtMTItMTggIEJyZW50IEZ1 bGdoYW0gIDxiZnVsZ2hhbUBhcHBsZS5jb20+CisKKyAgICAgICAgV0tXZWJWaWV3IGRlZmF1bHQg VUEgZG9lc24ndCBmcmVlemUgdGhlIGJ1aWxkIG51bWJlcgorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTkyODA5CisgICAgICAgIDxyZGFyOi8vcHJvYmxl bS80NDY4NzE4NT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBBbHdheXMgcmVwb3J0cyB0aGUgZnJvemVuIGJ1aWxkIG51bWJlci4KKworICAgICAgICAq IFVJUHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJWaWV3Q29uZmlndXJhdGlvbi5tbToKKyAgICAgICAg KGRlZmF1bHRBcHBsaWNhdGlvbk5hbWVGb3JVc2VyQWdlbnQpOiBEbyBub3QgZXhwb3NlIHRoZSBh Y3R1YWwgYnVpbGQgbnVtYmVyIHRocm91Z2ggdGhpcyBBUEkuCisKIDIwMTgtMTItMTQgIENocmlz IER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KIAogICAgICAgICBbUFNPTl0gV2Vic2l0ZVBvbGlj aWVzIGFyZSBsb3N0IG9uIHByb2Nlc3Mtc3dhcApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdExl Z2FjeS9tYWMvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdExlZ2FjeS9tYWMvQ2hhbmdlTG9nCmlu ZGV4IDM1NzAyNTk4NjE0MzhkZmFmNTQwODgyYzI2M2M5OTQ1YjEwOTllYTYuLmM2NzQxYTZhY2Q0 Y2MzYjZkMWYwNzU2M2Y5NzUxNzliOTY5YjBjMTAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXRM ZWdhY3kvbWFjL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0TGVnYWN5L21hYy9DaGFuZ2VM b2cKQEAgLTEsMyArMSwxOCBAQAorMjAxOC0xMi0xOCAgQnJlbnQgRnVsZ2hhbSAgPGJmdWxnaGFt QGFwcGxlLmNvbT4KKworICAgICAgICBXS1dlYlZpZXcgZGVmYXVsdCBVQSBkb2Vzbid0IGZyZWV6 ZSB0aGUgYnVpbGQgbnVtYmVyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xOTI4MDkKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzQ0Njg3MTg1PgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFsd2F5cyByZXBv cnRzIHRoZSBmcm96ZW4gYnVpbGQgbnVtYmVyLgorCisgICAgICAgICogV2ViVmlldy9XZWJWaWV3 Lm1tOgorICAgICAgICAoLVtXZWJWaWV3IF9zZXRCcm93c2VyVXNlckFnZW50UHJvZHVjdFZlcnNp b246YnVpbGRWZXJzaW9uOmJ1bmRsZVZlcnNpb246XSk6IERvIG5vdCByZXBvcnQgdGhlCisgICAg ICAgIGFjdHVhbCBidWlsZCBudW1iZXIgdGhyb3VnaCB0aGlzIG1ldGhvZCBjYWxsLgorICAgICAg ICAoLVtXZWJWaWV3IF9zZXRVSVdlYlZpZXdVc2VyQWdlbnRXaXRoQnVpbGRWZXJzaW9uOl0pOiBE aXR0by4KKwogMjAxOC0xMi0xMiAgUnlvc3VrZSBOaXdhICA8cm5pd2FAd2Via2l0Lm9yZz4KIAog ICAgICAgICBNYWtlIFRleHRJbnB1dENvbnRyb2xsZXIubGVnYWN5QXR0cmlidXRlZFN0cmluZyB0 YWtlIERPTSBub2RlcyBhbmQgb2Zmc2V0cwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVBy b2Nlc3MvQVBJL0NvY29hL1dLV2ViVmlld0NvbmZpZ3VyYXRpb24ubW0gYi9Tb3VyY2UvV2ViS2l0 L1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJWaWV3Q29uZmlndXJhdGlvbi5tbQppbmRleCBkMjg3 ZmQ5NWJkYzc5YmM5NDg2YzNlZDRmODM2ZTZlYzAwMzIwM2VjLi4zOGM5MWE0ZDJjMGZlMGI1NjNk OGYxZWY4MWE0ZjBlMWM2NDRkOTJiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vz cy9BUEkvQ29jb2EvV0tXZWJWaWV3Q29uZmlndXJhdGlvbi5tbQorKysgYi9Tb3VyY2UvV2ViS2l0 L1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJWaWV3Q29uZmlndXJhdGlvbi5tbQpAQCAtNDU2LDcg KzQ1Niw3IEBAIC0gKHZvaWQpc2V0V2Vic2l0ZURhdGFTdG9yZTooV0tXZWJzaXRlRGF0YVN0b3Jl ICopd2Vic2l0ZURhdGFTdG9yZQogc3RhdGljIE5TU3RyaW5nICpkZWZhdWx0QXBwbGljYXRpb25O YW1lRm9yVXNlckFnZW50KCkKIHsKICNpZiBQTEFURk9STShJT1NfRkFNSUxZKQotICAgIHJldHVy biBbQCJNb2JpbGUvIiBzdHJpbmdCeUFwcGVuZGluZ1N0cmluZzpbVUlEZXZpY2UgY3VycmVudERl dmljZV0uYnVpbGRWZXJzaW9uXTsKKyAgICByZXR1cm4gQCJNb2JpbGUvMTVFMTQ4IjsKICNlbHNl CiAgICAgcmV0dXJuIG5pbDsKICNlbmRpZgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdExlZ2Fj eS9tYWMvV2ViVmlldy9XZWJWaWV3Lm1tIGIvU291cmNlL1dlYktpdExlZ2FjeS9tYWMvV2ViVmll dy9XZWJWaWV3Lm1tCmluZGV4IDVlYjk1NzUyODJjMWI2NTNkY2JjOWFhNmE0N2VkNzBjMDVlN2Q1 ZWYuLjAxMTBiYmQ2MTYyNWI1NGNjYzUwNjljNTc5YjAyYjAwNjVkNGE3NjggMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJLaXRMZWdhY3kvbWFjL1dlYlZpZXcvV2ViVmlldy5tbQorKysgYi9Tb3VyY2Uv V2ViS2l0TGVnYWN5L21hYy9XZWJWaWV3L1dlYlZpZXcubW0KQEAgLTExNTgsMTIgKzExNTgsMTUg QEAgKyAoTlNTdHJpbmcgKilfc3RhbmRhcmRVc2VyQWdlbnRXaXRoQXBwbGljYXRpb25OYW1lOihO U1N0cmluZyAqKWFwcGxpY2F0aW9uTmFtZQogI2lmIFBMQVRGT1JNKElPU19GQU1JTFkpCiAtICh2 b2lkKV9zZXRCcm93c2VyVXNlckFnZW50UHJvZHVjdFZlcnNpb246KE5TU3RyaW5nICopcHJvZHVj dFZlcnNpb24gYnVpbGRWZXJzaW9uOihOU1N0cmluZyAqKWJ1aWxkVmVyc2lvbiBidW5kbGVWZXJz aW9uOihOU1N0cmluZyAqKWJ1bmRsZVZlcnNpb24KIHsKLSAgICBbc2VsZiBzZXRBcHBsaWNhdGlv bk5hbWVGb3JVc2VyQWdlbnQ6W05TU3RyaW5nIHN0cmluZ1dpdGhGb3JtYXQ6QCJWZXJzaW9uLyVA IE1vYmlsZS8lQCBTYWZhcmkvJUAiLCBwcm9kdWN0VmVyc2lvbiwgYnVpbGRWZXJzaW9uLCBidW5k bGVWZXJzaW9uXV07CisgICAgLy8gVGhlIHdlYi12aXNpYmxlIGJ1aWxkIGFuZCBidW5kbGUgdmVy c2lvbnMgYXJlIGZyb3plbiB0byByZW1vdmUgYSBmaW5nZXJwcmludGluZyBzdXJmYWNlCisgICAg VU5VU0VEX1BBUkFNKGJ1aWxkVmVyc2lvbik7CisgICAgW3NlbGYgc2V0QXBwbGljYXRpb25OYW1l Rm9yVXNlckFnZW50OltOU1N0cmluZyBzdHJpbmdXaXRoRm9ybWF0OkAiVmVyc2lvbi8lQCBNb2Jp bGUvMTVFMTQ4IFNhZmFyaS8lQCIsIHByb2R1Y3RWZXJzaW9uLCBidW5kbGVWZXJzaW9uXV07CiB9 CiAKIC0gKHZvaWQpX3NldFVJV2ViVmlld1VzZXJBZ2VudFdpdGhCdWlsZFZlcnNpb246KE5TU3Ry aW5nICopYnVpbGRWZXJzaW9uCiB7Ci0gICAgW3NlbGYgc2V0QXBwbGljYXRpb25OYW1lRm9yVXNl ckFnZW50OltAIk1vYmlsZS8iIHN0cmluZ0J5QXBwZW5kaW5nU3RyaW5nOmJ1aWxkVmVyc2lvbl1d OworICAgIFVOVVNFRF9QQVJBTShidWlsZFZlcnNpb24pOworICAgIFtzZWxmIHNldEFwcGxpY2F0 aW9uTmFtZUZvclVzZXJBZ2VudDpAIk1vYmlsZS8xNUUxNDgiXTsKIH0KICNlbmRpZiAvLyBQTEFU Rk9STShJT1NfRkFNSUxZKQogCg==