192805 2018-12-17 22:59:38 -0800 [Win] Fix the wrong return value checking of ScriptItemize in UniscribeController::itemizeShapeAndPlace 2020-02-11 19:56:52 -0800 1 1 1 Unclassified WebKit Platform WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=137526 P2 Normal --- 1 fujii fujii achristensen bfulgham don.olmstead koivisto mitz pvollan ross.kirsling oldest_to_newest 1488810 0 fujii 2018-12-17 22:59:38 -0800 [Win] Fix the wrong return value checking of ScriptItemize in UniscribeController::itemizeShapeAndPlace UniscribeController::itemizeShapeAndPlace has the following code. > while (rc = ::ScriptItemize(cp, length, m_items.size() - 1, &m_control, &m_state, m_items.data(), &numItems) == E_OUTOFMEMORY) { > m_items.resize(m_items.size() * 2); > resetControlAndState(); > } > if (FAILED(rc)) { > WTFLogAlways("UniscribeController::itemizeShapeAndPlace: ScriptItemize failed, rc=%lx", rc); > return; > } > rc is aligned 0 or 1, and checked by FAILED(rc). '==' has higher operator precedence than '='. It is interpreted as: > rc = (::ScriptItemize(...) == E_OUTOFMEMORY) https://en.cppreference.com/w/cpp/language/operator_precedence This code has been introduced in Bug 137526. 1488816 1 fujii 2018-12-17 23:09:17 -0800 FAILED macro | Microsoft Docs https://docs.microsoft.com/en-us/windows/desktop/api/winerror/nf-winerror-failed > #define FAILED(hr) (((HRESULT)(hr)) < 0) FAILED(rc) is always false. ScriptItemize function | Microsoft Docs https://docs.microsoft.com/en-us/windows/desktop/api/usp10/nf-usp10-scriptitemize > The function returns E_INVALIDARG if pwcInChars is set to NULL, cInChars is 0, pItems is set to NULL, or cMaxItems < 2. If I understand the code correctly, ScriptItemize never returns E_INVALIDARG in above code. There is no way to test. 1488820 2 357542 fujii 2018-12-17 23:24:43 -0800 Created attachment 357542 Patch 1488909 3 357542 achristensen 2018-12-18 09:19:02 -0800 Comment on attachment 357542 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=357542&action=review The change seems ok. The log seems problematic. > Source/WebCore/ChangeLog:22 > + Fortunately, as far as I understand the code, there is not an > + actual problem, and no way to test the coding error. If this is true we should just remove all this code. > Source/WebCore/ChangeLog:24 > + No new tests, no behavior changes. There is a behavior change. 1489226 4 fujii 2018-12-18 22:57:39 -0800 Do you mean the ScriptItemize can return E_INVALIDARG in the code? The code has been introduced to resolve static analyzer warnings in Bug 137526. I guess the resolve static analyzer was not smart enough to know ScriptItemize never return E_INVALIDARG in the condition. I guess the resolve static analyzer simply reported E_INVALIDARG is not handled. 1489228 5 fujii 2018-12-18 22:59:02 -0800 s/the resolve static analyzer/the static analyzer/ 1489232 6 fujii 2018-12-18 23:13:49 -0800 I think the following condition never be true because ScriptItemize never return E_INVALIDARG in the code. > if (FAILED(rc)) { > WTFLogAlways("UniscribeController::itemizeShapeAndPlace: ScriptItemize failed, rc=%lx", rc); > return; > } But, if I remove the above code, the varialbe 'rc' become unsued. Then, I need to remove all 'rc'. the static analyzer ends up reporting the warning again. 1490887 7 fujii 2018-12-26 23:41:59 -0800 (In reply to Fujii Hironori from comment #6) > I think the following condition never be true because ScriptItemize never > return E_INVALIDARG in the code. > > > if (FAILED(rc)) { > > WTFLogAlways("UniscribeController::itemizeShapeAndPlace: ScriptItemize failed, rc=%lx", rc); > > return; > > } > > But, if I remove the above code, the varialbe 'rc' become unsued. Then, I > need to remove all 'rc'. > the static analyzer ends up reporting the warning again. I'm able to remove the condition by using ASSERT_UNUSED macro. > ASSERT_UNUSED(rc, SUCCEEDED(rc)); // ScriptItemize never returns E_INVALIDARG. The benefit of this approach is there would be no behavior change even if ScriptItemize returns E_INVALIDARG in Release build. 1490888 8 358103 fujii 2018-12-27 00:22:01 -0800 Created attachment 358103 Patch 1490889 9 358104 fujii 2018-12-27 00:24:05 -0800 Created attachment 358104 Patch 1492187 10 fujii 2019-01-06 19:40:12 -0800 Review, please. 1492269 11 358104 bfulgham 2019-01-07 08:51:53 -0800 Comment on attachment 358104 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=358104&action=review > Source/WebCore/platform/graphics/win/UniscribeController.cpp:203 > + ASSERT_UNUSED(rc, SUCCEEDED(rc)); // ScriptItemize must not return E_INVALIDARG in this code. I'm afraid I don't understand the benefit of this change. I know that you found MSDN documentation that claims that ScriptItemize returns E_INVALIDARG in some cases, and is silent about other error conditions. But I don't think that's sufficient evidence to assume that ScriptItemize will never return some other error value (or might be modified in the future to do so). Why not leave this error check in place? 1492523 12 fujii 2019-01-07 18:39:11 -0800 Thank you for the feedback. Do you prefer the first patch? I have no preference to both approaches. I removed the error checking based on Alex's feedback (Comment 3). 1606258 13 fujii 2020-01-13 22:49:11 -0800 I removed the code in r254323. Closed. 357542 2018-12-17 23:24:43 -0800 2019-01-07 18:25:58 -0800 Patch bug-192805-20181218162442.patch text/plain 2430 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjM5MzIwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjVhNWQ3MTgyZDA3YWZi YjExYzAwZjE2MjcxZGVhOThjMzJhNGQ0Ni4uMzg0YjhlMmIyMmYzOTRjYjJjYjk5OTU1NmE3YTAy ZTRiNGZkZmJkNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDMxIEBACisyMDE4LTEyLTE3ICBGdWpp aSBIaXJvbm9yaSAgPEhpcm9ub3JpLkZ1amlpQHNvbnkuY29tPgorCisgICAgICAgIFtXaW5dIEZp eCB0aGUgd3JvbmcgcmV0dXJuIHZhbHVlIGNoZWNraW5nIG9mIFNjcmlwdEl0ZW1pemUgaW4gVW5p c2NyaWJlQ29udHJvbGxlcjo6aXRlbWl6ZVNoYXBlQW5kUGxhY2UKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5MjgwNQorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFVuaXNjcmliZUNvbnRyb2xsZXI6Oml0ZW1p emVTaGFwZUFuZFBsYWNlIGhhcyBhIGVycm9yIGNoZWNrIGZvcgorICAgICAgICB0aGUgcmV0dXJu IHZhbHVlIG9mIFNjcmlwdEl0ZW1pemUuIEJ1dCwgaXQgZGlkbid0IGFjdHVhbGx5IGNoZWNrCisg ICAgICAgIHRoZSByZXR1cm4gdmFsdWUuCisKKyAgICAgICAgVGhlIGVxdWFsIGNvbXBhcmlzb24g Jz09JyBoYXMgaGlnaGVyIG9wZXJhdG9yIHByZWNlZGVuY2UgdGhhbiB0aGUKKyAgICAgICAgYXNz aWdubWVudCAnPScuCisKKyAgICAgICAgMS4gcmMgPSA6OlNjcmlwdEl0ZW1pemUoLi4uKSA9PSBF X09VVE9GTUVNT1JZCisgICAgICAgIDIuIHJjID0gKDo6U2NyaXB0SXRlbWl6ZSguLi4pID09IEVf T1VUT0ZNRU1PUlkpCisgICAgICAgIDMuIChyYyA9IDo6U2NyaXB0SXRlbWl6ZSguLi4pKSA9PSBF X09VVE9GTUVNT1JZCisKKyAgICAgICAgVGh1cywgdGhlIGV4cHJlc3Npb24gIzEgaXMgc2FtZSB3 aXRoICMyLCBub3QgIzMuCisKKyAgICAgICAgRm9ydHVuYXRlbHksIGFzIGZhciBhcyBJIHVuZGVy c3RhbmQgdGhlIGNvZGUsIHRoZXJlIGlzIG5vdCBhbgorICAgICAgICBhY3R1YWwgcHJvYmxlbSwg YW5kIG5vIHdheSB0byB0ZXN0IHRoZSBjb2RpbmcgZXJyb3IuCisKKyAgICAgICAgTm8gbmV3IHRl c3RzLCBubyBiZWhhdmlvciBjaGFuZ2VzLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3Mv d2luL1VuaXNjcmliZUNvbnRyb2xsZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6VW5pc2NyaWJl Q29udHJvbGxlcjo6aXRlbWl6ZVNoYXBlQW5kUGxhY2UpOiBVc2UgcGFyZW50aGVzZXMgdG8gYXNz aWduICdyYycgdGhlIHJldHVybiBjb2RlLgorCiAyMDE4LTEyLTE3ICBGdWppaSBIaXJvbm9yaSAg PEhpcm9ub3JpLkZ1amlpQHNvbnkuY29tPgogCiAgICAgICAgIFtXaW5dW0NsYW5nXSBGaXggY29t cGlsYXRpb24gd2FybmluZ3MgV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcyBkaXJlY3RvcnkKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3dpbi9VbmlzY3JpYmVD b250cm9sbGVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3dpbi9Vbmlz Y3JpYmVDb250cm9sbGVyLmNwcAppbmRleCBmZjM3YWM1NmVjMTY4MjVlNjU2MzVjYTA5ZDBiN2Ew MzE4MGRmOGE0Li5lNzMyZDg2M2EzMTVhYWJhZmQyOTdlMjBiOGZiNjY4ZDI0MTgyNmRhIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy93aW4vVW5pc2NyaWJlQ29u dHJvbGxlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvd2luL1Vu aXNjcmliZUNvbnRyb2xsZXIuY3BwCkBAIC0xOTgsNyArMTk4LDcgQEAgdm9pZCBVbmlzY3JpYmVD b250cm9sbGVyOjppdGVtaXplU2hhcGVBbmRQbGFjZShjb25zdCBVQ2hhciogY3AsIHVuc2lnbmVk IGxlbmd0aCwKICAgICBtX2l0ZW1zLnJlc2l6ZSg2KTsKICAgICBpbnQgbnVtSXRlbXMgPSAwOwog ICAgIEhSRVNVTFQgcmMgPSBTX09LOwotICAgIHdoaWxlIChyYyA9IDo6U2NyaXB0SXRlbWl6ZShj cCwgbGVuZ3RoLCBtX2l0ZW1zLnNpemUoKSAtIDEsICZtX2NvbnRyb2wsICZtX3N0YXRlLCBtX2l0 ZW1zLmRhdGEoKSwgJm51bUl0ZW1zKSA9PSBFX09VVE9GTUVNT1JZKSB7CisgICAgd2hpbGUgKChy YyA9IDo6U2NyaXB0SXRlbWl6ZShjcCwgbGVuZ3RoLCBtX2l0ZW1zLnNpemUoKSAtIDEsICZtX2Nv bnRyb2wsICZtX3N0YXRlLCBtX2l0ZW1zLmRhdGEoKSwgJm51bUl0ZW1zKSkgPT0gRV9PVVRPRk1F TU9SWSkgewogICAgICAgICBtX2l0ZW1zLnJlc2l6ZShtX2l0ZW1zLnNpemUoKSAqIDIpOwogICAg ICAgICByZXNldENvbnRyb2xBbmRTdGF0ZSgpOwogICAgIH0K 358103 2018-12-27 00:22:01 -0800 2018-12-27 00:23:00 -0800 Patch bug-192805-20181227172200.patch text/plain 2918 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjM5NTU1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTIzOGI0Zjc4NTIxMmQ4 MWE0MzViNGVmYTk5Mzg1MThlODVkNDMyMC4uM2VhY2FmNmExMmQ0YjBjYzI1ZGY1OGYxNjY0NzE1 ZmRhOTUxNDk1NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDM1IEBACisyMDE4LTEyLTI2ICBGdWpp aSBIaXJvbm9yaSAgPEhpcm9ub3JpLkZ1amlpQHNvbnkuY29tPgorCisgICAgICAgIFtXaW5dIEZp eCB0aGUgd3JvbmcgcmV0dXJuIHZhbHVlIGNoZWNraW5nIG9mIFNjcmlwdEl0ZW1pemUgaW4gVW5p c2NyaWJlQ29udHJvbGxlcjo6aXRlbWl6ZVNoYXBlQW5kUGxhY2UKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5MjgwNQorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFVuaXNjcmliZUNvbnRyb2xsZXI6Oml0ZW1p emVTaGFwZUFuZFBsYWNlIGhhcyBhIGVycm9yIGNoZWNrCisgICAgICAgICdGQUlMRUQocmMpJyBm b3IgdGhlIHJldHVybiB2YWx1ZSBvZiBTY3JpcHRJdGVtaXplLiBIb3dldmVyLCBpdAorICAgICAg ICBkaWRuJ3QgYWN0dWFsbHkgY2hlY2sgdGhlIHJldHVybiB2YWx1ZS4KKworICAgICAgICBUaGUg ZXF1YWwgY29tcGFyaXNvbiAnPT0nIGhhcyBoaWdoZXIgb3BlcmF0b3IgcHJlY2VkZW5jZSB0aGFu IHRoZQorICAgICAgICBhc3NpZ25tZW50ICc9Jy4KKworICAgICAgICAxLiByYyA9IDo6U2NyaXB0 SXRlbWl6ZSguLi4pID09IEVfT1VUT0ZNRU1PUlkKKyAgICAgICAgMi4gcmMgPSAoOjpTY3JpcHRJ dGVtaXplKC4uLikgPT0gRV9PVVRPRk1FTU9SWSkKKyAgICAgICAgMy4gKHJjID0gOjpTY3JpcHRJ dGVtaXplKC4uLikpID09IEVfT1VUT0ZNRU1PUlkKKworICAgICAgICBUaHVzLCB0aGUgZXhwcmVz c2lvbiAjMSBpcyBzYW1lIHdpdGggIzIsIG5vdCAjMy4gQXMgdGhlIHJlc3VsdCwKKyAgICAgICAg J0ZBSUxFRChyYyknIG5ldmVyIGJlIHRydWUuCisKKyAgICAgICAgRm9ydHVuYXRlbHksIGFzIGZh ciBhcyBJIHVuZGVyc3RhbmQgdGhlIGNvZGUsIHRoZXJlIGlzIG5vdCBhbgorICAgICAgICBhY3R1 YWwgcHJvYmxlbSBiZWNhdXNlIFNjcmlwdEl0ZW1pemUgbmV2ZXIgcmV0dXJucyBFX0lOVkFMSURB UkcgaW4KKyAgICAgICAgdGhlIGNvZGUuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCBubyBiZWhh dmlvciBjaGFuZ2VzLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3Mvd2luL1VuaXNjcmli ZUNvbnRyb2xsZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6VW5pc2NyaWJlQ29udHJvbGxlcjo6 aXRlbWl6ZVNoYXBlQW5kUGxhY2UpOiBVc2UKKyAgICAgICAgcGFyZW50aGVzZXMgdG8gYXNzaWdu ICdyYycgdGhlIHJldHVybiBjb2RlLiBSZXBsYWNlZCB0aGUgdXNlbGVzcworICAgICAgICBlcnJv ciBjaGVjayB3aXRoIGFuIGFzc2VydGlvbiBlbnN1cmluZyAnU1VDQ0VFREVEKHJjKScuCisKIDIw MTgtMTItMjYgIEppbSBNYXNvbiAgPGptYXNvbkBpYmlueC5jb20+CiAKICAgICAgICAgW0ZyZWVU eXBlXSBSZXN0b3JlIGNvbmRpdGlvbmFsIGNvbXBpbGF0aW9uIGxvZ2ljIGZvciByZWNlbnQgSGFy ZkJ1enogcmVmYWN0b3JpbmcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL3dpbi9VbmlzY3JpYmVDb250cm9sbGVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL3dpbi9VbmlzY3JpYmVDb250cm9sbGVyLmNwcAppbmRleCA0NDBhMGExZTFj ZGQyMTEwNDQ4MDI0MTdmMmQ5ZjFjM2M5ZDM4YWVjLi45YzFkZWQ5YjJkYTMxYWVjOGU4NGVmZmRm YjM2MjlhMWM1MmQxZGFkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFw aGljcy93aW4vVW5pc2NyaWJlQ29udHJvbGxlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3Mvd2luL1VuaXNjcmliZUNvbnRyb2xsZXIuY3BwCkBAIC0xOTYsMTQgKzE5 NiwxMSBAQCB2b2lkIFVuaXNjcmliZUNvbnRyb2xsZXI6Oml0ZW1pemVTaGFwZUFuZFBsYWNlKGNv bnN0IFVDaGFyKiBjcCwgdW5zaWduZWQgbGVuZ3RoLAogICAgIG1faXRlbXMucmVzaXplKDYpOwog ICAgIGludCBudW1JdGVtcyA9IDA7CiAgICAgSFJFU1VMVCByYyA9IFNfT0s7Ci0gICAgd2hpbGUg KHJjID0gOjpTY3JpcHRJdGVtaXplKGNwLCBsZW5ndGgsIG1faXRlbXMuc2l6ZSgpIC0gMSwgJm1f Y29udHJvbCwgJm1fc3RhdGUsIG1faXRlbXMuZGF0YSgpLCAmbnVtSXRlbXMpID09IEVfT1VUT0ZN RU1PUlkpIHsKKyAgICB3aGlsZSAoKHJjID0gOjpTY3JpcHRJdGVtaXplKGNwLCBsZW5ndGgsIG1f aXRlbXMuc2l6ZSgpIC0gMSwgJm1fY29udHJvbCwgJm1fc3RhdGUsIG1faXRlbXMuZGF0YSgpLCAm bnVtSXRlbXMpKSA9PSBFX09VVE9GTUVNT1JZKSB7CiAgICAgICAgIG1faXRlbXMucmVzaXplKG1f aXRlbXMuc2l6ZSgpICogMik7CiAgICAgICAgIHJlc2V0Q29udHJvbEFuZFN0YXRlKCk7CiAgICAg fQotICAgIGlmIChGQUlMRUQocmMpKSB7Ci0gICAgICAgIFdURkxvZ0Fsd2F5cygiVW5pc2NyaWJl Q29udHJvbGxlcjo6aXRlbWl6ZVNoYXBlQW5kUGxhY2U6IFNjcmlwdEl0ZW1pemUgZmFpbGVkLCBy Yz0lbHgiLCByYyk7Ci0gICAgICAgIHJldHVybjsKLSAgICB9CisgICAgQVNTRVJUX1VOVVNFRChy YywgU1VDQ0VFREVEKHJjKSk7IC8vIFNjcmlwdEl0ZW1pemUgbmV2ZXIgcmV0dXJucyBFX0lOVkFM SURBUkcuCiAgICAgbV9pdGVtcy5yZXNpemUobnVtSXRlbXMgKyAxKTsKIAogICAgIGlmIChtX3J1 bi5ydGwoKSkgewo= 358104 2018-12-27 00:24:05 -0800 2020-02-11 19:56:52 -0800 Patch bug-192805-20181227172404.patch text/plain 2933 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjM5NTU1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTIzOGI0Zjc4NTIxMmQ4 MWE0MzViNGVmYTk5Mzg1MThlODVkNDMyMC4uM2VhY2FmNmExMmQ0YjBjYzI1ZGY1OGYxNjY0NzE1 ZmRhOTUxNDk1NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDM1IEBACisyMDE4LTEyLTI2ICBGdWpp aSBIaXJvbm9yaSAgPEhpcm9ub3JpLkZ1amlpQHNvbnkuY29tPgorCisgICAgICAgIFtXaW5dIEZp eCB0aGUgd3JvbmcgcmV0dXJuIHZhbHVlIGNoZWNraW5nIG9mIFNjcmlwdEl0ZW1pemUgaW4gVW5p c2NyaWJlQ29udHJvbGxlcjo6aXRlbWl6ZVNoYXBlQW5kUGxhY2UKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5MjgwNQorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFVuaXNjcmliZUNvbnRyb2xsZXI6Oml0ZW1p emVTaGFwZUFuZFBsYWNlIGhhcyBhIGVycm9yIGNoZWNrCisgICAgICAgICdGQUlMRUQocmMpJyBm b3IgdGhlIHJldHVybiB2YWx1ZSBvZiBTY3JpcHRJdGVtaXplLiBIb3dldmVyLCBpdAorICAgICAg ICBkaWRuJ3QgYWN0dWFsbHkgY2hlY2sgdGhlIHJldHVybiB2YWx1ZS4KKworICAgICAgICBUaGUg ZXF1YWwgY29tcGFyaXNvbiAnPT0nIGhhcyBoaWdoZXIgb3BlcmF0b3IgcHJlY2VkZW5jZSB0aGFu IHRoZQorICAgICAgICBhc3NpZ25tZW50ICc9Jy4KKworICAgICAgICAxLiByYyA9IDo6U2NyaXB0 SXRlbWl6ZSguLi4pID09IEVfT1VUT0ZNRU1PUlkKKyAgICAgICAgMi4gcmMgPSAoOjpTY3JpcHRJ dGVtaXplKC4uLikgPT0gRV9PVVRPRk1FTU9SWSkKKyAgICAgICAgMy4gKHJjID0gOjpTY3JpcHRJ dGVtaXplKC4uLikpID09IEVfT1VUT0ZNRU1PUlkKKworICAgICAgICBUaHVzLCB0aGUgZXhwcmVz c2lvbiAjMSBpcyBzYW1lIHdpdGggIzIsIG5vdCAjMy4gQXMgdGhlIHJlc3VsdCwKKyAgICAgICAg J0ZBSUxFRChyYyknIG5ldmVyIGJlIHRydWUuCisKKyAgICAgICAgRm9ydHVuYXRlbHksIGFzIGZh ciBhcyBJIHVuZGVyc3RhbmQgdGhlIGNvZGUsIHRoZXJlIGlzIG5vdCBhbgorICAgICAgICBhY3R1 YWwgcHJvYmxlbSBiZWNhdXNlIFNjcmlwdEl0ZW1pemUgbmV2ZXIgcmV0dXJucyBFX0lOVkFMSURB UkcgaW4KKyAgICAgICAgdGhlIGNvZGUuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCBubyBiZWhh dmlvciBjaGFuZ2VzLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3Mvd2luL1VuaXNjcmli ZUNvbnRyb2xsZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6VW5pc2NyaWJlQ29udHJvbGxlcjo6 aXRlbWl6ZVNoYXBlQW5kUGxhY2UpOiBVc2UKKyAgICAgICAgcGFyZW50aGVzZXMgdG8gYXNzaWdu ICdyYycgdGhlIHJldHVybiBjb2RlLiBSZXBsYWNlZCB0aGUgdXNlbGVzcworICAgICAgICBlcnJv ciBjaGVjayB3aXRoIGFuIGFzc2VydGlvbiBlbnN1cmluZyAnU1VDQ0VFREVEKHJjKScuCisKIDIw MTgtMTItMjYgIEppbSBNYXNvbiAgPGptYXNvbkBpYmlueC5jb20+CiAKICAgICAgICAgW0ZyZWVU eXBlXSBSZXN0b3JlIGNvbmRpdGlvbmFsIGNvbXBpbGF0aW9uIGxvZ2ljIGZvciByZWNlbnQgSGFy ZkJ1enogcmVmYWN0b3JpbmcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL3dpbi9VbmlzY3JpYmVDb250cm9sbGVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL3dpbi9VbmlzY3JpYmVDb250cm9sbGVyLmNwcAppbmRleCA0NDBhMGExZTFj ZGQyMTEwNDQ4MDI0MTdmMmQ5ZjFjM2M5ZDM4YWVjLi45MzhjNDAyODgyZmNiMGY3NjNmOTU4YjE3 NjE4OTBiMjQ3MjI2YzdjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFw aGljcy93aW4vVW5pc2NyaWJlQ29udHJvbGxlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3Mvd2luL1VuaXNjcmliZUNvbnRyb2xsZXIuY3BwCkBAIC0xOTYsMTQgKzE5 NiwxMSBAQCB2b2lkIFVuaXNjcmliZUNvbnRyb2xsZXI6Oml0ZW1pemVTaGFwZUFuZFBsYWNlKGNv bnN0IFVDaGFyKiBjcCwgdW5zaWduZWQgbGVuZ3RoLAogICAgIG1faXRlbXMucmVzaXplKDYpOwog ICAgIGludCBudW1JdGVtcyA9IDA7CiAgICAgSFJFU1VMVCByYyA9IFNfT0s7Ci0gICAgd2hpbGUg KHJjID0gOjpTY3JpcHRJdGVtaXplKGNwLCBsZW5ndGgsIG1faXRlbXMuc2l6ZSgpIC0gMSwgJm1f Y29udHJvbCwgJm1fc3RhdGUsIG1faXRlbXMuZGF0YSgpLCAmbnVtSXRlbXMpID09IEVfT1VUT0ZN RU1PUlkpIHsKKyAgICB3aGlsZSAoKHJjID0gOjpTY3JpcHRJdGVtaXplKGNwLCBsZW5ndGgsIG1f aXRlbXMuc2l6ZSgpIC0gMSwgJm1fY29udHJvbCwgJm1fc3RhdGUsIG1faXRlbXMuZGF0YSgpLCAm bnVtSXRlbXMpKSA9PSBFX09VVE9GTUVNT1JZKSB7CiAgICAgICAgIG1faXRlbXMucmVzaXplKG1f aXRlbXMuc2l6ZSgpICogMik7CiAgICAgICAgIHJlc2V0Q29udHJvbEFuZFN0YXRlKCk7CiAgICAg fQotICAgIGlmIChGQUlMRUQocmMpKSB7Ci0gICAgICAgIFdURkxvZ0Fsd2F5cygiVW5pc2NyaWJl Q29udHJvbGxlcjo6aXRlbWl6ZVNoYXBlQW5kUGxhY2U6IFNjcmlwdEl0ZW1pemUgZmFpbGVkLCBy Yz0lbHgiLCByYyk7Ci0gICAgICAgIHJldHVybjsKLSAgICB9CisgICAgQVNTRVJUX1VOVVNFRChy YywgU1VDQ0VFREVEKHJjKSk7IC8vIFNjcmlwdEl0ZW1pemUgbXVzdCBub3QgcmV0dXJuIEVfSU5W QUxJREFSRyBpbiB0aGlzIGNvZGUuCiAgICAgbV9pdGVtcy5yZXNpemUobnVtSXRlbXMgKyAxKTsK IAogICAgIGlmIChtX3J1bi5ydGwoKSkgewo=