192789 2018-12-17 16:42:45 -0800 Allow passing nil as session state to [WKWebView _restoreSessionState:] 2018-12-17 18:17:36 -0800 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cdumez cdumez achristensen beidson commit-queue ggaren webkit-bug-importer oldest_to_newest 1488670 0 cdumez 2018-12-17 16:42:45 -0800 Allow passing nil as session state to [WKWebView _restoreSessionState:] instead of crashing. 1488671 1 cdumez 2018-12-17 16:43:00 -0800 <rdar://problem/46755277> 1488672 2 357500 cdumez 2018-12-17 16:43:41 -0800 Created attachment 357500 Patch 1488673 3 357501 cdumez 2018-12-17 16:47:54 -0800 Created attachment 357501 Patch 1488700 4 357501 commit-queue 2018-12-17 18:17:34 -0800 Comment on attachment 357501 Patch Clearing flags on attachment: 357501 Committed r239310: <https://trac.webkit.org/changeset/239310> 1488701 5 commit-queue 2018-12-17 18:17:36 -0800 All reviewed patches have been landed. Closing bug. 357500 2018-12-17 16:43:41 -0800 2018-12-17 16:47:52 -0800 Patch bug-192789-20181217164341.patch text/plain 1626 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjM5Mjk0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDAwYzA5N2FmZWRhMzg3NTM4 MDVmZDRmZGNmODA5YWM4NDljNWU0MDguLmZkYTM3NTI4ZThiNWIzNTBiNWVkODk1YWQzYTZhZjkw OTNhZjY4ODQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTgtMTItMTcgIENocmlzIER1 bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKworICAgICAgICBBbGxvdyBwYXNzaW5nIG5pbCBhcyBz ZXNzaW9uIHN0YXRlIHRvIFtXS1dlYlZpZXcgX3Jlc3RvcmVTZXNzaW9uU3RhdGU6XQorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTkyNzg5CisgICAgICAg IDxyZGFyOi8vcHJvYmxlbS80Njc1NTI3Nz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBBbGxvdyBwYXNzaW5nIG5pbCBhcyBzZXNzaW9uIHN0YXRlIHRv IFtXS1dlYlZpZXcgX3Jlc3RvcmVTZXNzaW9uU3RhdGU6XSBpbnN0ZWFkIG9mIGNyYXNoaW5nLgor CisgICAgICAgICogVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1dlYlZpZXcubW06CisgICAgICAgICgt W1dLV2ViVmlldyBfcmVzdG9yZVNlc3Npb25TdGF0ZTphbmROYXZpZ2F0ZTpdKToKKwogMjAxOC0x Mi0xNyAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgogCiAgICAgICAgIFVucmV2aWV3 ZWQsIHJldmVydCByZWNlbnQgQ3Jhc2hSZXBvcnRlckNsaWVudCBidWlsZCBmaXhlcyBhcyB0aGV5 IGFyZSBubyBsb25nZXIgbmVlZGVkLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nl c3MvQVBJL0NvY29hL1dLV2ViVmlldy5tbSBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9D b2NvYS9XS1dlYlZpZXcubW0KaW5kZXggYmEyMDQ4ZWFiYWFiNjhjZDczMzgyNWM2NGY4YjkyMGZh Yjk2NDQxZS4uOGRjMzBmMThkY2QzNjcwNWMyZTg5ZjJmOWJkYTAxN2Q4NTEzMmQ4ZSAxMDA2NDQK LS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL0NvY29hL1dLV2ViVmlldy5tbQorKysg Yi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJWaWV3Lm1tCkBAIC00NzEy LDcgKzQ3MTIsNyBAQCAtICh2b2lkKV9yZXN0b3JlRnJvbVNlc3Npb25TdGF0ZURhdGE6KE5TRGF0 YSAqKXNlc3Npb25TdGF0ZURhdGEKIAogLSAoV0tOYXZpZ2F0aW9uICopX3Jlc3RvcmVTZXNzaW9u U3RhdGU6KF9XS1Nlc3Npb25TdGF0ZSAqKXNlc3Npb25TdGF0ZSBhbmROYXZpZ2F0ZTooQk9PTClu YXZpZ2F0ZQogewotICAgIHJldHVybiB3cmFwcGVyKF9wYWdlLT5yZXN0b3JlRnJvbVNlc3Npb25T dGF0ZShzZXNzaW9uU3RhdGUtPl9zZXNzaW9uU3RhdGUsIG5hdmlnYXRlKSk7CisgICAgcmV0dXJu IHdyYXBwZXIoX3BhZ2UtPnJlc3RvcmVGcm9tU2Vzc2lvblN0YXRlKHNlc3Npb25TdGF0ZSA/IHNl c3Npb25TdGF0ZS0+X3Nlc3Npb25TdGF0ZSA6IFdlYktpdDo6U2Vzc2lvblN0YXRlIHsgfSwgbmF2 aWdhdGUpKTsKIH0KIAogLSAodm9pZClfY2xvc2UK 357501 2018-12-17 16:47:54 -0800 2018-12-17 18:17:34 -0800 Patch bug-192789-20181217164753.patch text/plain 4067 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjM5Mjk0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDAwYzA5N2FmZWRhMzg3NTM4 MDVmZDRmZGNmODA5YWM4NDljNWU0MDguLmZkYTM3NTI4ZThiNWIzNTBiNWVkODk1YWQzYTZhZjkw OTNhZjY4ODQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTgtMTItMTcgIENocmlzIER1 bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKworICAgICAgICBBbGxvdyBwYXNzaW5nIG5pbCBhcyBz ZXNzaW9uIHN0YXRlIHRvIFtXS1dlYlZpZXcgX3Jlc3RvcmVTZXNzaW9uU3RhdGU6XQorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTkyNzg5CisgICAgICAg IDxyZGFyOi8vcHJvYmxlbS80Njc1NTI3Nz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBBbGxvdyBwYXNzaW5nIG5pbCBhcyBzZXNzaW9uIHN0YXRlIHRv IFtXS1dlYlZpZXcgX3Jlc3RvcmVTZXNzaW9uU3RhdGU6XSBpbnN0ZWFkIG9mIGNyYXNoaW5nLgor CisgICAgICAgICogVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1dlYlZpZXcubW06CisgICAgICAgICgt W1dLV2ViVmlldyBfcmVzdG9yZVNlc3Npb25TdGF0ZTphbmROYXZpZ2F0ZTpdKToKKwogMjAxOC0x Mi0xNyAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgogCiAgICAgICAgIFVucmV2aWV3 ZWQsIHJldmVydCByZWNlbnQgQ3Jhc2hSZXBvcnRlckNsaWVudCBidWlsZCBmaXhlcyBhcyB0aGV5 IGFyZSBubyBsb25nZXIgbmVlZGVkLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nl c3MvQVBJL0NvY29hL1dLV2ViVmlldy5tbSBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9D b2NvYS9XS1dlYlZpZXcubW0KaW5kZXggYmEyMDQ4ZWFiYWFiNjhjZDczMzgyNWM2NGY4YjkyMGZh Yjk2NDQxZS4uOGRjMzBmMThkY2QzNjcwNWMyZTg5ZjJmOWJkYTAxN2Q4NTEzMmQ4ZSAxMDA2NDQK LS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL0NvY29hL1dLV2ViVmlldy5tbQorKysg Yi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJWaWV3Lm1tCkBAIC00NzEy LDcgKzQ3MTIsNyBAQCAtICh2b2lkKV9yZXN0b3JlRnJvbVNlc3Npb25TdGF0ZURhdGE6KE5TRGF0 YSAqKXNlc3Npb25TdGF0ZURhdGEKIAogLSAoV0tOYXZpZ2F0aW9uICopX3Jlc3RvcmVTZXNzaW9u U3RhdGU6KF9XS1Nlc3Npb25TdGF0ZSAqKXNlc3Npb25TdGF0ZSBhbmROYXZpZ2F0ZTooQk9PTClu YXZpZ2F0ZQogewotICAgIHJldHVybiB3cmFwcGVyKF9wYWdlLT5yZXN0b3JlRnJvbVNlc3Npb25T dGF0ZShzZXNzaW9uU3RhdGUtPl9zZXNzaW9uU3RhdGUsIG5hdmlnYXRlKSk7CisgICAgcmV0dXJu IHdyYXBwZXIoX3BhZ2UtPnJlc3RvcmVGcm9tU2Vzc2lvblN0YXRlKHNlc3Npb25TdGF0ZSA/IHNl c3Npb25TdGF0ZS0+X3Nlc3Npb25TdGF0ZSA6IFdlYktpdDo6U2Vzc2lvblN0YXRlIHsgfSwgbmF2 aWdhdGUpKTsKIH0KIAogLSAodm9pZClfY2xvc2UKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxv ZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBlN2MwMzI0YThjYzAyZjEzODk2YzJkMzIzMTY5ZWQx ODllZDY3OTZhLi43NzgxMGU3ZTg5MjY5YTExZjM5MDcxMGY5MjdlNjcxNzg1MTQ1ODVhIDEwMDY0 NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEs MTYgQEAKKzIwMTgtMTItMTcgIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKworICAg ICAgICBBbGxvdyBwYXNzaW5nIG5pbCBhcyBzZXNzaW9uIHN0YXRlIHRvIFtXS1dlYlZpZXcgX3Jl c3RvcmVTZXNzaW9uU3RhdGU6XQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTkyNzg5CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS80Njc1NTI3Nz4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgQVBJIHRl c3QgY292ZXJhZ2UuCisKKyAgICAgICAgKiBUZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdC9XS0Jh Y2tGb3J3YXJkTGlzdC5tbToKKyAgICAgICAgKFRFU1QpOgorCiAyMDE4LTEyLTE3ICBEYW5pZWwg QmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4KIAogICAgICAgICBTdXBwb3J0IGNvbmNhdGVuYXRp bmcgU3RyaW5nVmlldyB3aXRoIG90aGVyIHN0cmluZyB0eXBlcwpkaWZmIC0tZ2l0IGEvVG9vbHMv VGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXQvV0tCYWNrRm9yd2FyZExpc3QubW0gYi9Ub29scy9U ZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdC9XS0JhY2tGb3J3YXJkTGlzdC5tbQppbmRleCAxNGI4 MGUzMTUxMWNiYTM3ZDEwZGQxMWRiOWE1MWVlNjhmM2I5ZTY4Li43MWE1NTY0NjNhM2U1Nzg1OWU1 NWI0Zjg3ZDczNWM4YmU5MjEyNjIxIDEwMDY0NAotLS0gYS9Ub29scy9UZXN0V2ViS2l0QVBJL1Rl c3RzL1dlYktpdC9XS0JhY2tGb3J3YXJkTGlzdC5tbQorKysgYi9Ub29scy9UZXN0V2ViS2l0QVBJ L1Rlc3RzL1dlYktpdC9XS0JhY2tGb3J3YXJkTGlzdC5tbQpAQCAtMTAzLDYgKzEwMywzNyBAQCBU RVNUKFdLQmFja0ZvcndhcmRMaXN0LCBDYW5Ob3RHb0JhY2tBZnRlclJlc3RvcmluZ0VtcHR5U2Vz c2lvblN0YXRlKQogICAgIEVYUEVDVF9FUSgoTlNVSW50ZWdlcikwLCBuZXdMaXN0LmZvcndhcmRM aXN0LmNvdW50KTsKIH0KIAorVEVTVChXS0JhY2tGb3J3YXJkTGlzdCwgUmVzdG9yaW5nTmlsU2Vz c2lvblN0YXRlKQoreworICAgIGF1dG8gd2ViVmlldyA9IGFkb3B0TlMoW1tXS1dlYlZpZXcgYWxs b2NdIGluaXRdKTsKKworICAgIFt3ZWJWaWV3IGxvYWRSZXF1ZXN0OltOU1VSTFJlcXVlc3QgcmVx dWVzdFdpdGhVUkw6W05TVVJMIFVSTFdpdGhTdHJpbmc6bG9hZGFibGVVUkwxXV1dOworICAgIFt3 ZWJWaWV3IF90ZXN0X3dhaXRGb3JEaWRGaW5pc2hOYXZpZ2F0aW9uXTsKKworICAgIFt3ZWJWaWV3 IGxvYWRSZXF1ZXN0OltOU1VSTFJlcXVlc3QgcmVxdWVzdFdpdGhVUkw6W05TVVJMIFVSTFdpdGhT dHJpbmc6bG9hZGFibGVVUkwyXV1dOworICAgIFt3ZWJWaWV3IF90ZXN0X3dhaXRGb3JEaWRGaW5p c2hOYXZpZ2F0aW9uXTsKKworICAgIFdLQmFja0ZvcndhcmRMaXN0ICpsaXN0ID0gW3dlYlZpZXcg YmFja0ZvcndhcmRMaXN0XTsKKyAgICBFWFBFQ1RfRVEoWUVTLCBbd2ViVmlldyBjYW5Hb0JhY2td KTsKKyAgICBFWFBFQ1RfRVEoTk8sIFt3ZWJWaWV3IGNhbkdvRm9yd2FyZF0pOworICAgIEVYUEVD VF9FUSgoTlNVSW50ZWdlcikxLCBsaXN0LmJhY2tMaXN0LmNvdW50KTsKKyAgICBFWFBFQ1RfRVEo KE5TVUludGVnZXIpMCwgbGlzdC5mb3J3YXJkTGlzdC5jb3VudCk7CisKKyAgICBhdXRvIHNpbmds ZVBhZ2VXZWJWaWV3ID0gYWRvcHROUyhbW1dLV2ViVmlldyBhbGxvY10gaW5pdF0pOworCisgICAg W3NpbmdsZVBhZ2VXZWJWaWV3IGxvYWRSZXF1ZXN0OltOU1VSTFJlcXVlc3QgcmVxdWVzdFdpdGhV Ukw6W05TVVJMIFVSTFdpdGhTdHJpbmc6bG9hZGFibGVVUkwxXV1dOworICAgIFtzaW5nbGVQYWdl V2ViVmlldyBfdGVzdF93YWl0Rm9yRGlkRmluaXNoTmF2aWdhdGlvbl07CisKKyAgICBbd2ViVmll dyBfcmVzdG9yZVNlc3Npb25TdGF0ZTpuaWwgYW5kTmF2aWdhdGU6Tk9dOworCisgICAgV0tCYWNr Rm9yd2FyZExpc3QgKm5ld0xpc3QgPSBbd2ViVmlldyBiYWNrRm9yd2FyZExpc3RdOworCisgICAg RVhQRUNUX0VRKFlFUywgW3dlYlZpZXcgY2FuR29CYWNrXSk7CisgICAgRVhQRUNUX0VRKE5PLCBb d2ViVmlldyBjYW5Hb0ZvcndhcmRdKTsKKyAgICBFWFBFQ1RfRVEoKE5TVUludGVnZXIpMSwgbmV3 TGlzdC5iYWNrTGlzdC5jb3VudCk7CisgICAgRVhQRUNUX0VRKChOU1VJbnRlZ2VyKTAsIG5ld0xp c3QuZm9yd2FyZExpc3QuY291bnQpOworfQorCiBzdGF0aWMgYm9vbCBkb25lOwogc3RhdGljIHNp emVfdCBuYXZpZ2F0aW9uczsKIAo=