192786 2018-12-17 16:29:52 -0800 webkitpy: Ignore device type for test when using --force 2018-12-18 11:43:06 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jbedard jbedard commit-queue dbates ews-watchlist glenn lforschler webkit-bug-importer oldest_to_newest 1488661 0 jbedard 2018-12-17 16:29:52 -0800 There are cases where a contributor may wish to ignore the device type associated with a test. This fits with the description of the existing --force flag. 1488663 1 webkit-bug-importer 2018-12-17 16:30:28 -0800 <rdar://problem/46794894> 1488666 2 357498 jbedard 2018-12-17 16:37:46 -0800 Created attachment 357498 Patch 1488674 3 357502 jbedard 2018-12-17 16:50:33 -0800 Created attachment 357502 Patch 1488943 4 357502 dbates 2018-12-18 10:41:53 -0800 Comment on attachment 357502 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=357502&action=review > Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py:245 > + help="Run all tests with PASS as expected result, even those marked SKIP in the test list and run tests " + \ > + "on available devices, even if the device type does not match (implies --skipped=ignore)"), The wording of this text is confusing and I had to read it over a few times for it to make sense to me. Maybe it would be clearer to write: "Run all tests with PASS as expected result, even those marked SKIP in the test list or are device-specific (implies --skipped=ignore)". 1488945 5 357502 dbates 2018-12-18 10:42:43 -0800 Comment on attachment 357502 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=357502&action=review > Tools/ChangeLog:8 > + A good change log message describes why we are making the change in addition to what the change is. 1488956 6 357583 jbedard 2018-12-18 11:04:32 -0800 Created attachment 357583 Patch for landing 1488982 7 357583 commit-queue 2018-12-18 11:43:05 -0800 Comment on attachment 357583 Patch for landing Clearing flags on attachment: 357583 Committed r239344: <https://trac.webkit.org/changeset/239344> 1488983 8 commit-queue 2018-12-18 11:43:06 -0800 All reviewed patches have been landed. Closing bug. 357498 2018-12-17 16:37:46 -0800 2018-12-17 16:50:32 -0800 Patch bug-192786-20181217163745.patch text/plain 2596 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIzOTMwMykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE2IEBACisyMDE4LTEyLTE3ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICB3ZWJraXRweTogSWdub3JlIGRldmljZSB0eXBlIGZvciB0ZXN0IHdoZW4g dXNpbmcgLS1mb3JjZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTkyNzg2CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS80Njc5NDg5ND4KKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0 cHkvbGF5b3V0X3Rlc3RzL3J1bl93ZWJraXRfdGVzdHMucHk6CisgICAgICAgIChwYXJzZV9hcmdz KToKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3BvcnQvZGV2aWNlX3BvcnQucHk6CisgICAg ICAgIChEZXZpY2VQb3J0LmRlZmF1bHRfY2hpbGRfcHJvY2Vzc2VzKTogU3RyaXAgZGV2aWNlIHR5 cGUgaW5mb3JtYXRpb24gd2hlbiB1c2luZyAtLWZvcmNlLgorCiAyMDE4LTEyLTE3ICBKb25hdGhh biBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNvbT4KIAogICAgICAgICB3ZWJraXRweTogSGFuZGxl IGNhc2Ugd2hlcmUgc3Rkb3V0IGFuZCBzdGRlcnIgZG9uJ3QgYWNjZXB0IHVuaWNvZGUKSW5kZXg6 IFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3J1bl93ZWJraXRfdGVzdHMucHkK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcnVuX3dl YmtpdF90ZXN0cy5weQkocmV2aXNpb24gMjM5MzAzKQorKysgVG9vbHMvU2NyaXB0cy93ZWJraXRw eS9sYXlvdXRfdGVzdHMvcnVuX3dlYmtpdF90ZXN0cy5weQkod29ya2luZyBjb3B5KQpAQCAtMjQx LDcgKzI0MSw4IEBAIGRlZiBwYXJzZV9hcmdzKGFyZ3MpOgogICAgICAgICAgICAgICAgICAiJ29u bHknID09IG9ubHkgcnVuIHRoZSBTS0lQIHRlc3RzLCAiCiAgICAgICAgICAgICAgICAgICInYWx3 YXlzJyA9PSBhbHdheXMgc2tpcCwgZXZlbiBpZiBsaXN0ZWQgb24gdGhlIGNvbW1hbmQgbGluZS4i KSksCiAgICAgICAgIG9wdHBhcnNlLm1ha2Vfb3B0aW9uKCItLWZvcmNlIiwgYWN0aW9uPSJzdG9y ZV90cnVlIiwgZGVmYXVsdD1GYWxzZSwKLSAgICAgICAgICAgIGhlbHA9IlJ1biBhbGwgdGVzdHMg d2l0aCBQQVNTIGFzIGV4cGVjdGVkIHJlc3VsdCwgZXZlbiB0aG9zZSBtYXJrZWQgU0tJUCBpbiB0 aGUgdGVzdCBsaXN0IChpbXBsaWVzIC0tc2tpcHBlZD1pZ25vcmUpIiksCisgICAgICAgICAgICBo ZWxwPSJSdW4gYWxsIHRlc3RzIHdpdGggUEFTUyBhcyBleHBlY3RlZCByZXN1bHQsIGV2ZW4gdGhv c2UgbWFya2VkIFNLSVAgaW4gdGhlIHRlc3QgbGlzdCBhbmQgcnVuIHRlc3RzICIgKyBcCisgICAg ICAgICAgICAgICAgICJvbiBhdmFpbGFibGUgZGV2aWNlcywgZXZlbiBpZiB0aGUgZGV2aWNlIHR5 cGUgZG9lcyBub3QgbWF0Y2ggKGltcGxpZXMgLS1za2lwcGVkPWlnbm9yZSkiKSwKICAgICAgICAg b3B0cGFyc2UubWFrZV9vcHRpb24oIi0tdGltZS1vdXQtbXMiLAogICAgICAgICAgICAgaGVscD0i U2V0IHRoZSB0aW1lb3V0IGZvciBlYWNoIHRlc3QiKSwKICAgICAgICAgb3B0cGFyc2UubWFrZV9v cHRpb24oIi0tb3JkZXIiLCBhY3Rpb249InN0b3JlIiwgZGVmYXVsdD0ibmF0dXJhbCIsCkluZGV4 OiBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3BvcnQvZGV2aWNlX3BvcnQucHkKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gVG9vbHMvU2NyaXB0cy93ZWJraXRweS9wb3J0L2RldmljZV9wb3J0LnB5CShyZXZpc2lvbiAy MzkzMDMpCisrKyBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3BvcnQvZGV2aWNlX3BvcnQucHkJKHdv cmtpbmcgY29weSkKQEAgLTEyMyw2ICsxMjMsMTAgQEAgY2xhc3MgRGV2aWNlUG9ydChEYXJ3aW5Q b3J0KToKICAgICAgICAgaWYgZGV2aWNlX3R5cGUuc29mdHdhcmVfdmFyaWFudCBhbmQgc2VsZi5E RUZBVUxUX0RFVklDRV9UWVBFLnNvZnR3YXJlX3ZhcmlhbnQgIT0gZGV2aWNlX3R5cGUuc29mdHdh cmVfdmFyaWFudDoKICAgICAgICAgICAgIHJldHVybiAwCiAKKyAgICAgICAgaWYgc2VsZi5nZXRf b3B0aW9uKCdmb3JjZScpOgorICAgICAgICAgICAgZGV2aWNlX3R5cGUuaGFyZHdhcmVfZmFtaWx5 ID0gTm9uZQorICAgICAgICAgICAgZGV2aWNlX3R5cGUuaGFyZHdhcmVfdHlwZSA9IE5vbmUKKwog ICAgICAgICByZXR1cm4gc2VsZi5ERVZJQ0VfTUFOQUdFUi5kZXZpY2VfY291bnRfZm9yX3R5cGUo CiAgICAgICAgICAgICBzZWxmLl9kZXZpY2VfdHlwZV93aXRoX3ZlcnNpb24oZGV2aWNlX3R5cGUp LAogICAgICAgICAgICAgaG9zdD1zZWxmLmhvc3QsCg== 357502 2018-12-17 16:50:33 -0800 2018-12-18 11:04:30 -0800 Patch bug-192786-20181217165032.patch text/plain 3100 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIzOTMwMykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE3IEBACisyMDE4LTEyLTE3ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICB3ZWJraXRweTogSWdub3JlIGRldmljZSB0eXBlIGZvciB0ZXN0IHdoZW4g dXNpbmcgLS1mb3JjZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTkyNzg2CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS80Njc5NDg5ND4KKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0 cHkvbGF5b3V0X3Rlc3RzL3J1bl93ZWJraXRfdGVzdHMucHk6CisgICAgICAgIChwYXJzZV9hcmdz KToKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3BvcnQvZGV2aWNlX3BvcnQucHk6CisgICAg ICAgIChEZXZpY2VQb3J0LmRlZmF1bHRfY2hpbGRfcHJvY2Vzc2VzKTogU3RyaXAgZGV2aWNlIHR5 cGUgaW5mb3JtYXRpb24gd2hlbiB1c2luZyAtLWZvcmNlLgorICAgICAgICAoRGV2aWNlUG9ydC5z ZXR1cF90ZXN0X3J1bik6IE9ubHkgYWxsb3cgaW5jb21wbGV0ZSBtYXRjaCB3aGVuIHVzaW5nIC0t Zm9yY2UuCisKIDIwMTgtMTItMTcgIEpvbmF0aGFuIEJlZGFyZCAgPGpiZWRhcmRAYXBwbGUuY29t PgogCiAgICAgICAgIHdlYmtpdHB5OiBIYW5kbGUgY2FzZSB3aGVyZSBzdGRvdXQgYW5kIHN0ZGVy ciBkb24ndCBhY2NlcHQgdW5pY29kZQpJbmRleDogVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlv dXRfdGVzdHMvcnVuX3dlYmtpdF90ZXN0cy5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRz L3dlYmtpdHB5L2xheW91dF90ZXN0cy9ydW5fd2Via2l0X3Rlc3RzLnB5CShyZXZpc2lvbiAyMzkz MDMpCisrKyBUb29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9ydW5fd2Via2l0X3Rl c3RzLnB5CSh3b3JraW5nIGNvcHkpCkBAIC0yNDEsNyArMjQxLDggQEAgZGVmIHBhcnNlX2FyZ3Mo YXJncyk6CiAgICAgICAgICAgICAgICAgICInb25seScgPT0gb25seSBydW4gdGhlIFNLSVAgdGVz dHMsICIKICAgICAgICAgICAgICAgICAgIidhbHdheXMnID09IGFsd2F5cyBza2lwLCBldmVuIGlm IGxpc3RlZCBvbiB0aGUgY29tbWFuZCBsaW5lLiIpKSwKICAgICAgICAgb3B0cGFyc2UubWFrZV9v cHRpb24oIi0tZm9yY2UiLCBhY3Rpb249InN0b3JlX3RydWUiLCBkZWZhdWx0PUZhbHNlLAotICAg ICAgICAgICAgaGVscD0iUnVuIGFsbCB0ZXN0cyB3aXRoIFBBU1MgYXMgZXhwZWN0ZWQgcmVzdWx0 LCBldmVuIHRob3NlIG1hcmtlZCBTS0lQIGluIHRoZSB0ZXN0IGxpc3QgKGltcGxpZXMgLS1za2lw cGVkPWlnbm9yZSkiKSwKKyAgICAgICAgICAgIGhlbHA9IlJ1biBhbGwgdGVzdHMgd2l0aCBQQVNT IGFzIGV4cGVjdGVkIHJlc3VsdCwgZXZlbiB0aG9zZSBtYXJrZWQgU0tJUCBpbiB0aGUgdGVzdCBs aXN0IGFuZCBydW4gdGVzdHMgIiArIFwKKyAgICAgICAgICAgICAgICAgIm9uIGF2YWlsYWJsZSBk ZXZpY2VzLCBldmVuIGlmIHRoZSBkZXZpY2UgdHlwZSBkb2VzIG5vdCBtYXRjaCAoaW1wbGllcyAt LXNraXBwZWQ9aWdub3JlKSIpLAogICAgICAgICBvcHRwYXJzZS5tYWtlX29wdGlvbigiLS10aW1l LW91dC1tcyIsCiAgICAgICAgICAgICBoZWxwPSJTZXQgdGhlIHRpbWVvdXQgZm9yIGVhY2ggdGVz dCIpLAogICAgICAgICBvcHRwYXJzZS5tYWtlX29wdGlvbigiLS1vcmRlciIsIGFjdGlvbj0ic3Rv cmUiLCBkZWZhdWx0PSJuYXR1cmFsIiwKSW5kZXg6IFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvcG9y dC9kZXZpY2VfcG9ydC5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3Bv cnQvZGV2aWNlX3BvcnQucHkJKHJldmlzaW9uIDIzOTMwMykKKysrIFRvb2xzL1NjcmlwdHMvd2Vi a2l0cHkvcG9ydC9kZXZpY2VfcG9ydC5weQkod29ya2luZyBjb3B5KQpAQCAtMTIzLDYgKzEyMywx MCBAQCBjbGFzcyBEZXZpY2VQb3J0KERhcndpblBvcnQpOgogICAgICAgICBpZiBkZXZpY2VfdHlw ZS5zb2Z0d2FyZV92YXJpYW50IGFuZCBzZWxmLkRFRkFVTFRfREVWSUNFX1RZUEUuc29mdHdhcmVf dmFyaWFudCAhPSBkZXZpY2VfdHlwZS5zb2Z0d2FyZV92YXJpYW50OgogICAgICAgICAgICAgcmV0 dXJuIDAKIAorICAgICAgICBpZiBzZWxmLmdldF9vcHRpb24oJ2ZvcmNlJyk6CisgICAgICAgICAg ICBkZXZpY2VfdHlwZS5oYXJkd2FyZV9mYW1pbHkgPSBOb25lCisgICAgICAgICAgICBkZXZpY2Vf dHlwZS5oYXJkd2FyZV90eXBlID0gTm9uZQorCiAgICAgICAgIHJldHVybiBzZWxmLkRFVklDRV9N QU5BR0VSLmRldmljZV9jb3VudF9mb3JfdHlwZSgKICAgICAgICAgICAgIHNlbGYuX2RldmljZV90 eXBlX3dpdGhfdmVyc2lvbihkZXZpY2VfdHlwZSksCiAgICAgICAgICAgICBob3N0PXNlbGYuaG9z dCwKQEAgLTE0Niw3ICsxNTAsNyBAQCBjbGFzcyBEZXZpY2VQb3J0KERhcndpblBvcnQpOgogICAg ICAgICAgICAgZGV2aWNlX3R5cGUsCiAgICAgICAgICAgICB1c2VfYm9vdGVkX3NpbXVsYXRvcj1u b3Qgc2VsZi5nZXRfb3B0aW9uKCdkZWRpY2F0ZWRfc2ltdWxhdG9ycycsIEZhbHNlKSwKICAgICAg ICAgICAgIHVzZV9leGlzdGluZ19zaW11bGF0b3I9RmFsc2UsCi0gICAgICAgICAgICBhbGxvd19p bmNvbXBsZXRlX21hdGNoPVRydWUsCisgICAgICAgICAgICBhbGxvd19pbmNvbXBsZXRlX21hdGNo PXNlbGYuZ2V0X29wdGlvbignZm9yY2UnKSwKICAgICAgICAgKQogICAgICAgICBzZWxmLkRFVklD RV9NQU5BR0VSLmluaXRpYWxpemVfZGV2aWNlcygKICAgICAgICAgICAgIFtyZXF1ZXN0XSAqIHNl bGYuY2hpbGRfcHJvY2Vzc2VzKCksCg== 357583 2018-12-18 11:04:32 -0800 2018-12-18 11:43:05 -0800 Patch for landing bug-192786-20181218110431.patch text/plain 3278 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIzOTM0MCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDIwIEBACisyMDE4LTEyLTE4ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICB3ZWJraXRweTogSWdub3JlIGRldmljZSB0eXBlIGZvciB0ZXN0IHdoZW4g dXNpbmcgLS1mb3JjZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTkyNzg2CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS80Njc5NDg5ND4KKworICAgICAg ICBSZXZpZXdlZCBieSBEYW5pZWwgQmF0ZXMuCisKKyAgICAgICAgSXQgaXMgc29tZXRpbWVzIHRo ZSBjYXNlIHRoYXQgYSBjb250cmlidXRvciB3aWxsIHdpc2ggdG8gcnVuIGEgdGVzdCBvbiBhIHNw ZWNpZmljIGRldmljZSwKKyAgICAgICAgZGVzcGl0ZSBleHBlY3RhdGlvbnMgd2hpY2ggaW5kaWNh dGUgYSB0ZXN0IHNob3VsZCBub3QgYmUgcnVuIG9uIHRoYXQgZGV2aWNlLgorCisgICAgICAgICog U2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcnVuX3dlYmtpdF90ZXN0cy5weToKKyAgICAg ICAgKHBhcnNlX2FyZ3MpOgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvcG9ydC9kZXZpY2Vf cG9ydC5weToKKyAgICAgICAgKERldmljZVBvcnQuZGVmYXVsdF9jaGlsZF9wcm9jZXNzZXMpOiBT dHJpcCBkZXZpY2UgdHlwZSBpbmZvcm1hdGlvbiB3aGVuIHVzaW5nIC0tZm9yY2UuCisgICAgICAg IChEZXZpY2VQb3J0LnNldHVwX3Rlc3RfcnVuKTogT25seSBhbGxvdyBpbmNvbXBsZXRlIG1hdGNo IHdoZW4gdXNpbmcgLS1mb3JjZS4KKwogMjAxOC0xMi0xOCAgQWxleCBDaHJpc3RlbnNlbiAgPGFj aHJpc3RlbnNlbkB3ZWJraXQub3JnPgogCiAgICAgICAgIFdLV2ViVmlldyBoYXMgb2xkIFVSTCB3 aGlsZSBkaXNwbGF5aW5nIFNhZmVCcm93c2luZyBpbnRlcnN0aXRpYWwsIGZvciBsaW5rLWNsaWNr IG5hdmlnYXRpb25zCkluZGV4OiBUb29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9y dW5fd2Via2l0X3Rlc3RzLnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkv bGF5b3V0X3Rlc3RzL3J1bl93ZWJraXRfdGVzdHMucHkJKHJldmlzaW9uIDIzOTM0MCkKKysrIFRv b2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3J1bl93ZWJraXRfdGVzdHMucHkJKHdv cmtpbmcgY29weSkKQEAgLTI0MSw3ICsyNDEsOCBAQCBkZWYgcGFyc2VfYXJncyhhcmdzKToKICAg ICAgICAgICAgICAgICAgIidvbmx5JyA9PSBvbmx5IHJ1biB0aGUgU0tJUCB0ZXN0cywgIgogICAg ICAgICAgICAgICAgICAiJ2Fsd2F5cycgPT0gYWx3YXlzIHNraXAsIGV2ZW4gaWYgbGlzdGVkIG9u IHRoZSBjb21tYW5kIGxpbmUuIikpLAogICAgICAgICBvcHRwYXJzZS5tYWtlX29wdGlvbigiLS1m b3JjZSIsIGFjdGlvbj0ic3RvcmVfdHJ1ZSIsIGRlZmF1bHQ9RmFsc2UsCi0gICAgICAgICAgICBo ZWxwPSJSdW4gYWxsIHRlc3RzIHdpdGggUEFTUyBhcyBleHBlY3RlZCByZXN1bHQsIGV2ZW4gdGhv c2UgbWFya2VkIFNLSVAgaW4gdGhlIHRlc3QgbGlzdCAoaW1wbGllcyAtLXNraXBwZWQ9aWdub3Jl KSIpLAorICAgICAgICAgICAgaGVscD0iUnVuIGFsbCB0ZXN0cyB3aXRoIFBBU1MgYXMgZXhwZWN0 ZWQgcmVzdWx0LCBldmVuIHRob3NlIG1hcmtlZCBTS0lQIGluIHRoZSB0ZXN0IGxpc3Qgb3IgIiAr IFwKKyAgICAgICAgICAgICAgICAgInRob3NlIHdoaWNoIGFyZSBkZXZpY2Utc3BlY2lmaWMgKGlt cGxpZXMgLS1za2lwcGVkPWlnbm9yZSkiKSwKICAgICAgICAgb3B0cGFyc2UubWFrZV9vcHRpb24o Ii0tdGltZS1vdXQtbXMiLAogICAgICAgICAgICAgaGVscD0iU2V0IHRoZSB0aW1lb3V0IGZvciBl YWNoIHRlc3QiKSwKICAgICAgICAgb3B0cGFyc2UubWFrZV9vcHRpb24oIi0tb3JkZXIiLCBhY3Rp b249InN0b3JlIiwgZGVmYXVsdD0ibmF0dXJhbCIsCkluZGV4OiBUb29scy9TY3JpcHRzL3dlYmtp dHB5L3BvcnQvZGV2aWNlX3BvcnQucHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvU2NyaXB0cy93ZWJr aXRweS9wb3J0L2RldmljZV9wb3J0LnB5CShyZXZpc2lvbiAyMzkzNDApCisrKyBUb29scy9TY3Jp cHRzL3dlYmtpdHB5L3BvcnQvZGV2aWNlX3BvcnQucHkJKHdvcmtpbmcgY29weSkKQEAgLTEyMyw2 ICsxMjMsMTAgQEAgY2xhc3MgRGV2aWNlUG9ydChEYXJ3aW5Qb3J0KToKICAgICAgICAgaWYgZGV2 aWNlX3R5cGUuc29mdHdhcmVfdmFyaWFudCBhbmQgc2VsZi5ERUZBVUxUX0RFVklDRV9UWVBFLnNv ZnR3YXJlX3ZhcmlhbnQgIT0gZGV2aWNlX3R5cGUuc29mdHdhcmVfdmFyaWFudDoKICAgICAgICAg ICAgIHJldHVybiAwCiAKKyAgICAgICAgaWYgc2VsZi5nZXRfb3B0aW9uKCdmb3JjZScpOgorICAg ICAgICAgICAgZGV2aWNlX3R5cGUuaGFyZHdhcmVfZmFtaWx5ID0gTm9uZQorICAgICAgICAgICAg ZGV2aWNlX3R5cGUuaGFyZHdhcmVfdHlwZSA9IE5vbmUKKwogICAgICAgICByZXR1cm4gc2VsZi5E RVZJQ0VfTUFOQUdFUi5kZXZpY2VfY291bnRfZm9yX3R5cGUoCiAgICAgICAgICAgICBzZWxmLl9k ZXZpY2VfdHlwZV93aXRoX3ZlcnNpb24oZGV2aWNlX3R5cGUpLAogICAgICAgICAgICAgaG9zdD1z ZWxmLmhvc3QsCkBAIC0xNDYsNyArMTUwLDcgQEAgY2xhc3MgRGV2aWNlUG9ydChEYXJ3aW5Qb3J0 KToKICAgICAgICAgICAgIGRldmljZV90eXBlLAogICAgICAgICAgICAgdXNlX2Jvb3RlZF9zaW11 bGF0b3I9bm90IHNlbGYuZ2V0X29wdGlvbignZGVkaWNhdGVkX3NpbXVsYXRvcnMnLCBGYWxzZSks CiAgICAgICAgICAgICB1c2VfZXhpc3Rpbmdfc2ltdWxhdG9yPUZhbHNlLAotICAgICAgICAgICAg YWxsb3dfaW5jb21wbGV0ZV9tYXRjaD1UcnVlLAorICAgICAgICAgICAgYWxsb3dfaW5jb21wbGV0 ZV9tYXRjaD1zZWxmLmdldF9vcHRpb24oJ2ZvcmNlJyksCiAgICAgICAgICkKICAgICAgICAgc2Vs Zi5ERVZJQ0VfTUFOQUdFUi5pbml0aWFsaXplX2RldmljZXMoCiAgICAgICAgICAgICBbcmVxdWVz dF0gKiBzZWxmLmNoaWxkX3Byb2Nlc3NlcygpLAo=