192779 2018-12-17 15:03:22 -0800 SamplingProfiler's isValidFramePointer() should reject address at stack origin. 2018-12-17 17:21:17 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mark.lam mark.lam commit-queue ews-watchlist keith_miller msaboff saam webkit-bug-importer oldest_to_newest 1488619 0 mark.lam 2018-12-17 15:03:22 -0800 <rdar://problem/46775869> 1488625 1 357483 mark.lam 2018-12-17 15:08:21 -0800 Created attachment 357483 proposed patch. 1488676 2 357483 mark.lam 2018-12-17 16:55:41 -0800 Comment on attachment 357483 proposed patch. Thanks for the review. Landing now. 1488680 3 357483 commit-queue 2018-12-17 17:21:15 -0800 Comment on attachment 357483 proposed patch. Clearing flags on attachment: 357483 Committed r239304: <https://trac.webkit.org/changeset/239304> 1488681 4 commit-queue 2018-12-17 17:21:17 -0800 All reviewed patches have been landed. Closing bug. 357483 2018-12-17 15:08:21 -0800 2018-12-17 17:21:15 -0800 proposed patch. bug-192779.patch text/plain 3451 mark.lam SW5kZXg6IEpTVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvQ2hhbmdlTG9n CShyZXZpc2lvbiAyMzkyOTEpCisrKyBKU1Rlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDEzIEBACisyMDE4LTEyLTE3ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNv bT4KKworICAgICAgICBTYW1wbGluZ1Byb2ZpbGVyJ3MgaXNWYWxpZEZyYW1lUG9pbnRlcigpIHNo b3VsZCByZWplY3QgYWRkcmVzcyBhdCBzdGFjayBvcmlnaW4uCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTI3NzkKKyAgICAgICAgPHJkYXI6Ly9wcm9i bGVtLzQ2Nzc1ODY5PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgICogc3RyZXNzL3NhbXBsaW5nLXByb2ZpbGVyLXNob3VsZC1ub3Qtc2FtcGxlLWJleW9u ZC1zdGFjay1ib3VuZHMuanM6IEFkZGVkLgorCiAyMDE4LTEyLTE3ICBNYXJrIExhbSAgPG1hcmsu bGFtQGFwcGxlLmNvbT4KIAogICAgICAgICBTdXBwcmVzcyBBU0FOIG9uIHZhbGlkIHN0YWNrIGFj Y2Vzc2VzIGluIFByb2JlLWJhc2VkIE9TUkV4aXQ6OmV4ZWN1dGVPU1JFeGl0KCkuCkluZGV4OiBK U1Rlc3RzL3N0cmVzcy9zYW1wbGluZy1wcm9maWxlci1zaG91bGQtbm90LXNhbXBsZS1iZXlvbmQt c3RhY2stYm91bmRzLmpzCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvc3RyZXNzL3NhbXBsaW5nLXBy b2ZpbGVyLXNob3VsZC1ub3Qtc2FtcGxlLWJleW9uZC1zdGFjay1ib3VuZHMuanMJKG5vbmV4aXN0 ZW50KQorKysgSlNUZXN0cy9zdHJlc3Mvc2FtcGxpbmctcHJvZmlsZXItc2hvdWxkLW5vdC1zYW1w bGUtYmV5b25kLXN0YWNrLWJvdW5kcy5qcwkod29ya2luZyBjb3B5KQpAQCAtMCwwICsxLDI0IEBA CisvL0AgcmVxdWlyZU9wdGlvbnMoIi0tdXNlU2FtcGxpbmdQcm9maWxlcj10cnVlIiwgIi0tdXNl UHJvYmVPU1JFeGl0PXRydWUiLCAiLS11c2VPYmplY3RBbGxvY2F0aW9uU2lua2luZz1mYWxzZSIs ICItLXNhbXBsZUludGVydmFsPTEwIikKKworZnVuY3Rpb24gZm9vKHJhbmdlcykgeworICAgIGNv bnN0IENIVU5LX1NJWkUgPSA5NTsKKyAgICBmb3IgKGNvbnN0IFtzdGFydCwgZW5kXSBvZiByYW5n ZXMpIHsKKyAgICAgICAgY29uc3QgY29kZVBvaW50cyA9IFtdOworICAgICAgICBmb3IgKGxldCBs ZW5ndGggPSAwLCBjb2RlUG9pbnQgPSBzdGFydDsgY29kZVBvaW50IDw9IGVuZDsgY29kZVBvaW50 KyspIHsKKyAgICAgICAgICAgIGNvZGVQb2ludHNbbGVuZ3RoKytdID0gY29kZVBvaW50OworICAg ICAgICAgICAgaWYgKGxlbmd0aCA9PT0gQ0hVTktfU0laRSkgeworICAgICAgICAgICAgICAgIGxl bmd0aCA9IDA7CisgICAgICAgICAgICAgICAgY29kZVBvaW50cy5sZW5ndGggPSAwOworICAgICAg ICAgICAgICAgIFN0cmluZy5mcm9tQ29kZVBvaW50KC4uLltdKTsKKyAgICAgICAgICAgIH0KKyAg ICAgICAgfQorICAgICAgICBTdHJpbmcuZnJvbUNvZGVQb2ludCguLi5jb2RlUG9pbnRzKTsKKyAg ICB9Cit9CisKK2ZvciAobGV0IGk9MDsgaTwzOyBpKyspIHsKKyAgICBsZXQgeCA9IGZvbyhbCisg ICAgICAgIFsgMCwgMTAwMDAgXSwKKyAgICAgICAgWyA2ODAwMCwgMTExNDExMSBdCisgICAgXSk7 Cit9CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIzOTI5MCkKKysrIFNv dXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwx OCBAQAorMjAxOC0xMi0xNyAgTWFyayBMYW0gIDxtYXJrLmxhbUBhcHBsZS5jb20+CisKKyAgICAg ICAgU2FtcGxpbmdQcm9maWxlcidzIGlzVmFsaWRGcmFtZVBvaW50ZXIoKSBzaG91bGQgcmVqZWN0 IGFkZHJlc3MgYXQgc3RhY2sgb3JpZ2luLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTkyNzc5CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS80Njc3NTg2 OT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBpc1Zh bGlkRnJhbWVQb2ludGVyKCkgd2FzIHByZXZpb3VzbHkgdHJlYXRpbmcgdGhlIGFkZHJlc3MgYXQg U3RhY2tCb3VuZHM6Om9yaWdpbigpCisgICAgICAgIGFzIHZhbGlkIHN0YWNrIG1lbW9yeS4gIFRo aXMgaXMgbm90IHRydWUuICBTdGFja0JvdW5kczo6b3JpZ2luKCkgaXMgYWN0dWFsbHkgdGhlCisg ICAgICAgIGZpcnN0IGFkZHJlc3MgYmV5b25kIHZhbGlkIHN0YWNrIG1lbW9yeS4gVGhpcyBpcyBu b3cgZml4ZWQuCisKKyAgICAgICAgKiBydW50aW1lL1NhbXBsaW5nUHJvZmlsZXIuY3BwOgorICAg ICAgICAoSlNDOjpGcmFtZVdhbGtlcjo6aXNWYWxpZEZyYW1lUG9pbnRlcik6CisKIDIwMTgtMTIt MTcgIE1hcmsgTGFtICA8bWFyay5sYW1AYXBwbGUuY29tPgogCiAgICAgICAgIFN1cHByZXNzIEFT QU4gb24gdmFsaWQgc3RhY2sgYWNjZXNzZXMgaW4gUHJvYmUtYmFzZWQgT1NSRXhpdDo6ZXhlY3V0 ZU9TUkV4aXQoKS4KSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL1NhbXBsaW5n UHJvZmlsZXIuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1l L1NhbXBsaW5nUHJvZmlsZXIuY3BwCShyZXZpc2lvbiAyMzkyOTApCisrKyBTb3VyY2UvSmF2YVNj cmlwdENvcmUvcnVudGltZS9TYW1wbGluZ1Byb2ZpbGVyLmNwcAkod29ya2luZyBjb3B5KQpAQCAt MTcyLDcgKzE3Miw4IEBAIHByb3RlY3RlZDoKICAgICAgICAgICAgIHVpbnQ4X3QqIHN0YWNrTGlt aXQgPSBzdGF0aWNfY2FzdDx1aW50OF90Kj4odGhyZWFkLT5zdGFjaygpLmVuZCgpKTsKICAgICAg ICAgICAgIFJFTEVBU0VfQVNTRVJUKHN0YWNrQmFzZSk7CiAgICAgICAgICAgICBSRUxFQVNFX0FT U0VSVChzdGFja0xpbWl0KTsKLSAgICAgICAgICAgIGlmIChmcENhc3QgPD0gc3RhY2tCYXNlICYm IGZwQ2FzdCA+PSBzdGFja0xpbWl0KQorICAgICAgICAgICAgUkVMRUFTRV9BU1NFUlQoc3RhY2tM aW1pdCA8PSBzdGFja0Jhc2UpOworICAgICAgICAgICAgaWYgKGZwQ2FzdCA8IHN0YWNrQmFzZSAm JiBmcENhc3QgPj0gc3RhY2tMaW1pdCkKICAgICAgICAgICAgICAgICByZXR1cm4gdHJ1ZTsKICAg ICAgICAgfQogICAgICAgICByZXR1cm4gZmFsc2U7Cg==