192775 2018-12-17 13:47:21 -0800 webkitpy: Handle case where stdout and stderr don't accept unicode 2018-12-17 16:12:15 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jbedard jbedard aakash_jain commit-queue ews-watchlist glenn lforschler rniwa slewis webkit-bug-importer oldest_to_newest 1488577 0 jbedard 2018-12-17 13:47:21 -0800 It turns out that while the terminal accepts unicode characters, buildbot's stdout and stderr does not. We should handle this case in the MeteredStream object. 1488578 1 webkit-bug-importer 2018-12-17 13:47:43 -0800 <rdar://problem/46788706> 1488583 2 357473 jbedard 2018-12-17 13:54:13 -0800 Created attachment 357473 Patch 1488652 3 357473 commit-queue 2018-12-17 16:12:13 -0800 Comment on attachment 357473 Patch Clearing flags on attachment: 357473 Committed r239303: <https://trac.webkit.org/changeset/239303> 1488653 4 commit-queue 2018-12-17 16:12:15 -0800 All reviewed patches have been landed. Closing bug. 357473 2018-12-17 13:54:13 -0800 2018-12-17 16:12:13 -0800 Patch bug-192775-20181217135413.patch text/plain 3024 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIzOTI4OCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE3IEBACisyMDE4LTEyLTE3ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICB3ZWJraXRweTogSGFuZGxlIGNhc2Ugd2hlcmUgc3Rkb3V0IGFuZCBzdGRl cnIgZG9uJ3QgYWNjZXB0IHVuaWNvZGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE5Mjc3NQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNDY0OTczMDM+ CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTY3Jp cHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy92aWV3cy9tZXRlcmVkX3N0cmVhbS5weToKKyAgICAg ICAgKE1ldGVyZWRTdHJlYW0ud3JpdGUpOiBJZiB1bmljb2RlIGNhbm5vdCBiZSB3cml0dGVuIHRv IHRoZSBzdHJlYW0sIHJlcGxhY2UgdW5pY29kZQorICAgICAgICBjaGFyYWN0ZXJzIHdpdGggJz8n LgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3ZpZXdzL21ldGVyZWRf c3RyZWFtX3VuaXR0ZXN0LnB5OgorICAgICAgICAoUmVndWxhclRlc3QudGVzdF9zdHJlYW1fd2l0 aF9lbmNvZGluZyk6CisKIDIwMTgtMTItMTcgIERhbmllbCBCYXRlcyAgPGRhYmF0ZXNAYXBwbGUu Y29tPgogCiAgICAgICAgIFN1cHBvcnQgY29uY2F0ZW5hdGluZyBTdHJpbmdWaWV3IHdpdGggb3Ro ZXIgc3RyaW5nIHR5cGVzCkluZGV4OiBUb29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0 cy92aWV3cy9tZXRlcmVkX3N0cmVhbS5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL3dl YmtpdHB5L2xheW91dF90ZXN0cy92aWV3cy9tZXRlcmVkX3N0cmVhbS5weQkocmV2aXNpb24gMjM5 Mjc4KQorKysgVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvdmlld3MvbWV0ZXJl ZF9zdHJlYW0ucHkJKHdvcmtpbmcgY29weSkKQEAgLTEwNyw3ICsxMDcsMTYgQEAgY2xhc3MgTWV0 ZXJlZFN0cmVhbShvYmplY3QpOgogICAgICAgICBpZiBub3Qgc2VsZi5faXNhdHR5IG9yIHNlbGYu X3ZlcmJvc2U6CiAgICAgICAgICAgICB0eHQgPSBzZWxmLl9lbnN1cmVfbmV3bGluZSh0eHQpCiAK LSAgICAgICAgc2VsZi5fc3RyZWFtLndyaXRlKHRpbWVzdGFtcF9zdHJpbmcgKyB0eHQpCisgICAg ICAgIHRyeToKKyAgICAgICAgICAgIHNlbGYuX3N0cmVhbS53cml0ZSh0aW1lc3RhbXBfc3RyaW5n ICsgdHh0KQorICAgICAgICBleGNlcHQgVW5pY29kZUVuY29kZUVycm9yOgorICAgICAgICAgICAg b3V0cHV0ID0gJycKKyAgICAgICAgICAgIGZvciBjIGluIHRpbWVzdGFtcF9zdHJpbmcgKyB0eHQ6 CisgICAgICAgICAgICAgICAgdHJ5OgorICAgICAgICAgICAgICAgICAgICBvdXRwdXQgKz0gJ3t9 Jy5mb3JtYXQoYykKKyAgICAgICAgICAgICAgICBleGNlcHQgVW5pY29kZUVuY29kZUVycm9yOgor ICAgICAgICAgICAgICAgICAgICBvdXRwdXQgKz0gJz8nCisgICAgICAgICAgICBzZWxmLl9zdHJl YW0ud3JpdGUob3V0cHV0KQogCiAgICAgZGVmIHdyaXRlbG4oc2VsZiwgdHh0LCBub3c9Tm9uZSwg cGlkPU5vbmUpOgogICAgICAgICBzZWxmLndyaXRlKHNlbGYuX2Vuc3VyZV9uZXdsaW5lKHR4dCks IG5vdywgcGlkKQpJbmRleDogVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvdmll d3MvbWV0ZXJlZF9zdHJlYW1fdW5pdHRlc3QucHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvU2NyaXB0 cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvdmlld3MvbWV0ZXJlZF9zdHJlYW1fdW5pdHRlc3QucHkJ KHJldmlzaW9uIDIzOTI3OCkKKysrIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3Rz L3ZpZXdzL21ldGVyZWRfc3RyZWFtX3VuaXR0ZXN0LnB5CSh3b3JraW5nIGNvcHkpCkBAIC0xMTcs NiArMTE3LDI0IEBAIGNsYXNzIFJlZ3VsYXJUZXN0KHVuaXR0ZXN0LlRlc3RDYXNlKToKICAgICAg ICAgc2VsZi5sb2dnZXIuaW5mbygn4oCYZXhhbXBsZeKAmScpCiAgICAgICAgIHNlbGYuYXNzZXJ0 RXF1YWwoc2VsZi5idWZsaXN0Wy0xXVstMTQ6XSwgJ+KAmGV4YW1wbGXigJlcbicpCiAKKyAgICBk ZWYgdGVzdF9zdHJlYW1fd2l0aF9lbmNvZGluZyhzZWxmKToKKyAgICAgICAgY2xhc3MgQXNjaWlT dHJlYW0oU3RyaW5nSU8uU3RyaW5nSU8pOgorICAgICAgICAgICAgZGVmIHdyaXRlKHNlbGYsIHMp OgorICAgICAgICAgICAgICAgIHJldHVybiBTdHJpbmdJTy5TdHJpbmdJTy53cml0ZShzZWxmLCAn e30nLmZvcm1hdChzKSkKKworICAgICAgICBzdHJlYW0gPSBBc2NpaVN0cmVhbSgpCisKKyAgICAg ICAgbG9nZ2VyID0gbG9nZ2luZy5nZXRMb2dnZXIoX19uYW1lX18pCisgICAgICAgIGxvZ2dlci5z ZXRMZXZlbChsb2dnaW5nLkRFQlVHKQorICAgICAgICBsb2dnZXIucHJvcGFnYXRlID0gRmFsc2UK KworICAgICAgICB0cnk6CisgICAgICAgICAgICBtZXRlciA9IE1ldGVyZWRTdHJlYW0oc3RyZWFt LCBzZWxmLnZlcmJvc2UsIGxvZ2dlciwgc2VsZi50aW1lX2ZuLCA4Njc1LCBwcmludF90aW1lc3Rh bXBzPXNlbGYucHJpbnRfdGltZXN0YW1wcykKKyAgICAgICAgICAgIHNlbGYubG9nZ2VyLmluZm8o dSdcdTI3MTMnKQorICAgICAgICAgICAgc2VsZi5hc3NlcnRFcXVhbChzdHJlYW0uYnVmbGlzdFst MV1bLTI6XSwgJz9cbicpCisgICAgICAgIGZpbmFsbHk6CisgICAgICAgICAgICBtZXRlci5jbGVh bnVwKCkKKwogCiBjbGFzcyBUdHlUZXN0KFJlZ3VsYXJUZXN0KToKICAgICB2ZXJib3NlID0gRmFs c2UK