192773 2018-12-17 13:24:56 -0800 Web Inspector: REGRESSION (r237195): Timelines: selecting a rendering frame row moves the time selection 2018-12-19 19:57:18 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 hi hi commit-queue hi inspector-bugzilla-changes joepeck webkit-bug-importer oldest_to_newest 1488563 0 hi 2018-12-17 13:24:56 -0800 # STEPS TO REPRODUCE: 1. open WebInspector to Timelines tab 2. go to the Frames view 3. start a recording 4. interact with the page (e.g. scroll) 5. stop the recording 6. select a small range towards the end of the recording 7. expand one of the non-filtered records 8. click on a child of the expanded record (e.g. Composite or Layout) => the selected time range changes to be towards the beginning of the recorded frames, but the blue selection bar is where it should be 1488564 1 hi 2018-12-17 13:25:15 -0800 <rdar://problem/46782446> 1488568 2 357471 hi 2018-12-17 13:30:45 -0800 Created attachment 357471 Patch 1489673 3 357471 joepeck 2018-12-19 19:31:14 -0800 Comment on attachment 357471 Patch r=me 1489684 4 357471 commit-queue 2018-12-19 19:57:17 -0800 Comment on attachment 357471 Patch Clearing flags on attachment: 357471 Committed r239421: <https://trac.webkit.org/changeset/239421> 1489685 5 commit-queue 2018-12-19 19:57:18 -0800 All reviewed patches have been landed. Closing bug. 357471 2018-12-17 13:30:45 -0800 2018-12-19 19:57:17 -0800 Patch bug-192773-20181217133044.patch text/plain 2651 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDkxNTJhZDQ1YTc2YjdiMTZjNzk3MDAwMGRmYTg5 ZjlmODM0YzBjZGYuLjk1MWIwMjI1ZDJjZmVkZjdmYzg5NjIyZTU2MDFhODVlN2U3NGM5NjkgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE4LTEyLTE3ICBEZXZp biBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBS RUdSRVNTSU9OIChyMjM3MTk1KTogVGltZWxpbmVzOiBzZWxlY3RpbmcgYSByZW5kZXJpbmcgZnJh bWUgcm93IG1vdmVzIHRoZSB0aW1lIHNlbGVjdGlvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTkyNzczCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS80 Njc4MjQ0Nj4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIFVzZXJJbnRlcmZhY2UvVmlld3MvVGltZWxpbmVPdmVydmlldy5qczoKKyAgICAgICAgKFdJ LlRpbWVsaW5lT3ZlcnZpZXcucHJvdG90eXBlLl9yZWNvcmRTZWxlY3RlZCk6CisgICAgICAgIFRo ZSBGcmFtZXMgdGltZWxpbmUgdXNlcyBgZnJhbWVJbmRleGAgaW5zdGVhZCBvZiBgc3RhcnRUaW1l YC9gZW5kVGltZWAsIHNvIHdoZW4gdHJ5aW5nIHRvCisgICAgICAgIGVuc3VyZSB0aGF0IHRoZSBz ZWxlY3RlZCByZWNvcmQgaXMgd2l0aGluIHRoZSBmaWx0ZXJlZCByYW5nZSwgdXNlIGBmcmFtZUlu ZGV4YCBpbnN0ZWFkLgorICAgICAgICBUaGUgYXNzb2NpYXRlZCBgV0kuVGltZWxpbmVSdWxlcmAg d2lsbCBhbHJlYWR5IGJlIHVzaW5nIGFuIGluZGV4LWJhc2VkIGFwcHJvYWNoIGZvcgorICAgICAg ICBzZWxlY3Rpb24sIHNvIHRoaXMgd2lsbCBtYXRjaC4KKwogMjAxOC0xMi0xNSAgTmlraXRhIFZh c2lseWV2ICA8bnZhc2lseWV2QGFwcGxlLmNvbT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBT dHlsZXM6IHRvZ2dsaW5nIHNlbGVjdGVkIHByb3BlcnRpZXMgbWF5IGNhdXNlIGRhdGEgY29ycnVw dGlvbgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmll d3MvVGltZWxpbmVPdmVydmlldy5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJm YWNlL1ZpZXdzL1RpbWVsaW5lT3ZlcnZpZXcuanMKaW5kZXggYmIwZGJlNTczNTgwNWQ0MTQ5YTE2 YmU4ZTdlNGFmYWYxNDQ1YTNjOS4uZjY4NWM1NGI5NGViNTg4NTAyZmU1ZWFmZWQ0YTYxMTU3ZjY2 NjYwOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmll d3MvVGltZWxpbmVPdmVydmlldy5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlcklu dGVyZmFjZS9WaWV3cy9UaW1lbGluZU92ZXJ2aWV3LmpzCkBAIC03MzMsMTAgKzczMywxMyBAQCBX SS5UaW1lbGluZU92ZXJ2aWV3ID0gY2xhc3MgVGltZWxpbmVPdmVydmlldyBleHRlbmRzIFdJLlZp ZXcKICAgICAgICAgICAgICAgICBsYXN0UmVjb3JkID0gcmVjb3JkQmFyLnJlY29yZHMubGFzdFZh bHVlOwogICAgICAgICAgICAgfQogCi0gICAgICAgICAgICBpZiAoZmlyc3RSZWNvcmQuc3RhcnRU aW1lIDwgdGhpcy5zZWxlY3Rpb25TdGFydFRpbWUgfHwgbGFzdFJlY29yZC5lbmRUaW1lID4gdGhp cy5zZWxlY3Rpb25TdGFydFRpbWUgKyB0aGlzLnNlbGVjdGlvbkR1cmF0aW9uKSB7CisgICAgICAg ICAgICBsZXQgc3RhcnRUaW1lID0gZmlyc3RSZWNvcmQgaW5zdGFuY2VvZiBXSS5SZW5kZXJpbmdG cmFtZVRpbWVsaW5lUmVjb3JkID8gZmlyc3RSZWNvcmQuZnJhbWVJbmRleCA6IGZpcnN0UmVjb3Jk LnN0YXJ0VGltZTsKKyAgICAgICAgICAgIGxldCBlbmRUaW1lID0gbGFzdFJlY29yZCBpbnN0YW5j ZW9mIFdJLlJlbmRlcmluZ0ZyYW1lVGltZWxpbmVSZWNvcmQgPyBsYXN0UmVjb3JkLmZyYW1lSW5k ZXggOiBsYXN0UmVjb3JkLnN0YXJ0VGltZTsKKworICAgICAgICAgICAgaWYgKHN0YXJ0VGltZSA8 IHRoaXMuc2VsZWN0aW9uU3RhcnRUaW1lIHx8IGVuZFRpbWUgPiB0aGlzLnNlbGVjdGlvblN0YXJ0 VGltZSArIHRoaXMuc2VsZWN0aW9uRHVyYXRpb24pIHsKICAgICAgICAgICAgICAgICBsZXQgc2Vs ZWN0aW9uUGFkZGluZyA9IHRoaXMuc2Vjb25kc1BlclBpeGVsICogMTA7Ci0gICAgICAgICAgICAg ICAgdGhpcy5zZWxlY3Rpb25TdGFydFRpbWUgPSBmaXJzdFJlY29yZC5zdGFydFRpbWUgLSBzZWxl Y3Rpb25QYWRkaW5nOwotICAgICAgICAgICAgICAgIHRoaXMuc2VsZWN0aW9uRHVyYXRpb24gPSBs YXN0UmVjb3JkLmVuZFRpbWUgLSBmaXJzdFJlY29yZC5zdGFydFRpbWUgKyAoc2VsZWN0aW9uUGFk ZGluZyAqIDIpOworICAgICAgICAgICAgICAgIHRoaXMuc2VsZWN0aW9uU3RhcnRUaW1lID0gc3Rh cnRUaW1lIC0gc2VsZWN0aW9uUGFkZGluZzsKKyAgICAgICAgICAgICAgICB0aGlzLnNlbGVjdGlv bkR1cmF0aW9uID0gZW5kVGltZSAtIHN0YXJ0VGltZSArIChzZWxlY3Rpb25QYWRkaW5nICogMik7 CiAgICAgICAgICAgICB9CiAgICAgICAgIH0KIAo=