192770 2018-12-17 12:17:13 -0800 Fix stale assertion in attemptToForceStringArrayModeByToStringConversion(). 2018-12-17 13:33:10 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mark.lam mark.lam ews-watchlist keith_miller msaboff saam webkit-bug-importer oldest_to_newest 1488533 0 mark.lam 2018-12-17 12:17:13 -0800 <rdar://problem/46449037> 1488537 1 357466 mark.lam 2018-12-17 12:22:47 -0800 Created attachment 357466 proposed patch. 1488546 2 357466 keith_miller 2018-12-17 12:52:12 -0800 Comment on attachment 357466 proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=357466&action=review r=me. > JSTests/ChangeLog:9 > + * stress/regress-192770.js: Added. Nit: Can we give this a real name? I kinda hate the "regress-<unclear number>.js" convention. 1488551 3 mark.lam 2018-12-17 13:01:12 -0800 Thanks for the review. (In reply to Keith Miller from comment #2) > Comment on attachment 357466 [details] > proposed patch. > > View in context: > https://bugs.webkit.org/attachment.cgi?id=357466&action=review > > r=me. > > > JSTests/ChangeLog:9 > > + * stress/regress-192770.js: Added. > > Nit: Can we give this a real name? I kinda hate the "regress-<unclear > number>.js" convention. Will rename to force-string-arrayMode-on-originalNonArray-array-class.js. 1488569 4 mark.lam 2018-12-17 13:33:10 -0800 Landed in r239287: <http://trac.webkit.org/r239287>. 357466 2018-12-17 12:22:47 -0800 2018-12-17 12:52:12 -0800 proposed patch. bug-192770.patch text/plain 2768 mark.lam SW5kZXg6IEpTVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvQ2hhbmdlTG9n CShyZXZpc2lvbiAyMzkyODApCisrKyBKU1Rlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDEzIEBACisyMDE4LTEyLTE3ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNv bT4KKworICAgICAgICBGaXggc3RhbGUgYXNzZXJ0aW9uIGluIGF0dGVtcHRUb0ZvcmNlU3RyaW5n QXJyYXlNb2RlQnlUb1N0cmluZ0NvbnZlcnNpb24oKS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5Mjc3MAorICAgICAgICA8cmRhcjovL3Byb2JsZW0v NDY0NDkwMzc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgKiBzdHJlc3MvcmVncmVzcy0xOTI3NzAuanM6IEFkZGVkLgorCiAyMDE4LTEyLTE0ICBNYXJr IExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KIAogICAgICAgICBDYWxsRnJhbWU6OmNvbnZlcnRU b1N0YWNrT3ZlcmZsb3dGcmFtZSgpIG5lZWRzIHRvIGtlZXAgdGhlIHRvcCBDb2RlQmxvY2sgYWxp dmUuCkluZGV4OiBKU1Rlc3RzL3N0cmVzcy9yZWdyZXNzLTE5Mjc3MC5qcwo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBKU1Rlc3RzL3N0cmVzcy9yZWdyZXNzLTE5Mjc3MC5qcwkobm9uZXhpc3RlbnQpCisrKyBKU1Rl c3RzL3N0cmVzcy9yZWdyZXNzLTE5Mjc3MC5qcwkod29ya2luZyBjb3B5KQpAQCAtMCwwICsxLDE2 IEBACisvL0AgcmVxdWlyZU9wdGlvbnMoIi0taml0UG9saWN5U2NhbGU9MC4xIikKKworZnVuY3Rp b24gZm9vKGEpIHsKKyAgICBhLmxlbmd0aDsKK30KKworZm9yIChsZXQgaSA9IDA7IGkgPCAxMDA7 IGkrKykgeworICAgIGxldCBhID0gaSAlIDIgPyBuZXcgVWludDhBcnJheSgpIDogbmV3IFVpbnQx NkFycmF5KCk7CisKKyAgICBmb3IgKGxldCBqID0gMDsgaiA8IDI7IGorKykKKyAgICAgICAgZm9v KGEpOworCisgICAgZ2MoKTsKKyAgICBmb28oJycpOworICAgIGZvbyhhKTsKK30KSW5kZXg6IFNv dXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFT Y3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjM5MjQzKQorKysgU291cmNlL0phdmFTY3Jp cHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDE4LTEy LTE3ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBGaXggc3RhbGUg YXNzZXJ0aW9uIGluIGF0dGVtcHRUb0ZvcmNlU3RyaW5nQXJyYXlNb2RlQnlUb1N0cmluZ0NvbnZl cnNpb24oKS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTE5Mjc3MAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNDY0NDkwMzc+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyBhc3NlcnRpb24gd2FzIGFk ZGVkIGJlZm9yZSBBcnJheTo6T3JpZ2luYWxOb25BcnJheSB3YXMgaW50cm9kdWNlZC4gIEl0IGp1 c3QKKyAgICAgICAgbmVlZHMgdG8gYmUgdXBkYXRlZCB0byBhbGxvdyBmb3IgQXJyYXk6Ok9yaWdp bmFsTm9uQXJyYXkuCisKKyAgICAgICAgKiBkZmcvREZHRml4dXBQaGFzZS5jcHA6CisgICAgICAg IChKU0M6OkRGRzo6Rml4dXBQaGFzZTo6YXR0ZW1wdFRvRm9yY2VTdHJpbmdBcnJheU1vZGVCeVRv U3RyaW5nQ29udmVyc2lvbik6CisKIDIwMTgtMTItMTQgIERhdmlkIEtpbHplciAgPGRka2lsemVy QGFwcGxlLmNvbT4KIAogICAgICAgICBjbGFuZy10aWR5OiBGaXggdW5uZWNlc3NhcnkgY29weSBv ZiBvYmplY3RzIGZvciBvcGVyYXRvcj09KCkgbWV0aG9kcwpJbmRleDogU291cmNlL0phdmFTY3Jp cHRDb3JlL2RmZy9ERkdGaXh1cFBoYXNlLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNj cmlwdENvcmUvZGZnL0RGR0ZpeHVwUGhhc2UuY3BwCShyZXZpc2lvbiAyMzkyNDMpCisrKyBTb3Vy Y2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0ZpeHVwUGhhc2UuY3BwCSh3b3JraW5nIGNvcHkpCkBA IC0yNDMyLDcgKzI0MzIsNyBAQCBwcml2YXRlOgogICAgIHRlbXBsYXRlPFVzZUtpbmQgdXNlS2lu ZD4KICAgICB2b2lkIGF0dGVtcHRUb0ZvcmNlU3RyaW5nQXJyYXlNb2RlQnlUb1N0cmluZ0NvbnZl cnNpb24oQXJyYXlNb2RlJiBhcnJheU1vZGUsIE5vZGUqIG5vZGUpCiAgICAgewotICAgICAgICBB U1NFUlQoYXJyYXlNb2RlID09IEFycmF5TW9kZShBcnJheTo6R2VuZXJpYywgQXJyYXk6OlJlYWQp KTsKKyAgICAgICAgQVNTRVJUKGFycmF5TW9kZSA9PSBBcnJheU1vZGUoQXJyYXk6OkdlbmVyaWMs IEFycmF5OjpSZWFkKSB8fCBhcnJheU1vZGUgPT0gQXJyYXlNb2RlKEFycmF5OjpHZW5lcmljLCBB cnJheTo6T3JpZ2luYWxOb25BcnJheSwgQXJyYXk6OlJlYWQpKTsKICAgICAgICAgCiAgICAgICAg IGlmICghbV9ncmFwaC5jYW5PcHRpbWl6ZVN0cmluZ09iamVjdEFjY2Vzcyhub2RlLT5vcmlnaW4u c2VtYW50aWMpKQogICAgICAgICAgICAgcmV0dXJuOwo=