192769 2018-12-17 11:58:10 -0800 Web Inspector: Audit: add plural result strings 2018-12-17 13:16:40 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 190754 1 hi hi bburg commit-queue hi inspector-bugzilla-changes webkit-bug-importer oldest_to_newest 1488527 0 hi 2018-12-17 11:58:10 -0800 . 1488528 1 hi 2018-12-17 11:58:29 -0800 <rdar://problem/46628680> 1488529 2 357462 hi 2018-12-17 11:59:58 -0800 Created attachment 357462 Patch 1488536 3 357462 bburg 2018-12-17 12:18:53 -0800 Comment on attachment 357462 Patch r=me 1488560 4 357462 commit-queue 2018-12-17 13:16:38 -0800 Comment on attachment 357462 Patch Clearing flags on attachment: 357462 Committed r239286: <https://trac.webkit.org/changeset/239286> 1488561 5 commit-queue 2018-12-17 13:16:40 -0800 All reviewed patches have been landed. Closing bug. 357462 2018-12-17 11:59:58 -0800 2018-12-17 13:16:38 -0800 Patch bug-192769-20181217115957.patch text/plain 6442 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDkxNTJhZDQ1YTc2YjdiMTZjNzk3MDAwMGRmYTg5 ZjlmODM0YzBjZGYuLjdiZmI3MjJhMjY0NjRhNDE3YWRkZDU2YTNkZTY4MDQ3ODAxZWE2OGMgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE4LTEyLTE3ICBEZXZp biBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBB dWRpdDogYWRkIHBsdXJhbCByZXN1bHQgc3RyaW5ncworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTkyNzY5CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS80 NjYyODY4MD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIFVzZXJJbnRlcmZhY2UvVmlld3MvQXVkaXRUZXN0Q29udGVudFZpZXcuanM6CisgICAgICAg IChXSS5BdWRpdFRlc3RDb250ZW50Vmlldy5wcm90b3R5cGUuc2hvd05vUmVzdWx0RGF0YVBsYWNl aG9sZGVyKToKKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvVmlld3MvQXVkaXRUZXN0R3JvdXBD b250ZW50Vmlldy5qczoKKyAgICAgICAgKFdJLkF1ZGl0VGVzdEdyb3VwQ29udGVudFZpZXcucHJv dG90eXBlLmxheW91dCk6CisKKyAgICAgICAgKiBMb2NhbGl6YXRpb25zL2VuLmxwcm9qL2xvY2Fs aXplZFN0cmluZ3MuanM6CisKIDIwMTgtMTItMTUgIE5pa2l0YSBWYXNpbHlldiAgPG52YXNpbHll dkBhcHBsZS5jb20+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogU3R5bGVzOiB0b2dnbGluZyBz ZWxlY3RlZCBwcm9wZXJ0aWVzIG1heSBjYXVzZSBkYXRhIGNvcnJ1cHRpb24KZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Mb2NhbGl6YXRpb25zL2VuLmxwcm9qL2xvY2FsaXplZFN0 cmluZ3MuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvTG9jYWxpemF0aW9ucy9lbi5scHJvai9s b2NhbGl6ZWRTdHJpbmdzLmpzCmluZGV4IDBkMWRiYThhNTlkYWE3NzU2ZWMyNzhmOTliZThlMDE2 MjllMGY1NTAuLjU0NGIwM2I1MjU3NGVmZDU3MWRmM2VhNjBmMTBlYTJiYzBmOTlmYmYgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Mb2NhbGl6YXRpb25zL2VuLmxwcm9qL2xvY2Fs aXplZFN0cmluZ3MuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0xvY2FsaXphdGlvbnMv ZW4ubHByb2ovbG9jYWxpemVkU3RyaW5ncy5qcwpAQCAtMjUsMTQgKzI1LDE0IEBAIGxvY2FsaXpl ZFN0cmluZ3NbIiUuM2ZtcyJdID0gIiUuM2ZtcyI7CiBsb2NhbGl6ZWRTdHJpbmdzWyIlZCBFcnJv ciJdID0gIiVkIEVycm9yIjsKIGxvY2FsaXplZFN0cmluZ3NbIiVkIEVycm9ycyJdID0gIiVkIEVy cm9ycyI7CiBsb2NhbGl6ZWRTdHJpbmdzWyIlZCBFcnJvcnMsICVkIFdhcm5pbmdzIl0gPSAiJWQg RXJyb3JzLCAlZCBXYXJuaW5ncyI7Ci1sb2NhbGl6ZWRTdHJpbmdzWyIlZCBGYWlsIl0gPSAiJWQg RmFpbCI7Citsb2NhbGl6ZWRTdHJpbmdzWyIlZCBGYWlsZWQiXSA9ICIlZCBGYWlsZWQiOwogbG9j YWxpemVkU3RyaW5nc1siJWQgRnJhbWUiXSA9ICIlZCBGcmFtZSI7CiBsb2NhbGl6ZWRTdHJpbmdz WyIlZCBGcmFtZXMiXSA9ICIlZCBGcmFtZXMiOwogbG9jYWxpemVkU3RyaW5nc1siJWQgTW9yZVx1 MjAyNiJdID0gIiVkIE1vcmVcdTIwMjYiOwotbG9jYWxpemVkU3RyaW5nc1siJWQgUGFzcyJdID0g IiVkIFBhc3MiOworbG9jYWxpemVkU3RyaW5nc1siJWQgUGFzc2VkIl0gPSAiJWQgUGFzc2VkIjsK IGxvY2FsaXplZFN0cmluZ3NbIiVkIFRocmVhZHMiXSA9ICIlZCBUaHJlYWRzIjsKIGxvY2FsaXpl ZFN0cmluZ3NbIiVkIFVuc3VwcG9ydGVkIl0gPSAiJWQgVW5zdXBwb3J0ZWQiOwotbG9jYWxpemVk U3RyaW5nc1siJWQgV2FybiJdID0gIiVkIFdhcm4iOworbG9jYWxpemVkU3RyaW5nc1siJWQgV2Fy bmluZyJdID0gIiVkIFdhcm5pbmciOwogbG9jYWxpemVkU3RyaW5nc1siJWQgV2FybmluZ3MiXSA9 ICIlZCBXYXJuaW5ncyI7CiBsb2NhbGl6ZWRTdHJpbmdzWyIlZCBceGQ3ICVkIHBpeGVscyJdID0g IiVkIFx4ZDcgJWQgcGl4ZWxzIjsKIGxvY2FsaXplZFN0cmluZ3NbIiVkIFx4ZDcgJWQgcGl4ZWxz IChOYXR1cmFsOiAlZCBceGQ3ICVkIHBpeGVscykiXSA9ICIlZCBceGQ3ICVkIHBpeGVscyAoTmF0 dXJhbDogJWQgXHhkNyAlZCBwaXhlbHMpIjsKQEAgLTkyMSw4ICs5MjEsOCBAQCBsb2NhbGl6ZWRT dHJpbmdzWyJUZXh0IE5vZGUiXSA9ICJUZXh0IE5vZGUiOwogbG9jYWxpemVkU3RyaW5nc1siVGhl IFx1MjAxQyVzXHUyMDFEIGF1ZGl0IGZhaWxlZCJdID0gIlRoZSBcdTIwMUMlc1x1MjAxRCBhdWRp dCBmYWlsZWQiOwogbG9jYWxpemVkU3RyaW5nc1siVGhlIFx1MjAxQyVzXHUyMDFEIGF1ZGl0IGlz IHVuc3VwcG9ydGVkIl0gPSAiVGhlIFx1MjAxQyVzXHUyMDFEIGF1ZGl0IGlzIHVuc3VwcG9ydGVk IjsKIGxvY2FsaXplZFN0cmluZ3NbIlRoZSBcdTIwMUMlc1x1MjAxRCBhdWRpdCBwYXNzZWQiXSA9 ICJUaGUgXHUyMDFDJXNcdTIwMUQgYXVkaXQgcGFzc2VkIjsKK2xvY2FsaXplZFN0cmluZ3NbIlRo ZSBcdTIwMUMlc1x1MjAxRCBhdWRpdCByZXN1bHRlZCBpbiBhIHdhcm5pbmciXSA9ICJUaGUgXHUy MDFDJXNcdTIwMUQgYXVkaXQgcmVzdWx0ZWQgaW4gYSB3YXJuaW5nIjsKIGxvY2FsaXplZFN0cmlu Z3NbIlRoZSBcdTIwMUMlc1x1MjAxRCBhdWRpdCB0aHJldyBhbiBlcnJvciJdID0gIlRoZSBcdTIw MUMlc1x1MjAxRCBhdWRpdCB0aHJldyBhbiBlcnJvciI7Ci1sb2NhbGl6ZWRTdHJpbmdzWyJUaGUg XHUyMDFDJXNcdTIwMUQgYXVkaXQgd2FybmVkIl0gPSAiVGhlIFx1MjAxQyVzXHUyMDFEIGF1ZGl0 IHdhcm5lZCI7CiBsb2NhbGl6ZWRTdHJpbmdzWyJUaGUgXHUyMDFDJXNcdTIwMURcbnRhYmxlIGlz IGVtcHR5LiJdID0gIlRoZSBcdTIwMUMlc1x1MjAxRFxudGFibGUgaXMgZW1wdHkuIjsKIGxvY2Fs aXplZFN0cmluZ3NbIlRoZSBwYWdlJ3MgY29udGVudCBoYXMgY2hhbmdlZCJdID0gIlRoZSBwYWdl J3MgY29udGVudCBoYXMgY2hhbmdlZCI7CiBsb2NhbGl6ZWRTdHJpbmdzWyJUaGUgcmVzb3VyY2Ug d2FzIHJlcXVlc3RlZCBpbnNlY3VyZWx5LiJdID0gIlRoZSByZXNvdXJjZSB3YXMgcmVxdWVzdGVk IGluc2VjdXJlbHkuIjsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50 ZXJmYWNlL1ZpZXdzL0F1ZGl0VGVzdENvbnRlbnRWaWV3LmpzIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL1VzZXJJbnRlcmZhY2UvVmlld3MvQXVkaXRUZXN0Q29udGVudFZpZXcuanMKaW5kZXggOGE0 MDFmNGNkODY4ZmEyMjE5YzU2NjU3OTNkZGI1ZDJkM2EyOTQxZC4uODQwYWUzYmNhY2EwZjhlZTVl NmRmMDIyNjZlNDEzNzdjNTBmNmQ4ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJ L1VzZXJJbnRlcmZhY2UvVmlld3MvQXVkaXRUZXN0Q29udGVudFZpZXcuanMKKysrIGIvU291cmNl L1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvQXVkaXRUZXN0Q29udGVudFZpZXcu anMKQEAgLTE4MCw3ICsxODAsNyBAQCBXSS5BdWRpdFRlc3RDb250ZW50VmlldyA9IGNsYXNzIEF1 ZGl0VGVzdENvbnRlbnRWaWV3IGV4dGVuZHMgV0kuQ29udGVudFZpZXcKICAgICAgICAgICAgIGVs c2UgaWYgKHJlc3VsdC5kaWRGYWlsKQogICAgICAgICAgICAgICAgIG1lc3NhZ2UgPSBXSS5VSVN0 cmluZygiVGhlIFx1MjAxQyVzXHUyMDFEIGF1ZGl0IGZhaWxlZCIpOwogICAgICAgICAgICAgZWxz ZSBpZiAocmVzdWx0LmRpZFdhcm4pCi0gICAgICAgICAgICAgICAgbWVzc2FnZSA9IFdJLlVJU3Ry aW5nKCJUaGUgXHUyMDFDJXNcdTIwMUQgYXVkaXQgd2FybmVkIik7CisgICAgICAgICAgICAgICAg bWVzc2FnZSA9IFdJLlVJU3RyaW5nKCJUaGUgXHUyMDFDJXNcdTIwMUQgYXVkaXQgcmVzdWx0ZWQg aW4gYSB3YXJuaW5nIik7CiAgICAgICAgICAgICBlbHNlIGlmIChyZXN1bHQuZGlkUGFzcykKICAg ICAgICAgICAgICAgICBtZXNzYWdlID0gV0kuVUlTdHJpbmcoIlRoZSBcdTIwMUMlc1x1MjAxRCBh dWRpdCBwYXNzZWQiKTsKICAgICAgICAgICAgIGVsc2UgaWYgKHJlc3VsdC51bnN1cHBvcnRlZCkK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0F1 ZGl0VGVzdEdyb3VwQ29udGVudFZpZXcuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlcklu dGVyZmFjZS9WaWV3cy9BdWRpdFRlc3RHcm91cENvbnRlbnRWaWV3LmpzCmluZGV4IGEwMzc3ZTRh NGQyZDUyOTFiMTFiN2MzYjU1MWUyOTU1YzRhMjgzNzcuLjU0YmFjZjRkYjE5MjIxMWZhOTMyY2Ri NGQ4MzY1MTQ5N2JkOWUwZTkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2Vy SW50ZXJmYWNlL1ZpZXdzL0F1ZGl0VGVzdEdyb3VwQ29udGVudFZpZXcuanMKKysrIGIvU291cmNl L1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvQXVkaXRUZXN0R3JvdXBDb250ZW50 Vmlldy5qcwpAQCAtOTcsMTEgKzk3LDEyIEBAIFdJLkF1ZGl0VGVzdEdyb3VwQ29udGVudFZpZXcg PSBjbGFzcyBBdWRpdFRlc3RHcm91cENvbnRlbnRWaWV3IGV4dGVuZHMgV0kuQXVkaXRUCiAgICAg ICAgIGlmICghdGhpcy5fbGV2ZWxTY29wZUJhcikgewogICAgICAgICAgICAgbGV0IHNjb3BlQmFy SXRlbXMgPSBbXTsKIAotICAgICAgICAgICAgbGV0IGFkZFNjb3BlQmFySXRlbSA9IChsZXZlbCwg bGFiZWwpID0+IHsKKyAgICAgICAgICAgIGxldCBhZGRTY29wZUJhckl0ZW0gPSAobGV2ZWwsIGxh YmVsU2luZ3VsYXIsIGxhYmVsUGx1cmFsKSA9PiB7CiAgICAgICAgICAgICAgICAgbGV0IGNvdW50 ID0gbGV2ZWxDb3VudHNbbGV2ZWxdOwogICAgICAgICAgICAgICAgIGlmIChpc05hTihjb3VudCkg fHwgY291bnQgPD0gMCkKICAgICAgICAgICAgICAgICAgICAgcmV0dXJuOwogCisgICAgICAgICAg ICAgICAgbGV0IGxhYmVsID0gKGxhYmVsUGx1cmFsICYmIGNvdW50ICE9PSAxKSA/IGxhYmVsUGx1 cmFsIDogbGFiZWxTaW5ndWxhcjsKICAgICAgICAgICAgICAgICBsZXQgc2NvcGVCYXJJdGVtID0g bmV3IFdJLlNjb3BlQmFySXRlbShsZXZlbCwgbGFiZWwuZm9ybWF0KGNvdW50KSwgewogICAgICAg ICAgICAgICAgICAgICBjbGFzc05hbWU6IGxldmVsLAogICAgICAgICAgICAgICAgICAgICBleGNs dXNpdmU6IGZhbHNlLApAQCAtMTExLDEwICsxMTIsMTAgQEAgV0kuQXVkaXRUZXN0R3JvdXBDb250 ZW50VmlldyA9IGNsYXNzIEF1ZGl0VGVzdEdyb3VwQ29udGVudFZpZXcgZXh0ZW5kcyBXSS5BdWRp dFQKICAgICAgICAgICAgICAgICBzY29wZUJhckl0ZW1zLnB1c2goc2NvcGVCYXJJdGVtKTsKICAg ICAgICAgICAgIH07CiAKLSAgICAgICAgICAgIGFkZFNjb3BlQmFySXRlbShXSS5BdWRpdFRlc3RD YXNlUmVzdWx0LkxldmVsLlBhc3MsIFdJLlVJU3RyaW5nKCIlZCBQYXNzIikpOwotICAgICAgICAg ICAgYWRkU2NvcGVCYXJJdGVtKFdJLkF1ZGl0VGVzdENhc2VSZXN1bHQuTGV2ZWwuV2FybiwgV0ku VUlTdHJpbmcoIiVkIFdhcm4iKSk7Ci0gICAgICAgICAgICBhZGRTY29wZUJhckl0ZW0oV0kuQXVk aXRUZXN0Q2FzZVJlc3VsdC5MZXZlbC5GYWlsLCBXSS5VSVN0cmluZygiJWQgRmFpbCIpKTsKLSAg ICAgICAgICAgIGFkZFNjb3BlQmFySXRlbShXSS5BdWRpdFRlc3RDYXNlUmVzdWx0LkxldmVsLkVy cm9yLCBXSS5VSVN0cmluZygiJWQgRXJyb3IiKSk7CisgICAgICAgICAgICBhZGRTY29wZUJhckl0 ZW0oV0kuQXVkaXRUZXN0Q2FzZVJlc3VsdC5MZXZlbC5QYXNzLCBXSS5VSVN0cmluZygiJWQgUGFz c2VkIikpOworICAgICAgICAgICAgYWRkU2NvcGVCYXJJdGVtKFdJLkF1ZGl0VGVzdENhc2VSZXN1 bHQuTGV2ZWwuV2FybiwgV0kuVUlTdHJpbmcoIiVkIFdhcm5pbmciKSwgV0kuVUlTdHJpbmcoIiVk IFdhcm5pbmdzIikpOworICAgICAgICAgICAgYWRkU2NvcGVCYXJJdGVtKFdJLkF1ZGl0VGVzdENh c2VSZXN1bHQuTGV2ZWwuRmFpbCwgV0kuVUlTdHJpbmcoIiVkIEZhaWxlZCIpKTsKKyAgICAgICAg ICAgIGFkZFNjb3BlQmFySXRlbShXSS5BdWRpdFRlc3RDYXNlUmVzdWx0LkxldmVsLkVycm9yLCBX SS5VSVN0cmluZygiJWQgRXJyb3IiKSwgV0kuVUlTdHJpbmcoIiVkIEVycm9ycyIpKTsKICAgICAg ICAgICAgIGFkZFNjb3BlQmFySXRlbShXSS5BdWRpdFRlc3RDYXNlUmVzdWx0LkxldmVsLlVuc3Vw cG9ydGVkLCBXSS5VSVN0cmluZygiJWQgVW5zdXBwb3J0ZWQiKSk7CiAKICAgICAgICAgICAgIHRo aXMuX2xldmVsU2NvcGVCYXIgPSBuZXcgV0kuU2NvcGVCYXIobnVsbCwgc2NvcGVCYXJJdGVtcyk7 Cg==