192766 2018-12-17 11:37:04 -0800 Web Inspector: Settings: add singular "space" UIString 2018-12-17 13:15:48 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 hi hi bburg commit-queue hi inspector-bugzilla-changes webkit-bug-importer oldest_to_newest 1488517 0 hi 2018-12-17 11:37:04 -0800 . 1488518 1 hi 2018-12-17 11:37:23 -0800 <rdar://problem/46776948> 1488519 2 357460 hi 2018-12-17 11:38:33 -0800 Created attachment 357460 Patch 1488534 3 357460 bburg 2018-12-17 12:17:58 -0800 Comment on attachment 357460 Patch r=me 1488558 4 357460 commit-queue 2018-12-17 13:15:46 -0800 Comment on attachment 357460 Patch Clearing flags on attachment: 357460 Committed r239285: <https://trac.webkit.org/changeset/239285> 1488559 5 commit-queue 2018-12-17 13:15:48 -0800 All reviewed patches have been landed. Closing bug. 357460 2018-12-17 11:38:33 -0800 2018-12-17 13:15:46 -0800 Patch bug-192766-20181217113832.patch text/plain 6052 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDkxNTJhZDQ1YTc2YjdiMTZjNzk3MDAwMGRmYTg5 ZjlmODM0YzBjZGYuLmE3ZTFhODNkNDM1ZjMxNzlmZWY1OWYxMDg1NjE4YjE4NWQ5ODk3NzAgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDE4LTEyLTE3ICBEZXZp biBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBT ZXR0aW5nczogYWRkIHNpbmd1bGFyICJzcGFjZSIgVUlTdHJpbmcKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5Mjc2NgorICAgICAgICA8cmRhcjovL3By b2JsZW0vNDY3NzY5NDg+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL1NldHRpbmdFZGl0b3IuanM6CisgICAgICAg IChXSS5TZXR0aW5nRWRpdG9yKToKKyAgICAgICAgKFdJLlNldHRpbmdFZGl0b3IucHJvdG90eXBl LmdldCBsYWJlbCk6CisgICAgICAgIChXSS5TZXR0aW5nRWRpdG9yLnByb3RvdHlwZS5zZXQgbGFi ZWwpOiBBZGRlZC4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvVmlld3MvU2V0dGluZ3NUYWJD b250ZW50Vmlldy5qczoKKyAgICAgICAgKFdJLlNldHRpbmdzVGFiQ29udGVudFZpZXcucHJvdG90 eXBlLl9jcmVhdGVHZW5lcmFsU2V0dGluZ3NWaWV3KToKKyAgICAgICAgKFdJLlNldHRpbmdzVGFi Q29udGVudFZpZXcucHJvdG90eXBlLl9jcmVhdGVHZW5lcmFsU2V0dGluZ3NWaWV3LmFkZFNwYWNl c1NldHRpbmcpOiBBZGRlZC4KKyAgICAgICAgKFdJLlNldHRpbmdzVGFiQ29udGVudFZpZXcucHJv dG90eXBlLl9jcmVhdGVHZW5lcmFsU2V0dGluZ3NWaWV3LmFkZFNwYWNlc1NldHRpbmcudXBkYXRl TGFiZWwpOiBBZGRlZC4KKworICAgICAgICAqIExvY2FsaXphdGlvbnMvZW4ubHByb2ovbG9jYWxp emVkU3RyaW5ncy5qczoKKwogMjAxOC0xMi0xNSAgTmlraXRhIFZhc2lseWV2ICA8bnZhc2lseWV2 QGFwcGxlLmNvbT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBTdHlsZXM6IHRvZ2dsaW5nIHNl bGVjdGVkIHByb3BlcnRpZXMgbWF5IGNhdXNlIGRhdGEgY29ycnVwdGlvbgpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkluc3BlY3RvclVJL0xvY2FsaXphdGlvbnMvZW4ubHByb2ovbG9jYWxpemVkU3Ry aW5ncy5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Mb2NhbGl6YXRpb25zL2VuLmxwcm9qL2xv Y2FsaXplZFN0cmluZ3MuanMKaW5kZXggMGQxZGJhOGE1OWRhYTc3NTZlYzI3OGY5OWJlOGUwMTYy OWUwZjU1MC4uYTljYmFjZjE1ZDA1NWU2ZDdiZDczMDViYTY1Yzk5MWVmMmI4OTMwYiAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL0xvY2FsaXphdGlvbnMvZW4ubHByb2ovbG9jYWxp emVkU3RyaW5ncy5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvTG9jYWxpemF0aW9ucy9l bi5scHJvai9sb2NhbGl6ZWRTdHJpbmdzLmpzCkBAIC0xMDQzLDYgKzEwNDMsNyBAQCBsb2NhbGl6 ZWRTdHJpbmdzWyJsaW5lICJdID0gImxpbmUgIjsKIGxvY2FsaXplZFN0cmluZ3NbIm9yaWdpbmFs bHkgJXMiXSA9ICJvcmlnaW5hbGx5ICVzIjsKIGxvY2FsaXplZFN0cmluZ3NbInBvcHVwIl0gPSAi cG9wdXAiOwogbG9jYWxpemVkU3RyaW5nc1sicG9wdXAsIHRvZ2dsZSJdID0gInBvcHVwLCB0b2dn bGUiOworbG9jYWxpemVkU3RyaW5nc1sic3BhY2UiXSA9ICJzcGFjZSI7CiBsb2NhbGl6ZWRTdHJp bmdzWyJzcGFjZXMiXSA9ICJzcGFjZXMiOwogbG9jYWxpemVkU3RyaW5nc1sidGltZSBiZWZvcmUg c3RvcHBpbmciXSA9ICJ0aW1lIGJlZm9yZSBzdG9wcGluZyI7CiBsb2NhbGl6ZWRTdHJpbmdzWyJ0 aW1lcyBiZWZvcmUgc3RvcHBpbmciXSA9ICJ0aW1lcyBiZWZvcmUgc3RvcHBpbmciOwpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvU2V0dGluZ0Vk aXRvci5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1NldHRp bmdFZGl0b3IuanMKaW5kZXggYWRkMGUzODZlNWNlMWQ0MjkzYWM0ZmQ0ZDdjOTE1OTkyODIzYmQz Mi4uNjQ4YmFhNmIxNGFiYTM3Njg0ZmU0NjE3N2IyMTI0ZWIzMWJjZDgyYSAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvU2V0dGluZ0VkaXRvci5q cworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9TZXR0aW5n RWRpdG9yLmpzCkBAIC0zMCw3ICszMCw2IEBAIFdJLlNldHRpbmdFZGl0b3IgPSBjbGFzcyBTZXR0 aW5nRWRpdG9yIGV4dGVuZHMgV0kuT2JqZWN0CiAgICAgICAgIHN1cGVyKCk7CiAKICAgICAgICAg dGhpcy5fdHlwZSA9IHR5cGU7Ci0gICAgICAgIHRoaXMuX2xhYmVsID0gbGFiZWw7CiAgICAgICAg IHRoaXMuX3ZhbHVlID0gbnVsbDsKIAogICAgICAgICB0aGlzLl9lZGl0b3JFbGVtZW50ID0gdGhp cy5fY3JlYXRlRWRpdG9yRWxlbWVudChvcHRpb25zKTsKQEAgLTQwLDE0ICszOSw3IEBAIFdJLlNl dHRpbmdFZGl0b3IgPSBjbGFzcyBTZXR0aW5nRWRpdG9yIGV4dGVuZHMgV0kuT2JqZWN0CiAgICAg ICAgIHRoaXMuX2VsZW1lbnQuY2xhc3NMaXN0LmFkZCgiZWRpdG9yIik7CiAgICAgICAgIHRoaXMu X2VsZW1lbnQuYXBwZW5kKHRoaXMuX2VkaXRvckVsZW1lbnQpOwogCi0gICAgICAgIGlmICh0aGlz Ll9sYWJlbCkgewotICAgICAgICAgICAgdGhpcy5fZWRpdG9yRWxlbWVudC5pZCA9ICJzZXR0aW5n LWVkaXRvci0iICsgV0kuU2V0dGluZ0VkaXRvci5fbmV4dEVkaXRvcklkZW50aWZpZXIrKzsKLSAg ICAgICAgICAgIGxldCBsYWJlbEVsZW1lbnQgPSBkb2N1bWVudC5jcmVhdGVFbGVtZW50KCJsYWJl bCIpOwotICAgICAgICAgICAgbGFiZWxFbGVtZW50LnNldEF0dHJpYnV0ZSgiZm9yIiwgdGhpcy5f ZWRpdG9yRWxlbWVudC5pZCk7Ci0gICAgICAgICAgICBsYWJlbEVsZW1lbnQudGV4dENvbnRlbnQg PSBsYWJlbDsKLQotICAgICAgICAgICAgdGhpcy5fZWxlbWVudC5hcHBlbmQobGFiZWxFbGVtZW50 KTsKLSAgICAgICAgfQorICAgICAgICB0aGlzLmxhYmVsID0gbGFiZWw7CiAgICAgfQogCiAgICAg c3RhdGljIGNyZWF0ZUZvclNldHRpbmcoc2V0dGluZywgbGFiZWwsIG9wdGlvbnMpCkBAIC03NCw3 ICs2NiwzNiBAQCBXSS5TZXR0aW5nRWRpdG9yID0gY2xhc3MgU2V0dGluZ0VkaXRvciBleHRlbmRz IFdJLk9iamVjdAogCiAgICAgZ2V0IGVsZW1lbnQoKSB7IHJldHVybiB0aGlzLl9lbGVtZW50OyB9 CiAgICAgZ2V0IHR5cGUoKSB7IHJldHVybiB0aGlzLl90eXBlOyB9Ci0gICAgZ2V0IGxhYmVsKCkg eyByZXR1cm4gdGhpcy5fbGFiZWw7IH0KKworICAgIGdldCBsYWJlbCgpCisgICAgeworICAgICAg ICByZXR1cm4gdGhpcy5fbGFiZWw7CisgICAgfQorCisgICAgc2V0IGxhYmVsKGxhYmVsKQorICAg IHsKKyAgICAgICAgaWYgKGxhYmVsID09PSB0aGlzLl9sYWJlbCkKKyAgICAgICAgICAgIHJldHVy bjsKKworICAgICAgICB0aGlzLl9sYWJlbCA9IGxhYmVsOworCisgICAgICAgIGlmICghdGhpcy5f bGFiZWwpIHsKKyAgICAgICAgICAgIGlmICh0aGlzLl9sYWJlbEVsZW1lbnQpCisgICAgICAgICAg ICAgICAgdGhpcy5fbGFiZWxFbGVtZW50LnJlbW92ZSgpOworCisgICAgICAgICAgICB0aGlzLl9l ZGl0b3JFbGVtZW50LnJlbW92ZUF0dHJpYnV0ZSgiaWQiKTsKKyAgICAgICAgICAgIHRoaXMuX2xh YmVsRWxlbWVudCA9IG51bGw7CisgICAgICAgICAgICByZXR1cm47CisgICAgICAgIH0KKworICAg ICAgICBpZiAoIXRoaXMuX2xhYmVsRWxlbWVudCkgeworICAgICAgICAgICAgdGhpcy5fZWRpdG9y RWxlbWVudC5pZCA9ICJzZXR0aW5nLWVkaXRvci0iICsgV0kuU2V0dGluZ0VkaXRvci5fbmV4dEVk aXRvcklkZW50aWZpZXIrKzsKKyAgICAgICAgICAgIHRoaXMuX2xhYmVsRWxlbWVudCA9IHRoaXMu X2VsZW1lbnQuYXBwZW5kQ2hpbGQoZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgibGFiZWwiKSk7Cisg ICAgICAgICAgICB0aGlzLl9sYWJlbEVsZW1lbnQuc2V0QXR0cmlidXRlKCJmb3IiLCB0aGlzLl9l ZGl0b3JFbGVtZW50LmlkKTsKKyAgICAgICAgfQorCisgICAgICAgIHRoaXMuX2xhYmVsRWxlbWVu dC50ZXh0Q29udGVudCA9IHRoaXMuX2xhYmVsOworICAgIH0KIAogICAgIGdldCB2YWx1ZSgpCiAg ICAgewpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmll d3MvU2V0dGluZ3NUYWJDb250ZW50Vmlldy5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2Vy SW50ZXJmYWNlL1ZpZXdzL1NldHRpbmdzVGFiQ29udGVudFZpZXcuanMKaW5kZXggZTRkNTZmMmZj N2Q4NzU2Y2NmMTUwZDczOTdmZDQxMTE3YTVhODMzMS4uNjA1MTFkZTNiMmQwN2FkYmVkM2UyN2Zk OTA5ZTg2NTI0NDM4MWM4NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJ bnRlcmZhY2UvVmlld3MvU2V0dGluZ3NUYWJDb250ZW50Vmlldy5qcworKysgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9TZXR0aW5nc1RhYkNvbnRlbnRWaWV3Lmpz CkBAIC0xODQsMTEgKzE4NCwxOSBAQCBXSS5TZXR0aW5nc1RhYkNvbnRlbnRWaWV3ID0gY2xhc3Mg U2V0dGluZ3NUYWJDb250ZW50VmlldyBleHRlbmRzIFdJLlRhYkNvbnRlbnRWaQogICAgICAgICAg ICAgV0kuc2V0dGluZ3MuaW5kZW50V2l0aFRhYnMudmFsdWUgPSBpbmRlbnRFZGl0b3IudmFsdWUg PT09IGluZGVudFZhbHVlc1swXTsKICAgICAgICAgfSk7CiAKLSAgICAgICAgY29uc3Qgd2lkdGhM YWJlbCA9IFdJLlVJU3RyaW5nKCJzcGFjZXMiKTsKLSAgICAgICAgY29uc3Qgd2lkdGhPcHRpb25z ID0ge21pbjogMX07CisgICAgICAgIGZ1bmN0aW9uIGFkZFNwYWNlc1NldHRpbmcodGl0bGUsIHNl dHRpbmcpIHsKKyAgICAgICAgICAgIGxldCBlZGl0b3IgPSBnZW5lcmFsU2V0dGluZ3NWaWV3LmFk ZFNldHRpbmcodGl0bGUsIHNldHRpbmcsIFdJLlVJU3RyaW5nKCJzcGFjZXMiKSwge21pbjogMX0p OwogCi0gICAgICAgIGdlbmVyYWxTZXR0aW5nc1ZpZXcuYWRkU2V0dGluZyhXSS5VSVN0cmluZygi VGFiIHdpZHRoOiIpLCBXSS5zZXR0aW5ncy50YWJTaXplLCB3aWR0aExhYmVsLCB3aWR0aE9wdGlv bnMpOwotICAgICAgICBnZW5lcmFsU2V0dGluZ3NWaWV3LmFkZFNldHRpbmcoV0kuVUlTdHJpbmco IkluZGVudCB3aWR0aDoiKSwgV0kuc2V0dGluZ3MuaW5kZW50VW5pdCwgd2lkdGhMYWJlbCwgd2lk dGhPcHRpb25zKTsKKyAgICAgICAgICAgIGZ1bmN0aW9uIHVwZGF0ZUxhYmVsKCkgeworICAgICAg ICAgICAgICAgIGVkaXRvci5sYWJlbCA9IHNldHRpbmcudmFsdWUgPT09IDEgPyBXSS5VSVN0cmlu Zygic3BhY2UiKSA6IFdJLlVJU3RyaW5nKCJzcGFjZXMiKTsKKyAgICAgICAgICAgIH0KKyAgICAg ICAgICAgIHNldHRpbmcuYWRkRXZlbnRMaXN0ZW5lcihXSS5TZXR0aW5nLkV2ZW50LkNoYW5nZWQs IChldmVudCkgPT4geworICAgICAgICAgICAgICAgIHVwZGF0ZUxhYmVsKCk7CisgICAgICAgICAg ICB9KTsKKyAgICAgICAgICAgIHVwZGF0ZUxhYmVsKCk7CisgICAgICAgIH0KKyAgICAgICAgYWRk U3BhY2VzU2V0dGluZyhXSS5VSVN0cmluZygiVGFiIHdpZHRoOiIpLCBXSS5zZXR0aW5ncy50YWJT aXplKTsKKyAgICAgICAgYWRkU3BhY2VzU2V0dGluZyhXSS5VSVN0cmluZygiSW5kZW50IHdpZHRo OiIpLCBXSS5zZXR0aW5ncy5pbmRlbnRVbml0KTsKIAogICAgICAgICBnZW5lcmFsU2V0dGluZ3NW aWV3LmFkZFNldHRpbmcoV0kuVUlTdHJpbmcoIkxpbmUgd3JhcHBpbmc6IiksIFdJLnNldHRpbmdz LmVuYWJsZUxpbmVXcmFwcGluZywgV0kuVUlTdHJpbmcoIldyYXAgbGluZXMgdG8gZWRpdG9yIHdp ZHRoIikpOwogCg==