192756 2018-12-17 08:00:15 -0800 [LFC][BFC][MarginCollapsing] BlockFormattingState should cache the maximum positive and negative margin values for margin collapsing. 2022-10-10 09:58:43 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified NEW P2 Normal --- 215087 1 zalan zalan ahmad.saleem792 bfulgham koivisto simon.fraser zalan oldest_to_newest 1488437 0 zalan 2018-12-17 08:00:15 -0800 When two or more margins collapse, the resulting margin width is the maximum of the collapsing margins' widths. In the case of negative margins, the maximum of the absolute values of the negative adjoining margins is deducted from the maximum of the positive adjoining margins. If there are no positive margins, the maximum of the absolute values of the adjoining margins is deducted from zero. 1488438 1 357440 zalan 2018-12-17 08:05:42 -0800 Created attachment 357440 Patch 1904519 2 ahmad.saleem792 2022-10-10 09:58:43 -0700 I checked with BugID on Webkit GitHub and it seems this r+ patch didn't landed. Thanks! 357440 2018-12-17 08:05:42 -0800 2018-12-18 07:36:52 -0800 Patch bug-192756-20181217080539.patch text/plain 2601 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjM5MjY0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDU5NDliZTI0YjY3NTU1 NTU1MDk5MzVkZGViNWY5ZjMxZjk2MzMyNy4uMzViMThkNzZmMmMyYTFiYjdjZjZjNTYwMGI2NzI5 OWQ5ZGZjZDlhZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDE4LTEyLTE3ICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW0xGQ11bQkZDXVtNYXJnaW5D b2xsYXBzaW5nXSBCbG9ja0Zvcm1hdHRpbmdTdGF0ZSBzaG91bGQgY2FjaGUgdGhlIG1heGltdW0g cG9zaXRpdmUgYW5kIG5lZ2F0aXZlIG1hcmdpbiB2YWx1ZXMgZm9yIG1hcmdpbiBjb2xsYXBzaW5n LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTkyNzU2 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgaHR0cHM6 Ly93d3cudzMub3JnL1RSL0NTUzIyL2JveC5odG1sI2NvbGxhcHNpbmctbWFyZ2lucworCisgICAg ICAgICJXaGVuIHR3byBvciBtb3JlIG1hcmdpbnMgY29sbGFwc2UsIHRoZSByZXN1bHRpbmcgbWFy Z2luIHdpZHRoIGlzIHRoZSBtYXhpbXVtIG9mIHRoZSBjb2xsYXBzaW5nIG1hcmdpbnMnIHdpZHRo cy4KKyAgICAgICAgSW4gdGhlIGNhc2Ugb2YgbmVnYXRpdmUgbWFyZ2lucywgdGhlIG1heGltdW0g b2YgdGhlIGFic29sdXRlIHZhbHVlcyBvZiB0aGUgbmVnYXRpdmUgYWRqb2luaW5nIG1hcmdpbnMg aXMgZGVkdWN0ZWQKKyAgICAgICAgZnJvbSB0aGUgbWF4aW11bSBvZiB0aGUgcG9zaXRpdmUgYWRq b2luaW5nIG1hcmdpbnMuIElmIHRoZXJlIGFyZSBubyBwb3NpdGl2ZSBtYXJnaW5zLCB0aGUgbWF4 aW11bSBvZiB0aGUgYWJzb2x1dGUKKyAgICAgICAgdmFsdWVzIG9mIHRoZSBhZGpvaW5pbmcgbWFy Z2lucyBpcyBkZWR1Y3RlZCBmcm9tIHplcm8uIgorCisgICAgICAgICogbGF5b3V0L2Jsb2NrZm9y bWF0dGluZy9CbG9ja0Zvcm1hdHRpbmdTdGF0ZS5oOgorICAgICAgICAoV2ViQ29yZTo6TGF5b3V0 OjpCbG9ja0Zvcm1hdHRpbmdTdGF0ZTo6c2V0UG9zaXRpdmVBbmROZWdhdGl2ZVZlcnRpY2FsTWFy Z2luKToKKyAgICAgICAgKFdlYkNvcmU6OkxheW91dDo6QmxvY2tGb3JtYXR0aW5nU3RhdGU6OnBv c2l0aXZlQW5kTmVnYXRpdmVWZXJ0aWNhbE1hcmdpbiBjb25zdCk6CisKIDIwMTgtMTItMTUgIFl1 c3VrZSBTdXp1a2kgIDx5dXN1a2VzdXp1a2lAc2xvd3N0YXJ0Lm9yZz4KIAogICAgICAgICBOdWxs IHBvaW50ZXIgZGVyZWZlcmVuY2UgaW4gSlNDOjpXcml0ZUJhcnJpZXJCYXNlKCkKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL2xheW91dC9ibG9ja2Zvcm1hdHRpbmcvQmxvY2tGb3JtYXR0aW5n U3RhdGUuaCBiL1NvdXJjZS9XZWJDb3JlL2xheW91dC9ibG9ja2Zvcm1hdHRpbmcvQmxvY2tGb3Jt YXR0aW5nU3RhdGUuaAppbmRleCBiYjk2NjkzOTBmZjlhMjg3NmZlNzE0ZGM4NTQ0YjAxZGY2ZGVh YTg0Li44NzA1OGQwNGQ1NDFjMzE2MzQ0NmFmZDg0ZDI4ZDJiY2UxMGM1YWY2IDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvYmxvY2tmb3JtYXR0aW5nL0Jsb2NrRm9ybWF0dGluZ1N0 YXRlLmgKKysrIGIvU291cmNlL1dlYkNvcmUvbGF5b3V0L2Jsb2NrZm9ybWF0dGluZy9CbG9ja0Zv cm1hdHRpbmdTdGF0ZS5oCkBAIC0yOCw2ICsyOCw3IEBACiAjaWYgRU5BQkxFKExBWU9VVF9GT1JN QVRUSU5HX0NPTlRFWFQpCiAKICNpbmNsdWRlICJGb3JtYXR0aW5nU3RhdGUuaCIKKyNpbmNsdWRl ICJNYXJnaW5UeXBlcy5oIgogI2luY2x1ZGUgPHd0Zi9Jc29NYWxsb2MuaD4KIAogbmFtZXNwYWNl IFdlYkNvcmUgewpAQCAtNDIsNiArNDMsMTIgQEAgcHVibGljOgogICAgIHZpcnR1YWwgfkJsb2Nr Rm9ybWF0dGluZ1N0YXRlKCk7CiAKICAgICBzdGQ6OnVuaXF1ZV9wdHI8Rm9ybWF0dGluZ0NvbnRl eHQ+IGNyZWF0ZUZvcm1hdHRpbmdDb250ZXh0KGNvbnN0IEJveCYgZm9ybWF0dGluZ0NvbnRleHRS b290KSBvdmVycmlkZTsKKworICAgIHZvaWQgc2V0UG9zaXRpdmVBbmROZWdhdGl2ZVZlcnRpY2Fs TWFyZ2luKGNvbnN0IEJveCYgbGF5b3V0Qm94LCBQb3NpdGl2ZUFuZE5lZ2F0aXZlVmVydGljYWxN YXJnaW4gdmVydGljYWxNYXJnaW4pIHsgbV9wb3NpdGl2ZUFuZE5lZ2F0aXZlVmVydGljYWxNYXJn aW4uc2V0KCZsYXlvdXRCb3gsIHZlcnRpY2FsTWFyZ2luKTsgfQorICAgIFBvc2l0aXZlQW5kTmVn YXRpdmVWZXJ0aWNhbE1hcmdpbiBwb3NpdGl2ZUFuZE5lZ2F0aXZlVmVydGljYWxNYXJnaW4oY29u c3QgQm94JiBsYXlvdXRCb3gpIGNvbnN0IHsgcmV0dXJuIG1fcG9zaXRpdmVBbmROZWdhdGl2ZVZl cnRpY2FsTWFyZ2luLmdldCgmbGF5b3V0Qm94KTsgfQorCitwcml2YXRlOgorICAgIEhhc2hNYXA8 Y29uc3QgQm94KiwgUG9zaXRpdmVBbmROZWdhdGl2ZVZlcnRpY2FsTWFyZ2luPiBtX3Bvc2l0aXZl QW5kTmVnYXRpdmVWZXJ0aWNhbE1hcmdpbjsKIH07CiAKIH0K