192744 2018-12-15 15:49:49 -0800 Fix occasional null-dereference crash in WebPageProxy::didReceiveServerRedirectForProvisionalLoadForFrame 2018-12-17 17:33:36 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 achristensen achristensen cdumez commit-queue webkit-bug-importer oldest_to_newest 1488320 0 achristensen 2018-12-15 15:49:49 -0800 Fix occasional null-dereference crash in WebPageProxy::didReceiveServerRedirectForProvisionalLoadForFrame 1488321 1 357408 achristensen 2018-12-15 15:50:55 -0800 Created attachment 357408 Patch 1488322 2 357408 cdumez 2018-12-15 16:00:24 -0800 Comment on attachment 357408 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=357408&action=review > Source/WebKit/ChangeLog:5 > + <rdar://problem/45842668> I believe I fixed this crash in https://trac.webkit.org/changeset/238565 already, with a test. 1488463 3 357408 achristensen 2018-12-17 10:36:32 -0800 Comment on attachment 357408 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=357408&action=review >> Source/WebKit/ChangeLog:5 >> + <rdar://problem/45842668> > > I believe I fixed this crash in https://trac.webkit.org/changeset/238565 already, with a test. You did not. This crash has been seen since then. 1488643 4 357408 cdumez 2018-12-17 15:56:31 -0800 Comment on attachment 357408 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=357408&action=review >>> Source/WebKit/ChangeLog:5 >>> + <rdar://problem/45842668> >> >> I believe I fixed this crash in https://trac.webkit.org/changeset/238565 already, with a test. > > You did not. This crash has been seen since then. Crash trace is actually different but yes. 1488684 5 357408 commit-queue 2018-12-17 17:32:43 -0800 Comment on attachment 357408 Patch Clearing flags on attachment: 357408 Committed r239305: <https://trac.webkit.org/changeset/239305> 1488685 6 commit-queue 2018-12-17 17:32:44 -0800 All reviewed patches have been landed. Closing bug. 1488686 7 webkit-bug-importer 2018-12-17 17:33:36 -0800 <rdar://problem/46796907> 357408 2018-12-15 15:50:55 -0800 2018-12-17 17:32:43 -0800 Patch bug-192744-20181215155054.patch text/plain 1724 achristensen SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyMzkyNTMpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE4LTEyLTE1ICBBbGV4IENocmlz dGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgRml4IG9jY2FzaW9u YWwgbnVsbC1kZXJlZmVyZW5jZSBjcmFzaCBpbiBXZWJQYWdlUHJveHk6OmRpZFJlY2VpdmVTZXJ2 ZXJSZWRpcmVjdEZvclByb3Zpc2lvbmFsTG9hZEZvckZyYW1lCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTI3NDQKKyAgICAgICAgPHJkYXI6Ly9wcm9i bGVtLzQ1ODQyNjY4PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgICogVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5jcHA6CisgICAgICAgIChXZWJLaXQ6Oldl YlBhZ2VQcm94eTo6ZGlkUmVjZWl2ZVNlcnZlclJlZGlyZWN0Rm9yUHJvdmlzaW9uYWxMb2FkRm9y RnJhbWUpOgorICAgICAgICBUaGluZ3MgaGFwcGVuLiAgTmF2aWdhdGlvbnMgY2FuIGJlIG51bGwu ICBJZiB0aGV5IGFyZSwgd2Ugc2hvdWxkbid0IGRlcmVmZXJlbmNlIHBvaW50ZXJzIHRvIHRoZW0u CisKIDIwMTgtMTItMTQgIFJ5YW4gSGFkZGFkICA8cnlhbmhhZGRhZEBhcHBsZS5jb20+CiAKICAg ICAgICAgVW5yZXZpZXdlZCwgZml4IHRoZSBidWlsZCB3aXRoIHJlY2VudCBTREtzLgpJbmRleDog U291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkuY3BwCShyZXZpc2lvbiAyMzkyMjIp CisrKyBTb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkuY3BwCSh3b3JraW5nIGNv cHkpCkBAIC0zNzcyLDExICszNzcyLDkgQEAgdm9pZCBXZWJQYWdlUHJveHk6OmRpZFJlY2VpdmVT ZXJ2ZXJSZWRpcgogICAgIE1FU1NBR0VfQ0hFQ0tfVVJMKHJlcXVlc3QudXJsKCkpOwogCiAgICAg Ly8gRklYTUU6IFdlIHNob3VsZCBtZXNzYWdlIGNoZWNrIHRoYXQgbmF2aWdhdGlvbklEIGlzIG5v dCB6ZXJvIGhlcmUsIGJ1dCBpdCdzIGN1cnJlbnRseSB6ZXJvIGZvciBzb21lIG5hdmlnYXRpb25z IHRocm91Z2ggdGhlIHBhZ2UgY2FjaGUuCi0gICAgUmVmUHRyPEFQSTo6TmF2aWdhdGlvbj4gbmF2 aWdhdGlvbjsKLSAgICBpZiAobmF2aWdhdGlvbklEKSB7Ci0gICAgICAgIG5hdmlnYXRpb24gPSBu YXZpZ2F0aW9uU3RhdGUoKS5uYXZpZ2F0aW9uKG5hdmlnYXRpb25JRCk7CisgICAgUmVmUHRyPEFQ STo6TmF2aWdhdGlvbj4gbmF2aWdhdGlvbiA9IG5hdmlnYXRpb25JRCA/IG5hdmlnYXRpb25TdGF0 ZSgpLm5hdmlnYXRpb24obmF2aWdhdGlvbklEKSA6IG51bGxwdHI7CisgICAgaWYgKG5hdmlnYXRp b24pCiAgICAgICAgIG5hdmlnYXRpb24tPmFwcGVuZFJlZGlyZWN0aW9uVVJMKHJlcXVlc3QudXJs KCkpOwotICAgIH0KIAogICAgIGF1dG8gdHJhbnNhY3Rpb24gPSBtX3BhZ2VMb2FkU3RhdGUudHJh bnNhY3Rpb24oKTsKIAo=