<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>192709</bug_id>
          
          <creation_ts>2018-12-14 11:39:39 -0800</creation_ts>
          <short_desc>Callers of JSString::getIndex should check for OOM exceptions</short_desc>
          <delta_ts>2018-12-14 12:53:19 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Keith Miller">keith_miller</reporter>
          <assigned_to name="Keith Miller">keith_miller</assigned_to>
          <cc>commit-queue</cc>
    
    <cc>ews-watchlist</cc>
    
    <cc>mark.lam</cc>
    
    <cc>msaboff</cc>
    
    <cc>saam</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1487984</commentid>
    <comment_count>0</comment_count>
    <who name="Keith Miller">keith_miller</who>
    <bug_when>2018-12-14 11:39:39 -0800</bug_when>
    <thetext>Callers of JSString::getIndex should check for OOM exceptions</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1487988</commentid>
    <comment_count>1</comment_count>
      <attachid>357327</attachid>
    <who name="Keith Miller">keith_miller</who>
    <bug_when>2018-12-14 11:43:17 -0800</bug_when>
    <thetext>Created attachment 357327
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1487989</commentid>
    <comment_count>2</comment_count>
      <attachid>357327</attachid>
    <who name="Mark Lam">mark.lam</who>
    <bug_when>2018-12-14 11:49:44 -0800</bug_when>
    <thetext>Comment on attachment 357327
Patch

r=me</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1487994</commentid>
    <comment_count>3</comment_count>
    <who name="Keith Miller">keith_miller</who>
    <bug_when>2018-12-14 12:14:09 -0800</bug_when>
    <thetext>rdar://problem/44451952</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1487995</commentid>
    <comment_count>4</comment_count>
      <attachid>357327</attachid>
    <who name="Keith Miller">keith_miller</who>
    <bug_when>2018-12-14 12:14:58 -0800</bug_when>
    <thetext>Comment on attachment 357327
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=357327&amp;action=review

&gt; JSTests/stress/StringObject-define-length-getter-rope-string-oom.js:3
&gt; +let char16 = decodeURI(&apos;%E7%9A%84&apos;);
&gt; +let rope = char16.padEnd(2147483644, 1);
&gt; +rope.__defineGetter__(256, function () {});

Whoops forgot to wrap this in a try catch. Will do that before landing.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1487997</commentid>
    <comment_count>5</comment_count>
      <attachid>357330</attachid>
    <who name="Keith Miller">keith_miller</who>
    <bug_when>2018-12-14 12:15:23 -0800</bug_when>
    <thetext>Created attachment 357330
Patch for landing</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1488008</commentid>
    <comment_count>6</comment_count>
      <attachid>357330</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2018-12-14 12:53:17 -0800</bug_when>
    <thetext>Comment on attachment 357330
Patch for landing

Clearing flags on attachment: 357330

Committed r239227: &lt;https://trac.webkit.org/changeset/239227&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1488009</commentid>
    <comment_count>7</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2018-12-14 12:53:19 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>357327</attachid>
            <date>2018-12-14 11:43:17 -0800</date>
            <delta_ts>2018-12-14 12:15:22 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-192709-20181214114315.patch</filename>
            <type>text/plain</type>
            <size>6607</size>
            <attacher name="Keith Miller">keith_miller</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjM5MTgwCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw
dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA3
NWFhMzc0NDZmYjdiYmU0MjgxZjFhYWYwMjk4NGJjMWMyYjEzYTdhLi4wN2QzMThiZTcxZGEzN2I4
MGZjNTU2YTQ0OTc1ZWFmM2NiYTRjNmJhIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv
cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs
MyArMSwyNSBAQAorMjAxOC0xMi0xNCAgS2VpdGggTWlsbGVyICA8a2VpdGhfbWlsbGVyQGFwcGxl
LmNvbT4KKworICAgICAgICBDYWxsZXJzIG9mIEpTU3RyaW5nOjpnZXRJbmRleCBzaG91bGQgY2hl
Y2sgZm9yIE9PTSBleGNlcHRpb25zCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No
b3dfYnVnLmNnaT9pZD0xOTI3MDkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh
KS4KKworICAgICAgICBUaGlzIHBhdGNoIGFsc28gYWxsb3dzIFN0cmluZ3MgdG8gT09NIHdoZW4g
dGhlIFN0cmluZ09iamVjdCB3cmFwcGVyCisgICAgICAgIGF0dGVtcHRzIHRvIGxvb2sgdXAgYW4g
b3duIHByb3BlcnR5IG9uIHRoZSBzdHJpbmcuCisKKyAgICAgICAgUmVtb3ZlIGlzRXh0ZW5zaWJs
ZUltcGwgYmVjYXVzZSBpdCdzIG9ubHkgdXNlZCBpbiBvbmUgcGxhY2UgYW5kIGNhbGwKKyAgICAg
ICAgaXNTdHJ1Y3R1cmVFeHRlbnNpYmxlIGluc3RlYWQuCisKKyAgICAgICAgKiBydW50aW1lL0pT
T2JqZWN0LmNwcDoKKyAgICAgICAgKEpTQzo6SlNPYmplY3Q6OmlzRXh0ZW5zaWJsZSk6CisgICAg
ICAgICogcnVudGltZS9KU09iamVjdC5oOgorICAgICAgICAoSlNDOjpKU09iamVjdDo6aXNFeHRl
bnNpYmxlSW1wbCk6IERlbGV0ZWQuCisgICAgICAgICogcnVudGltZS9KU1N0cmluZy5oOgorICAg
ICAgICAoSlNDOjpKU1N0cmluZzo6Z2V0U3RyaW5nUHJvcGVydHlTbG90KToKKyAgICAgICAgKiBy
dW50aW1lL1N0cmluZ09iamVjdC5jcHA6CisgICAgICAgIChKU0M6OlN0cmluZ09iamVjdDo6ZGVm
aW5lT3duUHJvcGVydHkpOgorCiAyMDE4LTEyLTEzICBDYWlvIExpbWEgIDx0aWNhaW9saW1hQGdt
YWlsLmNvbT4KIAogICAgICAgICBbQmlnSW50XSBBZGQgVmFsdWVEaXYgaW50byBERkcKZGlmZiAt
LWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTT2JqZWN0LmNwcCBiL1NvdXJj
ZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTT2JqZWN0LmNwcAppbmRleCBiN2ZhNzk1OTI4NjI5
NzE1NTg2MWY4NWM1NzZjYmNhYzNjM2E4MGFjLi4yMGZjZDQwMzJjZTZiMzgzMTdjNzZjNTM4Nzli
Y2ZkM2I2YjE2ODhmIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9K
U09iamVjdC5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNPYmplY3Qu
Y3BwCkBAIC0yNDMxLDcgKzI0MzEsNyBAQCBib29sIEpTT2JqZWN0OjpwcmV2ZW50RXh0ZW5zaW9u
cyhKU09iamVjdCogb2JqZWN0LCBFeGVjU3RhdGUqIGV4ZWMpCiAKIGJvb2wgSlNPYmplY3Q6Omlz
RXh0ZW5zaWJsZShKU09iamVjdCogb2JqLCBFeGVjU3RhdGUqIGV4ZWMpCiB7Ci0gICAgcmV0dXJu
IG9iai0+aXNFeHRlbnNpYmxlSW1wbChleGVjLT52bSgpKTsKKyAgICByZXR1cm4gb2JqLT5pc1N0
cnVjdHVyZUV4dGVuc2libGUoZXhlYy0+dm0oKSk7CiB9CiAKIGJvb2wgSlNPYmplY3Q6OmlzRXh0
ZW5zaWJsZShFeGVjU3RhdGUqIGV4ZWMpCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENv
cmUvcnVudGltZS9KU09iamVjdC5oIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNP
YmplY3QuaAppbmRleCAxNDhiMWIxYmJmNmJiMWE3ZmI2ZTU3NzJiMGU0MzE5ZTM3OTgwN2QzLi5h
NjM0YWUxMzUwNTI1MDkxZjU5NjBmYTQ2ZGIxM2Q1ZjE5Y2M5NWE5IDEwMDY0NAotLS0gYS9Tb3Vy
Y2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU09iamVjdC5oCisrKyBiL1NvdXJjZS9KYXZhU2Ny
aXB0Q29yZS9ydW50aW1lL0pTT2JqZWN0LmgKQEAgLTc1Myw3ICs3NTMsNiBAQCBwdWJsaWM6CiAK
IHByaXZhdGU6CiAgICAgTm9uUHJvcGVydHlUcmFuc2l0aW9uIHN1Z2dlc3RlZEFycmF5U3RvcmFn
ZVRyYW5zaXRpb24oVk0mKSBjb25zdDsKLSAgICBBTFdBWVNfSU5MSU5FIGJvb2wgaXNFeHRlbnNp
YmxlSW1wbChWTSYgdm0pIHsgcmV0dXJuIGlzU3RydWN0dXJlRXh0ZW5zaWJsZSh2bSk7IH0KIHB1
YmxpYzoKICAgICAvLyBZb3Ugc2hvdWxkIG9ubHkgY2FsbCBpc1N0cnVjdHVyZUV4dGVuc2libGUo
KSB3aGVuOgogICAgIC8vIC0gUGVyZm9ybWluZyB0aGlzIGNoZWNrIGluIGEgd2F5IHRoYXQgaXNu
J3QgZGVzY3JpYmVkIGluIHRoZSBzcGVjaWZpY2F0aW9uIApkaWZmIC0tZ2l0IGEvU291cmNlL0ph
dmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNTdHJpbmcuaCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9y
dW50aW1lL0pTU3RyaW5nLmgKaW5kZXggNjA1ZjQwYTNiODU3YzgxODliZmRmNmY1NWZkMDY1YTg5
MTg2OWFhYS4uZTBjMDRkZWIzODIxYmVhZTI0MzFjNmUxNzk2NTM0YjNmZDgyOWYxMyAxMDA2NDQK
LS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNTdHJpbmcuaAorKysgYi9Tb3Vy
Y2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU1N0cmluZy5oCkBAIC02ODcsNiArNjg3LDggQEAg
QUxXQVlTX0lOTElORSBKU1N0cmluZyoganNTdHJpbmdXaXRoQ2FjaGUoRXhlY1N0YXRlKiBleGVj
LCBjb25zdCBTdHJpbmcmIHMpCiBBTFdBWVNfSU5MSU5FIGJvb2wgSlNTdHJpbmc6OmdldFN0cmlu
Z1Byb3BlcnR5U2xvdChFeGVjU3RhdGUqIGV4ZWMsIFByb3BlcnR5TmFtZSBwcm9wZXJ0eU5hbWUs
IFByb3BlcnR5U2xvdCYgc2xvdCkKIHsKICAgICBWTSYgdm0gPSBleGVjLT52bSgpOworICAgIGF1
dG8gc2NvcGUgPSBERUNMQVJFX1RIUk9XX1NDT1BFKHZtKTsKKwogICAgIGlmIChwcm9wZXJ0eU5h
bWUgPT0gdm0ucHJvcGVydHlOYW1lcy0+bGVuZ3RoKSB7CiAgICAgICAgIHNsb3Quc2V0VmFsdWUo
dGhpcywgUHJvcGVydHlBdHRyaWJ1dGU6OkRvbnRFbnVtIHwgUHJvcGVydHlBdHRyaWJ1dGU6OkRv
bnREZWxldGUgfCBQcm9wZXJ0eUF0dHJpYnV0ZTo6UmVhZE9ubHksIGpzTnVtYmVyKGxlbmd0aCgp
KSk7CiAgICAgICAgIHJldHVybiB0cnVlOwpAQCAtNjk0LDcgKzY5Niw5IEBAIEFMV0FZU19JTkxJ
TkUgYm9vbCBKU1N0cmluZzo6Z2V0U3RyaW5nUHJvcGVydHlTbG90KEV4ZWNTdGF0ZSogZXhlYywg
UHJvcGVydHlOYW1lCiAKICAgICBzdGQ6Om9wdGlvbmFsPHVpbnQzMl90PiBpbmRleCA9IHBhcnNl
SW5kZXgocHJvcGVydHlOYW1lKTsKICAgICBpZiAoaW5kZXggJiYgaW5kZXgudmFsdWUoKSA8IGxl
bmd0aCgpKSB7Ci0gICAgICAgIHNsb3Quc2V0VmFsdWUodGhpcywgUHJvcGVydHlBdHRyaWJ1dGU6
OkRvbnREZWxldGUgfCBQcm9wZXJ0eUF0dHJpYnV0ZTo6UmVhZE9ubHksIGdldEluZGV4KGV4ZWMs
IGluZGV4LnZhbHVlKCkpKTsKKyAgICAgICAgSlNWYWx1ZSB2YWx1ZSA9IGdldEluZGV4KGV4ZWMs
IGluZGV4LnZhbHVlKCkpOworICAgICAgICBSRVRVUk5fSUZfRVhDRVBUSU9OKHNjb3BlLCBmYWxz
ZSk7CisgICAgICAgIHNsb3Quc2V0VmFsdWUodGhpcywgUHJvcGVydHlBdHRyaWJ1dGU6OkRvbnRE
ZWxldGUgfCBQcm9wZXJ0eUF0dHJpYnV0ZTo6UmVhZE9ubHksIHZhbHVlKTsKICAgICAgICAgcmV0
dXJuIHRydWU7CiAgICAgfQogCkBAIC03MDMsOCArNzA3LDEzIEBAIEFMV0FZU19JTkxJTkUgYm9v
bCBKU1N0cmluZzo6Z2V0U3RyaW5nUHJvcGVydHlTbG90KEV4ZWNTdGF0ZSogZXhlYywgUHJvcGVy
dHlOYW1lCiAKIEFMV0FZU19JTkxJTkUgYm9vbCBKU1N0cmluZzo6Z2V0U3RyaW5nUHJvcGVydHlT
bG90KEV4ZWNTdGF0ZSogZXhlYywgdW5zaWduZWQgcHJvcGVydHlOYW1lLCBQcm9wZXJ0eVNsb3Qm
IHNsb3QpCiB7CisgICAgVk0mIHZtID0gZXhlYy0+dm0oKTsKKyAgICBhdXRvIHNjb3BlID0gREVD
TEFSRV9USFJPV19TQ09QRSh2bSk7CisKICAgICBpZiAocHJvcGVydHlOYW1lIDwgbGVuZ3RoKCkp
IHsKLSAgICAgICAgc2xvdC5zZXRWYWx1ZSh0aGlzLCBQcm9wZXJ0eUF0dHJpYnV0ZTo6RG9udERl
bGV0ZSB8IFByb3BlcnR5QXR0cmlidXRlOjpSZWFkT25seSwgZ2V0SW5kZXgoZXhlYywgcHJvcGVy
dHlOYW1lKSk7CisgICAgICAgIEpTVmFsdWUgdmFsdWUgPSBnZXRJbmRleChleGVjLCBwcm9wZXJ0
eU5hbWUpOworICAgICAgICBSRVRVUk5fSUZfRVhDRVBUSU9OKHNjb3BlLCBmYWxzZSk7CisgICAg
ICAgIHNsb3Quc2V0VmFsdWUodGhpcywgUHJvcGVydHlBdHRyaWJ1dGU6OkRvbnREZWxldGUgfCBQ
cm9wZXJ0eUF0dHJpYnV0ZTo6UmVhZE9ubHksIHZhbHVlKTsKICAgICAgICAgcmV0dXJuIHRydWU7
CiAgICAgfQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9TdHJp
bmdPYmplY3QuY3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvU3RyaW5nT2JqZWN0
LmNwcAppbmRleCA1MDRhNjAwZTYyY2M0NTU1ZGMzYmUyYzg5MjdiMWYzNWU1YThjN2M3Li4yMzRl
Zjg5ZjU0ZjBjOTE3M2FlNjBlNWU4ZjQzZjQxMGNkOGJlNjc1IDEwMDY0NAotLS0gYS9Tb3VyY2Uv
SmF2YVNjcmlwdENvcmUvcnVudGltZS9TdHJpbmdPYmplY3QuY3BwCisrKyBiL1NvdXJjZS9KYXZh
U2NyaXB0Q29yZS9ydW50aW1lL1N0cmluZ09iamVjdC5jcHAKQEAgLTExNCw3ICsxMTQsOCBAQCBi
b29sIFN0cmluZ09iamVjdDo6ZGVmaW5lT3duUHJvcGVydHkoSlNPYmplY3QqIG9iamVjdCwgRXhl
Y1N0YXRlKiBleGVjLCBQcm9wZXJ0eQogICAgICAgICAvLyBodHRwczovL3RjMzkuZ2l0aHViLmlv
L2VjbWEyNjIvI3NlYy1zdHJpbmctZXhvdGljLW9iamVjdHMtZ2V0b3ducHJvcGVydHktcAogICAg
ICAgICBQcm9wZXJ0eURlc2NyaXB0b3IgY3VycmVudDsKICAgICAgICAgYm9vbCBpc0N1cnJlbnRE
ZWZpbmVkID0gdGhpc09iamVjdC0+Z2V0T3duUHJvcGVydHlEZXNjcmlwdG9yKGV4ZWMsIHByb3Bl
cnR5TmFtZSwgY3VycmVudCk7Ci0gICAgICAgIEFTU0VSVChpc0N1cnJlbnREZWZpbmVkKTsKKyAg
ICAgICAgRVhDRVBUSU9OX0FTU0VSVCghc2NvcGUuZXhjZXB0aW9uKCkgPT0gaXNDdXJyZW50RGVm
aW5lZCk7CisgICAgICAgIFJFVFVSTl9JRl9FWENFUFRJT04oc2NvcGUsIGZhbHNlKTsKICAgICAg
ICAgYm9vbCBpc0V4dGVuc2libGUgPSB0aGlzT2JqZWN0LT5pc0V4dGVuc2libGUoZXhlYyk7CiAg
ICAgICAgIFJFVFVSTl9JRl9FWENFUFRJT04oc2NvcGUsIGZhbHNlKTsKICAgICAgICAgUkVMRUFT
RV9BTkRfUkVUVVJOKHNjb3BlLCB2YWxpZGF0ZUFuZEFwcGx5UHJvcGVydHlEZXNjcmlwdG9yKGV4
ZWMsIG51bGxwdHIsIHByb3BlcnR5TmFtZSwgaXNFeHRlbnNpYmxlLCBkZXNjcmlwdG9yLCBpc0N1
cnJlbnREZWZpbmVkLCBjdXJyZW50LCB0aHJvd0V4Y2VwdGlvbikpOwpkaWZmIC0tZ2l0IGEvSlNU
ZXN0cy9DaGFuZ2VMb2cgYi9KU1Rlc3RzL0NoYW5nZUxvZwppbmRleCBlMzNmYTQwNTFjOGQxYzU4
M2Y4NTJkYTI0MmYwMTUwMGY5ZDFmMDI3Li40MjdhMjdmMWFjOTdlYjRiMzRkNTk2MTM2NzFhY2Zi
MDNiYzE4OWI0IDEwMDY0NAotLS0gYS9KU1Rlc3RzL0NoYW5nZUxvZworKysgYi9KU1Rlc3RzL0No
YW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDE4LTEyLTE0ICBLZWl0aCBNaWxsZXIgIDxrZWl0
aF9taWxsZXJAYXBwbGUuY29tPgorCisgICAgICAgIENhbGxlcnMgb2YgSlNTdHJpbmc6OmdldElu
ZGV4IHNob3VsZCBjaGVjayBmb3IgT09NIGV4Y2VwdGlvbnMKKyAgICAgICAgaHR0cHM6Ly9idWdz
LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5MjcwOQorCisgICAgICAgIFJldmlld2VkIGJ5
IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogc3RyZXNzL1N0cmluZ09iamVjdC1kZWZpbmUt
bGVuZ3RoLWdldHRlci1yb3BlLXN0cmluZy1vb20uanM6IEFkZGVkLgorCiAyMDE4LTEyLTEzICBD
YWlvIExpbWEgIDx0aWNhaW9saW1hQGdtYWlsLmNvbT4KIAogICAgICAgICBbQmlnSW50XSBBZGQg
VmFsdWVEaXYgaW50byBERkcKZGlmZiAtLWdpdCBhL0pTVGVzdHMvc3RyZXNzL1N0cmluZ09iamVj
dC1kZWZpbmUtbGVuZ3RoLWdldHRlci1yb3BlLXN0cmluZy1vb20uanMgYi9KU1Rlc3RzL3N0cmVz
cy9TdHJpbmdPYmplY3QtZGVmaW5lLWxlbmd0aC1nZXR0ZXItcm9wZS1zdHJpbmctb29tLmpzCm5l
dyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw
MDAwMDAwMDAuLmRhZjc1N2RmYjY5MDEzM2Q3OTkzYzU0MDdlZTJiMzBiMTYxNmViNDQKLS0tIC9k
ZXYvbnVsbAorKysgYi9KU1Rlc3RzL3N0cmVzcy9TdHJpbmdPYmplY3QtZGVmaW5lLWxlbmd0aC1n
ZXR0ZXItcm9wZS1zdHJpbmctb29tLmpzCkBAIC0wLDAgKzEsMyBAQAorbGV0IGNoYXIxNiA9IGRl
Y29kZVVSSSgnJUU3JTlBJTg0Jyk7CitsZXQgcm9wZSA9IGNoYXIxNi5wYWRFbmQoMjE0NzQ4MzY0
NCwgMSk7Cityb3BlLl9fZGVmaW5lR2V0dGVyX18oMjU2LCBmdW5jdGlvbiAoKSB7fSk7Cg==
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>357330</attachid>
            <date>2018-12-14 12:15:23 -0800</date>
            <delta_ts>2018-12-14 12:53:17 -0800</delta_ts>
            <desc>Patch for landing</desc>
            <filename>bug-192709-20181214121521.patch</filename>
            <type>text/plain</type>
            <size>6627</size>
            <attacher name="Keith Miller">keith_miller</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjM5MTgwCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw
dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA3
NWFhMzc0NDZmYjdiYmU0MjgxZjFhYWYwMjk4NGJjMWMyYjEzYTdhLi5mYzU2Yzc1ZjBkODQ0MTFk
ZDIzZWQ0NmVlZjIxZWQyZGFkMTliZTJiIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv
cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs
MyArMSwyNSBAQAorMjAxOC0xMi0xNCAgS2VpdGggTWlsbGVyICA8a2VpdGhfbWlsbGVyQGFwcGxl
LmNvbT4KKworICAgICAgICBDYWxsZXJzIG9mIEpTU3RyaW5nOjpnZXRJbmRleCBzaG91bGQgY2hl
Y2sgZm9yIE9PTSBleGNlcHRpb25zCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No
b3dfYnVnLmNnaT9pZD0xOTI3MDkKKworICAgICAgICBSZXZpZXdlZCBieSBNYXJrIExhbS4KKwor
ICAgICAgICBUaGlzIHBhdGNoIGFsc28gYWxsb3dzIFN0cmluZ3MgdG8gT09NIHdoZW4gdGhlIFN0
cmluZ09iamVjdCB3cmFwcGVyCisgICAgICAgIGF0dGVtcHRzIHRvIGxvb2sgdXAgYW4gb3duIHBy
b3BlcnR5IG9uIHRoZSBzdHJpbmcuCisKKyAgICAgICAgUmVtb3ZlIGlzRXh0ZW5zaWJsZUltcGwg
YmVjYXVzZSBpdCdzIG9ubHkgdXNlZCBpbiBvbmUgcGxhY2UgYW5kIGNhbGwKKyAgICAgICAgaXNT
dHJ1Y3R1cmVFeHRlbnNpYmxlIGluc3RlYWQuCisKKyAgICAgICAgKiBydW50aW1lL0pTT2JqZWN0
LmNwcDoKKyAgICAgICAgKEpTQzo6SlNPYmplY3Q6OmlzRXh0ZW5zaWJsZSk6CisgICAgICAgICog
cnVudGltZS9KU09iamVjdC5oOgorICAgICAgICAoSlNDOjpKU09iamVjdDo6aXNFeHRlbnNpYmxl
SW1wbCk6IERlbGV0ZWQuCisgICAgICAgICogcnVudGltZS9KU1N0cmluZy5oOgorICAgICAgICAo
SlNDOjpKU1N0cmluZzo6Z2V0U3RyaW5nUHJvcGVydHlTbG90KToKKyAgICAgICAgKiBydW50aW1l
L1N0cmluZ09iamVjdC5jcHA6CisgICAgICAgIChKU0M6OlN0cmluZ09iamVjdDo6ZGVmaW5lT3du
UHJvcGVydHkpOgorCiAyMDE4LTEyLTEzICBDYWlvIExpbWEgIDx0aWNhaW9saW1hQGdtYWlsLmNv
bT4KIAogICAgICAgICBbQmlnSW50XSBBZGQgVmFsdWVEaXYgaW50byBERkcKZGlmZiAtLWdpdCBh
L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTT2JqZWN0LmNwcCBiL1NvdXJjZS9KYXZh
U2NyaXB0Q29yZS9ydW50aW1lL0pTT2JqZWN0LmNwcAppbmRleCBiN2ZhNzk1OTI4NjI5NzE1NTg2
MWY4NWM1NzZjYmNhYzNjM2E4MGFjLi4yMGZjZDQwMzJjZTZiMzgzMTdjNzZjNTM4NzliY2ZkM2I2
YjE2ODhmIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU09iamVj
dC5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNPYmplY3QuY3BwCkBA
IC0yNDMxLDcgKzI0MzEsNyBAQCBib29sIEpTT2JqZWN0OjpwcmV2ZW50RXh0ZW5zaW9ucyhKU09i
amVjdCogb2JqZWN0LCBFeGVjU3RhdGUqIGV4ZWMpCiAKIGJvb2wgSlNPYmplY3Q6OmlzRXh0ZW5z
aWJsZShKU09iamVjdCogb2JqLCBFeGVjU3RhdGUqIGV4ZWMpCiB7Ci0gICAgcmV0dXJuIG9iai0+
aXNFeHRlbnNpYmxlSW1wbChleGVjLT52bSgpKTsKKyAgICByZXR1cm4gb2JqLT5pc1N0cnVjdHVy
ZUV4dGVuc2libGUoZXhlYy0+dm0oKSk7CiB9CiAKIGJvb2wgSlNPYmplY3Q6OmlzRXh0ZW5zaWJs
ZShFeGVjU3RhdGUqIGV4ZWMpCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVu
dGltZS9KU09iamVjdC5oIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNPYmplY3Qu
aAppbmRleCAxNDhiMWIxYmJmNmJiMWE3ZmI2ZTU3NzJiMGU0MzE5ZTM3OTgwN2QzLi5hNjM0YWUx
MzUwNTI1MDkxZjU5NjBmYTQ2ZGIxM2Q1ZjE5Y2M5NWE5IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2
YVNjcmlwdENvcmUvcnVudGltZS9KU09iamVjdC5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29y
ZS9ydW50aW1lL0pTT2JqZWN0LmgKQEAgLTc1Myw3ICs3NTMsNiBAQCBwdWJsaWM6CiAKIHByaXZh
dGU6CiAgICAgTm9uUHJvcGVydHlUcmFuc2l0aW9uIHN1Z2dlc3RlZEFycmF5U3RvcmFnZVRyYW5z
aXRpb24oVk0mKSBjb25zdDsKLSAgICBBTFdBWVNfSU5MSU5FIGJvb2wgaXNFeHRlbnNpYmxlSW1w
bChWTSYgdm0pIHsgcmV0dXJuIGlzU3RydWN0dXJlRXh0ZW5zaWJsZSh2bSk7IH0KIHB1YmxpYzoK
ICAgICAvLyBZb3Ugc2hvdWxkIG9ubHkgY2FsbCBpc1N0cnVjdHVyZUV4dGVuc2libGUoKSB3aGVu
OgogICAgIC8vIC0gUGVyZm9ybWluZyB0aGlzIGNoZWNrIGluIGEgd2F5IHRoYXQgaXNuJ3QgZGVz
Y3JpYmVkIGluIHRoZSBzcGVjaWZpY2F0aW9uIApkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3Jp
cHRDb3JlL3J1bnRpbWUvSlNTdHJpbmcuaCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1l
L0pTU3RyaW5nLmgKaW5kZXggNjA1ZjQwYTNiODU3YzgxODliZmRmNmY1NWZkMDY1YTg5MTg2OWFh
YS4uZTBjMDRkZWIzODIxYmVhZTI0MzFjNmUxNzk2NTM0YjNmZDgyOWYxMyAxMDA2NDQKLS0tIGEv
U291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNTdHJpbmcuaAorKysgYi9Tb3VyY2UvSmF2
YVNjcmlwdENvcmUvcnVudGltZS9KU1N0cmluZy5oCkBAIC02ODcsNiArNjg3LDggQEAgQUxXQVlT
X0lOTElORSBKU1N0cmluZyoganNTdHJpbmdXaXRoQ2FjaGUoRXhlY1N0YXRlKiBleGVjLCBjb25z
dCBTdHJpbmcmIHMpCiBBTFdBWVNfSU5MSU5FIGJvb2wgSlNTdHJpbmc6OmdldFN0cmluZ1Byb3Bl
cnR5U2xvdChFeGVjU3RhdGUqIGV4ZWMsIFByb3BlcnR5TmFtZSBwcm9wZXJ0eU5hbWUsIFByb3Bl
cnR5U2xvdCYgc2xvdCkKIHsKICAgICBWTSYgdm0gPSBleGVjLT52bSgpOworICAgIGF1dG8gc2Nv
cGUgPSBERUNMQVJFX1RIUk9XX1NDT1BFKHZtKTsKKwogICAgIGlmIChwcm9wZXJ0eU5hbWUgPT0g
dm0ucHJvcGVydHlOYW1lcy0+bGVuZ3RoKSB7CiAgICAgICAgIHNsb3Quc2V0VmFsdWUodGhpcywg
UHJvcGVydHlBdHRyaWJ1dGU6OkRvbnRFbnVtIHwgUHJvcGVydHlBdHRyaWJ1dGU6OkRvbnREZWxl
dGUgfCBQcm9wZXJ0eUF0dHJpYnV0ZTo6UmVhZE9ubHksIGpzTnVtYmVyKGxlbmd0aCgpKSk7CiAg
ICAgICAgIHJldHVybiB0cnVlOwpAQCAtNjk0LDcgKzY5Niw5IEBAIEFMV0FZU19JTkxJTkUgYm9v
bCBKU1N0cmluZzo6Z2V0U3RyaW5nUHJvcGVydHlTbG90KEV4ZWNTdGF0ZSogZXhlYywgUHJvcGVy
dHlOYW1lCiAKICAgICBzdGQ6Om9wdGlvbmFsPHVpbnQzMl90PiBpbmRleCA9IHBhcnNlSW5kZXgo
cHJvcGVydHlOYW1lKTsKICAgICBpZiAoaW5kZXggJiYgaW5kZXgudmFsdWUoKSA8IGxlbmd0aCgp
KSB7Ci0gICAgICAgIHNsb3Quc2V0VmFsdWUodGhpcywgUHJvcGVydHlBdHRyaWJ1dGU6OkRvbnRE
ZWxldGUgfCBQcm9wZXJ0eUF0dHJpYnV0ZTo6UmVhZE9ubHksIGdldEluZGV4KGV4ZWMsIGluZGV4
LnZhbHVlKCkpKTsKKyAgICAgICAgSlNWYWx1ZSB2YWx1ZSA9IGdldEluZGV4KGV4ZWMsIGluZGV4
LnZhbHVlKCkpOworICAgICAgICBSRVRVUk5fSUZfRVhDRVBUSU9OKHNjb3BlLCBmYWxzZSk7Cisg
ICAgICAgIHNsb3Quc2V0VmFsdWUodGhpcywgUHJvcGVydHlBdHRyaWJ1dGU6OkRvbnREZWxldGUg
fCBQcm9wZXJ0eUF0dHJpYnV0ZTo6UmVhZE9ubHksIHZhbHVlKTsKICAgICAgICAgcmV0dXJuIHRy
dWU7CiAgICAgfQogCkBAIC03MDMsOCArNzA3LDEzIEBAIEFMV0FZU19JTkxJTkUgYm9vbCBKU1N0
cmluZzo6Z2V0U3RyaW5nUHJvcGVydHlTbG90KEV4ZWNTdGF0ZSogZXhlYywgUHJvcGVydHlOYW1l
CiAKIEFMV0FZU19JTkxJTkUgYm9vbCBKU1N0cmluZzo6Z2V0U3RyaW5nUHJvcGVydHlTbG90KEV4
ZWNTdGF0ZSogZXhlYywgdW5zaWduZWQgcHJvcGVydHlOYW1lLCBQcm9wZXJ0eVNsb3QmIHNsb3Qp
CiB7CisgICAgVk0mIHZtID0gZXhlYy0+dm0oKTsKKyAgICBhdXRvIHNjb3BlID0gREVDTEFSRV9U
SFJPV19TQ09QRSh2bSk7CisKICAgICBpZiAocHJvcGVydHlOYW1lIDwgbGVuZ3RoKCkpIHsKLSAg
ICAgICAgc2xvdC5zZXRWYWx1ZSh0aGlzLCBQcm9wZXJ0eUF0dHJpYnV0ZTo6RG9udERlbGV0ZSB8
IFByb3BlcnR5QXR0cmlidXRlOjpSZWFkT25seSwgZ2V0SW5kZXgoZXhlYywgcHJvcGVydHlOYW1l
KSk7CisgICAgICAgIEpTVmFsdWUgdmFsdWUgPSBnZXRJbmRleChleGVjLCBwcm9wZXJ0eU5hbWUp
OworICAgICAgICBSRVRVUk5fSUZfRVhDRVBUSU9OKHNjb3BlLCBmYWxzZSk7CisgICAgICAgIHNs
b3Quc2V0VmFsdWUodGhpcywgUHJvcGVydHlBdHRyaWJ1dGU6OkRvbnREZWxldGUgfCBQcm9wZXJ0
eUF0dHJpYnV0ZTo6UmVhZE9ubHksIHZhbHVlKTsKICAgICAgICAgcmV0dXJuIHRydWU7CiAgICAg
fQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9TdHJpbmdPYmpl
Y3QuY3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvU3RyaW5nT2JqZWN0LmNwcApp
bmRleCA1MDRhNjAwZTYyY2M0NTU1ZGMzYmUyYzg5MjdiMWYzNWU1YThjN2M3Li4yMzRlZjg5ZjU0
ZjBjOTE3M2FlNjBlNWU4ZjQzZjQxMGNkOGJlNjc1IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNj
cmlwdENvcmUvcnVudGltZS9TdHJpbmdPYmplY3QuY3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0
Q29yZS9ydW50aW1lL1N0cmluZ09iamVjdC5jcHAKQEAgLTExNCw3ICsxMTQsOCBAQCBib29sIFN0
cmluZ09iamVjdDo6ZGVmaW5lT3duUHJvcGVydHkoSlNPYmplY3QqIG9iamVjdCwgRXhlY1N0YXRl
KiBleGVjLCBQcm9wZXJ0eQogICAgICAgICAvLyBodHRwczovL3RjMzkuZ2l0aHViLmlvL2VjbWEy
NjIvI3NlYy1zdHJpbmctZXhvdGljLW9iamVjdHMtZ2V0b3ducHJvcGVydHktcAogICAgICAgICBQ
cm9wZXJ0eURlc2NyaXB0b3IgY3VycmVudDsKICAgICAgICAgYm9vbCBpc0N1cnJlbnREZWZpbmVk
ID0gdGhpc09iamVjdC0+Z2V0T3duUHJvcGVydHlEZXNjcmlwdG9yKGV4ZWMsIHByb3BlcnR5TmFt
ZSwgY3VycmVudCk7Ci0gICAgICAgIEFTU0VSVChpc0N1cnJlbnREZWZpbmVkKTsKKyAgICAgICAg
RVhDRVBUSU9OX0FTU0VSVCghc2NvcGUuZXhjZXB0aW9uKCkgPT0gaXNDdXJyZW50RGVmaW5lZCk7
CisgICAgICAgIFJFVFVSTl9JRl9FWENFUFRJT04oc2NvcGUsIGZhbHNlKTsKICAgICAgICAgYm9v
bCBpc0V4dGVuc2libGUgPSB0aGlzT2JqZWN0LT5pc0V4dGVuc2libGUoZXhlYyk7CiAgICAgICAg
IFJFVFVSTl9JRl9FWENFUFRJT04oc2NvcGUsIGZhbHNlKTsKICAgICAgICAgUkVMRUFTRV9BTkRf
UkVUVVJOKHNjb3BlLCB2YWxpZGF0ZUFuZEFwcGx5UHJvcGVydHlEZXNjcmlwdG9yKGV4ZWMsIG51
bGxwdHIsIHByb3BlcnR5TmFtZSwgaXNFeHRlbnNpYmxlLCBkZXNjcmlwdG9yLCBpc0N1cnJlbnRE
ZWZpbmVkLCBjdXJyZW50LCB0aHJvd0V4Y2VwdGlvbikpOwpkaWZmIC0tZ2l0IGEvSlNUZXN0cy9D
aGFuZ2VMb2cgYi9KU1Rlc3RzL0NoYW5nZUxvZwppbmRleCBlMzNmYTQwNTFjOGQxYzU4M2Y4NTJk
YTI0MmYwMTUwMGY5ZDFmMDI3Li4xZWQwYzI4YTBjZThlZTk5NDllNzQ5MjI2NWFjMTc2Mzk5Mjhj
OTFmIDEwMDY0NAotLS0gYS9KU1Rlc3RzL0NoYW5nZUxvZworKysgYi9KU1Rlc3RzL0NoYW5nZUxv
ZwpAQCAtMSwzICsxLDEyIEBACisyMDE4LTEyLTE0ICBLZWl0aCBNaWxsZXIgIDxrZWl0aF9taWxs
ZXJAYXBwbGUuY29tPgorCisgICAgICAgIENhbGxlcnMgb2YgSlNTdHJpbmc6OmdldEluZGV4IHNo
b3VsZCBjaGVjayBmb3IgT09NIGV4Y2VwdGlvbnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp
dC5vcmcvc2hvd19idWcuY2dpP2lkPTE5MjcwOQorCisgICAgICAgIFJldmlld2VkIGJ5IE1hcmsg
TGFtLgorCisgICAgICAgICogc3RyZXNzL1N0cmluZ09iamVjdC1kZWZpbmUtbGVuZ3RoLWdldHRl
ci1yb3BlLXN0cmluZy1vb20uanM6IEFkZGVkLgorCiAyMDE4LTEyLTEzICBDYWlvIExpbWEgIDx0
aWNhaW9saW1hQGdtYWlsLmNvbT4KIAogICAgICAgICBbQmlnSW50XSBBZGQgVmFsdWVEaXYgaW50
byBERkcKZGlmZiAtLWdpdCBhL0pTVGVzdHMvc3RyZXNzL1N0cmluZ09iamVjdC1kZWZpbmUtbGVu
Z3RoLWdldHRlci1yb3BlLXN0cmluZy1vb20uanMgYi9KU1Rlc3RzL3N0cmVzcy9TdHJpbmdPYmpl
Y3QtZGVmaW5lLWxlbmd0aC1nZXR0ZXItcm9wZS1zdHJpbmctb29tLmpzCm5ldyBmaWxlIG1vZGUg
MTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLmU3
ZTcwNmMwZmU4NDYxOTU0N2I1NzU1ZjA5OGVlODllODIzYWRkZTEKLS0tIC9kZXYvbnVsbAorKysg
Yi9KU1Rlc3RzL3N0cmVzcy9TdHJpbmdPYmplY3QtZGVmaW5lLWxlbmd0aC1nZXR0ZXItcm9wZS1z
dHJpbmctb29tLmpzCkBAIC0wLDAgKzEsNSBAQAordHJ5IHsKKyAgICBsZXQgY2hhcjE2ID0gZGVj
b2RlVVJJKCclRTclOUElODQnKTsKKyAgICBsZXQgcm9wZSA9IGNoYXIxNi5wYWRFbmQoMjE0NzQ4
MzY0NCwgMSk7CisgICAgcm9wZS5fX2RlZmluZUdldHRlcl9fKDI1NiwgZnVuY3Rpb24gKCkge30p
OworfSBjYXRjaCB7IH0K
</data>

          </attachment>
      

    </bug>

</bugzilla>