192707 2018-12-14 10:49:55 -0800 clang-tidy: Fix unnecessary object copy in CPUMonitor::setCPULimit() 2018-12-17 20:10:00 -0800 1 1 1 Unclassified WebKit WebCore Misc. WebKit Local Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ddkilzer ddkilzer achristensen cdumez commit-queue dbates webkit-bug-importer oldest_to_newest 1487964 0 ddkilzer 2018-12-14 10:49:55 -0800 Running `clang-tidy -checks='-*,performance-*,-performance-noexcept-*' ...` on WebCore source files found this unnecessary object copy: Source/WebCore/platform/CPUMonitor.cpp:38:52: warning: the parameter 'cpuLimit' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param] void CPUMonitor::setCPULimit(std::optional<double> cpuLimit) ^ const & 1487965 1 webkit-bug-importer 2018-12-14 10:50:43 -0800 <rdar://problem/46734926> 1487967 2 357323 ddkilzer 2018-12-14 10:56:24 -0800 Created attachment 357323 Patch v1 1488744 3 357323 commit-queue 2018-12-17 20:09:59 -0800 Comment on attachment 357323 Patch v1 Clearing flags on attachment: 357323 Committed r239315: <https://trac.webkit.org/changeset/239315> 1488745 4 commit-queue 2018-12-17 20:10:00 -0800 All reviewed patches have been landed. Closing bug. 357323 2018-12-14 10:56:24 -0800 2018-12-17 20:09:59 -0800 Patch v1 bug-192707-20181214105623.patch text/plain 3695 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMjM5MTEyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODhmN2VkZGMyNjk1N2Mz ZTVkZTg2MjhjMmVkZjFmZDA3NDJkMDM3OS4uMWQ0NTFlMTZhNGI2MmE2YWI1NDdiMzM3NGVmZTg1 MzY1YjcwNjg5YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE4LTEyLTE0ICBEYXZp ZCBLaWx6ZXIgIDxkZGtpbHplckBhcHBsZS5jb20+CisKKyAgICAgICAgY2xhbmctdGlkeTogRml4 IHVubmVjZXNzYXJ5IG9iamVjdCBjb3B5IGluIENQVU1vbml0b3I6OnNldENQVUxpbWl0KCkKKyAg ICAgICAgPGh0dHBzOi8vd2Via2l0Lm9yZy9iLzE5MjcwNz4KKyAgICAgICAgPHJkYXI6Ly9wcm9i bGVtLzQ2NzM0OTI2PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgICogcGxhdGZvcm0vQ1BVTW9uaXRvci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpDUFVN b25pdG9yOjpzZXRDUFVMaW1pdCk6CisgICAgICAgICogcGxhdGZvcm0vQ1BVTW9uaXRvci5oOgor ICAgICAgICAoV2ViQ29yZTo6Q1BVTW9uaXRvcjo6c2V0Q1BVTGltaXQpOgorICAgICAgICAtIENo YW5nZSBwYXJhbWV0ZXIgdG8gY29uc3QgcmVmZXJlbmNlIHRvIGZpeCB1bm5lY2Vzc2FyeSBjb3Bp ZXMuCisKIDIwMTgtMTItMTMgIERhdmlkIEtpbHplciAgPGRka2lsemVyQGFwcGxlLmNvbT4KIAog ICAgICAgICBjbGFuZy10aWR5OiBsb29wIHZhcmlhYmxlIGlzIGNvcGllZCBidXQgb25seSB1c2Vk IGFzIGNvbnN0IHJlZmVyZW5jZSBpbiBEb2N1bWVudC5jcHAsIEVsZW1lbnQuY3BwCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmlu ZGV4IGMxNzhhZjc2NmExODVmOGRkYjQ2OTg2NDUyNmM3YmYxY2MxMmQ1MDMuLmY4MWE5YThiM2Yx YzcxMWZhZWI0OThjZTU5MDY2MGFhOWViZjAwNzQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQv Q2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAK KzIwMTgtMTItMTQgIERhdmlkIEtpbHplciAgPGRka2lsemVyQGFwcGxlLmNvbT4KKworICAgICAg ICBjbGFuZy10aWR5OiBGaXggdW5uZWNlc3Nhcnkgb2JqZWN0IGNvcHkgaW4gQ1BVTW9uaXRvcjo6 c2V0Q1BVTGltaXQoKQorICAgICAgICA8aHR0cHM6Ly93ZWJraXQub3JnL2IvMTkyNzA3PgorICAg ICAgICA8cmRhcjovL3Byb2JsZW0vNDY3MzQ5MjY+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgKiBXZWJQcm9jZXNzL2NvY29hL1dlYlByb2Nlc3NDb2Nv YS5tbToKKyAgICAgICAgKFdlYktpdDo6V2ViUHJvY2Vzczo6dXBkYXRlQ1BVTW9uaXRvclN0YXRl KToKKyAgICAgICAgLSBQYXNzIG1fY3B1TGltaXQgZGlyZWN0bHkgc2luY2UgZ2V0dGluZyBpdHMg dmFsdWUgY2F1c2VzIGFuCisgICAgICAgICAgaWRlbnRpY2FsIHN0ZDo6b3B0aW9uYWw8ZG91Ymxl PiB0byBiZSBjcmVhdGVkIHVubmVjZXNzYXJpbHkuCisKIDIwMTgtMTItMTIgIENocmlzIER1bWV6 ICA8Y2R1bWV6QGFwcGxlLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkIGF0dGVtcHQgdG8gZml4 IGJ1aWxkIHdpdGggb2xkZXIgU0RLcyBhZnRlciByMjM5MTEwLgpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vQ1BVTW9uaXRvci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9DUFVNb25pdG9yLmNwcAppbmRleCA1ZmFhZjY2ZTYwMmU3N2UxZDliMjE3NjUzOTBlMTRmMzdh YzhhN2ZiLi5lMjc1NjczY2NiNGIyMDZlNzk0YWJkNmEyN2E0NDNjNGM3M2M1MjgzIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9DUFVNb25pdG9yLmNwcAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9DUFVNb25pdG9yLmNwcApAQCAtMzUsNyArMzUsNyBAQCBDUFVNb25p dG9yOjpDUFVNb25pdG9yKFNlY29uZHMgY2hlY2tJbnRlcnZhbCwgRXhjZWVkZWRDUFVMaW1pdEhh bmRsZXImJiBleGNlZWRlZAogewogfQogCi12b2lkIENQVU1vbml0b3I6OnNldENQVUxpbWl0KHN0 ZDo6b3B0aW9uYWw8ZG91YmxlPiBjcHVMaW1pdCkKK3ZvaWQgQ1BVTW9uaXRvcjo6c2V0Q1BVTGlt aXQoY29uc3Qgc3RkOjpvcHRpb25hbDxkb3VibGU+JiBjcHVMaW1pdCkKIHsKICAgICBpZiAobV9j cHVMaW1pdCA9PSBjcHVMaW1pdCkKICAgICAgICAgcmV0dXJuOwpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vQ1BVTW9uaXRvci5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v Q1BVTW9uaXRvci5oCmluZGV4IGQ0ZGRiNzc4ZDZkNGU2YWZkOGQyZTJmZjRiYWI5Mjk1OGE1Njg0 NDcuLjZlYzQ4NmYzZjkzYTQxMzVhYjVmNTdiM2M3NzJjNDVlOTlkMDk1NDMgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL0NQVU1vbml0b3IuaAorKysgYi9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9DUFVNb25pdG9yLmgKQEAgLTM3LDcgKzM3LDcgQEAgcHVibGljOgogICAgIHVz aW5nIEV4Y2VlZGVkQ1BVTGltaXRIYW5kbGVyID0gV1RGOjpGdW5jdGlvbjx2b2lkKGRvdWJsZSk+ OwogICAgIFdFQkNPUkVfRVhQT1JUIENQVU1vbml0b3IoU2Vjb25kcyBjaGVja0ludGVydmFsLCBF eGNlZWRlZENQVUxpbWl0SGFuZGxlciYmKTsKIAotICAgIFdFQkNPUkVfRVhQT1JUIHZvaWQgc2V0 Q1BVTGltaXQoc3RkOjpvcHRpb25hbDxkb3VibGU+KTsKKyAgICBXRUJDT1JFX0VYUE9SVCB2b2lk IHNldENQVUxpbWl0KGNvbnN0IHN0ZDo6b3B0aW9uYWw8ZG91YmxlPiYpOwogCiBwcml2YXRlOgog ICAgIHZvaWQgdGltZXJGaXJlZCgpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9XZWJQcm9j ZXNzL2NvY29hL1dlYlByb2Nlc3NDb2NvYS5tbSBiL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9j b2NvYS9XZWJQcm9jZXNzQ29jb2EubW0KaW5kZXggYmRhZTc0NmQ1ZDQ4ZTU4MGQzM2JhOWVjZGEz NjM2MTVmOTNiOWY2Yy4uM2FlNDk5YzgzNGNkOTZlZjgzMDgxZDg0ZjFmODY1NWEwOWQxMTk5NiAx MDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL2NvY29hL1dlYlByb2Nlc3NDb2Nv YS5tbQorKysgYi9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvY29jb2EvV2ViUHJvY2Vzc0NvY29h Lm1tCkBAIC01NjksNyArNTY5LDcgQEAgdm9pZCBXZWJQcm9jZXNzOjp1cGRhdGVDUFVNb25pdG9y U3RhdGUoQ1BVTW9uaXRvclVwZGF0ZVJlYXNvbiByZWFzb24pCiAgICAgICAgIC8vIG5vdCB3YW50 IHRvIHJlcG9ydCB0aGF0IGEgcHJvY2VzcyBoYXMgZXhjZWVkZWQgaXRzIGJhY2tncm91bmQgQ1BV IGxpbWl0IGV2ZW4gdGhvdWdoIG1vc3Qgb2YgdGhlIENQVSB0aW1lIHdhcyB1c2VkIHdoaWxlIHRo ZSBwcm9jZXNzIHdhcyB2aXNpYmxlLgogICAgICAgICBtX2NwdU1vbml0b3ItPnNldENQVUxpbWl0 KHN0ZDo6bnVsbG9wdCk7CiAgICAgfQotICAgIG1fY3B1TW9uaXRvci0+c2V0Q1BVTGltaXQobV9j cHVMaW1pdC52YWx1ZSgpKTsKKyAgICBtX2NwdU1vbml0b3ItPnNldENQVUxpbWl0KG1fY3B1TGlt aXQpOwogI2Vsc2UKICAgICBVTlVTRURfUEFSQU0ocmVhc29uKTsKICNlbmRpZgo=