192703 2018-12-14 09:46:06 -0800 Add a style checker rule for Xcode version macros use 2020-03-26 09:24:32 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ap ap achristensen commit-queue ews-watchlist glenn lforschler thorton webkit-bug-importer oldest_to_newest 1487939 0 ap 2018-12-14 09:46:06 -0800 Check MIX_REQUIRED and MAX_ALLOWED family of macros. 1487940 1 357320 ap 2018-12-14 09:48:45 -0800 Created attachment 357320 proposed patch 1488265 2 357320 commit-queue 2018-12-14 23:52:03 -0800 Comment on attachment 357320 proposed patch Clearing flags on attachment: 357320 Committed r239250: <https://trac.webkit.org/changeset/239250> 1488266 3 commit-queue 2018-12-14 23:52:04 -0800 All reviewed patches have been landed. Closing bug. 1488267 4 webkit-bug-importer 2018-12-14 23:53:26 -0800 <rdar://problem/46751789> 1634212 5 357320 thorton 2020-03-25 22:35:48 -0700 Comment on attachment 357320 proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=357320&action=review > Tools/Scripts/webkitpy/style/checkers/cpp.py:1107 > + 2. VERSION_MIN_REQUIRED never changes for a minor OS version. This is not globally true, right? Only for macOS. 1634375 6 ap 2020-03-26 09:24:32 -0700 I think that you are right. I don't know how deployment target is communicated to clang (is it -target or an invisible environment variable, and how does it interact with -mmacosx-version-min?), so I'm not confident enough to rewrite this comment. 357320 2018-12-14 09:48:45 -0800 2018-12-14 23:52:03 -0800 proposed patch StyleCheck.txt text/plain 6644 ap SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIzOTIxMCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE3IEBACisyMDE4LTEyLTE0ICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29t PgorCisgICAgICAgIEFkZCBhIHN0eWxlIGNoZWNrZXIgcnVsZSBmb3IgWGNvZGUgdmVyc2lvbiBt YWNyb3MgdXNlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xOTI3MDMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIFNjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwLnB5OgorICAgICAgICAoY2hl Y2tfb3NfdmVyc2lvbl9jaGVja3MpOgorICAgICAgICAocHJvY2Vzc19saW5lKToKKyAgICAgICAg KENwcENoZWNrZXIpOgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMv Y3BwX3VuaXR0ZXN0LnB5OgorICAgICAgICAoV2ViS2l0U3R5bGVUZXN0LnRlc3Rfb3NfdmVyc2lv bl9jaGVja3MpOgorCiAyMDE4LTEyLTE0ICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+ CiAKICAgICAgICAgW1BTT05dIFdlYnNpdGVQb2xpY2llcyBhcmUgbG9zdCBvbiBwcm9jZXNzLXN3 YXAKSW5kZXg6IFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwLnB5Cj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwLnB5 CShyZXZpc2lvbiAyMzkwMzEpCisrKyBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNr ZXJzL2NwcC5weQkod29ya2luZyBjb3B5KQpAQCAtMTA5Myw2ICsxMDkzLDQzIEBAIGRlZiBjaGVj a19pbnZhbGlkX2luY3JlbWVudChjbGVhbl9saW5lcywKICAgICAgICAgICAgICAgJ0NoYW5naW5n IHBvaW50ZXIgaW5zdGVhZCBvZiB2YWx1ZSAob3IgdW51c2VkIHZhbHVlIG9mIG9wZXJhdG9yKiku JykKIAogCisjIE1hdGNoZXMgWGNvZGUgKlZFUlNJT05fTUlOX1JFUVVJUkVEIGFuZCAqVkVSU0lP Tl9NQVhfQUxMT1dFRCBtYWNyb3MuCitfUkVfUEFUVEVSTl9YQ09ERV9WRVJTSU9OX01BQ1JPID0g cmUuY29tcGlsZSgKKyAgICByJy4rKFZFUlNJT05fTUlOX1JFUVVJUkVEfFZFUlNJT05fTUFYX0FM TE9XRUQpJykKKworX1JFX1BBVFRFUk5fWENPREVfTUlOX1JFUVVJUkVEX01BQ1JPID0gcmUuY29t cGlsZSgKKyAgICByJy4rPyhbQS1aX10rKV9WRVJTSU9OX01JTl9SRVFVSVJFRCBbPjw9XSsgKFxk KyknKQorCisKK2RlZiBjaGVja19vc192ZXJzaW9uX2NoZWNrcyhmaWxlbmFtZSwgY2xlYW5fbGlu ZXMsIGxpbmVfbnVtYmVyLCBlcnJvcik6CisgICAgIiIiIENoZWNrcyBmb3IgbWlzdGFrZXMgdXNp bmcgVkVSU0lPTl9NSU5fUkVRVUlSRUQgYW5kIFZFUlNJT05fTUFYX0FMTE9XRUQgbWFjcm9zOgor ICAgIDEuIFRoZXNlIHNob3VsZCBvbmx5IGJlIHVzZWQgY2VudHJhbGx5IHRvIGRlZmluZWQgbmFt ZWQgSEFWRSwgVVNFIG9yIEVOQUJMRSBzdHlsZSBtYWNyb3MuCisgICAgMi4gVkVSU0lPTl9NSU5f UkVRVUlSRUQgbmV2ZXIgY2hhbmdlcyBmb3IgYSBtaW5vciBPUyB2ZXJzaW9uLgorCisgICAgVGhl c2Ugc2hvdWxkIGJlIGNlbnRyYWxpemVkIGluIHd0Zi9QbGF0Zm9ybS5oIGFuZCB3dGYvRmVhdHVy ZURlZmluZXMuaC4KKworICAgIEFyZ3M6CisgICAgICBmaWxlbmFtZTogTmFtZSBvZiB0aGUgZmls ZSB0aGF0IGlzIGJlaW5nIHByb2Nlc3NlZC4KKyAgICAgIGNsZWFuX2xpbmVzOiBBIENsZWFuc2Vk TGluZXMgaW5zdGFuY2UgY29udGFpbmluZyB0aGUgZmlsZS4KKyAgICAgIGxpbmVfbnVtYmVyOiBU aGUgbnVtYmVyIG9mIHRoZSBsaW5lIHRvIGNoZWNrLgorICAgICAgZXJyb3I6IFRoZSBmdW5jdGlv biB0byBjYWxsIHdpdGggYW55IGVycm9ycyBmb3VuZC4KKyAgICAiIiIKKworICAgIGxpbmUgPSBj bGVhbl9saW5lcy5lbGlkZWRbbGluZV9udW1iZXJdCisKKyAgICBmb3IgdmVyc2lvbl9tYXRjaCBp biBfUkVfUEFUVEVSTl9YQ09ERV9NSU5fUkVRVUlSRURfTUFDUk8uZmluZGl0ZXIobGluZSk6Cisg ICAgICAgIG9zX3ByZWZpeCA9IHZlcnNpb25fbWF0Y2guZ3JvdXAoMSkKKyAgICAgICAgdmVyc2lv bl9udW1iZXIgPSBpbnQodmVyc2lvbl9tYXRjaC5ncm91cCgyKSkKKyAgICAgICAgaWYgb3NfcHJl Zml4ID09ICdfX01BQ19PU19YJyBhbmQgdmVyc2lvbl9udW1iZXIgJSAxMDAgIT0gMCBvciBvc19w cmVmaXggIT0gJ19fTUFDX09TX1gnIGFuZCB2ZXJzaW9uX251bWJlciAlIDEwMDAwICE9IDA6Cisg ICAgICAgICAgICBlcnJvcihsaW5lX251bWJlciwgJ2J1aWxkL3ZlcnNpb25fY2hlY2snLCA1LCAn SW5jb3JyZWN0IE9TIHZlcnNpb24gY2hlY2suIFZFUlNJT05fTUlOX1JFUVVJUkVEIHZhbHVlcyBu ZXZlciBpbmNsdWRlIGEgbWlub3IgdmVyc2lvbi4gWW91IG1heSBiZSBsb29raW5nIGZvciBhIGNv bWJpbmF0aW9uIG9mIFZFUlNJT05fTUlOX1JFUVVJUkVEIGZvciB0YXJnZXQgT1MgdmVyc2lvbiBj aGVjayBhbmQgVkVSU0lPTl9NQVhfQUxMT1dFRCBmb3IgU0RLIGNoZWNrLicpCisgICAgICAgICAg ICBicmVhaworCisgICAgaWYgZmlsZW5hbWUgPT0gJ1NvdXJjZS9XVEYvd3RmL1BsYXRmb3JtLmgn IG9yIGZpbGVuYW1lID09ICdTb3VyY2UvV1RGL3d0Zi9GZWF0dXJlRGVmaW5lcy5oJzoKKyAgICAg ICAgcmV0dXJuCisKKyAgICBpZiBfUkVfUEFUVEVSTl9YQ09ERV9WRVJTSU9OX01BQ1JPLm1hdGNo KGxpbmUpOgorICAgICAgICBlcnJvcihsaW5lX251bWJlciwgJ2J1aWxkL3ZlcnNpb25fY2hlY2sn LCA1LCAnTWlzcGxhY2VkIE9TIHZlcnNpb24gY2hlY2suIFBsZWFzZSB1c2UgYSBuYW1lZCBtYWNy byBpbiB3dGYvUGxhdGZvcm0uaCBvciB3dGYvRmVhdHVyZURlZmluZXMuaC4nKQorCiBjbGFzcyBf Q2xhc3NJbmZvKG9iamVjdCk6CiAgICAgIiIiU3RvcmVzIGluZm9ybWF0aW9uIGFib3V0IGEgY2xh c3MuIiIiCiAKQEAgLTM4NjUsNiArMzkwMiw3IEBAIGRlZiBwcm9jZXNzX2xpbmUoZmlsZW5hbWUs IGZpbGVfZXh0ZW5zaW8KICAgICBjaGVja19mb3Jfbm9uX3N0YW5kYXJkX2NvbnN0cnVjdHMoY2xl YW5fbGluZXMsIGxpbmUsIGNsYXNzX3N0YXRlLCBlcnJvcikKICAgICBjaGVja19wb3NpeF90aHJl YWRpbmcoY2xlYW5fbGluZXMsIGxpbmUsIGVycm9yKQogICAgIGNoZWNrX2ludmFsaWRfaW5jcmVt ZW50KGNsZWFuX2xpbmVzLCBsaW5lLCBlcnJvcikKKyAgICBjaGVja19vc192ZXJzaW9uX2NoZWNr cyhmaWxlbmFtZSwgY2xlYW5fbGluZXMsIGxpbmUsIGVycm9yKQogCiAKIGNsYXNzIF9JbmxpbmVB U01TdGF0ZShvYmplY3QpOgpAQCAtMzk1NCw2ICszOTkyLDcgQEAgY2xhc3MgQ3BwQ2hlY2tlcihv YmplY3QpOgogICAgICAgICAnYnVpbGQvY3BwX2NvbW1lbnQnLAogICAgICAgICAnYnVpbGQvd2Vi Y29yZV9leHBvcnQnLAogICAgICAgICAnYnVpbGQvd2tfYXBpX2F2YWlsYWJsZScsCisgICAgICAg ICdidWlsZC92ZXJzaW9uX2NoZWNrJywKICAgICAgICAgJ2xlZ2FsL2NvcHlyaWdodCcsCiAgICAg ICAgICdyZWFkYWJpbGl0eS9icmFjZXMnLAogICAgICAgICAncmVhZGFiaWxpdHkvY2FzdGluZycs CkluZGV4OiBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcF91bml0dGVz dC5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJz L2NwcF91bml0dGVzdC5weQkocmV2aXNpb24gMjM5MDMxKQorKysgVG9vbHMvU2NyaXB0cy93ZWJr aXRweS9zdHlsZS9jaGVja2Vycy9jcHBfdW5pdHRlc3QucHkJKHdvcmtpbmcgY29weSkKQEAgLTU1 MjgsNiArNTUyOCwxNiBAQCBjbGFzcyBXZWJLaXRTdHlsZVRlc3QoQ3BwU3R5bGVUZXN0QmFzZSk6 CiAgICAgICAgIHNlbGYuYXNzZXJ0X2xpbnQoJ1dLX0FQSV9BVkFJTEFCTEUobWFjb3N4KFdLX0lP U19UQkEpLCBpb3MoMy40LjUpKScsICdXS19JT1NfVEJBIGlzIG5laXRoZXIgYSB2ZXJzaW9uIG51 bWJlciBub3IgV0tfTUFDX1RCQSAgW2J1aWxkL3drX2FwaV9hdmFpbGFibGVdIFs1XScpCiAgICAg ICAgIHNlbGYuYXNzZXJ0X2xpbnQoJ1dLX0FQSV9BVkFJTEFCTEUobWFjb3N4KDEuMi4zKSwgaW9z KFdLX01BQ19UQkEpKScsICdXS19NQUNfVEJBIGlzIG5laXRoZXIgYSB2ZXJzaW9uIG51bWJlciBu b3IgV0tfSU9TX1RCQSAgW2J1aWxkL3drX2FwaV9hdmFpbGFibGVdIFs1XScpCiAKKyAgICBkZWYg dGVzdF9vc192ZXJzaW9uX2NoZWNrcyhzZWxmKToKKyAgICAgICAgc2VsZi5hc3NlcnRfbGludCgn I2lmIFBMQVRGT1JNKElPU19GQU1JTFkpICYmIF9fSVBIT05FX09TX1ZFUlNJT05fTUlOX1JFUVVJ UkVEIDwgMTEwMDAwJywgJ01pc3BsYWNlZCBPUyB2ZXJzaW9uIGNoZWNrLiBQbGVhc2UgdXNlIGEg bmFtZWQgbWFjcm8gaW4gd3RmL1BsYXRmb3JtLmggb3Igd3RmL0ZlYXR1cmVEZWZpbmVzLmguICBb YnVpbGQvdmVyc2lvbl9jaGVja10gWzVdJykKKyAgICAgICAgc2VsZi5hc3NlcnRfbGludCgnI2lm IFBMQVRGT1JNKE1BQykgJiYgX19NQUNfT1NfWF9WRVJTSU9OX01BWF9BTExPV0VEID49IDEwMTMw MCcsICdNaXNwbGFjZWQgT1MgdmVyc2lvbiBjaGVjay4gUGxlYXNlIHVzZSBhIG5hbWVkIG1hY3Jv IGluIHd0Zi9QbGF0Zm9ybS5oIG9yIHd0Zi9GZWF0dXJlRGVmaW5lcy5oLiAgW2J1aWxkL3ZlcnNp b25fY2hlY2tdIFs1XScpCisgICAgICAgIHNlbGYuYXNzZXJ0X2xpbnQoJyNpZiBQTEFURk9STShN QUMpICYmIF9fTUFDX09TX1hfVkVSU0lPTl9NSU5fUkVRVUlSRUQgPCAxMDEzMDAnLCAnJywgJ1Nv dXJjZS9XVEYvd3RmL1BsYXRmb3JtLmgnKQorICAgICAgICBzZWxmLmFzc2VydF9saW50KCcjaWYg UExBVEZPUk0oTUFDKSAmJiBfX0lQSE9ORV9PU19WRVJTSU9OX01JTl9SRVFVSVJFRCA+IDEyMDAw MCcsICcnLCAnU291cmNlL1dURi93dGYvUGxhdGZvcm0uaCcpCisgICAgICAgIHNlbGYuYXNzZXJ0 X2xpbnQoJyNpZiBQTEFURk9STShNQUMpICYmIF9fSVBIT05FX09TX1ZFUlNJT05fTUlOX1JFUVVJ UkVEID4gMTIwNDAwJywgJ0luY29ycmVjdCBPUyB2ZXJzaW9uIGNoZWNrLiBWRVJTSU9OX01JTl9S RVFVSVJFRCB2YWx1ZXMgbmV2ZXIgaW5jbHVkZSBhIG1pbm9yIHZlcnNpb24uIFlvdSBtYXkgYmUg bG9va2luZyBmb3IgYSBjb21iaW5hdGlvbiBvZiBWRVJTSU9OX01JTl9SRVFVSVJFRCBmb3IgdGFy Z2V0IE9TIHZlcnNpb24gY2hlY2sgYW5kIFZFUlNJT05fTUFYX0FMTE9XRUQgZm9yIFNESyBjaGVj ay4gIFtidWlsZC92ZXJzaW9uX2NoZWNrXSBbNV0nLCAnU291cmNlL1dURi93dGYvUGxhdGZvcm0u aCcpCisgICAgICAgIHNlbGYuYXNzZXJ0X2xpbnQoJyNpZiAhVEFSR0VUX09TX1NJTVVMQVRPUiAm JiBfX1dBVENIX09TX1ZFUlNJT05fTUlOX1JFUVVJUkVEIDwgNTAwMDAnLCAnTWlzcGxhY2VkIE9T IHZlcnNpb24gY2hlY2suIFBsZWFzZSB1c2UgYSBuYW1lZCBtYWNybyBpbiB3dGYvUGxhdGZvcm0u aCBvciB3dGYvRmVhdHVyZURlZmluZXMuaC4gIFtidWlsZC92ZXJzaW9uX2NoZWNrXSBbNV0nKQor ICAgICAgICBzZWxmLmFzc2VydF9saW50KCcjaWYgKFBMQVRGT1JNKElPU19GQU1JTFkpICYmIF9f SVBIT05FX09TX1ZFUlNJT05fTUlOX1JFUVVJUkVEIDwgMTEwMDAwKSB8fCAoUExBVEZPUk0oTUFD KSAmJiBfX01BQ19PU19YX1ZFUlNJT05fTUlOX1JFUVVJUkVEIDwgMTAxMzA0KScsIFsnSW5jb3Jy ZWN0IE9TIHZlcnNpb24gY2hlY2suIFZFUlNJT05fTUlOX1JFUVVJUkVEIHZhbHVlcyBuZXZlciBp bmNsdWRlIGEgbWlub3IgdmVyc2lvbi4gWW91IG1heSBiZSBsb29raW5nIGZvciBhIGNvbWJpbmF0 aW9uIG9mIFZFUlNJT05fTUlOX1JFUVVJUkVEIGZvciB0YXJnZXQgT1MgdmVyc2lvbiBjaGVjayBh bmQgVkVSU0lPTl9NQVhfQUxMT1dFRCBmb3IgU0RLIGNoZWNrLiAgW2J1aWxkL3ZlcnNpb25fY2hl Y2tdIFs1XScsICdNaXNwbGFjZWQgT1MgdmVyc2lvbiBjaGVjay4gUGxlYXNlIHVzZSBhIG5hbWVk IG1hY3JvIGluIHd0Zi9QbGF0Zm9ybS5oIG9yIHd0Zi9GZWF0dXJlRGVmaW5lcy5oLiAgW2J1aWxk L3ZlcnNpb25fY2hlY2tdIFs1XSddKQorICAgICAgICBzZWxmLmFzc2VydF9saW50KCcjZGVmaW5l IEZPTyAoKFBMQVRGT1JNKE1BQykgJiYgX19NQUNfT1NfWF9WRVJTSU9OX01BWF9BTExPV0VEID49 IDEwMTMwMiAmJiBfX01BQ19PU19YX1ZFUlNJT05fTUlOX1JFUVVJUkVEID49IDEwMTMwMCkpJywg J01pc3BsYWNlZCBPUyB2ZXJzaW9uIGNoZWNrLiBQbGVhc2UgdXNlIGEgbmFtZWQgbWFjcm8gaW4g d3RmL1BsYXRmb3JtLmggb3Igd3RmL0ZlYXR1cmVEZWZpbmVzLmguICBbYnVpbGQvdmVyc2lvbl9j aGVja10gWzVdJykKKwogICAgIGRlZiB0ZXN0X290aGVyKHNlbGYpOgogICAgICAgICAjIEZJWE1F OiBJbXBsZW1lbnQgdGhpcy4KICAgICAgICAgcGFzcwo=