192690 2018-12-13 19:47:29 -0800 Remove a global 'using namespace WebKit' in WebViewImpl.mm 2018-12-14 10:15:26 -0800 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 david_quesada webkit-unassigned commit-queue thorton webkit-bug-importer oldest_to_newest 1487820 0 david_quesada 2018-12-13 19:47:29 -0800 I didn't see this covered by the other patches working on this now. An unrelated patch I ran through EWS shuffled the unified builds such that this using statement caused build failures, and I came up with the fix. 1487821 1 357290 david_quesada 2018-12-13 19:50:16 -0800 Created attachment 357290 Patch 1487949 2 357290 commit-queue 2018-12-14 10:14:40 -0800 Comment on attachment 357290 Patch Clearing flags on attachment: 357290 Committed r239218: <https://trac.webkit.org/changeset/239218> 1487950 3 commit-queue 2018-12-14 10:14:42 -0800 All reviewed patches have been landed. Closing bug. 1487951 4 webkit-bug-importer 2018-12-14 10:15:26 -0800 <rdar://problem/46733680> 357290 2018-12-13 19:50:16 -0800 2018-12-14 10:14:40 -0800 Patch file_192690.txt text/plain 5325 david_quesada Y29tbWl0IGJhNmU0NGQ4NTEzYWQ5ODJiMzhiMjNlNGI5OWIzMDc1M2NhMjVkNTINCkF1dGhvcjog RGF2aWQgUXVlc2FkYSA8ZGF2aWRfcXVlc2FkYUBhcHBsZS5jb20+DQpEYXRlOiAgIFRodSBEZWMg MTMgMTk6NDg6MzEgMjAxOCAtMDgwMA0KDQogICAgUmVtb3ZlIGEgZ2xvYmFsICd1c2luZyBuYW1l c3BhY2UgV2ViS2l0JyBpbiBXZWJWaWV3SW1wbC5tbQ0KICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xOTI2OTANCiAgICANCiAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4NCiAgICANCiAgICAqIFVJUHJvY2Vzcy9Db2NvYS9XZWJWaWV3SW1wbC5tbToNCiAg ICAoLVtXS1RleHRMaXN0VG91Y2hCYXJWaWV3Q29udHJvbGxlciBpbml0V2l0aFdlYlZpZXdJbXBs Ol0pOg0KICAgICgtW1dLVGV4dExpc3RUb3VjaEJhclZpZXdDb250cm9sbGVyIF9zZWxlY3RMaXN0 Ol0pOg0KICAgICgtW1dLVGV4dExpc3RUb3VjaEJhclZpZXdDb250cm9sbGVyIHNldEN1cnJlbnRM aXN0VHlwZTpdKToNCiAgICAoLVtXS1RleHRUb3VjaEJhckl0ZW1Db250cm9sbGVyIGluaXRXaXRo V2ViVmlld0ltcGw6XSk6DQoNCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZyBi L1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nDQppbmRleCBiNTM4YTlkNjdiMC4uYjRkN2E3N2Q5YzQg MTAwNjQ0DQotLS0gYS9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZw0KKysrIGIvU291cmNlL1dlYktp dC9DaGFuZ2VMb2cNCkBAIC0xLDMgKzEsMTYgQEANCisyMDE4LTEyLTEzICBEYXZpZCBRdWVzYWRh ICA8ZGF2aWRfcXVlc2FkYUBhcHBsZS5jb20+DQorDQorICAgICAgICBSZW1vdmUgYSBnbG9iYWwg J3VzaW5nIG5hbWVzcGFjZSBXZWJLaXQnIGluIFdlYlZpZXdJbXBsLm1tDQorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTkyNjkwDQorDQorICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4NCisNCisgICAgICAgICogVUlQcm9jZXNzL0NvY29h L1dlYlZpZXdJbXBsLm1tOg0KKyAgICAgICAgKC1bV0tUZXh0TGlzdFRvdWNoQmFyVmlld0NvbnRy b2xsZXIgaW5pdFdpdGhXZWJWaWV3SW1wbDpdKToNCisgICAgICAgICgtW1dLVGV4dExpc3RUb3Vj aEJhclZpZXdDb250cm9sbGVyIF9zZWxlY3RMaXN0Ol0pOg0KKyAgICAgICAgKC1bV0tUZXh0TGlz dFRvdWNoQmFyVmlld0NvbnRyb2xsZXIgc2V0Q3VycmVudExpc3RUeXBlOl0pOg0KKyAgICAgICAg KC1bV0tUZXh0VG91Y2hCYXJJdGVtQ29udHJvbGxlciBpbml0V2l0aFdlYlZpZXdJbXBsOl0pOg0K Kw0KIDIwMTgtMTItMTMgIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4NCiANCiAgICAg ICAgIFtQU09OXSBXZSBzaG91bGQgbm90IG5lZWQgdG8gbmF2aWdhdGUgdG8gJ2Fib3V0OmJsYW5r JyB0byBzdXNwZW5kIHBhZ2VzDQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3Mv Q29jb2EvV2ViVmlld0ltcGwubW0gYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9Db2NvYS9XZWJW aWV3SW1wbC5tbQ0KaW5kZXggZDc0ZGRiMzcwNTIuLjE1MzY1MDg0MGEwIDEwMDY0NA0KLS0tIGEv U291cmNlL1dlYktpdC9VSVByb2Nlc3MvQ29jb2EvV2ViVmlld0ltcGwubW0NCisrKyBiL1NvdXJj ZS9XZWJLaXQvVUlQcm9jZXNzL0NvY29hL1dlYlZpZXdJbXBsLm1tDQpAQCAtNTI4LDE5ICs1Mjgs MTcgQEAgLSAoQk9PTCl0cnlUb1BlcmZvcm06KFNFTClhY3Rpb24gd2l0aDooaWQpb2JqZWN0DQog DQogQGVuZA0KIA0KLXVzaW5nIG5hbWVzcGFjZSBXZWJLaXQ7DQotDQogI2lmIEhBVkUoVE9VQ0hf QkFSKQ0KIA0KIEBpbnRlcmZhY2UgV0tUZXh0TGlzdFRvdWNoQmFyVmlld0NvbnRyb2xsZXIgOiBO U1ZpZXdDb250cm9sbGVyIHsNCiBAcHJpdmF0ZQ0KLSAgICBXZWJWaWV3SW1wbCogX3dlYlZpZXdJ bXBsOw0KLSAgICBMaXN0VHlwZSBfY3VycmVudExpc3RUeXBlOw0KKyAgICBXZWJLaXQ6OldlYlZp ZXdJbXBsKiBfd2ViVmlld0ltcGw7DQorICAgIFdlYktpdDo6TGlzdFR5cGUgX2N1cnJlbnRMaXN0 VHlwZTsNCiB9DQogDQotQHByb3BlcnR5IChub25hdG9taWMpIExpc3RUeXBlIGN1cnJlbnRMaXN0 VHlwZTsNCitAcHJvcGVydHkgKG5vbmF0b21pYykgV2ViS2l0OjpMaXN0VHlwZSBjdXJyZW50TGlz dFR5cGU7DQogDQotLSAoaW5zdGFuY2V0eXBlKWluaXRXaXRoV2ViVmlld0ltcGw6KFdlYlZpZXdJ bXBsKil3ZWJWaWV3SW1wbDsNCistIChpbnN0YW5jZXR5cGUpaW5pdFdpdGhXZWJWaWV3SW1wbDoo V2ViS2l0OjpXZWJWaWV3SW1wbCopd2ViVmlld0ltcGw7DQogDQogQGVuZA0KIA0KQEAgLTU1Nyw3 ICs1NTUsNyBAQCBzdGF0aWMgY29uc3QgTlNVSW50ZWdlciBub0xpc3RTZWdtZW50ID0gMDsNCiBz dGF0aWMgY29uc3QgTlNVSW50ZWdlciB1bm9yZGVyZWRMaXN0U2VnbWVudCA9IDE7DQogc3RhdGlj IGNvbnN0IE5TVUludGVnZXIgb3JkZXJlZExpc3RTZWdtZW50ID0gMjsNCiANCi0tIChpbnN0YW5j ZXR5cGUpaW5pdFdpdGhXZWJWaWV3SW1wbDooV2ViVmlld0ltcGwqKXdlYlZpZXdJbXBsDQorLSAo aW5zdGFuY2V0eXBlKWluaXRXaXRoV2ViVmlld0ltcGw6KFdlYktpdDo6V2ViVmlld0ltcGwqKXdl YlZpZXdJbXBsDQogew0KICAgICBpZiAoIShzZWxmID0gW3N1cGVyIGluaXRdKSkNCiAgICAgICAg IHJldHVybiBuaWw7DQpAQCAtNjAwLDkgKzU5OCw5IEBAIC0gKHZvaWQpX3NlbGVjdExpc3Q6KGlk KXNlbmRlcg0KICAgICAgICAgLy8gVGhlcmUgaXMgbm8gInJlbW92ZSBsaXN0IiBlZGl0IGNvbW1h bmQsIGJ1dCBJbnNlcnRPcmRlcmVkTGlzdCBhbmQgSW5zZXJ0VW5vcmRlcmVkTGlzdCBib3RoDQog ICAgICAgICAvLyBiZWhhdmUgYXMgdG9nZ2xlcywgc28gd2UgY2FuIGludm9rZSB0aGUgYXBwcm9w cmlhdGUgZWRpdCBjb21tYW5kIGRlcGVuZGluZyBvbiBvdXIgX2N1cnJlbnRMaXN0VHlwZQ0KICAg ICAgICAgLy8gdG8gcmVtb3ZlIGFuIGV4aXN0aW5nIGxpc3QuIFdlIGRvbid0IGhhdmUgdG8gZG8g YW55dGhpbmcgaWYgX2N1cnJlbnRMaXN0VHlwZSBpcyBOb0xpc3QuDQotICAgICAgICBpZiAoX2N1 cnJlbnRMaXN0VHlwZSA9PSBPcmRlcmVkTGlzdCkNCisgICAgICAgIGlmIChfY3VycmVudExpc3RU eXBlID09IFdlYktpdDo6T3JkZXJlZExpc3QpDQogICAgICAgICAgICAgX3dlYlZpZXdJbXBsLT5w YWdlKCkuZXhlY3V0ZUVkaXRDb21tYW5kKEAiSW5zZXJ0T3JkZXJlZExpc3QiLCBAIiIpOw0KLSAg ICAgICAgZWxzZSBpZiAoX2N1cnJlbnRMaXN0VHlwZSA9PSBVbm9yZGVyZWRMaXN0KQ0KKyAgICAg ICAgZWxzZSBpZiAoX2N1cnJlbnRMaXN0VHlwZSA9PSBXZWJLaXQ6OlVub3JkZXJlZExpc3QpDQog ICAgICAgICAgICAgX3dlYlZpZXdJbXBsLT5wYWdlKCkuZXhlY3V0ZUVkaXRDb21tYW5kKEAiSW5z ZXJ0VW5vcmRlcmVkTGlzdCIsIEAiIik7DQogICAgICAgICBicmVhazsNCiAgICAgY2FzZSB1bm9y ZGVyZWRMaXN0U2VnbWVudDoNCkBAIC02MTYsMTcgKzYxNCwxNyBAQCAtICh2b2lkKV9zZWxlY3RM aXN0OihpZClzZW5kZXINCiAgICAgX3dlYlZpZXdJbXBsLT5kaXNtaXNzVGV4dFRvdWNoQmFyUG9w b3Zlckl0ZW1XaXRoSWRlbnRpZmllcihOU1RvdWNoQmFySXRlbUlkZW50aWZpZXJUZXh0TGlzdCk7 DQogfQ0KIA0KLS0gKHZvaWQpc2V0Q3VycmVudExpc3RUeXBlOihMaXN0VHlwZSlsaXN0VHlwZQ0K Ky0gKHZvaWQpc2V0Q3VycmVudExpc3RUeXBlOihXZWJLaXQ6Okxpc3RUeXBlKWxpc3RUeXBlDQog ew0KICAgICBOU1NlZ21lbnRlZENvbnRyb2wgKmluc2VydExpc3RDb250cm9sID0gKE5TU2VnbWVu dGVkQ29udHJvbCAqKXNlbGYudmlldzsNCiAgICAgc3dpdGNoIChsaXN0VHlwZSkgew0KLSAgICBj YXNlIE5vTGlzdDoNCisgICAgY2FzZSBXZWJLaXQ6Ok5vTGlzdDoNCiAgICAgICAgIFtpbnNlcnRM aXN0Q29udHJvbCBzZXRTZWxlY3RlZDpZRVMgZm9yU2VnbWVudDpub0xpc3RTZWdtZW50XTsNCiAg ICAgICAgIGJyZWFrOw0KLSAgICBjYXNlIE9yZGVyZWRMaXN0Og0KKyAgICBjYXNlIFdlYktpdDo6 T3JkZXJlZExpc3Q6DQogICAgICAgICBbaW5zZXJ0TGlzdENvbnRyb2wgc2V0U2VsZWN0ZWQ6WUVT IGZvclNlZ21lbnQ6b3JkZXJlZExpc3RTZWdtZW50XTsNCiAgICAgICAgIGJyZWFrOw0KLSAgICBj YXNlIFVub3JkZXJlZExpc3Q6DQorICAgIGNhc2UgV2ViS2l0OjpVbm9yZGVyZWRMaXN0Og0KICAg ICAgICAgW2luc2VydExpc3RDb250cm9sIHNldFNlbGVjdGVkOllFUyBmb3JTZWdtZW50OnVub3Jk ZXJlZExpc3RTZWdtZW50XTsNCiAgICAgICAgIGJyZWFrOw0KICAgICB9DQpAQCAtNjQ2LDcgKzY0 NCw3IEBAIEBwcml2YXRlDQogICAgIFJldGFpblB0cjxXS1RleHRMaXN0VG91Y2hCYXJWaWV3Q29u dHJvbGxlcj4gX3RleHRMaXN0VG91Y2hCYXJWaWV3Q29udHJvbGxlcjsNCiANCiBAcHJpdmF0ZQ0K LSAgICBXZWJWaWV3SW1wbCogX3dlYlZpZXdJbXBsOw0KKyAgICBXZWJLaXQ6OldlYlZpZXdJbXBs KiBfd2ViVmlld0ltcGw7DQogfQ0KIA0KIEBwcm9wZXJ0eSAobm9uYXRvbWljKSBCT09MIHRleHRJ c0JvbGQ7DQpAQCAtNjU1LDcgKzY1Myw3IEBAIEBwcm9wZXJ0eSAobm9uYXRvbWljKSBCT09MIHRl eHRJc1VuZGVybGluZWQ7DQogQHByb3BlcnR5IChub25hdG9taWMpIE5TVGV4dEFsaWdubWVudCBj dXJyZW50VGV4dEFsaWdubWVudDsNCiBAcHJvcGVydHkgKG5vbmF0b21pYywgcmV0YWluLCByZWFk d3JpdGUpIE5TQ29sb3IgKnRleHRDb2xvcjsNCiANCi0tIChpbnN0YW5jZXR5cGUpaW5pdFdpdGhX ZWJWaWV3SW1wbDooV2ViVmlld0ltcGwqKXdlYlZpZXdJbXBsOw0KKy0gKGluc3RhbmNldHlwZSlp bml0V2l0aFdlYlZpZXdJbXBsOihXZWJLaXQ6OldlYlZpZXdJbXBsKil3ZWJWaWV3SW1wbDsNCiBA ZW5kDQogDQogQGltcGxlbWVudGF0aW9uIFdLVGV4dFRvdWNoQmFySXRlbUNvbnRyb2xsZXINCkBA IC02NjUsNyArNjYzLDcgQEAgQHN5bnRoZXNpemUgdGV4dElzSXRhbGljPV90ZXh0SXNJdGFsaWM7 DQogQHN5bnRoZXNpemUgdGV4dElzVW5kZXJsaW5lZD1fdGV4dElzVW5kZXJsaW5lZDsNCiBAc3lu dGhlc2l6ZSBjdXJyZW50VGV4dEFsaWdubWVudD1fY3VycmVudFRleHRBbGlnbm1lbnQ7DQogDQot LSAoaW5zdGFuY2V0eXBlKWluaXRXaXRoV2ViVmlld0ltcGw6KFdlYlZpZXdJbXBsKil3ZWJWaWV3 SW1wbA0KKy0gKGluc3RhbmNldHlwZSlpbml0V2l0aFdlYlZpZXdJbXBsOihXZWJLaXQ6OldlYlZp ZXdJbXBsKil3ZWJWaWV3SW1wbA0KIHsNCiAgICAgaWYgKCEoc2VsZiA9IFtzdXBlciBpbml0XSkp DQogICAgICAgICByZXR1cm4gbmlsOw0K