192689 2018-12-13 19:35:19 -0800 [iOS] Web Inspector: Occasional UIProcess crashes under WebPageProxy::showInspectorIndication 2018-12-13 20:39:25 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck cdumez commit-queue inspector-bugzilla-changes joepeck simon.fraser webkit-bug-importer oldest_to_newest 1487814 0 joepeck 2018-12-13 19:35:19 -0800 [iOS] Web Inspector: Occasional UIProcess crashes under WebPageProxy::showInspectorIndication Steps to Reproduce: 1. Start Safari on iPad 2. Load a few tabs 3. Safari > Develop > iPad > hover items => Safari on iPad may crash Notes: With some logging it looks like the WebPageProxy was not valid, it should have been removed from being a target: (WebKit) >>> WebPageDebuggable::setIndicating - yes (WebKit) >>> WebPageInspectorController::setIndicating - yes (WebKit) >>> WebPageProxy::showInspectorIndication - valid - no (WebKit) >>> WebPageProxy::showInspectorIndication - this - 0x10b87e618 (WebKit) >>> WebPageProxy::showInspectorIndication - &pageClient() – 0x0 1487815 1 joepeck 2018-12-13 19:35:29 -0800 <rdar://problem/46323610> 1487816 2 357288 joepeck 2018-12-13 19:36:45 -0800 Created attachment 357288 [PATCH] Proposed Fix 1487830 3 357288 commit-queue 2018-12-13 20:10:09 -0800 Comment on attachment 357288 [PATCH] Proposed Fix Clearing flags on attachment: 357288 Committed r239196: <https://trac.webkit.org/changeset/239196> 1487831 4 commit-queue 2018-12-13 20:10:10 -0800 All reviewed patches have been landed. Closing bug. 1487837 5 cdumez 2018-12-13 20:39:25 -0800 Committed r239197: <https://trac.webkit.org/changeset/239197> 357288 2018-12-13 19:36:45 -0800 2018-12-13 20:10:09 -0800 [PATCH] Proposed Fix here-goes-1.patch text/plain 2006 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKaW5kZXggYzIwYmI1N2Y4OTMuLjA5ZjM2ZTFmYWYxIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZwpAQCAtMSwzICsx LDE4IEBACisyMDE4LTEyLTEzICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+ CisKKyAgICAgICAgW2lPU10gV2ViIEluc3BlY3RvcjogT2NjYXNpb25hbCBVSVByb2Nlc3MgY3Jh c2hlcyB1bmRlciBXZWJQYWdlUHJveHk6OnNob3dJbnNwZWN0b3JJbmRpY2F0aW9uCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTI2ODkKKyAgICAgICAg PHJkYXI6Ly9wcm9ibGVtLzQ2MzIzNjEwPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgICogVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5jcHA6CisgICAgICAg IChXZWJLaXQ6OldlYlBhZ2VQcm94eTo6Y2xvc2UpOgorICAgICAgICAqIFVJUHJvY2Vzcy9XZWJQ YWdlUHJveHkuaDoKKyAgICAgICAgRG9uJ3Qgd2FpdCB1bnRpbCB+V2ViUGFnZVByb3h5IHRvIGRl c3Ryb3kgdGhlIFdlYlBhZ2VQcm94eURlYnVnZ2FibGUKKyAgICAgICAgd2hpY2ggYnJvYWRjYXN0 cyBpdCBhcyBhIHJlbW90ZSBpbnNwZWN0b3IgdGFyZ2V0LiBUZXJtaW5hdGUgdGhpcworICAgICAg ICBhcyBzb29uIGFzIHRoZSBXZWJQYWdlUHJveHkgY2xvc2VzIGFuZCBiZWNvbWVzIGludmFsaWQu CisKIDIwMTgtMTItMTMgIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KIAogICAgICAg ICBbUFNPTl0gV2Ugc2hvdWxkIG5vdCBuZWVkIHRvIG5hdmlnYXRlIHRvICdhYm91dDpibGFuaycg dG8gc3VzcGVuZCBwYWdlcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2Vi UGFnZVByb3h5LmNwcCBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5jcHAK aW5kZXggMzU4ZGI2ZmMyNGUuLjA0YjAzOGVlMmNmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNz L1dlYlBhZ2VQcm94eS5jcHAKQEAgLTk1OCw2ICs5NTgsOSBAQCB2b2lkIFdlYlBhZ2VQcm94eTo6 Y2xvc2UoKQogCiAgICAgbV9iYWNrRm9yd2FyZExpc3QtPnBhZ2VDbG9zZWQoKTsKICAgICBtX2lu c3BlY3RvckNvbnRyb2xsZXItPnBhZ2VDbG9zZWQoKTsKKyNpZiBFTkFCTEUoUkVNT1RFX0lOU1BF Q1RPUikKKyAgICBtX2luc3BlY3RvckRlYnVnZ2FibGUgPSBudWxscHRyOworI2VuZGlmCiAgICAg cGFnZUNsaWVudCgpLnBhZ2VDbG9zZWQoKTsKIAogICAgIG1fcHJvY2Vzcy0+ZGlzY29ubmVjdEZy YW1lc0Zyb21QYWdlKHRoaXMpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3Mv V2ViUGFnZVByb3h5LmggYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkuaApp bmRleCAzZGZkNjUzMjAzYy4uZDk2NDczZTg5MzIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQv VUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5oCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dl YlBhZ2VQcm94eS5oCkBAIC0yMjk1LDcgKzIyOTUsNyBAQCBwcml2YXRlOgogCiAgICAgY29uc3Qg c3RkOjp1bmlxdWVfcHRyPFdlYlBhZ2VJbnNwZWN0b3JDb250cm9sbGVyPiBtX2luc3BlY3RvckNv bnRyb2xsZXI7CiAjaWYgRU5BQkxFKFJFTU9URV9JTlNQRUNUT1IpCi0gICAgY29uc3Qgc3RkOjp1 bmlxdWVfcHRyPFdlYlBhZ2VEZWJ1Z2dhYmxlPiBtX2luc3BlY3RvckRlYnVnZ2FibGU7CisgICAg c3RkOjp1bmlxdWVfcHRyPFdlYlBhZ2VEZWJ1Z2dhYmxlPiBtX2luc3BlY3RvckRlYnVnZ2FibGU7 CiAjZW5kaWYKIAogICAgIHN0ZDo6b3B0aW9uYWw8U3BlbGxEb2N1bWVudFRhZz4gbV9zcGVsbERv Y3VtZW50VGFnOwo=