192666 2018-12-13 08:37:07 -0800 clang-tidy: Fix unnecessary parameter copies in ParallelHelperPool.cpp 2018-12-13 12:49:21 -0800 1 1 1 Unclassified WebKit Web Template Framework WebKit Local Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ddkilzer ddkilzer achristensen benjamin cdumez cmarcelo commit-queue darin dbates ews-watchlist fpizlo ggaren mark.lam webkit-bug-importer ysuzuki oldest_to_newest 1487592 0 ddkilzer 2018-12-13 08:37:07 -0800 Running `clang-tidy -checks='-*,performance-*,-performance-noexcept-*' ...` on ParallelHelperPool.cpp found these unnecessary copies: Source/WTF/wtf/ParallelHelperPool.cpp:36:14: warning: parameter 'pool' is passed by value and only copied once; consider moving it to avoid unnecessary copies [performance-unnecessary-value-param] : m_pool(pool) ^ std::move( ) Source/WTF/wtf/ParallelHelperPool.cpp:61:14: warning: parameter 'task' is passed by value and only copied once; consider moving it to avoid unnecessary copies [performance-unnecessary-value-param] m_task = task; ^ std::move( ) Source/WTF/wtf/ParallelHelperPool.cpp:86:13: warning: parameter 'task' is passed by value and only copied once; consider moving it to avoid unnecessary copies [performance-unnecessary-value-param] setTask(task); ^ std::move( ) Source/WTF/wtf/ParallelHelperPool.cpp:107:64: warning: the parameter 'task' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param] void ParallelHelperClient::runTask(RefPtr<SharedTask<void ()>> task) ^ const & 1487594 1 webkit-bug-importer 2018-12-13 08:37:48 -0800 <rdar://problem/46697952> 1487596 2 357233 ddkilzer 2018-12-13 08:46:41 -0800 Created attachment 357233 Patch v1 1487597 3 ews-watchlist 2018-12-13 08:48:33 -0800 Attachment 357233 did not pass style-queue: ERROR: Source/WTF/wtf/ParallelHelperPool.h:137: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/ParallelHelperPool.h:153: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/ParallelHelperPool.h:173: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/ParallelHelperPool.cpp:57: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/ParallelHelperPool.cpp:84: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/ParallelHelperPool.cpp:107: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 6 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 1487607 4 357233 ddkilzer 2018-12-13 09:10:58 -0800 Comment on attachment 357233 Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=357233&action=review > Source/WTF/wtf/ParallelHelperPool.cpp:86 > setTask(task); Oops! Forgot the WTFMove() here. 1487608 5 357235 ddkilzer 2018-12-13 09:11:32 -0800 Created attachment 357235 Patch v1 1487610 6 ews-watchlist 2018-12-13 09:13:00 -0800 Attachment 357235 did not pass style-queue: ERROR: Source/WTF/wtf/ParallelHelperPool.h:137: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/ParallelHelperPool.h:153: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/ParallelHelperPool.h:173: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/ParallelHelperPool.cpp:57: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/ParallelHelperPool.cpp:84: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/ParallelHelperPool.cpp:107: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 6 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 1487637 7 357235 achristensen 2018-12-13 11:19:33 -0800 Comment on attachment 357235 Patch v1 r=me Is there a way to see the unnecessary String copies? 1487653 8 ddkilzer 2018-12-13 12:15:51 -0800 (In reply to Alex Christensen from comment #7) > Comment on attachment 357235 [details] > Patch v1 > > r=me > Is there a way to see the unnecessary String copies? In a nutshell: 1. Build your own llvm/clang. 2. Build WebKit and save the full build output to a file. 3. Write a script to take the build output and "replay" the compiler commands with clang-tidy. (I have a script attached to <rdar://problem/46556354> to do this. I need to clean it up before landing in the WebKit repo, if the powers that be are okay with that since it requires building your own clang to use, or use a clang distro that includes clang-tidy.) 4. Run the script, then fix the issues it finds. (I'm doing this now for JavaScriptCore and WebCore.) 1487666 9 357235 commit-queue 2018-12-13 12:49:19 -0800 Comment on attachment 357235 Patch v1 Clearing flags on attachment: 357235 Committed r239177: <https://trac.webkit.org/changeset/239177> 1487667 10 commit-queue 2018-12-13 12:49:21 -0800 All reviewed patches have been landed. Closing bug. 357233 2018-12-13 08:46:41 -0800 2018-12-13 09:11:30 -0800 Patch v1 bug-192666-20181213084641.patch text/plain 4205 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMjM5MTEyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGNkNzNkZjBiMmY4YTQ0OTk3YzQzYzNk ZTVhOTIwYTEzZDliZGRhYTMuLjkxYTY3ODI4ZTZhYjVhYWQ1OGRlZmJlOTA0N2EwNTU5OTY4NGU2 MGIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAKKzIwMTgtMTItMTMgIERhdmlkIEtpbHplciAgPGRka2ls emVyQGFwcGxlLmNvbT4KKworICAgICAgICBjbGFuZy10aWR5OiBGaXggdW5uZWNlc3NhcnkgcGFy YW1ldGVyIGNvcGllcyBpbiBQYXJhbGxlbEhlbHBlclBvb2wuY3BwCisgICAgICAgIDxodHRwczov L3dlYmtpdC5vcmcvYi8xOTI2NjY+CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS80NjY5Nzk1Mj4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHd0Zi9Q YXJhbGxlbEhlbHBlclBvb2wuY3BwOgorICAgICAgICAoV1RGOjpQYXJhbGxlbEhlbHBlckNsaWVu dDo6UGFyYWxsZWxIZWxwZXJDbGllbnQpOiBVc2UgcnZhbHVlCisgICAgICAgIHJlZmVyZW5jZSBh bmQgV1RGTW92ZSgpLgorICAgICAgICAoV1RGOjpQYXJhbGxlbEhlbHBlckNsaWVudDo6c2V0VGFz ayk6IERpdHRvLgorICAgICAgICAoV1RGOjpQYXJhbGxlbEhlbHBlckNsaWVudDo6cnVuVGFza0lu UGFyYWxsZWwpOiBVc2UgcnZhbHVlCisgICAgICAgIHJlZmVyZW5jZSB0byBwYXNzIHRoZSBwYXJh bWV0ZXIgdG8gc2V0VGFzaygpLgorICAgICAgICAoV1RGOjpQYXJhbGxlbEhlbHBlckNsaWVudDo6 cnVuVGFzayk6IFVzZSBjb25zdCByZWZlcmVuY2UuCisgICAgICAgICogd3RmL1BhcmFsbGVsSGVs cGVyUG9vbC5oOiBVcGRhdGUgZGVjbGFyYXRpb25zIHRvIG1hdGNoCisgICAgICAgIGltcGxlbWVu dGF0aW9ucy4KKwogMjAxOC0xMi0xMSAgRnVqaWkgSGlyb25vcmkgIDxIaXJvbm9yaS5GdWppaUBz b255LmNvbT4KIAogICAgICAgICBbV2luXVtDbGFuZ10gRml4IGNvbXBpbGF0aW9uIHdhcm5pbmdz IG9mIFdURgpkaWZmIC0tZ2l0IGEvU291cmNlL1dURi93dGYvUGFyYWxsZWxIZWxwZXJQb29sLmNw cCBiL1NvdXJjZS9XVEYvd3RmL1BhcmFsbGVsSGVscGVyUG9vbC5jcHAKaW5kZXggMDA2ZTQ2OGQ5 MDBjM2M3YjdjOTAzY2M1Y2IzZmNkMWMyYjI0YTRmNC4uMDM0ODRlNTk4ZjQwMTA0MjEyZGQzODMz ZTUwNTM5ZGE1M2I3M2ExZSAxMDA2NDQKLS0tIGEvU291cmNlL1dURi93dGYvUGFyYWxsZWxIZWxw ZXJQb29sLmNwcAorKysgYi9Tb3VyY2UvV1RGL3d0Zi9QYXJhbGxlbEhlbHBlclBvb2wuY3BwCkBA IC0zMiw4ICszMiw4IEBACiAKIG5hbWVzcGFjZSBXVEYgewogCi1QYXJhbGxlbEhlbHBlckNsaWVu dDo6UGFyYWxsZWxIZWxwZXJDbGllbnQoUmVmUHRyPFBhcmFsbGVsSGVscGVyUG9vbD4gcG9vbCkK LSAgICA6IG1fcG9vbChwb29sKQorUGFyYWxsZWxIZWxwZXJDbGllbnQ6OlBhcmFsbGVsSGVscGVy Q2xpZW50KFJlZlB0cjxQYXJhbGxlbEhlbHBlclBvb2w+JiYgcG9vbCkKKyAgICA6IG1fcG9vbChX VEZNb3ZlKHBvb2wpKQogewogICAgIExvY2tIb2xkZXIgbG9ja2VyKCptX3Bvb2wtPm1fbG9jayk7 CiAgICAgUkVMRUFTRV9BU1NFUlQoIW1fcG9vbC0+bV9pc0R5aW5nKTsKQEAgLTU0LDExICs1NCwx MSBAQCBQYXJhbGxlbEhlbHBlckNsaWVudDo6flBhcmFsbGVsSGVscGVyQ2xpZW50KCkKICAgICB9 CiB9CiAKLXZvaWQgUGFyYWxsZWxIZWxwZXJDbGllbnQ6OnNldFRhc2soUmVmUHRyPFNoYXJlZFRh c2s8dm9pZCAoKT4+IHRhc2spCit2b2lkIFBhcmFsbGVsSGVscGVyQ2xpZW50OjpzZXRUYXNrKFJl ZlB0cjxTaGFyZWRUYXNrPHZvaWQgKCk+PiYmIHRhc2spCiB7CiAgICAgTG9ja0hvbGRlciBsb2Nr ZXIoKm1fcG9vbC0+bV9sb2NrKTsKICAgICBSRUxFQVNFX0FTU0VSVCghbV90YXNrKTsKLSAgICBt X3Rhc2sgPSB0YXNrOworICAgIG1fdGFzayA9IFdURk1vdmUodGFzayk7CiAgICAgbV9wb29sLT5k aWRNYWtlV29ya0F2YWlsYWJsZShsb2NrZXIpOwogfQogCkBAIC04MSw3ICs4MSw3IEBAIHZvaWQg UGFyYWxsZWxIZWxwZXJDbGllbnQ6OmRvU29tZUhlbHBpbmcoKQogICAgIHJ1blRhc2sodGFzayk7 CiB9CiAKLXZvaWQgUGFyYWxsZWxIZWxwZXJDbGllbnQ6OnJ1blRhc2tJblBhcmFsbGVsKFJlZlB0 cjxTaGFyZWRUYXNrPHZvaWQgKCk+PiB0YXNrKQordm9pZCBQYXJhbGxlbEhlbHBlckNsaWVudDo6 cnVuVGFza0luUGFyYWxsZWwoUmVmUHRyPFNoYXJlZFRhc2s8dm9pZCAoKT4+JiYgdGFzaykKIHsK ICAgICBzZXRUYXNrKHRhc2spOwogICAgIGRvU29tZUhlbHBpbmcoKTsKQEAgLTEwNCw3ICsxMDQs NyBAQCBSZWZQdHI8U2hhcmVkVGFzazx2b2lkICgpPj4gUGFyYWxsZWxIZWxwZXJDbGllbnQ6OmNs YWltVGFzayhjb25zdCBBYnN0cmFjdExvY2tlcgogICAgIHJldHVybiBtX3Rhc2s7CiB9CiAKLXZv aWQgUGFyYWxsZWxIZWxwZXJDbGllbnQ6OnJ1blRhc2soUmVmUHRyPFNoYXJlZFRhc2s8dm9pZCAo KT4+IHRhc2spCit2b2lkIFBhcmFsbGVsSGVscGVyQ2xpZW50OjpydW5UYXNrKGNvbnN0IFJlZlB0 cjxTaGFyZWRUYXNrPHZvaWQgKCk+PiYgdGFzaykKIHsKICAgICBSRUxFQVNFX0FTU0VSVChtX251 bUFjdGl2ZSk7CiAgICAgUkVMRUFTRV9BU1NFUlQodGFzayk7CmRpZmYgLS1naXQgYS9Tb3VyY2Uv V1RGL3d0Zi9QYXJhbGxlbEhlbHBlclBvb2wuaCBiL1NvdXJjZS9XVEYvd3RmL1BhcmFsbGVsSGVs cGVyUG9vbC5oCmluZGV4IDc3NzgwZjg1YjBhNWFmMTQyZmVmZGQ1MTk5ODg4MjIxZTZjODdmZDYu LjFlNzU5OWM4M2Q2NzEyMWM3ZTZiZmU4N2NjYTkxZWY2Y2U4NmU0MDcgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XVEYvd3RmL1BhcmFsbGVsSGVscGVyUG9vbC5oCisrKyBiL1NvdXJjZS9XVEYvd3RmL1Bh cmFsbGVsSGVscGVyUG9vbC5oCkBAIC0xMzEsMTAgKzEzMSwxMCBAQCBjbGFzcyBQYXJhbGxlbEhl bHBlckNsaWVudCB7CiAgICAgV1RGX01BS0VfTk9OQ09QWUFCTEUoUGFyYWxsZWxIZWxwZXJDbGll bnQpOwogICAgIFdURl9NQUtFX0ZBU1RfQUxMT0NBVEVEOwogcHVibGljOgotICAgIFdURl9FWFBP UlRfUFJJVkFURSBQYXJhbGxlbEhlbHBlckNsaWVudChSZWZQdHI8UGFyYWxsZWxIZWxwZXJQb29s Pik7CisgICAgV1RGX0VYUE9SVF9QUklWQVRFIFBhcmFsbGVsSGVscGVyQ2xpZW50KFJlZlB0cjxQ YXJhbGxlbEhlbHBlclBvb2w+JiYpOwogICAgIFdURl9FWFBPUlRfUFJJVkFURSB+UGFyYWxsZWxI ZWxwZXJDbGllbnQoKTsKIAotICAgIFdURl9FWFBPUlRfUFJJVkFURSB2b2lkIHNldFRhc2soUmVm UHRyPFNoYXJlZFRhc2s8dm9pZCAoKT4+KTsKKyAgICBXVEZfRVhQT1JUX1BSSVZBVEUgdm9pZCBz ZXRUYXNrKFJlZlB0cjxTaGFyZWRUYXNrPHZvaWQgKCk+PiYmKTsKIAogICAgIHRlbXBsYXRlPHR5 cGVuYW1lIEZ1bmN0b3I+CiAgICAgdm9pZCBzZXRGdW5jdGlvbihjb25zdCBGdW5jdG9yJiBmdW5j dG9yKQpAQCAtMTUwLDcgKzE1MCw3IEBAIHB1YmxpYzoKICAgICAvLyBjbGllbnQtPnNldFRhc2so dGFzayk7CiAgICAgLy8gY2xpZW50LT5kb1NvbWVIZWxwaW5nKCk7CiAgICAgLy8gY2xpZW50LT5m aW5pc2goKTsKLSAgICBXVEZfRVhQT1JUX1BSSVZBVEUgdm9pZCBydW5UYXNrSW5QYXJhbGxlbChS ZWZQdHI8U2hhcmVkVGFzazx2b2lkICgpPj4pOworICAgIFdURl9FWFBPUlRfUFJJVkFURSB2b2lk IHJ1blRhc2tJblBhcmFsbGVsKFJlZlB0cjxTaGFyZWRUYXNrPHZvaWQgKCk+PiYmKTsKIAogICAg IC8vIEVxdWl2YWxlbnQgdG86CiAgICAgLy8gY2xpZW50LT5zZXRGdW5jdGlvbihmdW5jdG9yKTsK QEAgLTE3MCw3ICsxNzAsNyBAQCBwcml2YXRlOgogCiAgICAgdm9pZCBmaW5pc2goY29uc3QgQWJz dHJhY3RMb2NrZXImKTsKICAgICBSZWZQdHI8U2hhcmVkVGFzazx2b2lkICgpPj4gY2xhaW1UYXNr KGNvbnN0IEFic3RyYWN0TG9ja2VyJik7Ci0gICAgdm9pZCBydW5UYXNrKFJlZlB0cjxTaGFyZWRU YXNrPHZvaWQgKCk+Pik7CisgICAgdm9pZCBydW5UYXNrKGNvbnN0IFJlZlB0cjxTaGFyZWRUYXNr PHZvaWQgKCk+PiYpOwogICAgIAogICAgIFJlZlB0cjxQYXJhbGxlbEhlbHBlclBvb2w+IG1fcG9v bDsKICAgICBSZWZQdHI8U2hhcmVkVGFzazx2b2lkICgpPj4gbV90YXNrOwo= 357235 2018-12-13 09:11:32 -0800 2018-12-13 12:49:19 -0800 Patch v1 bug-192666-20181213091131.patch text/plain 4193 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMjM5MTEyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGNkNzNkZjBiMmY4YTQ0OTk3YzQzYzNk ZTVhOTIwYTEzZDliZGRhYTMuLmMwZGNhYjVlZDMyOWM4OWRlYzQwYmNmMzExYWE5YWY5MTZhMTRh OWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTgtMTItMTMgIERhdmlkIEtpbHplciAgPGRka2ls emVyQGFwcGxlLmNvbT4KKworICAgICAgICBjbGFuZy10aWR5OiBGaXggdW5uZWNlc3NhcnkgcGFy YW1ldGVyIGNvcGllcyBpbiBQYXJhbGxlbEhlbHBlclBvb2wuY3BwCisgICAgICAgIDxodHRwczov L3dlYmtpdC5vcmcvYi8xOTI2NjY+CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS80NjY5Nzk1Mj4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHd0Zi9Q YXJhbGxlbEhlbHBlclBvb2wuY3BwOgorICAgICAgICAoV1RGOjpQYXJhbGxlbEhlbHBlckNsaWVu dDo6UGFyYWxsZWxIZWxwZXJDbGllbnQpOiBVc2UgcnZhbHVlCisgICAgICAgIHJlZmVyZW5jZSBh bmQgV1RGTW92ZSgpLgorICAgICAgICAoV1RGOjpQYXJhbGxlbEhlbHBlckNsaWVudDo6c2V0VGFz ayk6IERpdHRvLgorICAgICAgICAoV1RGOjpQYXJhbGxlbEhlbHBlckNsaWVudDo6cnVuVGFza0lu UGFyYWxsZWwpOiBEaXR0by4KKyAgICAgICAgKFdURjo6UGFyYWxsZWxIZWxwZXJDbGllbnQ6OnJ1 blRhc2spOiBVc2UgY29uc3QgcmVmZXJlbmNlLgorICAgICAgICAqIHd0Zi9QYXJhbGxlbEhlbHBl clBvb2wuaDogVXBkYXRlIGRlY2xhcmF0aW9ucyB0byBtYXRjaAorICAgICAgICBpbXBsZW1lbnRh dGlvbnMuCisKIDIwMTgtMTItMTEgIEZ1amlpIEhpcm9ub3JpICA8SGlyb25vcmkuRnVqaWlAc29u eS5jb20+CiAKICAgICAgICAgW1dpbl1bQ2xhbmddIEZpeCBjb21waWxhdGlvbiB3YXJuaW5ncyBv ZiBXVEYKZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvd3RmL1BhcmFsbGVsSGVscGVyUG9vbC5jcHAg Yi9Tb3VyY2UvV1RGL3d0Zi9QYXJhbGxlbEhlbHBlclBvb2wuY3BwCmluZGV4IDAwNmU0NjhkOTAw YzNjN2I3YzkwM2NjNWNiM2ZjZDFjMmIyNGE0ZjQuLjRmOWE5MjJjMDg0YjIyMjVkZDE4NWM0NTU0 ZGNlNDNkYjkwNDliZDAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL1BhcmFsbGVsSGVscGVy UG9vbC5jcHAKKysrIGIvU291cmNlL1dURi93dGYvUGFyYWxsZWxIZWxwZXJQb29sLmNwcApAQCAt MzIsOCArMzIsOCBAQAogCiBuYW1lc3BhY2UgV1RGIHsKIAotUGFyYWxsZWxIZWxwZXJDbGllbnQ6 OlBhcmFsbGVsSGVscGVyQ2xpZW50KFJlZlB0cjxQYXJhbGxlbEhlbHBlclBvb2w+IHBvb2wpCi0g ICAgOiBtX3Bvb2wocG9vbCkKK1BhcmFsbGVsSGVscGVyQ2xpZW50OjpQYXJhbGxlbEhlbHBlckNs aWVudChSZWZQdHI8UGFyYWxsZWxIZWxwZXJQb29sPiYmIHBvb2wpCisgICAgOiBtX3Bvb2woV1RG TW92ZShwb29sKSkKIHsKICAgICBMb2NrSG9sZGVyIGxvY2tlcigqbV9wb29sLT5tX2xvY2spOwog ICAgIFJFTEVBU0VfQVNTRVJUKCFtX3Bvb2wtPm1faXNEeWluZyk7CkBAIC01NCwxMSArNTQsMTEg QEAgUGFyYWxsZWxIZWxwZXJDbGllbnQ6On5QYXJhbGxlbEhlbHBlckNsaWVudCgpCiAgICAgfQog fQogCi12b2lkIFBhcmFsbGVsSGVscGVyQ2xpZW50OjpzZXRUYXNrKFJlZlB0cjxTaGFyZWRUYXNr PHZvaWQgKCk+PiB0YXNrKQordm9pZCBQYXJhbGxlbEhlbHBlckNsaWVudDo6c2V0VGFzayhSZWZQ dHI8U2hhcmVkVGFzazx2b2lkICgpPj4mJiB0YXNrKQogewogICAgIExvY2tIb2xkZXIgbG9ja2Vy KCptX3Bvb2wtPm1fbG9jayk7CiAgICAgUkVMRUFTRV9BU1NFUlQoIW1fdGFzayk7Ci0gICAgbV90 YXNrID0gdGFzazsKKyAgICBtX3Rhc2sgPSBXVEZNb3ZlKHRhc2spOwogICAgIG1fcG9vbC0+ZGlk TWFrZVdvcmtBdmFpbGFibGUobG9ja2VyKTsKIH0KIApAQCAtODEsOSArODEsOSBAQCB2b2lkIFBh cmFsbGVsSGVscGVyQ2xpZW50Ojpkb1NvbWVIZWxwaW5nKCkKICAgICBydW5UYXNrKHRhc2spOwog fQogCi12b2lkIFBhcmFsbGVsSGVscGVyQ2xpZW50OjpydW5UYXNrSW5QYXJhbGxlbChSZWZQdHI8 U2hhcmVkVGFzazx2b2lkICgpPj4gdGFzaykKK3ZvaWQgUGFyYWxsZWxIZWxwZXJDbGllbnQ6OnJ1 blRhc2tJblBhcmFsbGVsKFJlZlB0cjxTaGFyZWRUYXNrPHZvaWQgKCk+PiYmIHRhc2spCiB7Ci0g ICAgc2V0VGFzayh0YXNrKTsKKyAgICBzZXRUYXNrKFdURk1vdmUodGFzaykpOwogICAgIGRvU29t ZUhlbHBpbmcoKTsKICAgICBmaW5pc2goKTsKIH0KQEAgLTEwNCw3ICsxMDQsNyBAQCBSZWZQdHI8 U2hhcmVkVGFzazx2b2lkICgpPj4gUGFyYWxsZWxIZWxwZXJDbGllbnQ6OmNsYWltVGFzayhjb25z dCBBYnN0cmFjdExvY2tlcgogICAgIHJldHVybiBtX3Rhc2s7CiB9CiAKLXZvaWQgUGFyYWxsZWxI ZWxwZXJDbGllbnQ6OnJ1blRhc2soUmVmUHRyPFNoYXJlZFRhc2s8dm9pZCAoKT4+IHRhc2spCit2 b2lkIFBhcmFsbGVsSGVscGVyQ2xpZW50OjpydW5UYXNrKGNvbnN0IFJlZlB0cjxTaGFyZWRUYXNr PHZvaWQgKCk+PiYgdGFzaykKIHsKICAgICBSRUxFQVNFX0FTU0VSVChtX251bUFjdGl2ZSk7CiAg ICAgUkVMRUFTRV9BU1NFUlQodGFzayk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi9QYXJh bGxlbEhlbHBlclBvb2wuaCBiL1NvdXJjZS9XVEYvd3RmL1BhcmFsbGVsSGVscGVyUG9vbC5oCmlu ZGV4IDc3NzgwZjg1YjBhNWFmMTQyZmVmZGQ1MTk5ODg4MjIxZTZjODdmZDYuLjFlNzU5OWM4M2Q2 NzEyMWM3ZTZiZmU4N2NjYTkxZWY2Y2U4NmU0MDcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3Rm L1BhcmFsbGVsSGVscGVyUG9vbC5oCisrKyBiL1NvdXJjZS9XVEYvd3RmL1BhcmFsbGVsSGVscGVy UG9vbC5oCkBAIC0xMzEsMTAgKzEzMSwxMCBAQCBjbGFzcyBQYXJhbGxlbEhlbHBlckNsaWVudCB7 CiAgICAgV1RGX01BS0VfTk9OQ09QWUFCTEUoUGFyYWxsZWxIZWxwZXJDbGllbnQpOwogICAgIFdU Rl9NQUtFX0ZBU1RfQUxMT0NBVEVEOwogcHVibGljOgotICAgIFdURl9FWFBPUlRfUFJJVkFURSBQ YXJhbGxlbEhlbHBlckNsaWVudChSZWZQdHI8UGFyYWxsZWxIZWxwZXJQb29sPik7CisgICAgV1RG X0VYUE9SVF9QUklWQVRFIFBhcmFsbGVsSGVscGVyQ2xpZW50KFJlZlB0cjxQYXJhbGxlbEhlbHBl clBvb2w+JiYpOwogICAgIFdURl9FWFBPUlRfUFJJVkFURSB+UGFyYWxsZWxIZWxwZXJDbGllbnQo KTsKIAotICAgIFdURl9FWFBPUlRfUFJJVkFURSB2b2lkIHNldFRhc2soUmVmUHRyPFNoYXJlZFRh c2s8dm9pZCAoKT4+KTsKKyAgICBXVEZfRVhQT1JUX1BSSVZBVEUgdm9pZCBzZXRUYXNrKFJlZlB0 cjxTaGFyZWRUYXNrPHZvaWQgKCk+PiYmKTsKIAogICAgIHRlbXBsYXRlPHR5cGVuYW1lIEZ1bmN0 b3I+CiAgICAgdm9pZCBzZXRGdW5jdGlvbihjb25zdCBGdW5jdG9yJiBmdW5jdG9yKQpAQCAtMTUw LDcgKzE1MCw3IEBAIHB1YmxpYzoKICAgICAvLyBjbGllbnQtPnNldFRhc2sodGFzayk7CiAgICAg Ly8gY2xpZW50LT5kb1NvbWVIZWxwaW5nKCk7CiAgICAgLy8gY2xpZW50LT5maW5pc2goKTsKLSAg ICBXVEZfRVhQT1JUX1BSSVZBVEUgdm9pZCBydW5UYXNrSW5QYXJhbGxlbChSZWZQdHI8U2hhcmVk VGFzazx2b2lkICgpPj4pOworICAgIFdURl9FWFBPUlRfUFJJVkFURSB2b2lkIHJ1blRhc2tJblBh cmFsbGVsKFJlZlB0cjxTaGFyZWRUYXNrPHZvaWQgKCk+PiYmKTsKIAogICAgIC8vIEVxdWl2YWxl bnQgdG86CiAgICAgLy8gY2xpZW50LT5zZXRGdW5jdGlvbihmdW5jdG9yKTsKQEAgLTE3MCw3ICsx NzAsNyBAQCBwcml2YXRlOgogCiAgICAgdm9pZCBmaW5pc2goY29uc3QgQWJzdHJhY3RMb2NrZXIm KTsKICAgICBSZWZQdHI8U2hhcmVkVGFzazx2b2lkICgpPj4gY2xhaW1UYXNrKGNvbnN0IEFic3Ry YWN0TG9ja2VyJik7Ci0gICAgdm9pZCBydW5UYXNrKFJlZlB0cjxTaGFyZWRUYXNrPHZvaWQgKCk+ Pik7CisgICAgdm9pZCBydW5UYXNrKGNvbnN0IFJlZlB0cjxTaGFyZWRUYXNrPHZvaWQgKCk+PiYp OwogICAgIAogICAgIFJlZlB0cjxQYXJhbGxlbEhlbHBlclBvb2w+IG1fcG9vbDsKICAgICBSZWZQ dHI8U2hhcmVkVGFzazx2b2lkICgpPj4gbV90YXNrOwo=