192661 2018-12-13 04:10:30 -0800 clang-tidy: loop variable is copied but only used as const reference in Document.cpp, Element.cpp 2018-12-17 01:37:13 -0800 1 1 1 Unclassified WebKit DOM WebKit Local Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=192751 http://clang.llvm.org/extra/clang-tidy/checks/performance-for-range-copy.html InRadar P2 Normal --- 188670 1 ddkilzer ddkilzer ajuma cdumez cmarcelo commit-queue dbates esprehn+autocc ews-watchlist kangil.han simon.fraser webkit-bug-importer oldest_to_newest 1487554 0 ddkilzer 2018-12-13 04:10:30 -0800 Running `clang-tidy '-checks=-*,performance-for-range-copy' ...` on Document.cpp and Element.cpp finds these unnecessary copies: Source/WebCore/dom/Document.cpp:7907:15: warning: loop variable is copied but only used as const reference; consider making it a const reference [performance-for-range-copy] for (auto observer : m_intersectionObserversWithPendingNotifications) { ^ const & Source/WebCore/dom/Element.cpp:1777:19: warning: loop variable is copied but only used as const reference; consider making it a const reference [performance-for-range-copy] for (auto observer : observerData->observers) { ^ const & Source/WebCore/dom/Element.cpp:3399:15: warning: loop variable is copied but only used as const reference; consider making it a const reference [performance-for-range-copy] for (auto observer : observerData->observers) ^ const & 1487555 1 webkit-bug-importer 2018-12-13 04:11:29 -0800 <rdar://problem/46694035> 1487571 2 357226 ddkilzer 2018-12-13 05:33:03 -0800 Created attachment 357226 Patch v1 1487576 3 357226 commit-queue 2018-12-13 06:44:36 -0800 Comment on attachment 357226 Patch v1 Clearing flags on attachment: 357226 Committed r239160: <https://trac.webkit.org/changeset/239160> 1487577 4 commit-queue 2018-12-13 06:44:38 -0800 All reviewed patches have been landed. Closing bug. 357226 2018-12-13 05:33:03 -0800 2018-12-13 06:44:36 -0800 Patch v1 bug-192661-20181213053302.patch text/plain 3432 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMjM5MTEyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYzBhZTRlYzNjZDM2YTkz NDAwNDQ1NzkxYzU1OWE4MjliYWJmNjczZC4uODhmN2VkZGMyNjk1N2MzZTVkZTg2MjhjMmVkZjFm ZDA3NDJkMDM3OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDE4LTEyLTEzICBEYXZp ZCBLaWx6ZXIgIDxkZGtpbHplckBhcHBsZS5jb20+CisKKyAgICAgICAgY2xhbmctdGlkeTogbG9v cCB2YXJpYWJsZSBpcyBjb3BpZWQgYnV0IG9ubHkgdXNlZCBhcyBjb25zdCByZWZlcmVuY2UgaW4g RG9jdW1lbnQuY3BwLCBFbGVtZW50LmNwcAorICAgICAgICA8aHR0cHM6Ly93ZWJraXQub3JnL2Iv MTkyNjYxPgorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNDY2OTQwMzU+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBkb20vRG9jdW1lbnQuY3BwOgor ICAgICAgICAoV2ViQ29yZTo6RG9jdW1lbnQ6OnVwZGF0ZUludGVyc2VjdGlvbk9ic2VydmF0aW9u cyk6CisgICAgICAgIChXZWJDb3JlOjpEb2N1bWVudDo6bm90aWZ5SW50ZXJzZWN0aW9uT2JzZXJ2 ZXJzVGltZXJGaXJlZCk6CisgICAgICAgICogZG9tL0VsZW1lbnQuY3BwOgorICAgICAgICAoV2Vi Q29yZTo6RWxlbWVudDo6ZGlkTW92ZVRvTmV3RG9jdW1lbnQpOgorICAgICAgICAoV2ViQ29yZTo6 RWxlbWVudDo6ZGlzY29ubmVjdEZyb21JbnRlcnNlY3Rpb25PYnNlcnZlcnMpOgorICAgICAgICAt IENoYW5nZSBsb29wIHZhcmlhYmxlcyBmcm9tIGBhdXRvYCB0byBgY29uc3QgYXV0byZgIHRvIHBy ZXZlbnQKKyAgICAgICAgICB1bm5lY2Vzc2FyeSBjb3BpZXMgb2YgV2Vha1B0cjxJbnRlcnNlY3Rp b25PYnNlcnZlcj4gb3IKKyAgICAgICAgICBzdHJ1Y3QgSW50ZXJzZWN0aW9uT2JzZXJ2ZXJSZWdp c3RyYXRpb24gb2JqZWN0cy4KKwogMjAxOC0xMi0xMiAgV2Vuc29uIEhzaWVoICA8d2Vuc29uX2hz aWVoQGFwcGxlLmNvbT4KIAogICAgICAgICBbaU9TXSBBIGZldyBBUEkgdGVzdHMgYXJlIGZhaWxp bmcgYWZ0ZXIgcjIzOTA4NgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50 LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHAKaW5kZXggMjI2YmZmMmE4YTI4 NTg4Mzc4NWMyNDUwMjMxMjFjNjg1ZGFjN2JjMy4uZDZiZTkxMmIxMjNhYjE3OTcwZTg4YjQ4MjE0 NjA5MTM4M2FhYmRkYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50LmNw cAorKysgYi9Tb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1lbnQuY3BwCkBAIC03ODE1LDcgKzc4MTUs NyBAQCB2b2lkIERvY3VtZW50Ojp1cGRhdGVJbnRlcnNlY3Rpb25PYnNlcnZhdGlvbnMoKQogCiAg ICAgbV9uZWVkc0ZvcmNlZEludGVyc2VjdGlvbk9ic2VydmF0aW9uVXBkYXRlID0gZmFsc2U7CiAK LSAgICBmb3IgKGF1dG8gb2JzZXJ2ZXIgOiBtX2ludGVyc2VjdGlvbk9ic2VydmVycykgeworICAg IGZvciAoY29uc3QgYXV0byYgb2JzZXJ2ZXIgOiBtX2ludGVyc2VjdGlvbk9ic2VydmVycykgewog ICAgICAgICBib29sIG5lZWROb3RpZnkgPSBmYWxzZTsKICAgICAgICAgRE9NSGlnaFJlc1RpbWVT dGFtcCB0aW1lc3RhbXA7CiAgICAgICAgIGlmICghb2JzZXJ2ZXItPmNyZWF0ZVRpbWVzdGFtcCh0 aW1lc3RhbXApKQpAQCAtNzkwNCw3ICs3OTA0LDcgQEAgdm9pZCBEb2N1bWVudDo6c2NoZWR1bGVG b3JjZWRJbnRlcnNlY3Rpb25PYnNlcnZhdGlvblVwZGF0ZSgpCiAKIHZvaWQgRG9jdW1lbnQ6Om5v dGlmeUludGVyc2VjdGlvbk9ic2VydmVyc1RpbWVyRmlyZWQoKQogewotICAgIGZvciAoYXV0byBv YnNlcnZlciA6IG1faW50ZXJzZWN0aW9uT2JzZXJ2ZXJzV2l0aFBlbmRpbmdOb3RpZmljYXRpb25z KSB7CisgICAgZm9yIChjb25zdCBhdXRvJiBvYnNlcnZlciA6IG1faW50ZXJzZWN0aW9uT2JzZXJ2 ZXJzV2l0aFBlbmRpbmdOb3RpZmljYXRpb25zKSB7CiAgICAgICAgIGlmIChvYnNlcnZlcikKICAg ICAgICAgICAgIG9ic2VydmVyLT5ub3RpZnkoKTsKICAgICB9CmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9kb20vRWxlbWVudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9kb20vRWxlbWVudC5jcHAK aW5kZXggOTNiZTdiYjJjYWM2YzU5MGI1NTAwOGI5ODQ1ZjhmYWEzZTRjMWU0NS4uNjQ2OGVhYmYz NDAwMDIyODVjNGM1NDI5ODRlZjc3ZDljZGE1NTg5NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvZG9tL0VsZW1lbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2RvbS9FbGVtZW50LmNwcApA QCAtMTc3NCw3ICsxNzc0LDcgQEAgdm9pZCBFbGVtZW50OjpkaWRNb3ZlVG9OZXdEb2N1bWVudChE b2N1bWVudCYgb2xkRG9jdW1lbnQsIERvY3VtZW50JiBuZXdEb2N1bWVudCkKIAogI2lmIEVOQUJM RShJTlRFUlNFQ1RJT05fT0JTRVJWRVIpCiAgICAgaWYgKGF1dG8qIG9ic2VydmVyRGF0YSA9IGlu dGVyc2VjdGlvbk9ic2VydmVyRGF0YSgpKSB7Ci0gICAgICAgIGZvciAoYXV0byBvYnNlcnZlciA6 IG9ic2VydmVyRGF0YS0+b2JzZXJ2ZXJzKSB7CisgICAgICAgIGZvciAoY29uc3QgYXV0byYgb2Jz ZXJ2ZXIgOiBvYnNlcnZlckRhdGEtPm9ic2VydmVycykgewogICAgICAgICAgICAgaWYgKG9ic2Vy dmVyLT5oYXNPYnNlcnZhdGlvblRhcmdldHMoKSkgewogICAgICAgICAgICAgICAgIG9sZERvY3Vt ZW50LnJlbW92ZUludGVyc2VjdGlvbk9ic2VydmVyKCpvYnNlcnZlcik7CiAgICAgICAgICAgICAg ICAgbmV3RG9jdW1lbnQuYWRkSW50ZXJzZWN0aW9uT2JzZXJ2ZXIoKm9ic2VydmVyKTsKQEAgLTMz OTIsMTEgKzMzOTIsMTEgQEAgdm9pZCBFbGVtZW50OjpkaXNjb25uZWN0RnJvbUludGVyc2VjdGlv bk9ic2VydmVycygpCiAgICAgaWYgKCFvYnNlcnZlckRhdGEpCiAgICAgICAgIHJldHVybjsKIAot ICAgIGZvciAoYXV0byYgcmVnaXN0cmF0aW9uIDogb2JzZXJ2ZXJEYXRhLT5yZWdpc3RyYXRpb25z KQorICAgIGZvciAoY29uc3QgYXV0byYgcmVnaXN0cmF0aW9uIDogb2JzZXJ2ZXJEYXRhLT5yZWdp c3RyYXRpb25zKQogICAgICAgICByZWdpc3RyYXRpb24ub2JzZXJ2ZXItPnRhcmdldERlc3Ryb3ll ZCgqdGhpcyk7CiAgICAgb2JzZXJ2ZXJEYXRhLT5yZWdpc3RyYXRpb25zLmNsZWFyKCk7CiAKLSAg ICBmb3IgKGF1dG8gb2JzZXJ2ZXIgOiBvYnNlcnZlckRhdGEtPm9ic2VydmVycykKKyAgICBmb3Ig KGNvbnN0IGF1dG8mIG9ic2VydmVyIDogb2JzZXJ2ZXJEYXRhLT5vYnNlcnZlcnMpCiAgICAgICAg IG9ic2VydmVyLT5yb290RGVzdHJveWVkKCk7CiAgICAgb2JzZXJ2ZXJEYXRhLT5vYnNlcnZlcnMu Y2xlYXIoKTsKIH0K