192660 2018-12-13 01:31:11 -0800 Improve GDB output for LLInt on Linux 2018-12-13 23:18:03 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 dominik.infuehr webkit-unassigned commit-queue ews-watchlist keith_miller mark.lam msaboff saam webkit-bug-importer ysuzuki oldest_to_newest 1487538 0 dominik.infuehr 2018-12-13 01:31:11 -0800 Improve GDB output for LLInt on Linux 1487540 1 357220 dominik.infuehr 2018-12-13 01:43:15 -0800 Created attachment 357220 Patch 1487543 2 357220 ysuzuki 2018-12-13 02:40:21 -0800 Comment on attachment 357220 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=357220&action=review > Source/JavaScriptCore/offlineasm/arm.rb:687 > + offsetLabel = ".L_offlineasm_arm_got_offset_#{uid}" Does this break OS(DARWIN)? See wtf/InlineASM.h's LOCAL_LABEL_STRING definition. 1487552 3 357223 dominik.infuehr 2018-12-13 04:08:12 -0800 Created attachment 357223 Patch 1487556 4 dominik.infuehr 2018-12-13 04:11:46 -0800 True, I didn't expect it to be used on OS(DARWIN) since I've only added `globaladdr` for ARM recently. But I've updated it to use `Assembler.localLabellReference`, should be a bit simpler. 1487579 5 357223 ysuzuki 2018-12-13 07:29:24 -0800 Comment on attachment 357223 Patch r=me 1487860 6 357223 commit-queue 2018-12-13 23:17:39 -0800 Comment on attachment 357223 Patch Clearing flags on attachment: 357223 Committed r239199: <https://trac.webkit.org/changeset/239199> 1487861 7 commit-queue 2018-12-13 23:17:41 -0800 All reviewed patches have been landed. Closing bug. 357220 2018-12-13 01:43:15 -0800 2018-12-13 04:08:07 -0800 Patch bug-192660-20181213104314.patch text/plain 2890 dominik.infuehr U3VidmVyc2lvbiBSZXZpc2lvbjogMjM5MTU0CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA3 NjhhOWI1MjlkMjMzODczNzIwZTljNjU4YTZlOGNkMWNlZjQ3OWYxLi4wODViYzkxNGZjMmRlMTZh MzRjNWIxYzU3MjdhNTFlMzU5NTBkZmVmIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNyBAQAorMjAxOC0xMi0xMyAgRG9taW5payBJbmZ1ZWhyICA8ZGluZnVlaHJAaWdhbGlh LmNvbT4KKworICAgICAgICBJbXByb3ZlIEdEQiBvdXRwdXQgZm9yIExMSW50IG9uIExpbnV4Cisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTI2NjAKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBbm5vdGF0ZSBh c3NlbWJseSBjb2RlIGdlbmVyYXRlZCBmb3IgTExJbnQgd2l0aCB0aGUgYnl0ZWNvZGUgb3BlcmF0 aW9uLiBXaGVuIGRlYnVnZ2luZworICAgICAgICBMTEludCBhc3NlbWJseSBjb2RlIEdEQiBpcyB0 aGVuIGFibGUgdG8gc2hvdyB3aGljaCBieXRlY29kZSBpbnN0cnVjdGlvbiBpcyBpbXBsZW1lbnRl ZCBieQorICAgICAgICB0aGUgY3VycmVudCBhc3NlbWJseSBjb2RlLiBUaGlzIGFsc28gd29ya3Mg Zm9yIGxpbnV4LXBlcmYuCisKKyAgICAgICAgKiBsbGludC9Mb3dMZXZlbEludGVycHJldGVyLmNw cDoKKyAgICAgICAgKiBvZmZsaW5lYXNtL2FybS5yYjoKKwogMjAxOC0xMi0xMyAgWXVzdWtlIFN1 enVraSAgPHl1c3VrZXN1enVraUBzbG93c3RhcnQub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQs IGJ1aWxkIGZpeCBhZnRlciByMjM5MTUzCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvbGxpbnQvTG93TGV2ZWxJbnRlcnByZXRlci5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv bGxpbnQvTG93TGV2ZWxJbnRlcnByZXRlci5jcHAKaW5kZXggY2ViZmU4YjFiZThhYTEwOTk4ZTdk YTE0MWYxMDhhMTg0MmNmOWI1MS4uODNhZDZjOTdmMTM0NmFiNTE5NTc5MTg1ZDBhNTU2NWRlZTYy NTIxZiAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2xsaW50L0xvd0xldmVsSW50 ZXJwcmV0ZXIuY3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9sbGludC9Mb3dMZXZlbElu dGVycHJldGVyLmNwcApAQCAtNTQ4LDYgKzU0OCw3IEBAIEpTVmFsdWUgQ0xvb3A6OmV4ZWN1dGUo T3Bjb2RlSUQgZW50cnlPcGNvZGVJRCwgdm9pZCogZXhlY3V0YWJsZUFkZHJlc3MsIFZNKiB2bSwK IAogI2RlZmluZSBPRkZMSU5FX0FTTV9PUENPREVfTEFCRUwoX19vcGNvZGUpIFwKICAgICBFTUJF RF9PUENPREVfSURfSUZfTkVFREVEKF9fb3Bjb2RlKSBcCisgICAgT0ZGTElORV9BU01fT1BDT0RF X0RFQlVHX0xBQkVMKGxsaW50XyMjX19vcGNvZGUpIFwKICAgICBPRkZMSU5FX0FTTV9MT0NBTF9M QUJFTChsbGludF8jI19fb3Bjb2RlKQogCiAjZGVmaW5lIE9GRkxJTkVfQVNNX0dMVUVfTEFCRUwo X19vcGNvZGUpICAgT0ZGTElORV9BU01fTE9DQUxfTEFCRUwoX19vcGNvZGUpCkBAIC01NzgsNiAr NTc5LDEyIEBAIEpTVmFsdWUgQ0xvb3A6OmV4ZWN1dGUoT3Bjb2RlSUQgZW50cnlPcGNvZGVJRCwg dm9pZCogZXhlY3V0YWJsZUFkZHJlc3MsIFZNKiB2bSwKIAogI2RlZmluZSBPRkZMSU5FX0FTTV9M T0NBTF9MQUJFTChsYWJlbCkgICBMT0NBTF9MQUJFTF9TVFJJTkcobGFiZWwpICI6XG4iCiAKKyNp ZiBPUyhMSU5VWCkKKyNkZWZpbmUgT0ZGTElORV9BU01fT1BDT0RFX0RFQlVHX0xBQkVMKGxhYmVs KSAgI2xhYmVsICI6XG4iCisjZWxzZQorI2RlZmluZSBPRkZMSU5FX0FTTV9PUENPREVfREVCVUdf TEFCRUwobGFiZWwpCisjZW5kaWYKKwogLy8gVGhpcyBpcyBhIGZpbGUgZ2VuZXJhdGVkIGJ5IG9m ZmxpbmVhc20sIHdoaWNoIGNvbnRhaW5zIGFsbCBvZiB0aGUgYXNzZW1ibHkgY29kZQogLy8gZm9y IHRoZSBpbnRlcnByZXRlciwgYXMgY29tcGlsZWQgZnJvbSBMb3dMZXZlbEludGVycHJldGVyLmFz bS4KICNpbmNsdWRlICJMTEludEFzc2VtYmx5LmgiCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNj cmlwdENvcmUvb2ZmbGluZWFzbS9hcm0ucmIgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvb2ZmbGlu ZWFzbS9hcm0ucmIKaW5kZXggYjBjMzM2MjdkMTA4NzIyNzllMDgxMWM0ZjRhN2VjYWQ0MWU1ZmM2 Ny4uYzY3ODY4N2MwY2Q5MDlkMTQzN2VjM2MzNWRhYjEyMTE0ZmI3YWViNCAxMDA2NDQKLS0tIGEv U291cmNlL0phdmFTY3JpcHRDb3JlL29mZmxpbmVhc20vYXJtLnJiCisrKyBiL1NvdXJjZS9KYXZh U2NyaXB0Q29yZS9vZmZsaW5lYXNtL2FybS5yYgpAQCAtNjgzLDggKzY4Myw4IEBAIGNsYXNzIElu c3RydWN0aW9uCiAgICAgICAgICAgICB0ZW1wID0gb3BlcmFuZHNbMl0KIAogICAgICAgICAgICAg dWlkID0gJGFzbS5uZXdVSUQKLSAgICAgICAgICAgIGdvdExhYmVsID0gIkxfb2ZmbGluZWFzbV9h cm1fZ290XyN7dWlkfSIKLSAgICAgICAgICAgIG9mZnNldExhYmVsID0gIkxfb2ZmbGluZWFzbV9h cm1fZ290X29mZnNldF8je3VpZH0iCisgICAgICAgICAgICBnb3RMYWJlbCA9ICIuTF9vZmZsaW5l YXNtX2FybV9nb3RfI3t1aWR9IgorICAgICAgICAgICAgb2Zmc2V0TGFiZWwgPSAiLkxfb2ZmbGlu ZWFzbV9hcm1fZ290X29mZnNldF8je3VpZH0iCiAKICAgICAgICAgICAgICRhc20ucHV0cyAibGRy ICN7ZGVzdC5hcm1PcGVyYW5kfSwgI3tnb3RMYWJlbH0iCiAgICAgICAgICAgICAkYXNtLnB1dHMg ImxkciAje3RlbXAuYXJtT3BlcmFuZH0sICN7Z290TGFiZWx9KzQiCg== 357223 2018-12-13 04:08:12 -0800 2018-12-13 23:17:39 -0800 Patch bug-192660-20181213130810.patch text/plain 2946 dominik.infuehr U3VidmVyc2lvbiBSZXZpc2lvbjogMjM5MTU0CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA3 NjhhOWI1MjlkMjMzODczNzIwZTljNjU4YTZlOGNkMWNlZjQ3OWYxLi4wODViYzkxNGZjMmRlMTZh MzRjNWIxYzU3MjdhNTFlMzU5NTBkZmVmIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNyBAQAorMjAxOC0xMi0xMyAgRG9taW5payBJbmZ1ZWhyICA8ZGluZnVlaHJAaWdhbGlh LmNvbT4KKworICAgICAgICBJbXByb3ZlIEdEQiBvdXRwdXQgZm9yIExMSW50IG9uIExpbnV4Cisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTI2NjAKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBbm5vdGF0ZSBh c3NlbWJseSBjb2RlIGdlbmVyYXRlZCBmb3IgTExJbnQgd2l0aCB0aGUgYnl0ZWNvZGUgb3BlcmF0 aW9uLiBXaGVuIGRlYnVnZ2luZworICAgICAgICBMTEludCBhc3NlbWJseSBjb2RlIEdEQiBpcyB0 aGVuIGFibGUgdG8gc2hvdyB3aGljaCBieXRlY29kZSBpbnN0cnVjdGlvbiBpcyBpbXBsZW1lbnRl ZCBieQorICAgICAgICB0aGUgY3VycmVudCBhc3NlbWJseSBjb2RlLiBUaGlzIGFsc28gd29ya3Mg Zm9yIGxpbnV4LXBlcmYuCisKKyAgICAgICAgKiBsbGludC9Mb3dMZXZlbEludGVycHJldGVyLmNw cDoKKyAgICAgICAgKiBvZmZsaW5lYXNtL2FybS5yYjoKKwogMjAxOC0xMi0xMyAgWXVzdWtlIFN1 enVraSAgPHl1c3VrZXN1enVraUBzbG93c3RhcnQub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQs IGJ1aWxkIGZpeCBhZnRlciByMjM5MTUzCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvbGxpbnQvTG93TGV2ZWxJbnRlcnByZXRlci5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv bGxpbnQvTG93TGV2ZWxJbnRlcnByZXRlci5jcHAKaW5kZXggY2ViZmU4YjFiZThhYTEwOTk4ZTdk YTE0MWYxMDhhMTg0MmNmOWI1MS4uODNhZDZjOTdmMTM0NmFiNTE5NTc5MTg1ZDBhNTU2NWRlZTYy NTIxZiAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2xsaW50L0xvd0xldmVsSW50 ZXJwcmV0ZXIuY3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9sbGludC9Mb3dMZXZlbElu dGVycHJldGVyLmNwcApAQCAtNTQ4LDYgKzU0OCw3IEBAIEpTVmFsdWUgQ0xvb3A6OmV4ZWN1dGUo T3Bjb2RlSUQgZW50cnlPcGNvZGVJRCwgdm9pZCogZXhlY3V0YWJsZUFkZHJlc3MsIFZNKiB2bSwK IAogI2RlZmluZSBPRkZMSU5FX0FTTV9PUENPREVfTEFCRUwoX19vcGNvZGUpIFwKICAgICBFTUJF RF9PUENPREVfSURfSUZfTkVFREVEKF9fb3Bjb2RlKSBcCisgICAgT0ZGTElORV9BU01fT1BDT0RF X0RFQlVHX0xBQkVMKGxsaW50XyMjX19vcGNvZGUpIFwKICAgICBPRkZMSU5FX0FTTV9MT0NBTF9M QUJFTChsbGludF8jI19fb3Bjb2RlKQogCiAjZGVmaW5lIE9GRkxJTkVfQVNNX0dMVUVfTEFCRUwo X19vcGNvZGUpICAgT0ZGTElORV9BU01fTE9DQUxfTEFCRUwoX19vcGNvZGUpCkBAIC01NzgsNiAr NTc5LDEyIEBAIEpTVmFsdWUgQ0xvb3A6OmV4ZWN1dGUoT3Bjb2RlSUQgZW50cnlPcGNvZGVJRCwg dm9pZCogZXhlY3V0YWJsZUFkZHJlc3MsIFZNKiB2bSwKIAogI2RlZmluZSBPRkZMSU5FX0FTTV9M T0NBTF9MQUJFTChsYWJlbCkgICBMT0NBTF9MQUJFTF9TVFJJTkcobGFiZWwpICI6XG4iCiAKKyNp ZiBPUyhMSU5VWCkKKyNkZWZpbmUgT0ZGTElORV9BU01fT1BDT0RFX0RFQlVHX0xBQkVMKGxhYmVs KSAgI2xhYmVsICI6XG4iCisjZWxzZQorI2RlZmluZSBPRkZMSU5FX0FTTV9PUENPREVfREVCVUdf TEFCRUwobGFiZWwpCisjZW5kaWYKKwogLy8gVGhpcyBpcyBhIGZpbGUgZ2VuZXJhdGVkIGJ5IG9m ZmxpbmVhc20sIHdoaWNoIGNvbnRhaW5zIGFsbCBvZiB0aGUgYXNzZW1ibHkgY29kZQogLy8gZm9y IHRoZSBpbnRlcnByZXRlciwgYXMgY29tcGlsZWQgZnJvbSBMb3dMZXZlbEludGVycHJldGVyLmFz bS4KICNpbmNsdWRlICJMTEludEFzc2VtYmx5LmgiCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNj cmlwdENvcmUvb2ZmbGluZWFzbS9hcm0ucmIgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvb2ZmbGlu ZWFzbS9hcm0ucmIKaW5kZXggYjBjMzM2MjdkMTA4NzIyNzllMDgxMWM0ZjRhN2VjYWQ0MWU1ZmM2 Ny4uZDc4YjgyZWVmODFmZTNjNjE5MzBmMGY0Y2ZmNmUwYTZkMzg2YjRjZCAxMDA2NDQKLS0tIGEv U291cmNlL0phdmFTY3JpcHRDb3JlL29mZmxpbmVhc20vYXJtLnJiCisrKyBiL1NvdXJjZS9KYXZh U2NyaXB0Q29yZS9vZmZsaW5lYXNtL2FybS5yYgpAQCAtNjgzLDggKzY4Myw4IEBAIGNsYXNzIElu c3RydWN0aW9uCiAgICAgICAgICAgICB0ZW1wID0gb3BlcmFuZHNbMl0KIAogICAgICAgICAgICAg dWlkID0gJGFzbS5uZXdVSUQKLSAgICAgICAgICAgIGdvdExhYmVsID0gIkxfb2ZmbGluZWFzbV9h cm1fZ290XyN7dWlkfSIKLSAgICAgICAgICAgIG9mZnNldExhYmVsID0gIkxfb2ZmbGluZWFzbV9h cm1fZ290X29mZnNldF8je3VpZH0iCisgICAgICAgICAgICBnb3RMYWJlbCA9IEFzc2VtYmxlci5s b2NhbExhYmVsUmVmZXJlbmNlKCJvZmZsaW5lYXNtX2FybV9nb3RfI3t1aWR9IikKKyAgICAgICAg ICAgIG9mZnNldExhYmVsID0gQXNzZW1ibGVyLmxvY2FsTGFiZWxSZWZlcmVuY2UoIm9mZmxpbmVh c21fYXJtX2dvdF9vZmZzZXRfI3t1aWR9IikKIAogICAgICAgICAgICAgJGFzbS5wdXRzICJsZHIg I3tkZXN0LmFybU9wZXJhbmR9LCAje2dvdExhYmVsfSIKICAgICAgICAgICAgICRhc20ucHV0cyAi bGRyICN7dGVtcC5hcm1PcGVyYW5kfSwgI3tnb3RMYWJlbH0rNCIK