192645 2018-12-12 16:14:44 -0800 Web Inspector: experimental settings reload button disappears after changing more than one setting 2018-12-13 14:31:34 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 hi hi commit-queue hi inspector-bugzilla-changes joepeck webkit-bug-importer oldest_to_newest 1487391 0 hi 2018-12-12 16:14:44 -0800 # STEPS TO REPRODUCE: 1. open WebInspector 2. go to the Experimental Settings view 3. change any option to make the "Reload Web Inspector" button appear (e.g. "Enable Layers tab") 4. change a different option that would have caused the "Reload Web Inspector" button to appear (e.g. "Enable Audit tab") 5. change the first option from #3 back to its initial state => "Reload Web Inspector" button disappears 1487392 1 hi 2018-12-12 16:15:00 -0800 <rdar://problem/46626204> 1487394 2 357188 hi 2018-12-12 16:15:42 -0800 Created attachment 357188 Patch 1487397 3 357188 joepeck 2018-12-12 16:25:00 -0800 Comment on attachment 357188 Patch r=me 1487718 4 357188 commit-queue 2018-12-13 14:31:32 -0800 Comment on attachment 357188 Patch Clearing flags on attachment: 357188 Committed r239179: <https://trac.webkit.org/changeset/239179> 1487719 5 commit-queue 2018-12-13 14:31:34 -0800 All reviewed patches have been landed. Closing bug. 357188 2018-12-12 16:15:42 -0800 2018-12-13 14:31:32 -0800 Patch bug-192645-20181212161541.patch text/plain 4167 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDE4M2U3ZmY4MzJkNTMzNmQ1MjMzYjI0OTBhNzMy ODc1Y2Y1NTdlNzEuLjRmNWY0MzliOWQwOWMzYzU3ODA1MjgyMGFmYmExNzMzMDMzODEwMjEgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE4LTEyLTEyICBEZXZp biBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBl eHBlcmltZW50YWwgc2V0dGluZ3MgcmVsb2FkIGJ1dHRvbiBkaXNhcHBlYXJzIGFmdGVyIGNoYW5n aW5nIG1vcmUgdGhhbiBvbmUgc2V0dGluZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTkyNjQ1CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS80NjYyNjIw ND4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVz ZXJJbnRlcmZhY2UvVmlld3MvU2V0dGluZ3NUYWJDb250ZW50Vmlldy5qczoKKyAgICAgICAgKFdJ LlNldHRpbmdzVGFiQ29udGVudFZpZXcucHJvdG90eXBlLl9jcmVhdGVFeHBlcmltZW50YWxTZXR0 aW5nc1ZpZXcubGlzdGVuRm9yQ2hhbmdlKToKKyAgICAgICAgKFdJLlNldHRpbmdzVGFiQ29udGVu dFZpZXcucHJvdG90eXBlLl9jcmVhdGVFeHBlcmltZW50YWxTZXR0aW5nc1ZpZXcpOgorCiAyMDE4 LTEyLTEwICBNYXR0IEJha2VyICA8bWF0dGJha2VyQGFwcGxlLmNvbT4KIAogICAgICAgICBXZWIg SW5zcGVjdG9yOiBSRUdSRVNTSU9OIChyMjM4NTk5KTogdW5hYmxlIHRvIHNlbGVjdCBzcGVjaWZp YyB0aW1lbGluZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZh Y2UvVmlld3MvU2V0dGluZ3NUYWJDb250ZW50Vmlldy5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JV SS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1NldHRpbmdzVGFiQ29udGVudFZpZXcuanMKaW5kZXggOGE3 NDAyMTZhYjM4ZDA0NzdmNTJkNzg4ZmEzNWVhZmI5ZDIzYTRjNi4uZTRkNTZmMmZjN2Q4NzU2Y2Nm MTUwZDczOTdmZDQxMTE3YTVhODMzMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJ L1VzZXJJbnRlcmZhY2UvVmlld3MvU2V0dGluZ3NUYWJDb250ZW50Vmlldy5qcworKysgYi9Tb3Vy Y2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9TZXR0aW5nc1RhYkNvbnRlbnRW aWV3LmpzCkBAIC0yNDIsMTkgKzI0MiwxOSBAQCBXSS5TZXR0aW5nc1RhYkNvbnRlbnRWaWV3ID0g Y2xhc3MgU2V0dGluZ3NUYWJDb250ZW50VmlldyBleHRlbmRzIFdJLlRhYkNvbnRlbnRWaQogCiAg ICAgICAgIGxldCBleHBlcmltZW50YWxTZXR0aW5nc1ZpZXcgPSBuZXcgV0kuU2V0dGluZ3NWaWV3 KCJleHBlcmltZW50YWwiLCBXSS5VSVN0cmluZygiRXhwZXJpbWVudGFsIikpOwogCisgICAgICAg IGxldCBpbml0aWFsVmFsdWVzID0gbmV3IE1hcDsKKwogICAgICAgICBpZiAod2luZG93LkNTU0Fn ZW50KSB7CiAgICAgICAgICAgICBsZXQgZ3JvdXAgPSBleHBlcmltZW50YWxTZXR0aW5nc1ZpZXcu YWRkR3JvdXAoV0kuVUlTdHJpbmcoIlN0eWxlcyBTaWRlYmFyOiIpKTsKICAgICAgICAgICAgIGdy b3VwLmFkZFNldHRpbmcoV0kuc2V0dGluZ3MuZXhwZXJpbWVudGFsRW5hYmxlQ29tcHV0ZWRTdHls ZUNhc2NhZGVzLCBXSS5VSVN0cmluZygiRW5hYmxlIENvbXB1dGVkIFN0eWxlIENhc2NhZGVzIikp OwogICAgICAgICAgICAgZXhwZXJpbWVudGFsU2V0dGluZ3NWaWV3LmFkZFNlcGFyYXRvcigpOwog ICAgICAgICB9CiAKLSAgICAgICAgbGV0IGxheWVyVGFiRW5hYmxlZCA9IHdpbmRvdy5MYXllclRy ZWVBZ2VudCAmJiBXSS5zZXR0aW5ncy5leHBlcmltZW50YWxFbmFibGVMYXllcnNUYWIudmFsdWU7 CiAgICAgICAgIGlmICh3aW5kb3cuTGF5ZXJUcmVlQWdlbnQpIHsKICAgICAgICAgICAgIGV4cGVy aW1lbnRhbFNldHRpbmdzVmlldy5hZGRTZXR0aW5nKFdJLlVJU3RyaW5nKCJMYXllcnM6IiksIFdJ LnNldHRpbmdzLmV4cGVyaW1lbnRhbEVuYWJsZUxheWVyc1RhYiwgV0kuVUlTdHJpbmcoIkVuYWJs ZSBMYXllcnMgVGFiIikpOwogICAgICAgICAgICAgZXhwZXJpbWVudGFsU2V0dGluZ3NWaWV3LmFk ZFNlcGFyYXRvcigpOwogICAgICAgICB9CiAKLSAgICAgICAgbGV0IGF1ZGl0VGFiRW5hYmxlZCA9 IFdJLnNldHRpbmdzLmV4cGVyaW1lbnRhbEVuYWJsZUF1ZGl0VGFiLnZhbHVlOwogICAgICAgICBl eHBlcmltZW50YWxTZXR0aW5nc1ZpZXcuYWRkU2V0dGluZyhXSS5VSVN0cmluZygiQXVkaXQ6Iiks IFdJLnNldHRpbmdzLmV4cGVyaW1lbnRhbEVuYWJsZUF1ZGl0VGFiLCBXSS5VSVN0cmluZygiRW5h YmxlIEF1ZGl0IFRhYiIpKTsKICAgICAgICAgZXhwZXJpbWVudGFsU2V0dGluZ3NWaWV3LmFkZFNl cGFyYXRvcigpOwogCkBAIC0yNjYsOSArMjY2LDkgQEAgV0kuU2V0dGluZ3NUYWJDb250ZW50Vmll dyA9IGNsYXNzIFNldHRpbmdzVGFiQ29udGVudFZpZXcgZXh0ZW5kcyBXSS5UYWJDb250ZW50VmkK ICAgICAgICAgcmVsb2FkSW5zcGVjdG9yQnV0dG9uLmFkZEV2ZW50TGlzdGVuZXIoImNsaWNrIiwg KGV2ZW50KSA9PiB7CiAgICAgICAgICAgICAvLyBGb3JjZSBhIGNvcHkgc28gdGhhdCBXSS5TZXR0 aW5nIHNlZXMgaXQgYXMgYSBuZXcgdmFsdWUuCiAgICAgICAgICAgICBsZXQgbmV3VGFicyA9IFdJ Ll9vcGVuVGFic1NldHRpbmcudmFsdWUuc2xpY2UoKTsKLSAgICAgICAgICAgIGlmICghbGF5ZXJU YWJFbmFibGVkICYmIHdpbmRvdy5MYXllclRyZWVBZ2VudCAmJiBXSS5zZXR0aW5ncy5leHBlcmlt ZW50YWxFbmFibGVMYXllcnNUYWIudmFsdWUpCisgICAgICAgICAgICBpZiAoIWluaXRpYWxWYWx1 ZXMuZ2V0KFdJLnNldHRpbmdzLmV4cGVyaW1lbnRhbEVuYWJsZUxheWVyc1RhYikgJiYgd2luZG93 LkxheWVyVHJlZUFnZW50ICYmIFdJLnNldHRpbmdzLmV4cGVyaW1lbnRhbEVuYWJsZUxheWVyc1Rh Yi52YWx1ZSkKICAgICAgICAgICAgICAgICBuZXdUYWJzLnB1c2goV0kuTGF5ZXJzVGFiQ29udGVu dFZpZXcuVHlwZSk7Ci0gICAgICAgICAgICBpZiAoIWF1ZGl0VGFiRW5hYmxlZCAmJiBXSS5zZXR0 aW5ncy5leHBlcmltZW50YWxFbmFibGVBdWRpdFRhYi52YWx1ZSkKKyAgICAgICAgICAgIGlmICgh aW5pdGlhbFZhbHVlcy5nZXQoV0kuc2V0dGluZ3MuZXhwZXJpbWVudGFsRW5hYmxlQXVkaXRUYWIp ICYmIFdJLnNldHRpbmdzLmV4cGVyaW1lbnRhbEVuYWJsZUF1ZGl0VGFiLnZhbHVlKQogICAgICAg ICAgICAgICAgIG5ld1RhYnMucHVzaChXSS5BdWRpdFRhYkNvbnRlbnRWaWV3LlR5cGUpOwogICAg ICAgICAgICAgV0kuX29wZW5UYWJzU2V0dGluZy52YWx1ZSA9IG5ld1RhYnM7CiAKQEAgLTI3OSw5 ICsyNzksOSBAQCBXSS5TZXR0aW5nc1RhYkNvbnRlbnRWaWV3ID0gY2xhc3MgU2V0dGluZ3NUYWJD b250ZW50VmlldyBleHRlbmRzIFdJLlRhYkNvbnRlbnRWaQogICAgICAgICByZWxvYWRJbnNwZWN0 b3JDb250YWluZXJFbGVtZW50LmNsYXNzTGlzdC5hZGQoImhpZGRlbiIpOwogCiAgICAgICAgIGZ1 bmN0aW9uIGxpc3RlbkZvckNoYW5nZShzZXR0aW5nKSB7Ci0gICAgICAgICAgICBsZXQgaW5pdGlh bFZhbHVlID0gc2V0dGluZy52YWx1ZTsKKyAgICAgICAgICAgIGluaXRpYWxWYWx1ZXMuc2V0KHNl dHRpbmcsIHNldHRpbmcudmFsdWUpOwogICAgICAgICAgICAgc2V0dGluZy5hZGRFdmVudExpc3Rl bmVyKFdJLlNldHRpbmcuRXZlbnQuQ2hhbmdlZCwgKCkgPT4gewotICAgICAgICAgICAgICAgIHJl bG9hZEluc3BlY3RvckNvbnRhaW5lckVsZW1lbnQuY2xhc3NMaXN0LnRvZ2dsZSgiaGlkZGVuIiwg aW5pdGlhbFZhbHVlID09PSBzZXR0aW5nLnZhbHVlKTsKKyAgICAgICAgICAgICAgICByZWxvYWRJ bnNwZWN0b3JDb250YWluZXJFbGVtZW50LmNsYXNzTGlzdC50b2dnbGUoImhpZGRlbiIsIEFycmF5 LmZyb20oaW5pdGlhbFZhbHVlcykuZXZlcnkoKFtzZXR0aW5nLCBpbml0aWFsVmFsdWVdKSA9PiBz ZXR0aW5nLnZhbHVlID09PSBpbml0aWFsVmFsdWUpKTsKICAgICAgICAgICAgIH0pOwogICAgICAg ICB9CiAK