<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>192634</bug_id>
          
          <creation_ts>2018-12-12 11:24:23 -0800</creation_ts>
          <short_desc>Make DocumentMarker::allMarkers() constexpr</short_desc>
          <delta_ts>2018-12-17 13:49:24 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebCore Misc.</component>
          <version>WebKit Local Build</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Daniel Bates">dbates</reporter>
          <assigned_to name="Daniel Bates">dbates</assigned_to>
          <cc>cdumez</cc>
    
    <cc>esprehn+autocc</cc>
    
    <cc>ews-watchlist</cc>
    
    <cc>kangil.han</cc>
    
    <cc>simon.fraser</cc>
    
    <cc>webkit-bug-importer</cc>
    
    <cc>wenson_hsieh</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1487289</commentid>
    <comment_count>0</comment_count>
    <who name="Daniel Bates">dbates</who>
    <bug_when>2018-12-12 11:24:23 -0800</bug_when>
    <thetext>We should annotate DocumentMarker::allMarkers() with constexpr since its result can be computed at compile-time.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1487290</commentid>
    <comment_count>1</comment_count>
      <attachid>357153</attachid>
    <who name="Daniel Bates">dbates</who>
    <bug_when>2018-12-12 11:26:01 -0800</bug_when>
    <thetext>Created attachment 357153
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1488476</commentid>
    <comment_count>2</comment_count>
      <attachid>357449</attachid>
    <who name="Daniel Bates">dbates</who>
    <bug_when>2018-12-17 10:46:36 -0800</bug_when>
    <thetext>Created attachment 357449
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1488579</commentid>
    <comment_count>3</comment_count>
      <attachid>357449</attachid>
    <who name="Daniel Bates">dbates</who>
    <bug_when>2018-12-17 13:48:04 -0800</bug_when>
    <thetext>Comment on attachment 357449
Patch

Clearing flags on attachment: 357449

Committed r239289: &lt;https://trac.webkit.org/changeset/239289&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1488580</commentid>
    <comment_count>4</comment_count>
    <who name="Daniel Bates">dbates</who>
    <bug_when>2018-12-17 13:48:06 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1488582</commentid>
    <comment_count>5</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2018-12-17 13:49:24 -0800</bug_when>
    <thetext>&lt;rdar://problem/46788754&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>357153</attachid>
            <date>2018-12-12 11:26:01 -0800</date>
            <delta_ts>2018-12-17 10:46:35 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-192634-20181212112600.patch</filename>
            <type>text/plain</type>
            <size>1695</size>
            <attacher name="Daniel Bates">dbates</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjM5MTE0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTlhNDgxOTZiODUwMjA4
YWNkMTg3OWI5MjNiM2NjYzEzMjcyOWE1MC4uOTRkNDI4ZWUxZWM5ZmEyZjMwMjZjOGJmNGQ4N2M4
N2FmYjMzYmRmMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE4LTEyLTEyICBEYW5p
ZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4KKworICAgICAgICBNYWtlIERvY3VtZW50TWFy
a2VyOjphbGxNYXJrZXJzKCkgY29uc3RleHByCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu
b3JnL3Nob3dfYnVnLmNnaT9pZD0xOTI2MzQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg
KE9PUFMhKS4KKworICAgICAgICBUaGUgcmVzdWx0IG9mIERvY3VtZW50TWFya2VyOjphbGxNYXJr
ZXJzKCkgY2FuIGJlIGNvbXB1dGVkIGF0IGNvbXBpbGUgdGltZS4gV2Ugc2hvdWxkIGFubm90YXRl
CisgICAgICAgIGl0IGNvbnN0ZXhwciB0byBkbyBqdXN0IHRoYXQuCisKKyAgICAgICAgKiBkb20v
RG9jdW1lbnRNYXJrZXIuaDoKKyAgICAgICAgKFdlYkNvcmU6OkRvY3VtZW50TWFya2VyOjphbGxN
YXJrZXJzKToKKwogMjAxOC0xMi0xMiAgRGFuaWVsIEJhdGVzICA8ZGFiYXRlc0BhcHBsZS5jb20+
CiAKICAgICAgICAgW2lPU10gUmVtb3ZlIC1bV2ViRXZlbnQgaW5pdFdpdGhLZXlFdmVudFR5cGU6
Li4uOmNoYXJhY3RlclNldDpdCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1l
bnRNYXJrZXIuaCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudE1hcmtlci5oCmluZGV4IDk5
NGMzOWMwM2Q2ZWU4YTRmOWMwOTQyMjEyYmZjZTVjZjExOTUwOTEuLjg0MWFhMmZjNDEwZDlhMGFk
NzNiMGM5ZmY0MWUzNDQwMjFiNzY2NGYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2RvbS9E
b2N1bWVudE1hcmtlci5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudE1hcmtlci5o
CkBAIC04Miw3ICs4Miw3IEBAIHB1YmxpYzoKICAgICAgICAgRHJhZ2dlZENvbnRlbnQgPSAxIDw8
IDE0CiAgICAgfTsKIAotICAgIHN0YXRpYyBPcHRpb25TZXQ8TWFya2VyVHlwZT4gYWxsTWFya2Vy
cygpOworICAgIGNvbnN0ZXhwciBzdGF0aWMgT3B0aW9uU2V0PE1hcmtlclR5cGU+IGFsbE1hcmtl
cnMoKTsKIAogICAgIHVzaW5nIElzQWN0aXZlTWF0Y2hEYXRhID0gYm9vbDsKICAgICB1c2luZyBE
ZXNjcmlwdGlvbkRhdGEgPSBTdHJpbmc7CkBAIC0xNDEsOSArMTQxLDkgQEAgcHJpdmF0ZToKICAg
ICBEYXRhIG1fZGF0YTsKIH07CiAKLWlubGluZSBhdXRvIERvY3VtZW50TWFya2VyOjphbGxNYXJr
ZXJzKCkgLT4gT3B0aW9uU2V0PE1hcmtlclR5cGU+Citjb25zdGV4cHIgYXV0byBEb2N1bWVudE1h
cmtlcjo6YWxsTWFya2VycygpIC0+IE9wdGlvblNldDxNYXJrZXJUeXBlPgogewotICAgIE9wdGlv
blNldDxNYXJrZXJUeXBlPiBtYXJrZXJzIHsKKyAgICBjb25zdGV4cHIgT3B0aW9uU2V0PE1hcmtl
clR5cGU+IG1hcmtlcnMgewogICAgICAgICBBY2NlcHRlZENhbmRpZGF0ZSwKICAgICAgICAgQXV0
b2NvcnJlY3RlZCwKICAgICAgICAgQ29ycmVjdGlvbkluZGljYXRvciwK
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>357449</attachid>
            <date>2018-12-17 10:46:36 -0800</date>
            <delta_ts>2018-12-17 13:48:04 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-192634-20181217104636.patch</filename>
            <type>text/plain</type>
            <size>1917</size>
            <attacher name="Daniel Bates">dbates</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjM5MjcwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMGQyMzkzNTRhMzA2NWVi
NmRlYmY5MmZjMWI5NDNhZTFiMGRiY2FkZS4uOWI2MjVmYzNjMzgwZGYxOGUxZDlkYmJhMDE4ZjI4
MTAwZDgzNjU5OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE4LTEyLTEyICBEYW5p
ZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4KKworICAgICAgICBNYWtlIERvY3VtZW50TWFy
a2VyOjphbGxNYXJrZXJzKCkgY29uc3RleHByCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu
b3JnL3Nob3dfYnVnLmNnaT9pZD0xOTI2MzQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg
KE9PUFMhKS4KKworICAgICAgICBUaGUgcmVzdWx0IG9mIERvY3VtZW50TWFya2VyOjphbGxNYXJr
ZXJzKCkgY2FuIGJlIGNvbXB1dGVkIGF0IGNvbXBpbGUgdGltZS4gV2Ugc2hvdWxkIGFubm90YXRl
CisgICAgICAgIGl0IGNvbnN0ZXhwciB0byBkbyBqdXN0IHRoYXQuCisKKyAgICAgICAgKiBkb20v
RG9jdW1lbnRNYXJrZXIuaDoKKyAgICAgICAgKFdlYkNvcmU6OkRvY3VtZW50TWFya2VyOjphbGxN
YXJrZXJzKToKKwogMjAxOC0xMi0xMiAgRGFuaWVsIEJhdGVzICA8ZGFiYXRlc0BhcHBsZS5jb20+
CiAKICAgICAgICAgW2lPU10gUmVtb3ZlIC1bV2ViRXZlbnQgaW5pdFdpdGhLZXlFdmVudFR5cGU6
Li4uOmNoYXJhY3RlclNldDpdCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1l
bnRNYXJrZXIuaCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudE1hcmtlci5oCmluZGV4IDk5
NGMzOWMwM2Q2ZWU4YTRmOWMwOTQyMjEyYmZjZTVjZjExOTUwOTEuLjQ5YjBhMTVjMWVmNjUyOWU2
OThhMzQxY2Q4OWFjOGM1NzYwMWFmZmMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2RvbS9E
b2N1bWVudE1hcmtlci5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudE1hcmtlci5o
CkBAIC04Miw3ICs4Miw3IEBAIHB1YmxpYzoKICAgICAgICAgRHJhZ2dlZENvbnRlbnQgPSAxIDw8
IDE0CiAgICAgfTsKIAotICAgIHN0YXRpYyBPcHRpb25TZXQ8TWFya2VyVHlwZT4gYWxsTWFya2Vy
cygpOworICAgIHN0YXRpYyBjb25zdGV4cHIgT3B0aW9uU2V0PE1hcmtlclR5cGU+IGFsbE1hcmtl
cnMoKTsKIAogICAgIHVzaW5nIElzQWN0aXZlTWF0Y2hEYXRhID0gYm9vbDsKICAgICB1c2luZyBE
ZXNjcmlwdGlvbkRhdGEgPSBTdHJpbmc7CkBAIC0xNDEsOSArMTQxLDkgQEAgcHJpdmF0ZToKICAg
ICBEYXRhIG1fZGF0YTsKIH07CiAKLWlubGluZSBhdXRvIERvY3VtZW50TWFya2VyOjphbGxNYXJr
ZXJzKCkgLT4gT3B0aW9uU2V0PE1hcmtlclR5cGU+Citjb25zdGV4cHIgYXV0byBEb2N1bWVudE1h
cmtlcjo6YWxsTWFya2VycygpIC0+IE9wdGlvblNldDxNYXJrZXJUeXBlPgogewotICAgIE9wdGlv
blNldDxNYXJrZXJUeXBlPiBtYXJrZXJzIHsKKyAgICByZXR1cm4gewogICAgICAgICBBY2NlcHRl
ZENhbmRpZGF0ZSwKICAgICAgICAgQXV0b2NvcnJlY3RlZCwKICAgICAgICAgQ29ycmVjdGlvbklu
ZGljYXRvciwKQEAgLTE2NCw3ICsxNjQsNiBAQCBpbmxpbmUgYXV0byBEb2N1bWVudE1hcmtlcjo6
YWxsTWFya2VycygpIC0+IE9wdGlvblNldDxNYXJrZXJUeXBlPgogICAgICAgICBEaWN0YXRpb25S
ZXN1bHQsCiAjZW5kaWYKICAgICB9OwotICAgIHJldHVybiBtYXJrZXJzOwogfQogCiBpbmxpbmUg
RG9jdW1lbnRNYXJrZXI6OkRvY3VtZW50TWFya2VyKHVuc2lnbmVkIHN0YXJ0T2Zmc2V0LCB1bnNp
Z25lZCBlbmRPZmZzZXQsIGJvb2wgaXNBY3RpdmVNYXRjaCkK
</data>

          </attachment>
      

    </bug>

</bugzilla>