192609 2018-12-11 19:33:11 -0800 Web Inspector: Canvas: support recording TypedOMCSSImageValue 2019-04-23 13:33:20 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 190217 1 justin_michaud hi commit-queue ews-watchlist hi inspector-bugzilla-changes joepeck justin_michaud timothy webkit-bug-importer oldest_to_newest 1487103 0 justin_michaud 2018-12-11 19:33:11 -0800 There is a TODO in InspectorCanvas.cpp, to implement buildAction for TypedOMCSSImageValue. It is (as of the time of this bug) located on line 624. 1528755 1 367799 hi 2019-04-19 08:27:44 -0700 Created attachment 367799 Patch 1528814 2 367810 hi 2019-04-19 11:54:58 -0700 Created attachment 367810 Patch 1528840 3 justin_michaud 2019-04-19 13:33:56 -0700 Sweet 1529724 4 367810 commit-queue 2019-04-23 13:32:45 -0700 Comment on attachment 367810 Patch Clearing flags on attachment: 367810 Committed r244562: <https://trac.webkit.org/changeset/244562> 1529725 5 commit-queue 2019-04-23 13:32:46 -0700 All reviewed patches have been landed. Closing bug. 1529726 6 webkit-bug-importer 2019-04-23 13:33:20 -0700 <rdar://problem/50142011> 367799 2019-04-19 08:27:44 -0700 2019-04-19 11:54:58 -0700 Patch 192609.diff text/plain 3742 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAxNDI4NjYyMzUyYi4uYjYxMGVjZDdiMzMgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNSBAQAorMjAxOS0wNC0xOSAgRGV2aW4gUm91c3NvICA8ZHJvdXNzb0BhcHBsZS5jb20+ CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogQ2FudmFzOiBzdXBwb3J0IHJlY29yZGluZyBUeXBl ZE9NQ1NTSW1hZ2VWYWx1ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTkyNjA5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgKiBpbnNwZWN0b3IvSW5zcGVjdG9yQ2FudmFzLmg6CisgICAgICAgICogaW5zcGVj dG9yL0luc3BlY3RvckNhbnZhcy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpJbnNwZWN0b3JDYW52 YXM6OmluZGV4Rm9yRGF0YSk6CisgICAgICAgIChXZWJDb3JlOjpJbnNwZWN0b3JDYW52YXM6OmJ1 aWxkQWN0aW9uKToKKwogMjAxOS0wNC0xOCAgU2hhd24gUm9iZXJ0cyAgPHNyb2JlcnRzQGFwcGxl LmNvbT4KIAogICAgICAgICBVbnJldmlld2VkIG1hbnVhbCByb2xsb3V0IG9mIHIyNDQyNDggYW5k IHIyNDQ0MDkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JD YW52YXMuY3BwIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckNhbnZhcy5jcHAK aW5kZXggOTZmN2EyNDQ2OTkuLmExZmNhNDRiYjRhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9pbnNwZWN0b3IvSW5zcGVjdG9yQ2FudmFzLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNw ZWN0b3IvSW5zcGVjdG9yQ2FudmFzLmNwcApAQCAtNTcsNiArNTcsOSBAQAogI2luY2x1ZGUgIlJl Y29yZGluZ1N3aXp6bGVUeXBlcy5oIgogI2luY2x1ZGUgIlNWR1BhdGhVdGlsaXRpZXMuaCIKICNp bmNsdWRlICJTdHJpbmdBZGFwdG9ycy5oIgorI2lmIEVOQUJMRShDU1NfVFlQRURfT00pCisjaW5j bHVkZSAiVHlwZWRPTUNTU0ltYWdlVmFsdWUuaCIKKyNlbmRpZgogI2lmIEVOQUJMRShXRUJHTCkK ICNpbmNsdWRlICJXZWJHTFJlbmRlcmluZ0NvbnRleHQuaCIKICNlbmRpZgpAQCAtNDU0LDYgKzQ1 NywyMiBAQCBpbnQgSW5zcGVjdG9yQ2FudmFzOjppbmRleEZvckRhdGEoRHVwbGljYXRlRGF0YVZh cmlhbnQgZGF0YSkKICAgICAgICAgICAgICAgICBhcnJheS0+YWRkSXRlbShpbmRleEZvckRhdGEo c2NyaXB0Q2FsbFN0YWNrLT5hdChpKSkpOwogICAgICAgICAgICAgaXRlbSA9IFdURk1vdmUoYXJy YXkpOwogICAgICAgICB9LAorI2lmIEVOQUJMRShDU1NfVFlQRURfT00pCisgICAgICAgIFsmXSAo Y29uc3QgUmVmUHRyPFR5cGVkT01DU1NJbWFnZVZhbHVlPiYgY3NzSW1hZ2VWYWx1ZSkgeworICAg ICAgICAgICAgU3RyaW5nIGRhdGFVUkwgPSAiZGF0YTosIl9zOworCisgICAgICAgICAgICBpZiAo YXV0byogY2FjaGVkSW1hZ2UgPSBjc3NJbWFnZVZhbHVlLmltYWdlKCkpIHsKKyAgICAgICAgICAg ICAgICBhdXRvKiBpbWFnZSA9IGNhY2hlZEltYWdlLT5pbWFnZSgpOworICAgICAgICAgICAgICAg IGlmIChpbWFnZSAmJiBpbWFnZSAhPSAmSW1hZ2U6Om51bGxJbWFnZSgpKSB7CisgICAgICAgICAg ICAgICAgICAgIGF1dG8gaW1hZ2VCdWZmZXIgPSBJbWFnZUJ1ZmZlcjo6Y3JlYXRlKGltYWdlLT5z aXplKCksIFJlbmRlcmluZ01vZGU6OlVuYWNjZWxlcmF0ZWQpOworICAgICAgICAgICAgICAgICAg ICBpbWFnZUJ1ZmZlci0+Y29udGV4dCgpLmRyYXdJbWFnZSgqaW1hZ2UsIEZsb2F0UG9pbnQoMCwg MCkpOworICAgICAgICAgICAgICAgICAgICBkYXRhVVJMID0gaW1hZ2VCdWZmZXItPnRvRGF0YVVS TCgiaW1hZ2UvcG5nIik7CisgICAgICAgICAgICAgICAgfQorICAgICAgICAgICAgfQorCisgICAg ICAgICAgICBpbmRleCA9IGluZGV4Rm9yRGF0YShkYXRhVVJMKTsKKyAgICAgICAgfSwKKyNlbmRp ZgogICAgICAgICBbJl0gKGNvbnN0IFNjcmlwdENhbGxGcmFtZSYgc2NyaXB0Q2FsbEZyYW1lKSB7 CiAgICAgICAgICAgICBhdXRvIGFycmF5ID0gSlNPTjo6QXJyYXlPZjxkb3VibGU+OjpjcmVhdGUo KTsKICAgICAgICAgICAgIGFycmF5LT5hZGRJdGVtKGluZGV4Rm9yRGF0YShzY3JpcHRDYWxsRnJh bWUuZnVuY3Rpb25OYW1lKCkpKTsKQEAgLTY2NCw4ICs2ODMsNyBAQCBSZWY8SlNPTjo6QXJyYXlP ZjxKU09OOjpWYWx1ZT4+IEluc3BlY3RvckNhbnZhczo6YnVpbGRBY3Rpb24oY29uc3QgU3RyaW5n JiBuYW1lLAogICAgICAgICAgICAgWyZdIChjb25zdCBSZWZQdHI8SFRNTFZpZGVvRWxlbWVudD4m IHZhbHVlKSB7IGFkZFBhcmFtZXRlcihpbmRleEZvckRhdGEodmFsdWUpLCBSZWNvcmRpbmdTd2l6 emxlVHlwZXM6OkltYWdlKTsgfSwKICNlbmRpZgogI2lmIEVOQUJMRShDU1NfVFlQRURfT00pCi0g ICAgICAgICAgICAvLyBGSVhNRSBpbXBsZW1lbnQ6IDxodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTkyNjA5Pi4KLSAgICAgICAgICAgIFsmXSAoY29uc3QgUmVmUHRyPFR5 cGVkT01DU1NJbWFnZVZhbHVlPiYpIHsgfSwKKyAgICAgICAgICAgIFsmXSAoY29uc3QgUmVmUHRy PFR5cGVkT01DU1NJbWFnZVZhbHVlPiYgdmFsdWUpIHsgYWRkUGFyYW1ldGVyKGluZGV4Rm9yRGF0 YSh2YWx1ZSksIFJlY29yZGluZ1N3aXp6bGVUeXBlczo6SW1hZ2UpOyB9LAogI2VuZGlmCiAgICAg ICAgICAgICBbJl0gKGNvbnN0IFJlZlB0cjxJbWFnZUJpdG1hcD4mIHZhbHVlKSB7IGFkZFBhcmFt ZXRlcihpbmRleEZvckRhdGEodmFsdWUpLCBSZWNvcmRpbmdTd2l6emxlVHlwZXM6OkltYWdlQml0 bWFwKTsgfSwKICAgICAgICAgICAgIFsmXSAoY29uc3QgUmVmUHRyPEltYWdlRGF0YT4mIHZhbHVl KSB7IGFkZFBhcmFtZXRlcihpbmRleEZvckRhdGEodmFsdWUpLCBSZWNvcmRpbmdTd2l6emxlVHlw ZXM6OkltYWdlRGF0YSk7IH0sCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3Iv SW5zcGVjdG9yQ2FudmFzLmggYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yQ2Fu dmFzLmgKaW5kZXggMjZjODY3MTAzNDUuLjQ1YTQzZDQ3NDZkIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yQ2FudmFzLmgKKysrIGIvU291cmNlL1dlYkNvcmUv aW5zcGVjdG9yL0luc3BlY3RvckNhbnZhcy5oCkBAIC00Myw2ICs0Myw5IEBAIGNsYXNzIEhUTUxJ bWFnZUVsZW1lbnQ7CiBjbGFzcyBIVE1MVmlkZW9FbGVtZW50OwogY2xhc3MgSW1hZ2VCaXRtYXA7 CiBjbGFzcyBJbWFnZURhdGE7CisjaWYgRU5BQkxFKENTU19UWVBFRF9PTSkKK2NsYXNzIFR5cGVk T01DU1NJbWFnZVZhbHVlOworI2VuZGlmCiAKIHR5cGVkZWYgU3RyaW5nIEVycm9yU3RyaW5nOwog CkBAIC05NCw2ICs5Nyw5IEBAIHByaXZhdGU6CiAgICAgICAgIFJlZlB0cjxJbWFnZURhdGE+LAog ICAgICAgICBSZWZQdHI8SW1hZ2VCaXRtYXA+LAogICAgICAgICBSZWZQdHI8SW5zcGVjdG9yOjpT Y3JpcHRDYWxsU3RhY2s+LAorI2lmIEVOQUJMRShDU1NfVFlQRURfT00pCisgICAgICAgIFJlZlB0 cjxUeXBlZE9NQ1NTSW1hZ2VWYWx1ZT4sCisjZW5kaWYKICAgICAgICAgSW5zcGVjdG9yOjpTY3Jp cHRDYWxsRnJhbWUsCiAgICAgICAgIFN0cmluZwogICAgID47Cg== 367810 2019-04-19 11:54:58 -0700 2019-04-23 13:32:45 -0700 Patch 192609.diff text/plain 3743 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAxNDI4NjYyMzUyYi4uYjYxMGVjZDdiMzMgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNSBAQAorMjAxOS0wNC0xOSAgRGV2aW4gUm91c3NvICA8ZHJvdXNzb0BhcHBsZS5jb20+ CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogQ2FudmFzOiBzdXBwb3J0IHJlY29yZGluZyBUeXBl ZE9NQ1NTSW1hZ2VWYWx1ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTkyNjA5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgKiBpbnNwZWN0b3IvSW5zcGVjdG9yQ2FudmFzLmg6CisgICAgICAgICogaW5zcGVj dG9yL0luc3BlY3RvckNhbnZhcy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpJbnNwZWN0b3JDYW52 YXM6OmluZGV4Rm9yRGF0YSk6CisgICAgICAgIChXZWJDb3JlOjpJbnNwZWN0b3JDYW52YXM6OmJ1 aWxkQWN0aW9uKToKKwogMjAxOS0wNC0xOCAgU2hhd24gUm9iZXJ0cyAgPHNyb2JlcnRzQGFwcGxl LmNvbT4KIAogICAgICAgICBVbnJldmlld2VkIG1hbnVhbCByb2xsb3V0IG9mIHIyNDQyNDggYW5k IHIyNDQ0MDkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JD YW52YXMuY3BwIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckNhbnZhcy5jcHAK aW5kZXggOTZmN2EyNDQ2OTkuLmExZmNhNDRiYjRhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9pbnNwZWN0b3IvSW5zcGVjdG9yQ2FudmFzLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNw ZWN0b3IvSW5zcGVjdG9yQ2FudmFzLmNwcApAQCAtNTcsNiArNTcsOSBAQAogI2luY2x1ZGUgIlJl Y29yZGluZ1N3aXp6bGVUeXBlcy5oIgogI2luY2x1ZGUgIlNWR1BhdGhVdGlsaXRpZXMuaCIKICNp bmNsdWRlICJTdHJpbmdBZGFwdG9ycy5oIgorI2lmIEVOQUJMRShDU1NfVFlQRURfT00pCisjaW5j bHVkZSAiVHlwZWRPTUNTU0ltYWdlVmFsdWUuaCIKKyNlbmRpZgogI2lmIEVOQUJMRShXRUJHTCkK ICNpbmNsdWRlICJXZWJHTFJlbmRlcmluZ0NvbnRleHQuaCIKICNlbmRpZgpAQCAtNDU0LDYgKzQ1 NywyMiBAQCBpbnQgSW5zcGVjdG9yQ2FudmFzOjppbmRleEZvckRhdGEoRHVwbGljYXRlRGF0YVZh cmlhbnQgZGF0YSkKICAgICAgICAgICAgICAgICBhcnJheS0+YWRkSXRlbShpbmRleEZvckRhdGEo c2NyaXB0Q2FsbFN0YWNrLT5hdChpKSkpOwogICAgICAgICAgICAgaXRlbSA9IFdURk1vdmUoYXJy YXkpOwogICAgICAgICB9LAorI2lmIEVOQUJMRShDU1NfVFlQRURfT00pCisgICAgICAgIFsmXSAo Y29uc3QgUmVmUHRyPFR5cGVkT01DU1NJbWFnZVZhbHVlPiYgY3NzSW1hZ2VWYWx1ZSkgeworICAg ICAgICAgICAgU3RyaW5nIGRhdGFVUkwgPSAiZGF0YTosIl9zOworCisgICAgICAgICAgICBpZiAo YXV0byogY2FjaGVkSW1hZ2UgPSBjc3NJbWFnZVZhbHVlLT5pbWFnZSgpKSB7CisgICAgICAgICAg ICAgICAgYXV0byogaW1hZ2UgPSBjYWNoZWRJbWFnZS0+aW1hZ2UoKTsKKyAgICAgICAgICAgICAg ICBpZiAoaW1hZ2UgJiYgaW1hZ2UgIT0gJkltYWdlOjpudWxsSW1hZ2UoKSkgeworICAgICAgICAg ICAgICAgICAgICBhdXRvIGltYWdlQnVmZmVyID0gSW1hZ2VCdWZmZXI6OmNyZWF0ZShpbWFnZS0+ c2l6ZSgpLCBSZW5kZXJpbmdNb2RlOjpVbmFjY2VsZXJhdGVkKTsKKyAgICAgICAgICAgICAgICAg ICAgaW1hZ2VCdWZmZXItPmNvbnRleHQoKS5kcmF3SW1hZ2UoKmltYWdlLCBGbG9hdFBvaW50KDAs IDApKTsKKyAgICAgICAgICAgICAgICAgICAgZGF0YVVSTCA9IGltYWdlQnVmZmVyLT50b0RhdGFV UkwoImltYWdlL3BuZyIpOworICAgICAgICAgICAgICAgIH0KKyAgICAgICAgICAgIH0KKworICAg ICAgICAgICAgaW5kZXggPSBpbmRleEZvckRhdGEoZGF0YVVSTCk7CisgICAgICAgIH0sCisjZW5k aWYKICAgICAgICAgWyZdIChjb25zdCBTY3JpcHRDYWxsRnJhbWUmIHNjcmlwdENhbGxGcmFtZSkg ewogICAgICAgICAgICAgYXV0byBhcnJheSA9IEpTT046OkFycmF5T2Y8ZG91YmxlPjo6Y3JlYXRl KCk7CiAgICAgICAgICAgICBhcnJheS0+YWRkSXRlbShpbmRleEZvckRhdGEoc2NyaXB0Q2FsbEZy YW1lLmZ1bmN0aW9uTmFtZSgpKSk7CkBAIC02NjQsOCArNjgzLDcgQEAgUmVmPEpTT046OkFycmF5 T2Y8SlNPTjo6VmFsdWU+PiBJbnNwZWN0b3JDYW52YXM6OmJ1aWxkQWN0aW9uKGNvbnN0IFN0cmlu ZyYgbmFtZSwKICAgICAgICAgICAgIFsmXSAoY29uc3QgUmVmUHRyPEhUTUxWaWRlb0VsZW1lbnQ+ JiB2YWx1ZSkgeyBhZGRQYXJhbWV0ZXIoaW5kZXhGb3JEYXRhKHZhbHVlKSwgUmVjb3JkaW5nU3dp enpsZVR5cGVzOjpJbWFnZSk7IH0sCiAjZW5kaWYKICNpZiBFTkFCTEUoQ1NTX1RZUEVEX09NKQot ICAgICAgICAgICAgLy8gRklYTUUgaW1wbGVtZW50OiA8aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE5MjYwOT4uCi0gICAgICAgICAgICBbJl0gKGNvbnN0IFJlZlB0cjxU eXBlZE9NQ1NTSW1hZ2VWYWx1ZT4mKSB7IH0sCisgICAgICAgICAgICBbJl0gKGNvbnN0IFJlZlB0 cjxUeXBlZE9NQ1NTSW1hZ2VWYWx1ZT4mIHZhbHVlKSB7IGFkZFBhcmFtZXRlcihpbmRleEZvckRh dGEodmFsdWUpLCBSZWNvcmRpbmdTd2l6emxlVHlwZXM6OkltYWdlKTsgfSwKICNlbmRpZgogICAg ICAgICAgICAgWyZdIChjb25zdCBSZWZQdHI8SW1hZ2VCaXRtYXA+JiB2YWx1ZSkgeyBhZGRQYXJh bWV0ZXIoaW5kZXhGb3JEYXRhKHZhbHVlKSwgUmVjb3JkaW5nU3dpenpsZVR5cGVzOjpJbWFnZUJp dG1hcCk7IH0sCiAgICAgICAgICAgICBbJl0gKGNvbnN0IFJlZlB0cjxJbWFnZURhdGE+JiB2YWx1 ZSkgeyBhZGRQYXJhbWV0ZXIoaW5kZXhGb3JEYXRhKHZhbHVlKSwgUmVjb3JkaW5nU3dpenpsZVR5 cGVzOjpJbWFnZURhdGEpOyB9LApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9y L0luc3BlY3RvckNhbnZhcy5oIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckNh bnZhcy5oCmluZGV4IDI2Yzg2NzEwMzQ1Li40NWE0M2Q0NzQ2ZCAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckNhbnZhcy5oCisrKyBiL1NvdXJjZS9XZWJDb3Jl L2luc3BlY3Rvci9JbnNwZWN0b3JDYW52YXMuaApAQCAtNDMsNiArNDMsOSBAQCBjbGFzcyBIVE1M SW1hZ2VFbGVtZW50OwogY2xhc3MgSFRNTFZpZGVvRWxlbWVudDsKIGNsYXNzIEltYWdlQml0bWFw OwogY2xhc3MgSW1hZ2VEYXRhOworI2lmIEVOQUJMRShDU1NfVFlQRURfT00pCitjbGFzcyBUeXBl ZE9NQ1NTSW1hZ2VWYWx1ZTsKKyNlbmRpZgogCiB0eXBlZGVmIFN0cmluZyBFcnJvclN0cmluZzsK IApAQCAtOTQsNiArOTcsOSBAQCBwcml2YXRlOgogICAgICAgICBSZWZQdHI8SW1hZ2VEYXRhPiwK ICAgICAgICAgUmVmUHRyPEltYWdlQml0bWFwPiwKICAgICAgICAgUmVmUHRyPEluc3BlY3Rvcjo6 U2NyaXB0Q2FsbFN0YWNrPiwKKyNpZiBFTkFCTEUoQ1NTX1RZUEVEX09NKQorICAgICAgICBSZWZQ dHI8VHlwZWRPTUNTU0ltYWdlVmFsdWU+LAorI2VuZGlmCiAgICAgICAgIEluc3BlY3Rvcjo6U2Ny aXB0Q2FsbEZyYW1lLAogICAgICAgICBTdHJpbmcKICAgICA+Owo=