192600 2018-12-11 12:10:16 -0800 Globally namespaced objects shouldn't use framework-prefixed names 2018-12-11 16:18:23 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jer.noble jer.noble commit-queue eric.carlson webkit-bug-importer oldest_to_newest 1487001 0 jer.noble 2018-12-11 12:10:16 -0800 Globally namespaced objects shouldn't use framework-prefixed names 1487002 1 webkit-bug-importer 2018-12-11 12:12:23 -0800 <rdar://problem/46637086> 1487003 2 357068 jer.noble 2018-12-11 12:12:25 -0800 Created attachment 357068 Patch 1487004 3 webkit-bug-importer 2018-12-11 12:12:25 -0800 <rdar://problem/46637087> 1487062 4 357068 commit-queue 2018-12-11 16:18:21 -0800 Comment on attachment 357068 Patch Clearing flags on attachment: 357068 Committed r239091: <https://trac.webkit.org/changeset/239091> 1487063 5 commit-queue 2018-12-11 16:18:23 -0800 All reviewed patches have been landed. Closing bug. 357068 2018-12-11 12:12:25 -0800 2018-12-11 16:18:21 -0800 Patch bug-192600-20181211121224.patch text/plain 2722 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogMjM4OTA3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjg4MWVlNzAzZDM2ZWEx MTdjN2Q1YjI4NTcyMDUwMGY5N2I5NzQwOS4uMThkMjQxOGZkMmI4NjY4ZGM5ZGY0MzIxNzFhNzUz YjI3NDgxMTQ0YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE4LTEyLTExICBKZXIg Tm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgorCisgICAgICAgIEdsb2JhbGx5IG5hbWVzcGFj ZWQgb2JqZWN0cyBzaG91bGRuJ3QgdXNlIGZyYW1ld29yay1wcmVmaXhlZCBuYW1lcworICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTkyNjAwCisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmVuYW1lIENNU2FtcGxl QnVmZmVySXMuLi4gLT4gaXNDTVNhbXBsZUJ1ZmZlci4uLgorCisgICAgICAgICogcGxhdGZvcm0v Z3JhcGhpY3MvYXZmb3VuZGF0aW9uL29iamMvTWVkaWFTYW1wbGVBVkZPYmpDLm1tOgorICAgICAg ICAoV2ViQ29yZTo6aXNDTVNhbXBsZUJ1ZmZlclJhbmRvbUFjY2Vzcyk6CisgICAgICAgIChXZWJD b3JlOjppc0NNU2FtcGxlQnVmZmVyTm9uRGlzcGxheWluZyk6CisgICAgICAgIChXZWJDb3JlOjpN ZWRpYVNhbXBsZUFWRk9iakM6OmZsYWdzIGNvbnN0KToKKyAgICAgICAgKFdlYkNvcmU6OkNNU2Ft cGxlQnVmZmVySXNSYW5kb21BY2Nlc3MpOiBEZWxldGVkLgorICAgICAgICAoV2ViQ29yZTo6Q01T YW1wbGVCdWZmZXJJc05vbkRpc3BsYXlpbmcpOiBEZWxldGVkLgorCiAyMDE4LTExLTMwICBKZXIg Tm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgogCiAgICAgICAgIFdlYiBDb250ZW50IHByb2Nl c3MgbWFpbiB0aHJlYWQgYmxvY2tlZCBiZW5lYXRoIEltYWdlRGVjb2RlckFWRk9iakM6OnJlYWRT YW1wbGVzIGZvciBtYW55IHNlY29uZHMgb24gaW1ndXIuY29tCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9hdmZvdW5kYXRpb24vb2JqYy9NZWRpYVNhbXBsZUFW Rk9iakMubW0gYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9hdmZvdW5kYXRpb24v b2JqYy9NZWRpYVNhbXBsZUFWRk9iakMubW0KaW5kZXggNjdiYjRjNmRmZTMzMDQ5ZGJlMTkyMjhi NTBmN2NhODc2NzE0YzdlZS4uMGVmOTQzYzRkZDJiZjQzY2VhZjViYTVmZTMzNDViYTI4YzUyYjJl NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvYXZmb3VuZGF0 aW9uL29iamMvTWVkaWFTYW1wbGVBVkZPYmpDLm1tCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL2F2Zm91bmRhdGlvbi9vYmpjL01lZGlhU2FtcGxlQVZGT2JqQy5tbQpAQCAt MTE5LDcgKzExOSw3IEBAIHVpbnQzMl90IE1lZGlhU2FtcGxlQVZGT2JqQzo6dmlkZW9QaXhlbEZv cm1hdCgpIGNvbnN0CiAgICAgcmV0dXJuIENWUGl4ZWxCdWZmZXJHZXRQaXhlbEZvcm1hdFR5cGUo cGl4ZWxCdWZmZXIpOwogfQogCi1zdGF0aWMgYm9vbCBDTVNhbXBsZUJ1ZmZlcklzUmFuZG9tQWNj ZXNzKENNU2FtcGxlQnVmZmVyUmVmIHNhbXBsZSkKK3N0YXRpYyBib29sIGlzQ01TYW1wbGVCdWZm ZXJSYW5kb21BY2Nlc3MoQ01TYW1wbGVCdWZmZXJSZWYgc2FtcGxlKQogewogICAgIENGQXJyYXlS ZWYgYXR0YWNobWVudHMgPSBDTVNhbXBsZUJ1ZmZlckdldFNhbXBsZUF0dGFjaG1lbnRzQXJyYXko c2FtcGxlLCBmYWxzZSk7CiAgICAgaWYgKCFhdHRhY2htZW50cykKQEAgLTEzMyw3ICsxMzMsNyBA QCBzdGF0aWMgYm9vbCBDTVNhbXBsZUJ1ZmZlcklzUmFuZG9tQWNjZXNzKENNU2FtcGxlQnVmZmVy UmVmIHNhbXBsZSkKICAgICByZXR1cm4gdHJ1ZTsKIH0KIAotc3RhdGljIGJvb2wgQ01TYW1wbGVC dWZmZXJJc05vbkRpc3BsYXlpbmcoQ01TYW1wbGVCdWZmZXJSZWYgc2FtcGxlKQorc3RhdGljIGJv b2wgaXNDTVNhbXBsZUJ1ZmZlck5vbkRpc3BsYXlpbmcoQ01TYW1wbGVCdWZmZXJSZWYgc2FtcGxl KQogewogICAgIENGQXJyYXlSZWYgYXR0YWNobWVudHMgPSBDTVNhbXBsZUJ1ZmZlckdldFNhbXBs ZUF0dGFjaG1lbnRzQXJyYXkoc2FtcGxlLCBmYWxzZSk7CiAgICAgaWYgKCFhdHRhY2htZW50cykK QEAgLTE1MiwxMCArMTUyLDEwIEBAIE1lZGlhU2FtcGxlOjpTYW1wbGVGbGFncyBNZWRpYVNhbXBs ZUFWRk9iakM6OmZsYWdzKCkgY29uc3QKIHsKICAgICBpbnQgcmV0dXJuVmFsdWUgPSBNZWRpYVNh bXBsZTo6Tm9uZTsKICAgICAKLSAgICBpZiAoQ01TYW1wbGVCdWZmZXJJc1JhbmRvbUFjY2Vzcyht X3NhbXBsZS5nZXQoKSkpCisgICAgaWYgKGlzQ01TYW1wbGVCdWZmZXJSYW5kb21BY2Nlc3MobV9z YW1wbGUuZ2V0KCkpKQogICAgICAgICByZXR1cm5WYWx1ZSB8PSBNZWRpYVNhbXBsZTo6SXNTeW5j OwogCi0gICAgaWYgKENNU2FtcGxlQnVmZmVySXNOb25EaXNwbGF5aW5nKG1fc2FtcGxlLmdldCgp KSkKKyAgICBpZiAoaXNDTVNhbXBsZUJ1ZmZlck5vbkRpc3BsYXlpbmcobV9zYW1wbGUuZ2V0KCkp KQogICAgICAgICByZXR1cm5WYWx1ZSB8PSBNZWRpYVNhbXBsZTo6SXNOb25EaXNwbGF5aW5nOwog ICAgIAogICAgIHJldHVybiBTYW1wbGVGbGFncyhyZXR1cm5WYWx1ZSk7Cg==