<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>192581</bug_id>
          
          <creation_ts>2018-12-10 23:00:22 -0800</creation_ts>
          <short_desc>[Win][WebKitLegacy][Clang] WebKit.h warning: &apos;IWebEditingDelegate2::shouldInsertNode&apos; hides overloaded virtual function [-Woverloaded-virtual]</short_desc>
          <delta_ts>2019-09-10 23:08:44 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit API</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>171618</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Fujii Hironori">fujii</reporter>
          <assigned_to name="Fujii Hironori">fujii</assigned_to>
          <cc>achristensen</cc>
    
    <cc>annulen</cc>
    
    <cc>bfulgham</cc>
    
    <cc>don.olmstead</cc>
    
    <cc>ews-watchlist</cc>
    
    <cc>gyuyoung.kim</cc>
    
    <cc>pvollan</cc>
    
    <cc>rakuco</cc>
    
    <cc>ross.kirsling</cc>
    
    <cc>ryuan.choi</cc>
    
    <cc>sergio</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1486889</commentid>
    <comment_count>0</comment_count>
    <who name="Fujii Hironori">fujii</who>
    <bug_when>2018-12-10 23:00:22 -0800</bug_when>
    <thetext>[Win][WebKitLegacy][Clang] WebKit.h warning: &apos;IWebEditingDelegate2::shouldInsertNode&apos; hides overloaded virtual function [-Woverloaded-virtual]

clang-cl reports the following compilation warnings:

&gt; [5697/6307] Building CXX object Source\WebKitLegacy\CMakeFiles\WebKitLegacy.dir\win\WebKitPrefix.cpp.obj
&gt; In file included from &lt;built-in&gt;:1:
&gt; In file included from ..\..\Source\WebKitLegacy\win\WebKitPrefix.h:46:
&gt; DerivedSources\WebKitLegacy\Interfaces\WebKit.h(1571,99):  warning: suggest braces around initialization of subobject [-Wmissing-braces]
&gt; extern const GUID  __declspec(selectany) SID_AccessibleComparable = { 0x62b8cb5f, 0xfb7a, 0x4faf, 0x81, 0xe8, 0x52, 0xb6, 0x5f, 0x12, 0x8b, 0x31 };
&gt;                                                                                                   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
&gt;                                                                                                   {                                             }
&gt; DerivedSources\WebKitLegacy\Interfaces\WebKit.h(23610,43):  warning: &apos;IWebEditingDelegate2::shouldInsertNode&apos; hides overloaded virtual function [-Woverloaded-virtual]
&gt;         virtual HRESULT STDMETHODCALLTYPE shouldInsertNode( 
&gt;                                           ^
&gt; DerivedSources\WebKitLegacy\Interfaces\WebKit.h(23188,43):  note: hidden overloaded virtual function &apos;IWebEditingDelegate::shouldInsertNode&apos; declared here: different number of parameters (4 vs 5)
&gt;         virtual HRESULT STDMETHODCALLTYPE shouldInsertNode( 
&gt;                                           ^
&gt; DerivedSources\WebKitLegacy\Interfaces\WebKit.h(46015,43):  warning: &apos;IWebViewPrivate2::addUserScriptToGroup&apos; hides overloaded virtual function [-Woverloaded-virtual]
&gt;         virtual HRESULT STDMETHODCALLTYPE addUserScriptToGroup( 
&gt;                                           ^
&gt; DerivedSources\WebKitLegacy\Interfaces\WebKit.h(45046,43):  note: hidden overloaded virtual function &apos;IWebViewPrivate::addUserScriptToGroup&apos; declared here: different number of parameters (9 vs 10)
&gt;         virtual HRESULT STDMETHODCALLTYPE addUserScriptToGroup( 
&gt;                                           ^
&gt; DerivedSources\WebKitLegacy\Interfaces\WebKit.h(46027,43):  warning: &apos;IWebViewPrivate2::addUserStyleSheetToGroup&apos; hides overloaded virtual function [-Woverloaded-virtual]
&gt;         virtual HRESULT STDMETHODCALLTYPE addUserStyleSheetToGroup( 
&gt;                                           ^
&gt; DerivedSources\WebKitLegacy\Interfaces\WebKit.h(45057,43):  note: hidden overloaded virtual function &apos;IWebViewPrivate::addUserStyleSheetToGroup&apos; declared here: different number of parameters (8 vs 9)
&gt;         virtual HRESULT STDMETHODCALLTYPE addUserStyleSheetToGroup( 
&gt;                                           ^
&gt; 4 warnings generated.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1486895</commentid>
    <comment_count>1</comment_count>
      <attachid>357039</attachid>
    <who name="Fujii Hironori">fujii</who>
    <bug_when>2018-12-10 23:39:52 -0800</bug_when>
    <thetext>Created attachment 357039
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1487114</commentid>
    <comment_count>2</comment_count>
      <attachid>357039</attachid>
    <who name="Fujii Hironori">fujii</who>
    <bug_when>2018-12-11 21:19:42 -0800</bug_when>
    <thetext>Comment on attachment 357039
Patch

Clearing flags on attachment: 357039

Committed r239097: &lt;https://trac.webkit.org/changeset/239097&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1487115</commentid>
    <comment_count>3</comment_count>
    <who name="Fujii Hironori">fujii</who>
    <bug_when>2018-12-11 21:19:45 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1487116</commentid>
    <comment_count>4</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2018-12-11 21:20:29 -0800</bug_when>
    <thetext>&lt;rdar://problem/46651605&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1569800</commentid>
    <comment_count>5</comment_count>
    <who name="Fujii Hironori">fujii</who>
    <bug_when>2019-09-10 18:52:43 -0700</bug_when>
    <thetext>This isn&apos;t a right fix.
DumpRenderTree, MiniBrowser and TestWebKitAPI are still reporting the same warning.

&gt; [4768/5007] Building CXX object Tools\DumpRenderTree\CMakeFiles\DumpRenderTreeLib.dir\win\DRTDesktopNotificationPresenter.cpp.obj
&gt; In file included from ..\..\Tools\DumpRenderTree\win\DRTDesktopNotificationPresenter.cpp:33:
&gt; In file included from ..\..\Tools\DumpRenderTree\win/DRTDesktopNotificationPresenter.h:32:
&gt; WebKitLegacy\Headers\WebKitLegacy/WebKit.h(23600,43): warning: &apos;IWebEditingDelegate2::shouldInsertNode&apos; hides overloaded virtual function [-Woverloaded-virtual]
&gt;         virtual HRESULT STDMETHODCALLTYPE shouldInsertNode( 
&gt;                                           ^
&gt; WebKitLegacy\Headers\WebKitLegacy/WebKit.h(23178,43): note: hidden overloaded virtual function &apos;IWebEditingDelegate::shouldInsertNode&apos; declared here: different number of parameters (4 vs 5)
&gt;         virtual HRESULT STDMETHODCALLTYPE shouldInsertNode( 
&gt;                                           ^
&gt; WebKitLegacy\Headers\WebKitLegacy/WebKit.h(46133,43): warning: &apos;IWebViewPrivate2::addUserScriptToGroup&apos; hides overloaded virtual function [-Woverloaded-virtual]
&gt;         virtual HRESULT STDMETHODCALLTYPE addUserScriptToGroup( 
&gt;                                           ^
&gt; WebKitLegacy\Headers\WebKitLegacy/WebKit.h(45164,43): note: hidden overloaded virtual function &apos;IWebViewPrivate::addUserScriptToGroup&apos; declared here: different number of parameters (9 vs 10)
&gt;         virtual HRESULT STDMETHODCALLTYPE addUserScriptToGroup( 
&gt;                                           ^
&gt; WebKitLegacy\Headers\WebKitLegacy/WebKit.h(46145,43): warning: &apos;IWebViewPrivate2::addUserStyleSheetToGroup&apos; hides overloaded virtual function [-Woverloaded-virtual]
&gt;         virtual HRESULT STDMETHODCALLTYPE addUserStyleSheetToGroup( 
&gt;                                           ^
&gt; WebKitLegacy\Headers\WebKitLegacy/WebKit.h(45175,43): note: hidden overloaded virtual function &apos;IWebViewPrivate::addUserStyleSheetToGroup&apos; declared here: different number of parameters (8 vs 9)
&gt;         virtual HRESULT STDMETHODCALLTYPE addUserStyleSheetToGroup( 
&gt;                                           ^
&gt; 3 warnings generated.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1569801</commentid>
    <comment_count>6</comment_count>
    <who name="Fujii Hironori">fujii</who>
    <bug_when>2019-09-10 18:57:40 -0700</bug_when>
    <thetext>Committed r249750: &lt;https://trac.webkit.org/changeset/249750&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1569802</commentid>
    <comment_count>7</comment_count>
    <who name="Fujii Hironori">fujii</who>
    <bug_when>2019-09-10 18:58:28 -0700</bug_when>
    <thetext>Reverted.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1569809</commentid>
    <comment_count>8</comment_count>
      <attachid>378531</attachid>
    <who name="Fujii Hironori">fujii</who>
    <bug_when>2019-09-10 19:36:43 -0700</bug_when>
    <thetext>Created attachment 378531
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1569812</commentid>
    <comment_count>9</comment_count>
    <who name="Alex Christensen">achristensen</who>
    <bug_when>2019-09-10 19:52:44 -0700</bug_when>
    <thetext>We probably don&apos;t want to ignore that warning globally.  Can&apos;t we just #pragma clang our way around it for this one file?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1569816</commentid>
    <comment_count>10</comment_count>
      <attachid>378533</attachid>
    <who name="Fujii Hironori">fujii</who>
    <bug_when>2019-09-10 20:36:14 -0700</bug_when>
    <thetext>Created attachment 378533
Patch

How about this patch?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1569845</commentid>
    <comment_count>11</comment_count>
      <attachid>378533</attachid>
    <who name="Fujii Hironori">fujii</who>
    <bug_when>2019-09-10 23:08:40 -0700</bug_when>
    <thetext>Comment on attachment 378533
Patch

Clearing flags on attachment: 378533

Committed r249755: &lt;https://trac.webkit.org/changeset/249755&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1569846</commentid>
    <comment_count>12</comment_count>
    <who name="Fujii Hironori">fujii</who>
    <bug_when>2019-09-10 23:08:44 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>357039</attachid>
            <date>2018-12-10 23:39:52 -0800</date>
            <delta_ts>2019-09-10 19:36:34 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-192581-20181211163951.patch</filename>
            <type>text/plain</type>
            <size>1807</size>
            <attacher name="Fujii Hironori">fujii</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjM5MDYxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0TGVn
YWN5L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXRMZWdhY3kvQ2hhbmdlTG9nCmluZGV4IDgzZWFm
ZjMwYWJiYjZmZjg1MmVhMWY2NmM2ZDI2MGVkYzM5NjE2ZTAuLjRiYzFhY2FiOWRmOWQwMGQ5YTYy
MDlmY2JkOTRjY2I1NTA2MDcyNjYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXRMZWdhY3kvQ2hh
bmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXRMZWdhY3kvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAg
QEAKKzIwMTgtMTItMTAgIEZ1amlpIEhpcm9ub3JpICA8SGlyb25vcmkuRnVqaWlAc29ueS5jb20+
CisKKyAgICAgICAgW1dpbl1bV2ViS2l0TGVnYWN5XVtDbGFuZ10gV2ViS2l0Lmggd2FybmluZzog
J0lXZWJFZGl0aW5nRGVsZWdhdGUyOjpzaG91bGRJbnNlcnROb2RlJyBoaWRlcyBvdmVybG9hZGVk
IHZpcnR1YWwgZnVuY3Rpb24gWy1Xb3ZlcmxvYWRlZC12aXJ0dWFsXQorICAgICAgICBodHRwczov
L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTkyNTgxCisKKyAgICAgICAgUmV2aWV3
ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ29udmVudGlvbmFsbHksIFdlYktpdCBD
T00gaW50ZXJmYWNlIGFkZHMgYSBuZXcgaW50ZXJmYWNlIHdpdGgKKyAgICAgICAgc2FtZSBuYW1l
IG1ldGhvZHMgd2l0aCB0aGUgb2xkIGludGVyZmFjZS4gRm9yIGV4YW1wbGUsIGJvdGgKKyAgICAg
ICAgSVdlYkVkaXRpbmdEZWxlZ2F0ZSBhbmQgSVdlYkVkaXRpbmdEZWxlZ2F0ZTIgaW50ZXJmYWNl
cyBoYXMKKyAgICAgICAgc2hvdWxkSW5zZXJ0Tm9kZSBtZXRob2QuCisKKyAgICAgICAgVGhpcyBp
cyBhIHBhcnQgb2YgcHVibGljIEFQSSwgY2FuJ3QgYmUgcmVuYW1lZC4KKworICAgICAgICAqIFBs
YXRmb3JtV2luLmNtYWtlOiBBZGRlZCAtV25vLW92ZXJsb2FkZWQtdmlydHVhbCBjb21waWxlciBv
cHRpb24KKyAgICAgICAgZm9yIFdlYktpdExlZ2FjeQorCiAyMDE4LTEyLTA2ICBBbGV4IENocmlz
dGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmVtb3ZlIHVudXNl
ZCBMb2FkZXJTdHJhdGVneTo6c3RvcmVEZXJpdmVkRGF0YVRvQ2FjaGUgYW5kIGFzc29jaWF0ZWQg
ZGVhZCBjb2RlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0TGVnYWN5L1BsYXRmb3JtV2luLmNt
YWtlIGIvU291cmNlL1dlYktpdExlZ2FjeS9QbGF0Zm9ybVdpbi5jbWFrZQppbmRleCAwMmEwYjBm
ZWIwOGM2MTk4Yzc3NGUyNjdlYzEzY2VjMmEwMWVhYmRiLi5jOGRhYjM2OTY5MmZmZjEyMmM2ZjA3
NWRkYmYyYTY4MjQzZDg0NGY5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0TGVnYWN5L1BsYXRm
b3JtV2luLmNtYWtlCisrKyBiL1NvdXJjZS9XZWJLaXRMZWdhY3kvUGxhdGZvcm1XaW4uY21ha2UK
QEAgLTI3Nyw2ICsyNzcsMTAgQEAgaWYgKENNQUtFX1NJWkVPRl9WT0lEX1AgRVFVQUwgOCkKICAg
ICBlbmRpZiAoKQogZW5kaWYgKCkKIAoraWYgKENPTVBJTEVSX0lTX0dDQ19PUl9DTEFORykKKyAg
ICBXRUJLSVRfQUREX1RBUkdFVF9DWFhfRkxBR1MoV2ViS2l0TGVnYWN5IC1Xbm8tb3ZlcmxvYWRl
ZC12aXJ0dWFsKQorZW5kaWYgKCkKKwogbGlzdChBUFBFTkQgV2ViS2l0TGVnYWN5X1NPVVJDRVMg
JHtXZWJLaXRMZWdhY3lfSU5DTFVERVN9ICR7V2ViS2l0TGVnYWN5X1NPVVJDRVNfQ2xhc3Nlc30g
JHtXZWJLaXRMZWdhY3lfU09VUkNFU19XZWJDb3JlU3VwcG9ydH0pCiAKIHNvdXJjZV9ncm91cChJ
bmNsdWRlcyBGSUxFUyAke1dlYktpdExlZ2FjeV9JTkNMVURFU30pCg==
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>378531</attachid>
            <date>2019-09-10 19:36:43 -0700</date>
            <delta_ts>2019-09-10 20:36:06 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-192581-20190911113641.patch</filename>
            <type>text/plain</type>
            <size>1782</size>
            <attacher name="Fujii Hironori">fujii</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ5NzUwCmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvV2Vi
S2l0Q29tcGlsZXJGbGFncy5jbWFrZSBiL1NvdXJjZS9jbWFrZS9XZWJLaXRDb21waWxlckZsYWdz
LmNtYWtlCmluZGV4IGM1ZmE0YzNlYTU4ZTZjMWZmMTI1ZTE3NWFjYmRiMWQyNzdkMmFkMTkuLmJl
YzNiZDNiMGM5ZjA0NjM4Mjg5ZmNlOGFkZjIyZWYzNjQ4NTU5ZTggMTAwNjQ0Ci0tLSBhL1NvdXJj
ZS9jbWFrZS9XZWJLaXRDb21waWxlckZsYWdzLmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9XZWJL
aXRDb21waWxlckZsYWdzLmNtYWtlCkBAIC05OSw2ICs5OSw3IEBAIGlmIChDT01QSUxFUl9JU19H
Q0NfT1JfQ0xBTkcpCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAtV25vLW1hY3JvLXJlZGVmaW5lZAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgLVduby11bmtub3duLXByYWdtYXMKICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgIC1Xbm8tbm9ucG9ydGFibGUtaW5jbHVkZS1wYXRoCisgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAtV25vLW92ZXJsb2FkZWQt
dmlydHVhbAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgLVdu
by11bmtub3duLWFyZ3VtZW50KQogICAgIGVsc2UgKCkKICAgICAgICAgV0VCS0lUX0FQUEVORF9H
TE9CQUxfQ09NUElMRVJfRkxBR1MoLWZuby1leGNlcHRpb25zKQpkaWZmIC0tZ2l0IGEvQ2hhbmdl
TG9nIGIvQ2hhbmdlTG9nCmluZGV4IDY2ZjU0YTQyODVmZTkyZDUxZTYxYTY3NzgzYWU3ZGQ5Yjhm
ODgwZGEuLmM5MTQzY2ZmM2RhZTgxY2UxNTRlZjAzYzQxMmJiMWI0MGIzODgyM2MgMTAwNjQ0Ci0t
LSBhL0NoYW5nZUxvZworKysgYi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAxOS0wOS0x
MCAgRnVqaWkgSGlyb25vcmkgIDxIaXJvbm9yaS5GdWppaUBzb255LmNvbT4KKworICAgICAgICBb
V2luXVtXZWJLaXRMZWdhY3ldW0NsYW5nXSBXZWJLaXQuaCB3YXJuaW5nOiAnSVdlYkVkaXRpbmdE
ZWxlZ2F0ZTI6OnNob3VsZEluc2VydE5vZGUnIGhpZGVzIG92ZXJsb2FkZWQgdmlydHVhbCBmdW5j
dGlvbiBbLVdvdmVybG9hZGVkLXZpcnR1YWxdCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu
b3JnL3Nob3dfYnVnLmNnaT9pZD0xOTI1ODEKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzQ2NjUx
NjA1PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdl
YktpdExlZ2FjeSBDT00gaW50ZXJmYWNlcyBoYXZlIHNhbWUgbmFtZSBtZXRob2RzIHdpdGhpbiB0
aGUgb2xkCisgICAgICAgIGFuZCBuZXcgaW50ZXJmYWNlcy4gRm9yIGV4YW1wbGUsIGJvdGggSVdl
YkVkaXRpbmdEZWxlZ2F0ZSBhbmQKKyAgICAgICAgSVdlYkVkaXRpbmdEZWxlZ2F0ZTIgaW50ZXJm
YWNlcyBoYXZlICdzaG91bGRJbnNlcnROb2RlJyBtZXRob2QuCisgICAgICAgIFRoaXMgaXMgYSBw
YXJ0IG9mIHB1YmxpYyBBUEksIGNhbid0IGJlIHJlbmFtZWQuCisKKyAgICAgICAgKiBTb3VyY2Uv
Y21ha2UvV2ViS2l0Q29tcGlsZXJGbGFncy5jbWFrZTogQWRkZWQgLVduby1vdmVybG9hZGVkLXZp
cnR1YWwgY29tcGlsZXIgb3B0aW9uLgorCiAyMDE5LTA5LTA5ICBDYXJsb3MgR2FyY2lhIENhbXBv
cyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLiBCdW1wIEdUSyB2
ZXJzaW9uIG51bWJlcnMK
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>378533</attachid>
            <date>2019-09-10 20:36:14 -0700</date>
            <delta_ts>2019-09-10 23:08:40 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-192581-20190911123613.patch</filename>
            <type>text/plain</type>
            <size>3718</size>
            <attacher name="Fujii Hironori">fujii</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ5NzUwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0TGVn
YWN5L3dpbi9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0TGVnYWN5L3dpbi9DaGFuZ2VMb2cKaW5k
ZXggY2E3Y2MxODczMzI1MmE0Nzg4MzMyOGIwNDEwOGIwMGU5MTgzZGE4Ny4uNGJjNjdjZDFkZGQ2
MWQ0MGNkNzg5M2Q2YjlmZDRjZjEyODk4MDdhMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdExl
Z2FjeS93aW4vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXRMZWdhY3kvd2luL0NoYW5nZUxv
ZwpAQCAtMSwzICsxLDIwIEBACisyMDE5LTA5LTEwICBGdWppaSBIaXJvbm9yaSAgPEhpcm9ub3Jp
LkZ1amlpQHNvbnkuY29tPgorCisgICAgICAgIFtXaW5dW1dlYktpdExlZ2FjeV1bQ2xhbmddIFdl
YktpdC5oIHdhcm5pbmc6ICdJV2ViRWRpdGluZ0RlbGVnYXRlMjo6c2hvdWxkSW5zZXJ0Tm9kZScg
aGlkZXMgb3ZlcmxvYWRlZCB2aXJ0dWFsIGZ1bmN0aW9uIFstV292ZXJsb2FkZWQtdmlydHVhbF0K
KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5MjU4MQor
ICAgICAgICA8cmRhcjovL3Byb2JsZW0vNDY2NTE2MDU+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg
Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2ViS2l0TGVnYWN5IENPTSBpbnRlcmZhY2VzIGhh
dmUgc2FtZSBuYW1lIG1ldGhvZHMgd2l0aGluIHRoZSBvbGQKKyAgICAgICAgYW5kIG5ldyBpbnRl
cmZhY2VzLiBGb3IgZXhhbXBsZSwgYm90aCBJV2ViRWRpdGluZ0RlbGVnYXRlIGFuZAorICAgICAg
ICBJV2ViRWRpdGluZ0RlbGVnYXRlMiBpbnRlcmZhY2VzIGhhdmUgJ3Nob3VsZEluc2VydE5vZGUn
IG1ldGhvZC4KKyAgICAgICAgVGhpcyBpcyBhIHBhcnQgb2YgcHVibGljIEFQSSwgY2FuJ3QgYmUg
cmVuYW1lZC4KKworICAgICAgICAqIEludGVyZmFjZXMvSVdlYkVkaXRpbmdEZWxlZ2F0ZS5pZGw6
CisgICAgICAgICogSW50ZXJmYWNlcy9JV2ViVmlld1ByaXZhdGUuaWRsOgorICAgICAgICBBZGRl
ZCAjcHJhZ21hIHRvIGlnbm9yZSB0aGUgd2FybmluZy4KKwogMjAxOS0wOS0wOSAgRnVqaWkgSGly
b25vcmkgIDxIaXJvbm9yaS5GdWppaUBzb255LmNvbT4KIAogICAgICAgICBbV2luXVtXZWJLaXRM
ZWdhY3ldIFdlYktpdERMTC5oKDUzLDM3KTogd2FybmluZzogJ2dDbGFzc05hbWVDb3VudCcgaGFz
IEMtbGlua2FnZSBzcGVjaWZpZWQsIGJ1dCByZXR1cm5zIHVzZXItZGVmaW5lZCB0eXBlICdIYXNo
Q291bnRlZFNldDxXVEY6OlN0cmluZz4gJicgd2hpY2ggaXMgaW5jb21wYXRpYmxlIHdpdGggQyBb
LVdyZXR1cm4tdHlwZS1jLWxpbmthZ2VdCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0TGVnYWN5
L3dpbi9JbnRlcmZhY2VzL0lXZWJFZGl0aW5nRGVsZWdhdGUuaWRsIGIvU291cmNlL1dlYktpdExl
Z2FjeS93aW4vSW50ZXJmYWNlcy9JV2ViRWRpdGluZ0RlbGVnYXRlLmlkbAppbmRleCBiMjg2Nzk5
NTIyMGYxNjkwYTRjMjU3YmYxOWUzYzUzMzY4NTZiZDg2Li5lMzI2ODRiYzk4OGQ5MjBjZTRhNDM0
ODI5NzQ5M2MxZTI2NDllNzg4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0TGVnYWN5L3dpbi9J
bnRlcmZhY2VzL0lXZWJFZGl0aW5nRGVsZWdhdGUuaWRsCisrKyBiL1NvdXJjZS9XZWJLaXRMZWdh
Y3kvd2luL0ludGVyZmFjZXMvSVdlYkVkaXRpbmdEZWxlZ2F0ZS5pZGwKQEAgLTE4OSw2ICsxODks
MTEgQEAgaW50ZXJmYWNlIElXZWJFZGl0aW5nRGVsZWdhdGUgOiBJVW5rbm93bgogICAgIEhSRVNV
TFQgdXBkYXRlR3JhbW1hcigpOwogfQogCitjcHBfcXVvdGUoIiNpZiBkZWZpbmVkKF9fR05VQ19f
KSB8fCBkZWZpbmVkKF9fY2xhbmdfXykiKQorY3BwX3F1b3RlKCIjcHJhZ21hIEdDQyBkaWFnbm9z
dGljIHB1c2giKQorY3BwX3F1b3RlKCIjcHJhZ21hIEdDQyBkaWFnbm9zdGljIGlnbm9yZWQgXCIt
V292ZXJsb2FkZWQtdmlydHVhbFwiIikKK2NwcF9xdW90ZSgiI2VuZGlmIikKKwogWwogICAgIHV1
aWQoOTk3M0QxOTAtMzM0Ni00Q0FBLUFCNzYtRjA3MENBQjBCNTlCKQogXQpAQCAtMTk4LDQgKzIw
Myw4IEBAIGludGVyZmFjZSBJV2ViRWRpdGluZ0RlbGVnYXRlMiA6IElXZWJFZGl0aW5nRGVsZWdh
dGUKICAgICAtIChCT09MKXdlYlZpZXc6KFdlYlZpZXcgKil3ZWJWaWV3IHNob3VsZEluc2VydE5v
ZGU6KERPTU5vZGUgKilub2RlIHJlcGxhY2luZ0RPTVJhbmdlOihET01SYW5nZSAqKXJhbmdlIGdp
dmVuQWN0aW9uOihXZWJWaWV3SW5zZXJ0QWN0aW9uKWFjdGlvbjsKICAgICAqLwogICAgIEhSRVNV
TFQgc2hvdWxkSW5zZXJ0Tm9kZShbaW5dIElXZWJWaWV3KiB3ZWJWaWV3LCBbaW5dIElET01Ob2Rl
KiBub2RlLCBbaW5dIElET01SYW5nZSogcmFuZ2UsIFtpbl0gV2ViVmlld0luc2VydEFjdGlvbiBh
Y3Rpb24sIFtvdXQsIHJldHZhbF0gQk9PTCogcmVzdWx0KTsKLX0KXCBObyBuZXdsaW5lIGF0IGVu
ZCBvZiBmaWxlCit9CisKK2NwcF9xdW90ZSgiI2lmIGRlZmluZWQoX19HTlVDX18pIHx8IGRlZmlu
ZWQoX19jbGFuZ19fKSIpCitjcHBfcXVvdGUoIiNwcmFnbWEgR0NDIGRpYWdub3N0aWMgcG9wIikK
K2NwcF9xdW90ZSgiI2VuZGlmIikKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXRMZWdhY3kvd2lu
L0ludGVyZmFjZXMvSVdlYlZpZXdQcml2YXRlLmlkbCBiL1NvdXJjZS9XZWJLaXRMZWdhY3kvd2lu
L0ludGVyZmFjZXMvSVdlYlZpZXdQcml2YXRlLmlkbAppbmRleCBkMzVmMjZkYWEwMjUyNGMxMDhl
YjI1ZjMwODhiOGMxZTcyM2Q2ZDNiLi41OWVkYjBiZGQ3YjkwZTVkNzAzOWM5ZDYxNjBkNGI0MWQ2
MDlmY2U1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0TGVnYWN5L3dpbi9JbnRlcmZhY2VzL0lX
ZWJWaWV3UHJpdmF0ZS5pZGwKKysrIGIvU291cmNlL1dlYktpdExlZ2FjeS93aW4vSW50ZXJmYWNl
cy9JV2ViVmlld1ByaXZhdGUuaWRsCkBAIC0yOTcsNiArMjk3LDExIEBAIGludGVyZmFjZSBJV2Vi
Vmlld1ByaXZhdGUgOiBJVW5rbm93bgogICAgIEhSRVNVTFQgc2VsZWN0ZWRSYW5nZUZvclRlc3Rp
bmcoW291dF0gVUlOVCogbG9jYXRpb24sIFtvdXRdIFVJTlQqIGxlbmd0aCk7CiB9CiAKK2NwcF9x
dW90ZSgiI2lmIGRlZmluZWQoX19HTlVDX18pIHx8IGRlZmluZWQoX19jbGFuZ19fKSIpCitjcHBf
cXVvdGUoIiNwcmFnbWEgR0NDIGRpYWdub3N0aWMgcHVzaCIpCitjcHBfcXVvdGUoIiNwcmFnbWEg
R0NDIGRpYWdub3N0aWMgaWdub3JlZCBcIi1Xb3ZlcmxvYWRlZC12aXJ0dWFsXCIiKQorY3BwX3F1
b3RlKCIjZW5kaWYiKQorCiBbIHV1aWQoNjcxRkIyNTktQUJFRi00OEZDLTg4RkItRUM0Q0YzMDRF
ODY2KSBdCiBpbnRlcmZhY2UgSVdlYlZpZXdQcml2YXRlMiA6IElXZWJWaWV3UHJpdmF0ZQogewpA
QCAtMzIxLDYgKzMyNiwxMCBAQCBpbnRlcmZhY2UgSVdlYlZpZXdQcml2YXRlMiA6IElXZWJWaWV3
UHJpdmF0ZQogICAgICAgICBbaW5dIFdlYlVzZXJDb250ZW50SW5qZWN0ZWRGcmFtZXMgaW5qZWN0
ZWRGcmFtZXMpOwogfQogCitjcHBfcXVvdGUoIiNpZiBkZWZpbmVkKF9fR05VQ19fKSB8fCBkZWZp
bmVkKF9fY2xhbmdfXykiKQorY3BwX3F1b3RlKCIjcHJhZ21hIEdDQyBkaWFnbm9zdGljIHBvcCIp
CitjcHBfcXVvdGUoIiNlbmRpZiIpCisKIHR5cGVkZWYgZW51bSB7CiAgICAgV2ViRmluZE9wdGlv
bnNDYXNlSW5zZW5zaXRpdmUgPSAxIDw8IDAsCiAgICAgV2ViRmluZE9wdGlvbnNBdFdvcmRTdGFy
dHMgPSAxIDw8IDEsCg==
</data>

          </attachment>
      

    </bug>

</bugzilla>