192569 2018-12-10 13:56:09 -0800 LinkBuffer::copyCompactAndLinkCode() needs to be aware of ENABLE(SEPARATED_WX_HEAP). 2018-12-10 15:15:03 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mark.lam mark.lam fpizlo keith_miller msaboff rmorisset saam tzagallo webkit-bug-importer oldest_to_newest 1486719 0 mark.lam 2018-12-10 13:56:09 -0800 Patch coming. <rdar://problem/45615617> 1486733 1 356999 mark.lam 2018-12-10 14:09:58 -0800 Created attachment 356999 proposed patch. 1486741 2 356999 saam 2018-12-10 14:22:30 -0800 Comment on attachment 356999 proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=356999&action=review > Source/JavaScriptCore/assembler/LinkBuffer.cpp:45 > +extern JS_EXPORT_PRIVATE bool useFastPermisionsJITCopy; typo: useFastPermisionsJITCopy => useFastPermissionsJITCopy 1486763 3 356999 mark.lam 2018-12-10 15:06:07 -0800 Comment on attachment 356999 proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=356999&action=review >> Source/JavaScriptCore/assembler/LinkBuffer.cpp:45 >> +extern JS_EXPORT_PRIVATE bool useFastPermisionsJITCopy; > > typo: useFastPermisionsJITCopy => useFastPermissionsJITCopy Thanks for the review. This is a pre-existing typo. I'll fix it everywhere in a separate patch. I will fix "isUsingFastPermisionsJITCopy" (that I introduced in this patch) before landing though. 1486768 4 mark.lam 2018-12-10 15:15:03 -0800 Landed in r239055: <http://trac.webkit.org/r239055>. 356999 2018-12-10 14:09:58 -0800 2018-12-10 14:22:30 -0800 proposed patch. bug-192569.patch text/plain 4124 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjM5MDUxKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBA CisyMDE4LTEyLTEwICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBM aW5rQnVmZmVyOjpjb3B5Q29tcGFjdEFuZExpbmtDb2RlKCkgbmVlZHMgdG8gYmUgYXdhcmUgb2Yg RU5BQkxFKFNFUEFSQVRFRF9XWF9IRUFQKS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTE5MjU2OQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNDU2MTU2 MTc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBh c3NlbWJsZXIvTGlua0J1ZmZlci5jcHA6CisgICAgICAgIChKU0M6OkxpbmtCdWZmZXI6OmNvcHlD b21wYWN0QW5kTGlua0NvZGUpOgorCiAyMDE4LTEyLTEwICBDYWlvIExpbWEgIDx0aWNhaW9saW1h QGdtYWlsLmNvbT4KIAogICAgICAgICBbQmlnSW50XSBBZGQgVmFsdWVNdWwgaW50byBERkcKSW5k ZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvTGlua0J1ZmZlci5jcHAKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9MaW5rQnVmZmVyLmNwcAko cmV2aXNpb24gMjM5MDUxKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9MaW5r QnVmZmVyLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNDEsNiArNDEsMTAgQEAKIAogbmFtZXNwYWNl IEpTQyB7CiAKKyNpZiBFTkFCTEUoU0VQQVJBVEVEX1dYX0hFQVApCitleHRlcm4gSlNfRVhQT1JU X1BSSVZBVEUgYm9vbCB1c2VGYXN0UGVybWlzaW9uc0pJVENvcHk7CisjZW5kaWYgLy8gRU5BQkxF KFNFUEFSQVRFRF9XWF9IRUFQKQorCiBib29sIHNob3VsZER1bXBEaXNhc3NlbWJseUZvcihDb2Rl QmxvY2sqIGNvZGVCbG9jaykKIHsKICAgICBpZiAoY29kZUJsb2NrICYmIEpJVENvZGU6OmlzT3B0 aW1pemluZ0pJVChjb2RlQmxvY2stPmppdFR5cGUoKSkgJiYgT3B0aW9uczo6ZHVtcERGR0Rpc2Fz c2VtYmx5KCkpCkBAIC0xMTYsNiArMTIwLDE0IEBAIHN0YXRpYyBBTFdBWVNfSU5MSU5FIHZvaWQg cmVjb3JkTGlua09mZnMKIHRlbXBsYXRlIDx0eXBlbmFtZSBJbnN0cnVjdGlvblR5cGU+CiB2b2lk IExpbmtCdWZmZXI6OmNvcHlDb21wYWN0QW5kTGlua0NvZGUoTWFjcm9Bc3NlbWJsZXImIG1hY3Jv QXNzZW1ibGVyLCB2b2lkKiBvd25lclVJRCwgSklUQ29tcGlsYXRpb25FZmZvcnQgZWZmb3J0KQog eworI2lmIENQVShBUk02NEUpICYmIEVOQUJMRShGQVNUX0pJVF9QRVJNSVNTSU9OUykKKyNpZiBF TkFCTEUoU0VQQVJBVEVEX1dYX0hFQVApCisgICAgY29uc3QgYm9vbCBpc1VzaW5nRmFzdFBlcm1p c2lvbnNKSVRDb3B5ID0gdXNlRmFzdFBlcm1pc2lvbnNKSVRDb3B5OworI2Vsc2UKKyAgICBjb25z dCBib29sIGlzVXNpbmdGYXN0UGVybWlzaW9uc0pJVENvcHkgPSB0cnVlOworI2VuZGlmCisjZW5k aWYKKwogICAgIGFsbG9jYXRlKG1hY3JvQXNzZW1ibGVyLCBvd25lclVJRCwgZWZmb3J0KTsKICAg ICBjb25zdCBzaXplX3QgaW5pdGlhbFNpemUgPSBtYWNyb0Fzc2VtYmxlci5tX2Fzc2VtYmxlci5j b2RlU2l6ZSgpOwogICAgIGlmIChkaWRGYWlsVG9BbGxvY2F0ZSgpKQpAQCAtMTMwLDYgKzE0Miwx MSBAQCB2b2lkIExpbmtCdWZmZXI6OmNvcHlDb21wYWN0QW5kTGlua0NvZGUoCiAgICAgY29uc3Qg QVJNNjRFSGFzaCBhc3NlbWJsZXJCdWZmZXJIYXNoID0gbWFjcm9Bc3NlbWJsZXIubV9hc3NlbWJs ZXIuYnVmZmVyKCkuaGFzaCgpOwogICAgIEFSTTY0RUhhc2ggdmVyaWZ5VW5jb21wYWN0ZWRIYXNo KGFzc2VtYmxlckJ1ZmZlckhhc2gucmFuZG9tU2VlZCgpKTsKICAgICB1aW50OF90KiBvdXREYXRh ID0gY29kZU91dERhdGE7CisjaWYgRU5BQkxFKFNFUEFSQVRFRF9XWF9IRUFQKQorICAgIEFzc2Vt YmxlckRhdGEgb3V0QnVmZmVyKG1fc2l6ZSk7CisgICAgaWYgKCFpc1VzaW5nRmFzdFBlcm1pc2lv bnNKSVRDb3B5KQorICAgICAgICBvdXREYXRhID0gcmVpbnRlcnByZXRfY2FzdDx1aW50OF90Kj4o b3V0QnVmZmVyLmJ1ZmZlcigpKTsKKyNlbmRpZiAvLyBFTkFCTEUoU0VQQVJBVEVEX1dYX0hFQVAp CiAjZWxzZQogICAgIEFzc2VtYmxlckRhdGEgb3V0QnVmZmVyKG1fc2l6ZSk7CiAgICAgdWludDhf dCogb3V0RGF0YSA9IHJlaW50ZXJwcmV0X2Nhc3Q8dWludDhfdCo+KG91dEJ1ZmZlci5idWZmZXIo KSk7CkBAIC0xNDQsNyArMTYxLDggQEAgdm9pZCBMaW5rQnVmZmVyOjpjb3B5Q29tcGFjdEFuZExp bmtDb2RlKAogICAgIHVuc2lnbmVkIGp1bXBDb3VudCA9IGp1bXBzVG9MaW5rLnNpemUoKTsKIAog I2lmIENQVShBUk02NEUpICYmIEVOQUJMRShGQVNUX0pJVF9QRVJNSVNTSU9OUykKLSAgICBvc190 aHJlYWRfc2VsZl9yZXN0cmljdF9yd3hfdG9fcncoKTsKKyAgICBpZiAoaXNVc2luZ0Zhc3RQZXJt aXNpb25zSklUQ29weSkKKyAgICAgICAgb3NfdGhyZWFkX3NlbGZfcmVzdHJpY3Rfcnd4X3RvX3J3 KCk7CiAjZW5kaWYKIAogICAgIGlmIChtX3Nob3VsZFBlcmZvcm1CcmFuY2hDb21wYWN0aW9uKSB7 CkBAIC0yNDAsNiArMjU4LDggQEAgdm9pZCBMaW5rQnVmZmVyOjpjb3B5Q29tcGFjdEFuZExpbmtD b2RlKAogICAgIGZvciAodW5zaWduZWQgaSA9IDA7IGkgPCBqdW1wQ291bnQ7ICsraSkgewogI2lm IENQVShBUk02NEUpICYmIEVOQUJMRShGQVNUX0pJVF9QRVJNSVNTSU9OUykKICAgICAgICAgYXV0 byBtZW1jcHlGdW5jdGlvbiA9IG1lbWNweTsKKyAgICAgICAgaWYgKCFpc1VzaW5nRmFzdFBlcm1p c2lvbnNKSVRDb3B5KQorICAgICAgICAgICAgbWVtY3B5RnVuY3Rpb24gPSBwZXJmb3JtSklUTWVt Y3B5OwogI2Vsc2UKICAgICAgICAgYXV0byBtZW1jcHlGdW5jdGlvbiA9IHBlcmZvcm1KSVRNZW1j cHk7CiAjZW5kaWYKQEAgLTI1Niw3ICsyNzYsOCBAQCB2b2lkIExpbmtCdWZmZXI6OmNvcHlDb21w YWN0QW5kTGlua0NvZGUoCiAgICAgfQogCiAjaWYgQ1BVKEFSTTY0RSkgJiYgRU5BQkxFKEZBU1Rf SklUX1BFUk1JU1NJT05TKQotICAgIG9zX3RocmVhZF9zZWxmX3Jlc3RyaWN0X3J3eF90b19yeCgp OworICAgIGlmIChpc1VzaW5nRmFzdFBlcm1pc2lvbnNKSVRDb3B5KQorICAgICAgICBvc190aHJl YWRfc2VsZl9yZXN0cmljdF9yd3hfdG9fcngoKTsKICNlbmRpZgogCiAgICAgaWYgKG1fZXhlY3V0 YWJsZU1lbW9yeSkgewpAQCAtMjY4LDcgKzI4OSwxMiBAQCB2b2lkIExpbmtCdWZmZXI6OmNvcHlD b21wYWN0QW5kTGlua0NvZGUoCiAgICAgQVNTRVJUKGNvZGVPdXREYXRhICE9IG91dERhdGEpOwog ICAgIHBlcmZvcm1KSVRNZW1jcHkoY29kZU91dERhdGEsIG91dERhdGEsIG1fc2l6ZSk7CiAjZWxz ZQotICAgIEFTU0VSVChjb2RlT3V0RGF0YSA9PSBvdXREYXRhKTsKKyAgICBpZiAoaXNVc2luZ0Zh c3RQZXJtaXNpb25zSklUQ29weSkKKyAgICAgICAgQVNTRVJUKGNvZGVPdXREYXRhID09IG91dERh dGEpOworICAgIGVsc2UgeworICAgICAgICBBU1NFUlQoY29kZU91dERhdGEgIT0gb3V0RGF0YSk7 CisgICAgICAgIHBlcmZvcm1KSVRNZW1jcHkoY29kZU91dERhdGEsIG91dERhdGEsIG1fc2l6ZSk7 CisgICAgfQogI2VuZGlmCiAKICAgICBqdW1wc1RvTGluay5jbGVhcigpOwpAQCAtMjgwLDcgKzMw Niw3IEBAIHZvaWQgTGlua0J1ZmZlcjo6Y29weUNvbXBhY3RBbmRMaW5rQ29kZSgKICAgICBkdW1w Q29kZShjb2RlT3V0RGF0YSwgbV9zaXplKTsKICNlbmRpZgogfQotI2VuZGlmCisjZW5kaWYgLy8g RU5BQkxFKEJSQU5DSF9DT01QQUNUSU9OKQogCiAKIHZvaWQgTGlua0J1ZmZlcjo6bGlua0NvZGUo TWFjcm9Bc3NlbWJsZXImIG1hY3JvQXNzZW1ibGVyLCB2b2lkKiBvd25lclVJRCwgSklUQ29tcGls YXRpb25FZmZvcnQgZWZmb3J0KQo=