192566 2018-12-10 13:25:51 -0800 DataChannels created asynchronously never open and are unusable 2018-12-10 19:44:25 -0800 1 1 1 Unclassified WebKit WebRTC Safari 12 Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 thomasmullendesign youennf commit-queue eric.carlson webkit-bug-importer youennf oldest_to_newest 1486691 0 thomasmullendesign 2018-12-10 13:25:51 -0800 RTCDataChannels that are created asynchronously will never open. This makes it impossible to create new channels later in the connection. Chrome and Firefox have no such issue. Simple reproduction: https://codepen.io/RationalCoding/pen/Qzwqrg?editors=0011 1486694 1 thomasmullendesign 2018-12-10 13:26:58 -0800 It should be noted that the channel is received by the remote peer (ondatachannel is fired). The channel just never opens and cannot send data. 1486767 2 357004 youennf 2018-12-10 15:12:42 -0800 Created attachment 357004 Patch 1486854 3 357004 commit-queue 2018-12-10 19:43:47 -0800 Comment on attachment 357004 Patch Clearing flags on attachment: 357004 Committed r239064: <https://trac.webkit.org/changeset/239064> 1486855 4 commit-queue 2018-12-10 19:43:48 -0800 All reviewed patches have been landed. Closing bug. 1486857 5 webkit-bug-importer 2018-12-10 19:44:25 -0800 <rdar://problem/46617152> 357004 2018-12-10 15:12:42 -0800 2018-12-10 19:43:47 -0800 Patch bug-192566-20181210151241.patch text/plain 6980 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjM5MDI4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggM2FhMGU4Y2VhMDM1MTQ0 Y2NlYWZjOTVlODE0MTI2NDZiZjViOTJlOS4uZmY5N2ZjY2I0ZTExMmZjYWZiZGIyYTA4MGI3NjJk NzlhNmE4NGM3YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDE4LTEyLTEwICBZb3Vl bm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KKworICAgICAgICBEYXRhQ2hhbm5lbHMgY3Jl YXRlZCBhc3luY2hyb25vdXNseSBuZXZlciBvcGVuIGFuZCBhcmUgdW51c2FibGUKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5MjU2NgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZvciBldmVyeSBuZXcgZGF0 YSBjaGFubmVsIChyZW1vdGUgb3IgbG9jYWwpLCB3ZSBzaG91bGQgY2hlY2sgdGhlIHVuZGVybHlp bmcgYmFja2VuZCBzdGF0ZS4KKyAgICAgICAgVGhpcyBhbGxvd3MgZmlyaW5nIGV2ZW50cyBpZiBu ZWVkZWQuCisgICAgICAgIFdlIHdlcmUgbm90IGFsd2F5cyBkb2luZyB0aGF0IHdoaWNoIHdhcyBw cm9oaWJpdGluZyBzZW5kaW5nIHNvbWUgb3BlbgorICAgICAgICBldmVudHMgZm9yIGRhdGEgY2hh bm5lbHMgY3JlYXRlZCBhZnRlciB0aGUgU0NUUCBjb25uZWN0aW9uIGlzIHNldCB1cC4KKworICAg ICAgICBDb3ZlcmVkIGJ5IHVwZGF0ZWQgdGVzdC4KKworICAgICAgICAqIE1vZHVsZXMvbWVkaWFz dHJlYW0vbGlid2VicnRjL0xpYldlYlJUQ0RhdGFDaGFubmVsSGFuZGxlci5jcHA6CisgICAgICAg IChXZWJDb3JlOjpMaWJXZWJSVENEYXRhQ2hhbm5lbEhhbmRsZXI6OmNoYW5uZWxFdmVudCk6Cisg ICAgICAgIChXZWJDb3JlOjpMaWJXZWJSVENEYXRhQ2hhbm5lbEhhbmRsZXI6OnNldENsaWVudCk6 CisgICAgICAgIChXZWJDb3JlOjpMaWJXZWJSVENEYXRhQ2hhbm5lbEhhbmRsZXI6Ok9uU3RhdGVD aGFuZ2UpOgorICAgICAgICAoV2ViQ29yZTo6TGliV2ViUlRDRGF0YUNoYW5uZWxIYW5kbGVyOjpj aGVja1N0YXRlKToKKyAgICAgICAgKiBNb2R1bGVzL21lZGlhc3RyZWFtL2xpYndlYnJ0Yy9MaWJX ZWJSVENEYXRhQ2hhbm5lbEhhbmRsZXIuaDoKKwogMjAxOC0xMi0xMCAgWW91ZW5uIEZhYmxldCAg PHlvdWVubkBhcHBsZS5jb20+CiAKICAgICAgICAgUmVtb3ZlIGRlcml2ZWQgY2xhc3NlcyBvZiBS ZWFsdGltZU1lZGlhU291cmNlQ2VudGVyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1 bGVzL21lZGlhc3RyZWFtL2xpYndlYnJ0Yy9MaWJXZWJSVENEYXRhQ2hhbm5lbEhhbmRsZXIuY3Bw IGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYXN0cmVhbS9saWJ3ZWJydGMvTGliV2ViUlRD RGF0YUNoYW5uZWxIYW5kbGVyLmNwcAppbmRleCBiY2ZlMmE0NWYwZTg5NGQ4MjBkYmYyYjY5Yzdh NTM3OGMyYWFlZWVhLi5hYWE0MDAwMjA3MzY1ZmZjYmU1MjgxMjhlMjhjZTAyZjZjNjA3Y2RkIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhc3RyZWFtL2xpYndlYnJ0Yy9M aWJXZWJSVENEYXRhQ2hhbm5lbEhhbmRsZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL01vZHVs ZXMvbWVkaWFzdHJlYW0vbGlid2VicnRjL0xpYldlYlJUQ0RhdGFDaGFubmVsSGFuZGxlci5jcHAK QEAgLTY5LDE5ICs2OSw5IEBAIFJlZjxSVENEYXRhQ2hhbm5lbEV2ZW50PiBMaWJXZWJSVENEYXRh Q2hhbm5lbEhhbmRsZXI6OmNoYW5uZWxFdmVudChTY3JpcHRFeGVjdXRpCiAgICAgaW5pdC5uZWdv dGlhdGVkID0gZGF0YUNoYW5uZWwtPm5lZ290aWF0ZWQoKTsKICAgICBpbml0LmlkID0gZGF0YUNo YW5uZWwtPmlkKCk7CiAKLSAgICBib29sIGlzT3BlbmVkID0gZGF0YUNoYW5uZWwtPnN0YXRlKCkg PT0gd2VicnRjOjpEYXRhQ2hhbm5lbEludGVyZmFjZTo6a09wZW47Ci0KICAgICBhdXRvIGhhbmRs ZXIgPSAgc3RkOjptYWtlX3VuaXF1ZTxMaWJXZWJSVENEYXRhQ2hhbm5lbEhhbmRsZXI+KFdURk1v dmUoZGF0YUNoYW5uZWwpKTsKICAgICBhdXRvIGNoYW5uZWwgPSBSVENEYXRhQ2hhbm5lbDo6Y3Jl YXRlKGNvbnRleHQsIFdURk1vdmUoaGFuZGxlciksIGZyb21TdGRTdHJpbmcobGFiZWwpLCBXVEZN b3ZlKGluaXQpKTsKIAotICAgIGlmIChpc09wZW5lZCkgewotICAgICAgICBjYWxsT25NYWluVGhy ZWFkKFtjaGFubmVsID0gY2hhbm5lbC5jb3B5UmVmKCldIHsKLSAgICAgICAgICAgIC8vIEZJWE1F OiBXZSBzaG91bGQgYmUgYWJsZSB0byB3cml0ZSBjaGFubmVsLT5kaWRDaGFuZ2VSZWFkeVN0YXRl KC4uLikKLSAgICAgICAgICAgIFJUQ0RhdGFDaGFubmVsSGFuZGxlckNsaWVudCYgY2xpZW50ID0g Y2hhbm5lbC5nZXQoKTsKLSAgICAgICAgICAgIGNsaWVudC5kaWRDaGFuZ2VSZWFkeVN0YXRlKFJU Q0RhdGFDaGFubmVsU3RhdGU6Ok9wZW4pOwotICAgICAgICB9KTsKLSAgICB9Ci0KICAgICByZXR1 cm4gUlRDRGF0YUNoYW5uZWxFdmVudDo6Y3JlYXRlKGV2ZW50TmFtZXMoKS5kYXRhY2hhbm5lbEV2 ZW50LCBFdmVudDo6Q2FuQnViYmxlOjpObywgRXZlbnQ6OklzQ2FuY2VsYWJsZTo6Tm8sIFdURk1v dmUoY2hhbm5lbCkpOwogfQogCkBAIC05Niw2ICs4Niw3IEBAIHZvaWQgTGliV2ViUlRDRGF0YUNo YW5uZWxIYW5kbGVyOjpzZXRDbGllbnQoUlRDRGF0YUNoYW5uZWxIYW5kbGVyQ2xpZW50JiBjbGll bnQpCiAgICAgQVNTRVJUKCFtX2NsaWVudCk7CiAgICAgbV9jbGllbnQgPSAmY2xpZW50OwogICAg IG1fY2hhbm5lbC0+UmVnaXN0ZXJPYnNlcnZlcih0aGlzKTsKKyAgICBjaGVja1N0YXRlKCk7CiB9 CiAKIGJvb2wgTGliV2ViUlRDRGF0YUNoYW5uZWxIYW5kbGVyOjpzZW5kU3RyaW5nRGF0YShjb25z dCBTdHJpbmcmIHRleHQpCkBAIC0xMjIsNyArMTEzLDExIEBAIHZvaWQgTGliV2ViUlRDRGF0YUNo YW5uZWxIYW5kbGVyOjpPblN0YXRlQ2hhbmdlKCkKIHsKICAgICBpZiAoIW1fY2xpZW50KQogICAg ICAgICByZXR1cm47CisgICAgY2hlY2tTdGF0ZSgpOworfQogCit2b2lkIExpYldlYlJUQ0RhdGFD aGFubmVsSGFuZGxlcjo6Y2hlY2tTdGF0ZSgpCit7CiAgICAgUlRDRGF0YUNoYW5uZWxTdGF0ZSBz dGF0ZTsKICAgICBzd2l0Y2ggKG1fY2hhbm5lbC0+c3RhdGUoKSkgewogICAgIGNhc2Ugd2VicnRj OjpEYXRhQ2hhbm5lbEludGVyZmFjZTo6a0Nvbm5lY3Rpbmc6CmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9Nb2R1bGVzL21lZGlhc3RyZWFtL2xpYndlYnJ0Yy9MaWJXZWJSVENEYXRhQ2hhbm5l bEhhbmRsZXIuaCBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFzdHJlYW0vbGlid2VicnRj L0xpYldlYlJUQ0RhdGFDaGFubmVsSGFuZGxlci5oCmluZGV4IDAwNTUyYmY2NjZiOGRkNzkyZTc4 NTg5N2Q3OWQyMGFlN2Q3NDNkMDQuLmU4MDEwMTk2ZDZlOTlhMDY1MDJiNTY0NGFlNTBmNDVhZmVi Y2Q1Y2UgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFzdHJlYW0vbGli d2VicnRjL0xpYldlYlJUQ0RhdGFDaGFubmVsSGFuZGxlci5oCisrKyBiL1NvdXJjZS9XZWJDb3Jl L01vZHVsZXMvbWVkaWFzdHJlYW0vbGlid2VicnRjL0xpYldlYlJUQ0RhdGFDaGFubmVsSGFuZGxl ci5oCkBAIC01Nyw2ICs1Nyw3IEBAIHB1YmxpYzoKIHByaXZhdGU6CiAgICAgLy8gUlRDRGF0YUNo YW5uZWxIYW5kbGVyIEFQSQogICAgIHZvaWQgc2V0Q2xpZW50KFJUQ0RhdGFDaGFubmVsSGFuZGxl ckNsaWVudCYpIGZpbmFsOworICAgIHZvaWQgY2hlY2tTdGF0ZSgpOwogICAgIGJvb2wgc2VuZFN0 cmluZ0RhdGEoY29uc3QgU3RyaW5nJikgZmluYWw7CiAgICAgYm9vbCBzZW5kUmF3RGF0YShjb25z dCBjaGFyKiwgc2l6ZV90KSBmaW5hbDsKICAgICB2b2lkIGNsb3NlKCkgZmluYWw7CmRpZmYgLS1n aXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXgg MjAyODkzOTE3ZTUzZDlhYWEwYWYyNzNmYzU3MzY2N2FkOGE4ZWE1Ni4uYTY1OTRjYzNkZTVmZDcx ZWRhMWYzODg5ZTliMGFjMTdiYTEwZTc1OSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdl TG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE4LTEy LTEwICBZb3Vlbm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KKworICAgICAgICBEYXRhQ2hh bm5lbHMgY3JlYXRlZCBhc3luY2hyb25vdXNseSBuZXZlciBvcGVuIGFuZCBhcmUgdW51c2FibGUK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5MjU2Ngor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogd2VicnRj L2RhdGFjaGFubmVsL2Jhc2ljLWV4cGVjdGVkLnR4dDoKKyAgICAgICAgKiB3ZWJydGMvZGF0YWNo YW5uZWwvYmFzaWMuaHRtbDoKKwogMjAxOC0xMi0wOSAgQ29tbWl0IFF1ZXVlICA8Y29tbWl0LXF1 ZXVlQHdlYmtpdC5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjIzOTAx MC4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3dlYnJ0Yy9kYXRhY2hhbm5lbC9iYXNpYy1leHBl Y3RlZC50eHQgYi9MYXlvdXRUZXN0cy93ZWJydGMvZGF0YWNoYW5uZWwvYmFzaWMtZXhwZWN0ZWQu dHh0CmluZGV4IDBlYjIyNmVlMzBlYWU3YjMwMjNmZTU2NTYyODY2Yzc3YWJhNjAxNTEuLmI4ZWJl NDNmM2Y2YmIxOGYwYWEwNTlhODkzODA5NzBlZmM5NTBiMmMgMTAwNjQ0Ci0tLSBhL0xheW91dFRl c3RzL3dlYnJ0Yy9kYXRhY2hhbm5lbC9iYXNpYy1leHBlY3RlZC50eHQKKysrIGIvTGF5b3V0VGVz dHMvd2VicnRjL2RhdGFjaGFubmVsL2Jhc2ljLWV4cGVjdGVkLnR4dApAQCAtMyw0ICszLDUgQEAg UEFTUyBCYXNpYyBkYXRhIGNoYW5uZWwgZXhjaGFuZ2UgZnJvbSBvZmZlcmVyIHRvIHJlY2VpdmVy CiBQQVNTIEJhc2ljIGRhdGEgY2hhbm5lbCBleGNoYW5nZSBmcm9tIHJlY2VpdmVyIHRvIG9mZmVy ZXIgCiBQQVNTIEJhc2ljIGRhdGEgY2hhbm5lbCBleGNoYW5nZSBmcm9tIG9mZmVyZXIgdG8gcmVj ZWl2ZXIgdXNpbmcgVURQIG9ubHkgCiBQQVNTIEJhc2ljIGRhdGEgY2hhbm5lbCBleGNoYW5nZSBm cm9tIG9mZmVyZXIgdG8gcmVjZWl2ZXIgCitQQVNTIENyZWF0ZSBhIHNlY29uZCBjaGFubmVsIGFz eW5jaHJvbm91c2x5IGFuZCBzZW5kIG1lc3NhZ2VzIAogCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0 cy93ZWJydGMvZGF0YWNoYW5uZWwvYmFzaWMuaHRtbCBiL0xheW91dFRlc3RzL3dlYnJ0Yy9kYXRh Y2hhbm5lbC9iYXNpYy5odG1sCmluZGV4IGZhMzE1ZDA1MTk5ZGFmZDFjMzBlYzgzOGVjMWU4NzQ0 M2RjZjBlMjguLmZiOWY0ZGIzMGVmZTMyNGMxOWQ2ZmE4YzY3NGUxMDY3MjIwMzA4MWUgMTAwNjQ0 Ci0tLSBhL0xheW91dFRlc3RzL3dlYnJ0Yy9kYXRhY2hhbm5lbC9iYXNpYy5odG1sCisrKyBiL0xh eW91dFRlc3RzL3dlYnJ0Yy9kYXRhY2hhbm5lbC9iYXNpYy5odG1sCkBAIC0xMjYsNiArMTI2LDQw IEBAIHByb21pc2VfdGVzdCgodGVzdCkgPT4gewogICAgIH0pOwogfSwgIkJhc2ljIGRhdGEgY2hh bm5lbCBleGNoYW5nZSBmcm9tIG9mZmVyZXIgdG8gcmVjZWl2ZXIiKTsKIAorcHJvbWlzZV90ZXN0 KGFzeW5jICh0ZXN0KSA9PiB7CisgICAgYXdhaXQgbmV3IFByb21pc2UoKHJlc29sdmUsIHJlamVj dCkgPT4geworICAgICAgICBmaW5pc2hUZXN0ID0gcmVzb2x2ZTsKKyAgICAgICAgY3JlYXRlQ29u bmVjdGlvbnMoKGxvY2FsQ29ubmVjdGlvbikgPT4geworICAgICAgICAgICAgbG9jYWxDaGFubmVs ID0gbG9jYWxDb25uZWN0aW9uLmNyZWF0ZURhdGFDaGFubmVsKCdzZW5kRGF0YUNoYW5uZWwnKTsK KyAgICAgICAgfSwgKHJlbW90ZUNvbm5lY3Rpb24pID0+IHsKKyAgICAgICAgICAgIHJlbW90ZUNv bm5lY3Rpb24ub25kYXRhY2hhbm5lbCA9IHJlc29sdmU7CisgICAgICAgIH0pOworICAgICAgICBz ZXRUaW1lb3V0KCgpID0+IHsgcmVqZWN0KCJUZXN0IHN0ZXAgMSB0aW1lZCBvdXQiKTsgfSwgNTAw MCk7CisgICAgfSk7CisgICAgYXdhaXQgd2FpdEZvcig1MCk7CisgICAgbGV0IHdhaXRGb3JMb2Nh bENoYW5uZWxPcGVuaW5nID0gbmV3IFByb21pc2UoKHJlc29sdmUpID0+IHsKKyAgICAgICAgbG9j YWxDaGFubmVsID0gbG9jYWxDb25uZWN0aW9uLmNyZWF0ZURhdGFDaGFubmVsKCdzZW5kRGF0YUNo YW5uZWwyJyk7CisgICAgICAgIGxvY2FsQ2hhbm5lbC5vbm9wZW4gPSByZXNvbHZlOworICAgIH0p OworCisgICAgbGV0IHdhaXRGb3JSZW1vdGVDaGFubmVsID0gbmV3IFByb21pc2UoKHJlc29sdmUp ID0+IHsKKyAgICAgICAgcmVtb3RlQ29ubmVjdGlvbi5vbmRhdGFjaGFubmVsID0gKGV2ZW50KSA9 PiB7CisgICAgICAgICAgICByZW1vdGVDaGFubmVsID0gZXZlbnQuY2hhbm5lbDsKKyAgICAgICAg ICAgIHJlc29sdmUoKTsKKyAgICAgICAgfTsKKyAgICB9KTsKKworICAgIGF3YWl0IFByb21pc2Uu YWxsKFt3YWl0Rm9yTG9jYWxDaGFubmVsT3BlbmluZywgd2FpdEZvclJlbW90ZUNoYW5uZWxdKTsK KworICAgIGNvdW50ZXIgPSAwOworICAgIGF3YWl0IG5ldyBQcm9taXNlKChyZXNvbHZlLCByZWpl Y3QpID0+IHsKKyAgICAgICAgZmluaXNoVGVzdCA9IHJlc29sdmU7CisgICAgICAgIHJlbW90ZUNo YW5uZWwub25tZXNzYWdlID0gcmVjZWl2ZU1lc3NhZ2VzOworICAgICAgICBzZW5kTWVzc2FnZXMo bG9jYWxDaGFubmVsKTsKKyAgICAgICAgc2V0VGltZW91dCgoKSA9PiB7IHJlamVjdCgiVGVzdCBz dGVwIDIgdGltZWQgb3V0Iik7IH0sIDUwMDApOworICAgIH0pOworfSwgIkNyZWF0ZSBhIHNlY29u ZCBjaGFubmVsIGFzeW5jaHJvbm91c2x5IGFuZCBzZW5kIG1lc3NhZ2VzIik7CisKICAgICA8L3Nj cmlwdD4KICAgPC9ib2R5PgogPC9odG1sPgo=