192562 2018-12-10 11:32:58 -0800 [GLib] FileSystem::moveFile() should fall back to copying 2018-12-10 12:47:27 -0800 1 1 1 Unclassified WebKit WebCore Misc. Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 154553 1 aperez aperez cgarcia commit-queue darin mcatanzaro mmaxfield webkit-bug-importer ysuzuki zan oldest_to_newest 1486635 0 aperez 2018-12-10 11:32:58 -0800 Note that: - Cocoa (in “Source/WebCore/platform/cocoa/FileSystemCocoa.mm”) uses [NSFileManager movItemAtURL:toURL:], which falls back to copying, as per https://developer.apple.com/documentation/foundation/nsfilemanager/1414750-moveitematurl?language=objc - Windows (in “Source/WebCore/platform/win/FileSystemWin.cpp”) uses MoveFileEx(), passing flags MOVEFILE_COPY_ALLOWED|MOVEFILE_REPLACE_EXISTING But in the other hand: - “Source/WebCore/platform/posix/FileSystemPOSIX.cpp” uses a plain rename(2), which does NOT fall-back to copying. - “Source/WebCore/platform/glib/FileSystemGlib.cpp” uses g_rename(), which ends up calling rename(2) -- why this does not simply use the POSIX implmentation beats me ¯\_(ツ)_/¯ While working on the content extensions code, I have noticed that compiling a content extension involves creating a temporary file, and then moving it to its final location. For the GLib-based ports (GTK+, WPE) on Unix, the temporary file will be created under “/tmp”, and then FileSystem::moveFile() is used to place it in its final location, typically under the user's $HOME directory. There is a catch, though: frequently “/tmp” is on a different mount point than the final location! This is *very* often true in modern GNU/Linux distributions that have “/tmp” on tmpfs. Or, even if “/tmp” is the same file system as “/”, not uncommonly “/home” can be a separate file system itself. To me it is quite clear that FileSyste::moveFile() has to fall-back to copying, otherwise anything that makes use if this function will be far too easy to randomly break in unexptected ways. 1486639 1 aperez 2018-12-10 11:42:11 -0800 For FileSystemGLib I am planning to rewrite the function to use g_file_move(), which does implements a copy+delete fallback. 1486649 2 356977 aperez 2018-12-10 11:56:08 -0800 Created attachment 356977 Patch 1486673 3 356977 commit-queue 2018-12-10 12:46:36 -0800 Comment on attachment 356977 Patch Clearing flags on attachment: 356977 Committed r239043: <https://trac.webkit.org/changeset/239043> 1486674 4 commit-queue 2018-12-10 12:46:38 -0800 All reviewed patches have been landed. Closing bug. 1486676 5 webkit-bug-importer 2018-12-10 12:47:27 -0800 <rdar://problem/46604998> 356977 2018-12-10 11:56:08 -0800 2018-12-10 12:46:36 -0800 Patch bug-192562-20181210215607.patch text/plain 1748 aperez U3VidmVyc2lvbiBSZXZpc2lvbjogMjM5MDM3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjMwOWNkM2EzNTViZDYx YjY1NjAwZmU0YWUzZDkwMDE5MTVkM2EzMi4uOWVmNDM4NTFiNGU3ZTdjNjQzYzQyYjRjMTYyZGE1 ZmRhZTU3NWViYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE4LTEyLTEwICBBZHJp YW4gUGVyZXogZGUgQ2FzdHJvICA8YXBlcmV6QGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dMaWJd IEZpbGVTeXN0ZW06Om1vdmVGaWxlKCkgc2hvdWxkIGZhbGwgYmFjayB0byBjb3B5aW5nCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTI1NjIKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcgdGVzdHMg bmVlZGVkLgorCisgICAgICAgICogcGxhdGZvcm0vZ2xpYi9GaWxlU3lzdGVtR2xpYi5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpGaWxlU3lzdGVtOjptb3ZlRmlsZSk6IFVzZSBnX2ZpbGVfbW92ZSgp IGluc3RlYWQgb2YgYSBwbGFpbiBnX3JlbmFtZSgpLCB3aGljaAorICAgICAgICBwcm92aWRlcyBh IGZhbGwtYmFjayB3aGljaCBkb2VzIGNvcHkrZGVsZXRlIHdoZW4gYSBkaXJlY3QgbW92ZSBvciBy ZW5hbWUgY2Fubm90IGJlIGRvbmUuCisKIDIwMTgtMTItMTAgIERlYW4gSmFja3NvbiAgPGRpbm9A YXBwbGUuY29tPgogCiAgICAgICAgIFVzZSB0ZXh0L2phdmFzY3JpcHQgYXMgcmVjb21tZW5kZWQg YnkgdGhlIEhUTUwgc3BlY2lmaWNhdGlvbgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ2xpYi9GaWxlU3lzdGVtR2xpYi5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9n bGliL0ZpbGVTeXN0ZW1HbGliLmNwcAppbmRleCA4ZmM2ODY0Y2VjNjdhZGRlMjliMzEyYmI4MTBl YmE1MzczYjE4ODMxLi5iOTBlZWM2NmUyMzc2OGM3MWYwYTVhZjE4Y2Q4YTk4YWEyZmVjMzE3IDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9nbGliL0ZpbGVTeXN0ZW1HbGliLmNw cAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9nbGliL0ZpbGVTeXN0ZW1HbGliLmNwcApA QCAtNDAwLDcgKzQwMCwxMCBAQCBib29sIG1vdmVGaWxlKGNvbnN0IFN0cmluZyYgb2xkUGF0aCwg Y29uc3QgU3RyaW5nJiBuZXdQYXRoKQogICAgIGlmICghbmV3RmlsZW5hbWUpCiAgICAgICAgIHJl dHVybiBmYWxzZTsKIAotICAgIHJldHVybiBnX3JlbmFtZShvbGRGaWxlbmFtZS5nZXQoKSwgbmV3 RmlsZW5hbWUuZ2V0KCkpICE9IC0xOworICAgIEdSZWZQdHI8R0ZpbGU+IG9sZEZpbGUgPSBhZG9w dEdSZWYoZ19maWxlX25ld19mb3JfcGF0aChvbGRGaWxlbmFtZS5nZXQoKSkpOworICAgIEdSZWZQ dHI8R0ZpbGU+IG5ld0ZpbGUgPSBhZG9wdEdSZWYoZ19maWxlX25ld19mb3JfcGF0aChuZXdGaWxl bmFtZS5nZXQoKSkpOworCisgICAgcmV0dXJuIGdfZmlsZV9tb3ZlKG9sZEZpbGUuZ2V0KCksIG5l d0ZpbGUuZ2V0KCksIEdfRklMRV9DT1BZX09WRVJXUklURSwgbnVsbHB0ciwgbnVsbHB0ciwgbnVs bHB0ciwgbnVsbHB0cik7CiB9CiAKIGJvb2wgaGFyZExpbmtPckNvcHlGaWxlKGNvbnN0IFN0cmlu ZyYgc291cmNlLCBjb25zdCBTdHJpbmcmIGRlc3RpbmF0aW9uKQo=