192541 2018-12-09 08:10:20 -0800 Build failure due to missing include of APIWebsiteDataStore.h 2018-12-09 12:18:46 -0800 1 1 1 Unclassified WebKit WebKit Misc. Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aperez aperez achristensen commit-queue mcatanzaro webkit-bug-importer youennf oldest_to_newest 1486434 0 aperez 2018-12-09 08:10:20 -0800 Found this while making a WPE build with -DCMAKE_BUILD_TYPE=Debug and it looks like a missing #include which went unnoticed due to the usage of unified sources. We really should have a way of disabling unified sources and have at least one EWS do builds with them disabled to catch this kind of issues ~_~ --- In file included from DerivedSources/WebKit/unified-sources/UnifiedSource47.cpp:1: ../Source/WebKit/UIProcess/WebsiteData/WebsiteDataStoreConfiguration.cpp: In constructor WebKit::WebsiteDataStoreConfiguration::WebsiteDataStoreConfiguration()’: ../Source/WebKit/UIProcess/WebsiteData/WebsiteDataStoreConfiguration.cpp:33:46: error: ‘API::WebsiteDataStore’ has not been declared : m_resourceLoadStatisticsDirectory(API::WebsiteDataStore::defaultResourceLoadStatisticsDirectory()) ^~~~~~~~~~~~~~~~ 1486435 1 356922 aperez 2018-12-09 08:21:22 -0800 Created attachment 356922 Patch 1486438 2 356922 youennf 2018-12-09 09:19:14 -0800 Comment on attachment 356922 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=356922&action=review > Source/WebKit/UIProcess/WebsiteData/WebsiteDataStoreConfiguration.cpp:27 > + We usually do not put a line between config.h and the header of the corresponding cpp. 1486442 3 mcatanzaro 2018-12-09 10:19:46 -0800 (In reply to Adrian Perez from comment #0) > We really should have a way of disabling unified sources and have > at least one EWS do builds with them disabled to catch this kind > of issues ~_~ The answer will always be: if there's a way to disable unified sources, people will use it, and they will introduce build failures that only occur with unified sources enabled. What I don't understand is why you hit this build failure when none of the bots did. I presume a different set of build flags somehow results in different unified source bundles, which is a worrisome prospect. 1486446 4 aperez 2018-12-09 11:35:34 -0800 (In reply to Michael Catanzaro from comment #3) > (In reply to Adrian Perez from comment #0) > > We really should have a way of disabling unified sources and have > > at least one EWS do builds with them disabled to catch this kind > > of issues ~_~ > > The answer will always be: if there's a way to disable unified sources, > people will use it, and they will introduce build failures that only occur > with unified sources enabled. Wrong: people will use whatever is the default. If we have EWS bots which build both *with* and *without* unified sources, breaking any of them would prevent patches from going in, which would ensure that both modes are always working. > What I don't understand is why you hit this build failure when none of the > bots did. I presume a different set of build flags somehow results in > different unified source bundles, which is a worrisome prospect. Yes, I am working on having content extensions working for the WPE and GTK+ ports, so on top of having the option enabled there are additional files added to the list of sources to build ;-) 1486447 5 aperez 2018-12-09 11:36:28 -0800 (In reply to youenn fablet from comment #2) > Comment on attachment 356922 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=356922&action=review > > > Source/WebKit/UIProcess/WebsiteData/WebsiteDataStoreConfiguration.cpp:27 > > + > > We usually do not put a line between config.h and the header of the > corresponding cpp. I think the style checker complained, but I'll double-check before landing. Thanks for the review! 1486448 6 356927 aperez 2018-12-09 11:40:21 -0800 Created attachment 356927 Patch for landing 1486449 7 aperez 2018-12-09 11:43:32 -0800 (In reply to Adrian Perez from comment #5) > (In reply to youenn fablet from comment #2) > > Comment on attachment 356922 [details] > > Patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=356922&action=review > > > > > Source/WebKit/UIProcess/WebsiteData/WebsiteDataStoreConfiguration.cpp:27 > > > + > > > > We usually do not put a line between config.h and the header of the > > corresponding cpp. > > I think the style checker complained, but I'll double-check before > landing. Thanks for the review! You were right -- the style checker complained about a different thing (I still had the message in the scrollback of my terminal emulator!). I have removed the empty line as suggested and re-sent the patch for landing. :) 1486450 8 356927 commit-queue 2018-12-09 12:17:28 -0800 Comment on attachment 356927 Patch for landing Clearing flags on attachment: 356927 Committed r239022: <https://trac.webkit.org/changeset/239022> 1486451 9 commit-queue 2018-12-09 12:17:29 -0800 All reviewed patches have been landed. Closing bug. 1486452 10 webkit-bug-importer 2018-12-09 12:18:46 -0800 <rdar://problem/46581101> 356922 2018-12-09 08:21:22 -0800 2018-12-09 11:40:15 -0800 Patch bug-192541-20181209182121.patch text/plain 1385 aperez U3VidmVyc2lvbiBSZXZpc2lvbjogMjM5MDE5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDI5NmZhYzkyN2JhODFmOWQy YzE4YTIyODliMThkY2QzYTMyYTJlYzIuLmRhOWQxY2M4ZjgxYmMwYTdhMmI0OTFhMDRhZGY1YWY0 YTEzZjg0OTEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTgtMTItMDkgIEFkcmlhbiBQ ZXJleiBkZSBDYXN0cm8gIDxhcGVyZXpAaWdhbGlhLmNvbT4KKworICAgICAgICBCdWlsZCBmYWls dXJlIGR1ZSB0byBtaXNzaW5nIGluY2x1ZGUgb2YgQVBJV2Vic2l0ZURhdGFTdG9yZS5oCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTI1NDEKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9X ZWJzaXRlRGF0YS9XZWJzaXRlRGF0YVN0b3JlQ29uZmlndXJhdGlvbi5jcHA6IEFkZCBtaXNzaW5n CisgICAgICAgIGluY2x1ZGUgb2YgQVBJV2Vic2l0ZURhdGFTdG9yZS5oCisKIDIwMTgtMTItMDkg IFdlbnNvbiBIc2llaCAgPHdlbnNvbl9oc2llaEBhcHBsZS5jb20+CiAKICAgICAgICAgW2lPUyBk ZXZpY2VdIENyYXNoIHdoZW4gYXR0ZW1wdGluZyB0byBjYWxsIC1bX1dLQXR0YWNobWVudCBpbmZv XSBmb3IgYW4gZWRpdGFibGUgaW1hZ2UKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9j ZXNzL1dlYnNpdGVEYXRhL1dlYnNpdGVEYXRhU3RvcmVDb25maWd1cmF0aW9uLmNwcCBiL1NvdXJj ZS9XZWJLaXQvVUlQcm9jZXNzL1dlYnNpdGVEYXRhL1dlYnNpdGVEYXRhU3RvcmVDb25maWd1cmF0 aW9uLmNwcAppbmRleCAzMmVlOTRhNTFiMDJmOWI4ZTEyYTEyYTYzMjBiMjhhNTgxZWRjMzVhLi4z YzRlMDY0NGVmZjc2NDU0ODk4NTY4MTczYmI4MDIzZDhiYjk4NGVjIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJzaXRlRGF0YS9XZWJzaXRlRGF0YVN0b3JlQ29uZmlndXJh dGlvbi5jcHAKKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2Vic2l0ZURhdGEvV2Vic2l0 ZURhdGFTdG9yZUNvbmZpZ3VyYXRpb24uY3BwCkBAIC0yNCw4ICsyNCwxMSBAQAogICovCiAKICNp bmNsdWRlICJjb25maWcuaCIKKwogI2luY2x1ZGUgIldlYnNpdGVEYXRhU3RvcmVDb25maWd1cmF0 aW9uLmgiCiAKKyNpbmNsdWRlICJBUElXZWJzaXRlRGF0YVN0b3JlLmgiCisKIG5hbWVzcGFjZSBX ZWJLaXQgewogCiBXZWJzaXRlRGF0YVN0b3JlQ29uZmlndXJhdGlvbjo6V2Vic2l0ZURhdGFTdG9y ZUNvbmZpZ3VyYXRpb24oKQo= 356927 2018-12-09 11:40:21 -0800 2018-12-09 12:17:28 -0800 Patch for landing bug-192541-20181209214020.patch text/plain 1374 aperez U3VidmVyc2lvbiBSZXZpc2lvbjogMjM5MDIxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDI5NmZhYzkyN2JhODFmOWQy YzE4YTIyODliMThkY2QzYTMyYTJlYzIuLmRiNDNkZTkwYzYwZmI3NzI3NDc4NTI5OGFjZDgwNTRl MTAwYzJjMmYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTgtMTItMDkgIEFkcmlhbiBQ ZXJleiBkZSBDYXN0cm8gIDxhcGVyZXpAaWdhbGlhLmNvbT4KKworICAgICAgICBCdWlsZCBmYWls dXJlIGR1ZSB0byBtaXNzaW5nIGluY2x1ZGUgb2YgQVBJV2Vic2l0ZURhdGFTdG9yZS5oCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTI1NDEKKworICAg ICAgICBSZXZpZXdlZCBieSBZb3Vlbm4gRmFibGV0LgorCisgICAgICAgICogVUlQcm9jZXNzL1dl YnNpdGVEYXRhL1dlYnNpdGVEYXRhU3RvcmVDb25maWd1cmF0aW9uLmNwcDogQWRkIG1pc3NpbmcK KyAgICAgICAgaW5jbHVkZSBvZiBBUElXZWJzaXRlRGF0YVN0b3JlLmgKKwogMjAxOC0xMi0wOSAg V2Vuc29uIEhzaWVoICA8d2Vuc29uX2hzaWVoQGFwcGxlLmNvbT4KIAogICAgICAgICBbaU9TIGRl dmljZV0gQ3Jhc2ggd2hlbiBhdHRlbXB0aW5nIHRvIGNhbGwgLVtfV0tBdHRhY2htZW50IGluZm9d IGZvciBhbiBlZGl0YWJsZSBpbWFnZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nl c3MvV2Vic2l0ZURhdGEvV2Vic2l0ZURhdGFTdG9yZUNvbmZpZ3VyYXRpb24uY3BwIGIvU291cmNl L1dlYktpdC9VSVByb2Nlc3MvV2Vic2l0ZURhdGEvV2Vic2l0ZURhdGFTdG9yZUNvbmZpZ3VyYXRp b24uY3BwCmluZGV4IDMyZWU5NGE1MWIwMmY5YjhlMTJhMTJhNjMyMGIyOGE1ODFlZGMzNWEuLjNj MDlkZGQ2N2M0Yjk4NWQ3ODAyNTc3MzUwNTZlOTUxYzdjN2YzNWUgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQvVUlQcm9jZXNzL1dlYnNpdGVEYXRhL1dlYnNpdGVEYXRhU3RvcmVDb25maWd1cmF0 aW9uLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJzaXRlRGF0YS9XZWJzaXRl RGF0YVN0b3JlQ29uZmlndXJhdGlvbi5jcHAKQEAgLTI2LDYgKzI2LDggQEAKICNpbmNsdWRlICJj b25maWcuaCIKICNpbmNsdWRlICJXZWJzaXRlRGF0YVN0b3JlQ29uZmlndXJhdGlvbi5oIgogCisj aW5jbHVkZSAiQVBJV2Vic2l0ZURhdGFTdG9yZS5oIgorCiBuYW1lc3BhY2UgV2ViS2l0IHsKIAog V2Vic2l0ZURhdGFTdG9yZUNvbmZpZ3VyYXRpb246OldlYnNpdGVEYXRhU3RvcmVDb25maWd1cmF0 aW9uKCkK