192526 2018-12-08 09:59:02 -0800 Reduce size of PropertySlot and PutPropertySlot. 2018-12-08 15:55:25 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mark.lam mark.lam commit-queue fpizlo keith_miller msaboff rmorisset saam tzagallo webkit-bug-importer ysuzuki oldest_to_newest 1486310 0 mark.lam 2018-12-08 09:59:02 -0800 With some minor adjustments, we can reduce the size of PropertySlot from 80 bytes (19 padding bytes) to 64 bytes (3 padding bytes), and PutPropertySlot from 40 bytes (4 padding bytes) to 32 bytes (0 padding bytes but with 6 unused bits). These measurements are for a 64-bit build. 1486311 1 356874 mark.lam 2018-12-08 10:02:20 -0800 Created attachment 356874 proposed patch. 1486317 2 356874 keith_miller 2018-12-08 10:31:01 -0800 Comment on attachment 356874 proposed patch. r=me. I think these only live on the stack anyway, however, so size is less important. 1486323 3 356874 mark.lam 2018-12-08 11:17:25 -0800 Comment on attachment 356874 proposed patch. Thanks for the review. Landing now. 1486325 4 356874 saam 2018-12-08 11:26:41 -0800 Comment on attachment 356874 proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=356874&action=review > Source/JavaScriptCore/ChangeLog:3 > + Reduce side of PropertySlot and PutPropertySlot. side => size 1486357 5 mark.lam 2018-12-08 15:54:07 -0800 Landed in r239013: <http://trac.webkit.org/r239013>. 1486358 6 webkit-bug-importer 2018-12-08 15:55:25 -0800 <rdar://problem/46577386> 356874 2018-12-08 10:02:20 -0800 2018-12-08 11:26:58 -0800 proposed patch. bug-192526.patch text/plain 3826 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjM5MDA5KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBA CisyMDE4LTEyLTA4ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBS ZWR1Y2Ugc2lkZSBvZiBQcm9wZXJ0eVNsb3QgYW5kIFB1dFByb3BlcnR5U2xvdC4KKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5MjUyNgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdpdGggc29tZSBtaW5vciBh ZGp1c3RtZW50cywgd2UgY2FuIHJlZHVjZSB0aGUgc2l6ZSBvZiBQcm9wZXJ0eVNsb3QgZnJvbSA4 MCBieXRlcworICAgICAgICAoMTkgcGFkZGluZyBieXRlcykgdG8gNjQgYnl0ZXMgKDMgcGFkZGlu ZyBieXRlcyksIGFuZCBQdXRQcm9wZXJ0eVNsb3QgZnJvbSA0MAorICAgICAgICBieXRlcyAoNCBw YWRkaW5nIGJ5dGVzKSB0byAzMiBieXRlcyAoMCBwYWRkaW5nIGJ5dGVzIGJ1dCB3aXRoIDYgdW51 c2VkIGJpdHMpLgorICAgICAgICBUaGVzZSBtZWFzdXJlbWVudHMgYXJlIGZvciBhIDY0LWJpdCBi dWlsZC4KKworICAgICAgICAqIHJ1bnRpbWUvUHJvcGVydHlTbG90Lmg6CisgICAgICAgICogcnVu dGltZS9QdXRQcm9wZXJ0eVNsb3QuaDoKKyAgICAgICAgKEpTQzo6UHV0UHJvcGVydHlTbG90OjpQ dXRQcm9wZXJ0eVNsb3QpOgorCiAyMDE4LTEyLTA4ICBEb21pbmlrIEluZnVlaHIgIDxkaW5mdWVo ckBpZ2FsaWEuY29tPgogCiAgICAgICAgIFJlY29yZCByaWdodCBvZmZzZXQgd2l0aCBhbGlnbmVk IHdpZGUgaW5zdHJ1Y3Rpb25zCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9Q cm9wZXJ0eVNsb3QuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGlt ZS9Qcm9wZXJ0eVNsb3QuaAkocmV2aXNpb24gMjM5MDA5KQorKysgU291cmNlL0phdmFTY3JpcHRD b3JlL3J1bnRpbWUvUHJvcGVydHlTbG90LmgJKHdvcmtpbmcgY29weSkKQEAgLTM3MCw3ICszNzAs NiBAQCBwcml2YXRlOgogICAgIEpTX0VYUE9SVF9QUklWQVRFIEpTVmFsdWUgY3VzdG9tR2V0dGVy KEV4ZWNTdGF0ZSosIFByb3BlcnR5TmFtZSkgY29uc3Q7CiAgICAgSlNfRVhQT1JUX1BSSVZBVEUg SlNWYWx1ZSBjdXN0b21BY2Nlc3NvckdldHRlcihFeGVjU3RhdGUqLCBQcm9wZXJ0eU5hbWUpIGNv bnN0OwogCi0gICAgdW5zaWduZWQgbV9hdHRyaWJ1dGVzOwogICAgIHVuaW9uIHsKICAgICAgICAg RW5jb2RlZEpTVmFsdWUgdmFsdWU7CiAgICAgICAgIHN0cnVjdCB7CkBAIC0zODQsNiArMzgzLDcg QEAgcHJpdmF0ZToKICAgICAgICAgfSBjdXN0b21BY2Nlc3NvcjsKICAgICB9IG1fZGF0YTsKIAor ICAgIHVuc2lnbmVkIG1fYXR0cmlidXRlczsKICAgICBQcm9wZXJ0eU9mZnNldCBtX29mZnNldDsK ICAgICBKU1ZhbHVlIG1fdGhpc1ZhbHVlOwogICAgIEpTT2JqZWN0KiBtX3Nsb3RCYXNlOwpAQCAt MzkyLDExICszOTIsMTEgQEAgcHJpdmF0ZToKICAgICBQcm9wZXJ0eVR5cGUgbV9wcm9wZXJ0eVR5 cGU7CiAgICAgSW50ZXJuYWxNZXRob2RUeXBlIG1faW50ZXJuYWxNZXRob2RUeXBlOwogICAgIEFk ZGl0aW9uYWxEYXRhVHlwZSBtX2FkZGl0aW9uYWxEYXRhVHlwZTsKKyAgICBib29sIG1faXNUYWlu dGVkQnlPcGFxdWVPYmplY3Q7CiAgICAgdW5pb24gewogICAgICAgICBET01BdHRyaWJ1dGVBbm5v dGF0aW9uIGRvbUF0dHJpYnV0ZTsKICAgICAgICAgTW9kdWxlTmFtZXNwYWNlU2xvdCBtb2R1bGVO YW1lc3BhY2VTbG90OwogICAgIH0gbV9hZGRpdGlvbmFsRGF0YTsKLSAgICBib29sIG1faXNUYWlu dGVkQnlPcGFxdWVPYmplY3Q7CiB9OwogCiBBTFdBWVNfSU5MSU5FIEpTVmFsdWUgUHJvcGVydHlT bG90OjpnZXRWYWx1ZShFeGVjU3RhdGUqIGV4ZWMsIFByb3BlcnR5TmFtZSBwcm9wZXJ0eU5hbWUp IGNvbnN0CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9QdXRQcm9wZXJ0eVNs b3QuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9QdXRQcm9w ZXJ0eVNsb3QuaAkocmV2aXNpb24gMjM5MDA5KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL3J1 bnRpbWUvUHV0UHJvcGVydHlTbG90LmgJKHdvcmtpbmcgY29weSkKQEAgLTM2LDE3ICszNiwxNyBA QCBjbGFzcyBKU0Z1bmN0aW9uOwogICAgIAogY2xhc3MgUHV0UHJvcGVydHlTbG90IHsKIHB1Ymxp YzoKLSAgICBlbnVtIFR5cGUgeyBVbmNhY2hhYmxlLCBFeGlzdGluZ1Byb3BlcnR5LCBOZXdQcm9w ZXJ0eSwgU2V0dGVyUHJvcGVydHksIEN1c3RvbVZhbHVlLCBDdXN0b21BY2Nlc3NvciB9OworICAg IGVudW0gVHlwZSA6IHVpbnQ4X3QgeyBVbmNhY2hhYmxlLCBFeGlzdGluZ1Byb3BlcnR5LCBOZXdQ cm9wZXJ0eSwgU2V0dGVyUHJvcGVydHksIEN1c3RvbVZhbHVlLCBDdXN0b21BY2Nlc3NvciB9Owog ICAgIGVudW0gQ29udGV4dCB7IFVua25vd25Db250ZXh0LCBQdXRCeUlkLCBQdXRCeUlkRXZhbCB9 OwogICAgIHR5cGVkZWYgYm9vbCAoKlB1dFZhbHVlRnVuYykoRXhlY1N0YXRlKiwgRW5jb2RlZEpT VmFsdWUgdGhpc09iamVjdCwgRW5jb2RlZEpTVmFsdWUgdmFsdWUpOwogCiAgICAgUHV0UHJvcGVy dHlTbG90KEpTVmFsdWUgdGhpc1ZhbHVlLCBib29sIGlzU3RyaWN0TW9kZSA9IGZhbHNlLCBDb250 ZXh0IGNvbnRleHQgPSBVbmtub3duQ29udGV4dCwgYm9vbCBpc0luaXRpYWxpemF0aW9uID0gZmFs c2UpCi0gICAgICAgIDogbV90eXBlKFVuY2FjaGFibGUpCi0gICAgICAgICwgbV9iYXNlKDApCisg ICAgICAgIDogbV9iYXNlKDApCiAgICAgICAgICwgbV90aGlzVmFsdWUodGhpc1ZhbHVlKQogICAg ICAgICAsIG1fb2Zmc2V0KGludmFsaWRPZmZzZXQpCiAgICAgICAgICwgbV9pc1N0cmljdE1vZGUo aXNTdHJpY3RNb2RlKQogICAgICAgICAsIG1faXNJbml0aWFsaXphdGlvbihpc0luaXRpYWxpemF0 aW9uKQorICAgICAgICAsIG1fdHlwZShVbmNhY2hhYmxlKQogICAgICAgICAsIG1fY29udGV4dChj b250ZXh0KQogICAgICAgICAsIG1fY2FjaGVhYmlsaXR5KENhY2hpbmdBbGxvd2VkKQogICAgIHsK QEAgLTEyOSwxMiArMTI5LDEyIEBAIHB1YmxpYzoKIHByaXZhdGU6CiAgICAgYm9vbCBpc0NhY2hl YWJsZSgpIGNvbnN0IHsgcmV0dXJuIG1fY2FjaGVhYmlsaXR5ID09IENhY2hpbmdBbGxvd2VkOyB9 CiAKLSAgICBUeXBlIG1fdHlwZTsKICAgICBKU09iamVjdCogbV9iYXNlOwogICAgIEpTVmFsdWUg bV90aGlzVmFsdWU7CiAgICAgUHJvcGVydHlPZmZzZXQgbV9vZmZzZXQ7Ci0gICAgYm9vbCBtX2lz U3RyaWN0TW9kZTsKLSAgICBib29sIG1faXNJbml0aWFsaXphdGlvbjsKKyAgICBib29sIG1faXNT dHJpY3RNb2RlIDogMTsKKyAgICBib29sIG1faXNJbml0aWFsaXphdGlvbiA6IDE7CisgICAgVHlw ZSBtX3R5cGU7CiAgICAgdWludDhfdCBtX2NvbnRleHQ7CiAgICAgQ2FjaGVhYmlsaXR5VHlwZSBt X2NhY2hlYWJpbGl0eTsKICAgICBGdW5jdGlvblB0cjxPcGVyYXRpb25QdHJUYWc+IG1fcHV0RnVu Y3Rpb247Cg==