192521 2018-12-07 15:45:41 -0800 Animated scrolling on Google Maps scrolls the page in addition to moving the map 2018-12-10 16:32:48 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 thorton thorton commit-queue sam simon.fraser webkit-bug-importer wenson_hsieh oldest_to_newest 1486192 0 thorton 2018-12-07 15:45:41 -0800 Animated scrolling on Google Maps scrolls the page in addition to moving the map 1486193 1 356846 thorton 2018-12-07 15:45:48 -0800 Created attachment 356846 Patch 1486194 2 thorton 2018-12-07 15:45:49 -0800 <rdar://problem/46382007> 1486279 3 356846 sam 2018-12-07 20:20:49 -0800 Comment on attachment 356846 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=356846&action=review > Source/WebKit/ChangeLog:14 > + * UIProcess/ios/WKKeyboardScrollingAnimator.mm: > + (-[WKKeyboardScrollViewAnimator rubberbandableDirections]): > + Only do keyboard-based rubber-banding in directions that we can actually > + scroll, not directions we can only finger-rubber-band in. This effectively > + means keyboard scrolling will ignore "alwaysBounce{Vertical, Horizontal}". Is there any way to test this? 1486799 4 thorton 2018-12-10 16:23:09 -0800 This is one of those things where it's a bit tricky to make a layout test to prove the non-existence of something (e.g. a scroll event) without being slow or flaky. Maybe possible to API test instead. 1486806 5 356846 commit-queue 2018-12-10 16:32:46 -0800 Comment on attachment 356846 Patch Clearing flags on attachment: 356846 Committed r239059: <https://trac.webkit.org/changeset/239059> 1486808 6 commit-queue 2018-12-10 16:32:48 -0800 All reviewed patches have been landed. Closing bug. 356846 2018-12-07 15:45:48 -0800 2018-12-10 16:32:46 -0800 Patch bug-192521-20181207154547.patch text/plain 2702 thorton U3VidmVyc2lvbiBSZXZpc2lvbjogMjM4OTYxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDBkMGUxNWMxYzJlNTcxZDM0 YzRkMzlkODNlMTVjNmEwMTEwNzA0MmEuLjk1MDZhYzdiNGFjZTZmNmEwY2ZmZjliNmE5NzA5M2Y4 NGQ5NjQ5YTkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTgtMTItMDcgIFRpbSBIb3J0 b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CisKKyAgICAgICAgQW5pbWF0ZWQgc2Nyb2xs aW5nIG9uIEdvb2dsZSBNYXBzIHNjcm9sbHMgdGhlIHBhZ2UgaW4gYWRkaXRpb24gdG8gbW92aW5n IHRoZSBtYXAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTE5MjUyMQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNDYzODIwMDc+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBQbGF0Zm9ybS9zcGkvaW9zL1VJ S2l0U1BJLmg6CisgICAgICAgICogVUlQcm9jZXNzL2lvcy9XS0tleWJvYXJkU2Nyb2xsaW5nQW5p bWF0b3IubW06CisgICAgICAgICgtW1dLS2V5Ym9hcmRTY3JvbGxWaWV3QW5pbWF0b3IgcnViYmVy YmFuZGFibGVEaXJlY3Rpb25zXSk6CisgICAgICAgIE9ubHkgZG8ga2V5Ym9hcmQtYmFzZWQgcnVi YmVyLWJhbmRpbmcgaW4gZGlyZWN0aW9ucyB0aGF0IHdlIGNhbiBhY3R1YWxseQorICAgICAgICBz Y3JvbGwsIG5vdCBkaXJlY3Rpb25zIHdlIGNhbiBvbmx5IGZpbmdlci1ydWJiZXItYmFuZCBpbi4g VGhpcyBlZmZlY3RpdmVseQorICAgICAgICBtZWFucyBrZXlib2FyZCBzY3JvbGxpbmcgd2lsbCBp Z25vcmUgImFsd2F5c0JvdW5jZXtWZXJ0aWNhbCwgSG9yaXpvbnRhbH0iLgorCiAyMDE4LTEyLTA3 ICBUcnVpdHQgU2F2ZWxsICA8dHNhdmVsbEBhcHBsZS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdl ZCwgcm9sbGluZyBvdXQgcjIzODk0Ny4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvUGxhdGZv cm0vc3BpL2lvcy9VSUtpdFNQSS5oIGIvU291cmNlL1dlYktpdC9QbGF0Zm9ybS9zcGkvaW9zL1VJ S2l0U1BJLmgKaW5kZXggNTY5ODhjNjhlMjQ2NThjYzIwNTk0MDJlYzFmODIxZTFjODY4NDIxMi4u NDQzY2RiYjVlNTM2M2M4YjNlMjNmYjQ3Yjk1ZTFkNjI3MzA1ODNkYSAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYktpdC9QbGF0Zm9ybS9zcGkvaW9zL1VJS2l0U1BJLmgKKysrIGIvU291cmNlL1dlYktp dC9QbGF0Zm9ybS9zcGkvaW9zL1VJS2l0U1BJLmgKQEAgLTEwNDksOCArMTA0OSw4IEBAIHR5cGVk ZWYgTlNJbnRlZ2VyIFVJQ29tcG9zaXRpbmdNb2RlOwogLSAodm9pZClfYWRqdXN0Rm9yQXV0b21h dGljS2V5Ym9hcmRJbmZvOihOU0RpY3Rpb25hcnkgKilpbmZvIGFuaW1hdGVkOihCT09MKWFuaW1h dGVkIGxhc3RBZGp1c3RtZW50OihDR0Zsb2F0KilsYXN0QWRqdXN0bWVudDsKIC0gKEJPT0wpX2lz U2Nyb2xsaW5nVG9Ub3A7CiAtIChDR1BvaW50KV9hbmltYXRlZFRhcmdldE9mZnNldDsKLS0gKEJP T0wpX2NhblNjcm9sbFg7Ci0tIChCT09MKV9jYW5TY3JvbGxZOworLSAoQk9PTClfY2FuU2Nyb2xs V2l0aG91dEJvdW5jaW5nWDsKKy0gKEJPT0wpX2NhblNjcm9sbFdpdGhvdXRCb3VuY2luZ1k7CiAt ICh2b2lkKV9zZXRDb250ZW50T2Zmc2V0V2l0aERlY2VsZXJhdGlvbkFuaW1hdGlvbjooQ0dQb2lu dCljb250ZW50T2Zmc2V0OwogLSAoQ0dQb2ludClfYWRqdXN0ZWRDb250ZW50T2Zmc2V0Rm9yQ29u dGVudE9mZnNldDooQ0dQb2ludCljb250ZW50T2Zmc2V0OwogLSAodm9pZClfZmxhc2hTY3JvbGxJ bmRpY2F0b3JzUGVyc2lzdGluZ1ByZXZpb3VzRmxhc2hlczooQk9PTClwZXJzaXN0aW5nOwpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL1dLS2V5Ym9hcmRTY3JvbGxpbmdB bmltYXRvci5tbSBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9XS0tleWJvYXJkU2Nyb2xs aW5nQW5pbWF0b3IubW0KaW5kZXggOTg1NDdjNzI2OWI3MGM5ZmE3OGMzNWI5N2EzYTVjOWMyMzY1 ZmQ4Zi4uOTkzMGVhMTUyN2ViMzViOTY1YTgyYzBhZjViYzUzNzc2NTRjYzdjYSAxMDA2NDQKLS0t IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL1dLS2V5Ym9hcmRTY3JvbGxpbmdBbmltYXRv ci5tbQorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvV0tLZXlib2FyZFNjcm9sbGlu Z0FuaW1hdG9yLm1tCkBAIC02NzgsOSArNjc4LDkgQEAgLSAoV2ViQ29yZTo6UmVjdEVkZ2VzPGJv b2w+KXJ1YmJlcmJhbmRhYmxlRGlyZWN0aW9ucwogCiAgICAgV2ViQ29yZTo6UmVjdEVkZ2VzPGJv b2w+IGVkZ2VzOwogCi0gICAgZWRnZXMuc2V0VG9wKHNjcm9sbFZpZXcuX2NhblNjcm9sbFkpOwor ICAgIGVkZ2VzLnNldFRvcChzY3JvbGxWaWV3Ll9jYW5TY3JvbGxXaXRob3V0Qm91bmNpbmdZKTsK ICAgICBlZGdlcy5zZXRCb3R0b20oZWRnZXMudG9wKCkpOwotICAgIGVkZ2VzLnNldExlZnQoc2Ny b2xsVmlldy5fY2FuU2Nyb2xsWCk7CisgICAgZWRnZXMuc2V0TGVmdChzY3JvbGxWaWV3Ll9jYW5T Y3JvbGxXaXRob3V0Qm91bmNpbmdYKTsKICAgICBlZGdlcy5zZXRSaWdodChlZGdlcy5sZWZ0KCkp OwogCiAgICAgcmV0dXJuIGVkZ2VzOwo=