192514 2018-12-07 14:04:00 -0800 [MediaStream] Address post-review comments after r238904 2018-12-07 19:10:50 -0800 1 1 1 Unclassified WebKit WebRTC Safari 12 Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 192379 1 eric.carlson eric.carlson commit-queue webkit-bug-importer youennf oldest_to_newest 1486138 0 eric.carlson 2018-12-07 14:04:00 -0800 Fix potential ARC incompatibilities. 1486140 1 webkit-bug-importer 2018-12-07 14:04:43 -0800 <rdar://problem/46564302> 1486143 2 356835 eric.carlson 2018-12-07 14:15:28 -0800 Created attachment 356835 Patch 1486145 3 356835 youennf 2018-12-07 14:19:36 -0800 Comment on attachment 356835 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=356835&action=review > Source/WebCore/platform/graphics/cv/ImageTransferSessionVT.mm:91 > + (__bridge NSString *)kCVPixelBufferPixelFormatTypeKey : @(m_pixelFormat), In other parts of the code (RealtimeXXSourceCocoa, ImageDecoderAVFObjC), we put name: value. Not sure what the preferred style is. 1486269 4 356835 commit-queue 2018-12-07 19:10:48 -0800 Comment on attachment 356835 Patch Clearing flags on attachment: 356835 Committed r239005: <https://trac.webkit.org/changeset/239005> 1486270 5 commit-queue 2018-12-07 19:10:50 -0800 All reviewed patches have been landed. Closing bug. 356835 2018-12-07 14:15:28 -0800 2018-12-07 19:10:48 -0800 Patch bug-192514-20181207141527.patch text/plain 5085 eric.carlson U3VidmVyc2lvbiBSZXZpc2lvbjogMjM4OTY0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzY0YzJjMzY5ODEyZjRk OWQ1MDhlYzc5YjZmYTE2MDdkZTQyZTg3MC4uYjEyY2VjMmViNzgwNDVkN2MzNjFiYmJhOGM4N2Fj ODhhMmNhZWM1NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE4LTEyLTA3ICBFcmlj IENhcmxzb24gIDxlcmljLmNhcmxzb25AYXBwbGUuY29tPgorCisgICAgICAgIFtNZWRpYVN0cmVh bV0gQWRkcmVzcyBwb3N0LXJldmlldyBjb21tZW50cyBhZnRlciByMjM4OTA0CisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTI1MTQKKyAgICAgICAgPHJk YXI6Ly9wcm9ibGVtLzQ2NTY0MzAyPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cywgbm8gZnVuY3Rpb25hbCBjaGFuZ2UuCisKKyAg ICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9jdi9JbWFnZVRyYW5zZmVyU2Vzc2lvblZULm1tOgor ICAgICAgICAoV2ViQ29yZTo6SW1hZ2VUcmFuc2ZlclNlc3Npb25WVDo6c2V0U2l6ZSk6CisgICAg ICAgICogcGxhdGZvcm0vbWVkaWFzdHJlYW0vbWFjL1NjcmVlbkRpc3BsYXlDYXB0dXJlU291cmNl TWFjLm1tOgorICAgICAgICAoV2ViQ29yZTo6U2NyZWVuRGlzcGxheUNhcHR1cmVTb3VyY2VNYWM6 OmNyZWF0ZURpc3BsYXlTdHJlYW0pOgorCiAyMDE4LTEyLTA3ICBBbnR0aSBLb2l2aXN0byAgPGFu dHRpQGFwcGxlLmNvbT4KIAogICAgICAgICBSZW5hbWUgTGF5b3V0U3RhdGUgdG8gUmVuZGVyTGF5 b3V0U3RhdGUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2N2 L0ltYWdlVHJhbnNmZXJTZXNzaW9uVlQubW0gYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFw aGljcy9jdi9JbWFnZVRyYW5zZmVyU2Vzc2lvblZULm1tCmluZGV4IGRiZDU4YjMyZWY2ODQyNDYw NDExMTJkMzYxYmM2NmZjMmZkMTllYWYuLjI0YWE0OGM0MWM5MzIyMzNiNTM0ODRkNGM3NGU3OTM3 ZmE4YzVlNjkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2N2 L0ltYWdlVHJhbnNmZXJTZXNzaW9uVlQubW0KKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3MvY3YvSW1hZ2VUcmFuc2ZlclNlc3Npb25WVC5tbQpAQCAtODUsMjAgKzg1LDIwIEBA IGJvb2wgSW1hZ2VUcmFuc2ZlclNlc3Npb25WVDo6c2V0U2l6ZShjb25zdCBJbnRTaXplJiBzaXpl KQogICAgIGlmIChtX3NpemUgPT0gc2l6ZSAmJiBtX291dHB1dEJ1ZmZlclBvb2wpCiAgICAgICAg IHJldHVybiB0cnVlOwogCi0gICAgQ0ZEaWN0aW9uYXJ5UmVmIHBpeGVsQnVmZmVyT3B0aW9ucyA9 IChfX2JyaWRnZSBDRkRpY3Rpb25hcnlSZWYpIEB7Ci0gICAgICAgIChfX2JyaWRnZSBOU1N0cmlu ZyAqKWtDVlBpeGVsQnVmZmVyV2lkdGhLZXkgOkAoc2l6ZS53aWR0aCgpKSwKLSAgICAgICAgKF9f YnJpZGdlIE5TU3RyaW5nICopa0NWUGl4ZWxCdWZmZXJIZWlnaHRLZXk6QChzaXplLmhlaWdodCgp KSwKLSAgICAgICAgKF9fYnJpZGdlIE5TU3RyaW5nICopa0NWUGl4ZWxCdWZmZXJQaXhlbEZvcm1h dFR5cGVLZXk6QChtX3BpeGVsRm9ybWF0KSwKKyAgICBOU0RpY3Rpb25hcnkqIHBpeGVsQnVmZmVy T3B0aW9ucyA9IEB7CisgICAgICAgIChfX2JyaWRnZSBOU1N0cmluZyAqKWtDVlBpeGVsQnVmZmVy V2lkdGhLZXkgOiBAKHNpemUud2lkdGgoKSksCisgICAgICAgIChfX2JyaWRnZSBOU1N0cmluZyAq KWtDVlBpeGVsQnVmZmVySGVpZ2h0S2V5IDogQChzaXplLmhlaWdodCgpKSwKKyAgICAgICAgKF9f YnJpZGdlIE5TU3RyaW5nICopa0NWUGl4ZWxCdWZmZXJQaXhlbEZvcm1hdFR5cGVLZXkgOiBAKG1f cGl4ZWxGb3JtYXQpLAogICAgICAgICAoX19icmlkZ2UgTlNTdHJpbmcgKiljdlBpeGVsRm9ybWF0 T3BlbkdMS2V5KCkgOiBAKFlFUyksCiAgICAgICAgIChfX2JyaWRnZSBOU1N0cmluZyAqKWtDVlBp eGVsQnVmZmVySU9TdXJmYWNlUHJvcGVydGllc0tleSA6IEB7IC8qZW1wdHkgZGljdGlvbmFyeSov IH0sCiAgICAgfTsKIAotICAgIENGRGljdGlvbmFyeVJlZiBwaXhlbEJ1ZmZlclBvb2xPcHRpb25z ID0gKF9fYnJpZGdlIENGRGljdGlvbmFyeVJlZikgQHsKLSAgICAgICAgKF9fYnJpZGdlIE5TU3Ry aW5nICopa0NWUGl4ZWxCdWZmZXJQb29sTWluaW11bUJ1ZmZlckNvdW50S2V5IDogQCg2KQorICAg IE5TRGljdGlvbmFyeSogcGl4ZWxCdWZmZXJQb29sT3B0aW9ucyA9IEB7CisgICAgICAgIChfX2Jy aWRnZSBOU1N0cmluZyAqKWtDVlBpeGVsQnVmZmVyUG9vbE1pbmltdW1CdWZmZXJDb3VudEtleTog QCg2KQogICAgIH07CiAKICAgICBDVlBpeGVsQnVmZmVyUG9vbFJlZiBidWZmZXJQb29sOwotICAg IGF1dG8gc3RhdHVzID0gQ1ZQaXhlbEJ1ZmZlclBvb2xDcmVhdGUoa0NGQWxsb2NhdG9yRGVmYXVs dCwgcGl4ZWxCdWZmZXJQb29sT3B0aW9ucywgcGl4ZWxCdWZmZXJPcHRpb25zLCAmYnVmZmVyUG9v bCk7CisgICAgYXV0byBzdGF0dXMgPSBDVlBpeGVsQnVmZmVyUG9vbENyZWF0ZShrQ0ZBbGxvY2F0 b3JEZWZhdWx0LCAoX19icmlkZ2UgQ0ZEaWN0aW9uYXJ5UmVmKXBpeGVsQnVmZmVyUG9vbE9wdGlv bnMsIChfX2JyaWRnZSBDRkRpY3Rpb25hcnlSZWYpcGl4ZWxCdWZmZXJPcHRpb25zLCAmYnVmZmVy UG9vbCk7CiAgICAgQVNTRVJUKCFzdGF0dXMpOwogICAgIGlmIChzdGF0dXMgIT0ga0NWUmV0dXJu U3VjY2VzcykKICAgICAgICAgcmV0dXJuIGZhbHNlOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vbWVkaWFzdHJlYW0vbWFjL1NjcmVlbkRpc3BsYXlDYXB0dXJlU291cmNlTWFj Lm1tIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWVkaWFzdHJlYW0vbWFjL1NjcmVlbkRpc3Bs YXlDYXB0dXJlU291cmNlTWFjLm1tCmluZGV4IDgzYjIwMjIyNDhlODhlNDg2NjE4NGNiNjY0MGYz ZGYzMDg0OTJmNjIuLjgyMDBlOTAxOTE4MzU1MmE4ODYxNGUxZGY1M2E4ZmE2ZTI3MmQ3MjkgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21lZGlhc3RyZWFtL21hYy9TY3JlZW5E aXNwbGF5Q2FwdHVyZVNvdXJjZU1hYy5tbQorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9t ZWRpYXN0cmVhbS9tYWMvU2NyZWVuRGlzcGxheUNhcHR1cmVTb3VyY2VNYWMubW0KQEAgLTE0MSwx MCArMTQxLDEwIEBAIGJvb2wgU2NyZWVuRGlzcGxheUNhcHR1cmVTb3VyY2VNYWM6OmNyZWF0ZURp c3BsYXlTdHJlYW0oKQogICAgICAgICBpZiAoIW1fY2FwdHVyZVF1ZXVlKQogICAgICAgICAgICAg bV9jYXB0dXJlUXVldWUgPSBhZG9wdE9TT2JqZWN0KGRpc3BhdGNoX3F1ZXVlX2NyZWF0ZSgiU2Ny ZWVuRGlzcGxheUNhcHR1cmVTb3VyY2VNYWMgQ2FwdHVyZSBRdWV1ZSIsIERJU1BBVENIX1FVRVVF X1NFUklBTCkpOwogCi0gICAgICAgIENGRGljdGlvbmFyeVJlZiBzdHJlYW1PcHRpb25zID0gKF9f YnJpZGdlIENGRGljdGlvbmFyeVJlZikgQHsKLSAgICAgICAgICAgIChfX2JyaWRnZSBOU1N0cmlu ZyAqKWtDR0Rpc3BsYXlTdHJlYW1NaW5pbXVtRnJhbWVUaW1lIDpAKDEgLyBmcmFtZVJhdGUoKSks Ci0gICAgICAgICAgICAoX19icmlkZ2UgTlNTdHJpbmcgKilrQ0dEaXNwbGF5U3RyZWFtUXVldWVE ZXB0aDpAKHNjcmVlblF1ZXVlTWF4aW11bUxlbmd0aCksCi0gICAgICAgICAgICAoX19icmlkZ2Ug TlNTdHJpbmcgKilrQ0dEaXNwbGF5U3RyZWFtQ29sb3JTcGFjZTooX19icmlkZ2UgaWQpc1JHQkNv bG9yU3BhY2VSZWYoKSwKKyAgICAgICAgTlNEaWN0aW9uYXJ5KiBzdHJlYW1PcHRpb25zID0gQHsK KyAgICAgICAgICAgIChfX2JyaWRnZSBOU1N0cmluZyAqKWtDR0Rpc3BsYXlTdHJlYW1NaW5pbXVt RnJhbWVUaW1lIDogQCgxIC8gZnJhbWVSYXRlKCkpLAorICAgICAgICAgICAgKF9fYnJpZGdlIE5T U3RyaW5nICopa0NHRGlzcGxheVN0cmVhbVF1ZXVlRGVwdGggOiBAKHNjcmVlblF1ZXVlTWF4aW11 bUxlbmd0aCksCisgICAgICAgICAgICAoX19icmlkZ2UgTlNTdHJpbmcgKilrQ0dEaXNwbGF5U3Ry ZWFtQ29sb3JTcGFjZSA6IChfX2JyaWRnZSBpZClzUkdCQ29sb3JTcGFjZVJlZigpLAogICAgICAg ICAgICAgKF9fYnJpZGdlIE5TU3RyaW5nICopa0NHRGlzcGxheVN0cmVhbVNob3dDdXJzb3IgOiBA KFlFUyksCiAgICAgICAgIH07CiAKQEAgLTE1Niw3ICsxNTYsNyBAQCBib29sIFNjcmVlbkRpc3Bs YXlDYXB0dXJlU291cmNlTWFjOjpjcmVhdGVEaXNwbGF5U3RyZWFtKCkKICAgICAgICAgICAgIHdl YWtUaGlzLT5mcmFtZUF2YWlsYWJsZShzdGF0dXMsIGRpc3BsYXlUaW1lLCBmcmFtZVN1cmZhY2Us IHVwZGF0ZVJlZik7CiAgICAgICAgIH07CiAKLSAgICAgICAgbV9kaXNwbGF5U3RyZWFtID0gYWRv cHRDRihDR0Rpc3BsYXlTdHJlYW1DcmVhdGVXaXRoRGlzcGF0Y2hRdWV1ZShtX2Rpc3BsYXlJRCwg c2NyZWVuV2lkdGgsIHNjcmVlbkhlaWdodCwgcHJlZmVyZWRQaXhlbEJ1ZmZlckZvcm1hdCgpLCBz dHJlYW1PcHRpb25zLCBtX2NhcHR1cmVRdWV1ZS5nZXQoKSwgZnJhbWVBdmFpbGFibGVCbG9jaykp OworICAgICAgICBtX2Rpc3BsYXlTdHJlYW0gPSBhZG9wdENGKENHRGlzcGxheVN0cmVhbUNyZWF0 ZVdpdGhEaXNwYXRjaFF1ZXVlKG1fZGlzcGxheUlELCBzY3JlZW5XaWR0aCwgc2NyZWVuSGVpZ2h0 LCBwcmVmZXJlZFBpeGVsQnVmZmVyRm9ybWF0KCksIChfX2JyaWRnZSBDRkRpY3Rpb25hcnlSZWYp c3RyZWFtT3B0aW9ucywgbV9jYXB0dXJlUXVldWUuZ2V0KCksIGZyYW1lQXZhaWxhYmxlQmxvY2sp KTsKICAgICAgICAgaWYgKCFtX2Rpc3BsYXlTdHJlYW0pIHsKICAgICAgICAgICAgIFJFTEVBU0Vf TE9HKE1lZGlhLCAiU2NyZWVuRGlzcGxheUNhcHR1cmVTb3VyY2VNYWM6OmNyZWF0ZURpc3BsYXlT dHJlYW06IENHRGlzcGxheVN0cmVhbUNyZWF0ZSBmYWlsZWQiKTsKICAgICAgICAgICAgIGNhcHR1 cmVGYWlsZWQoKTsK